December 2015 - jbosstools-issues

[JBoss JIRA] (JBIDE-21161) various UI issues on new cdk server adapter

by Viacheslav Kabanovich (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21161?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich edited comment on JBIDE-21161 at 12/3/15 12:18 AM: ------------------------------------------------------------------------- GridLayout might do better than FormLayout, 'Browse' button makes 'Folder' controls to look somewhat lopsided. I wonder, why 'Add credentials...' is a link under 'Username:', I would suggest button 'Add...' or 'New...' to the right of its combo. Putting credentials in a group may work, but the component may also be made more flexible to be fit into any grid. Functionality may be moved from ChooseCredentialComposite to a new class ChooseCredentialComponent which will not inherit from Composite but implement method create(Composite) that will layout its controls into parent's grid. Then ChooseCredentialComposite may aggregate ChooseCredentialComponent and call create with itself as the parent. Other clients may either reuse ChooseCredentialComposite or instantiate ChooseCredentialComponent to call create with any composite. As a good example, take New Java Class wizard. It contains a lot of inputs, grouped into many reusable components that are fitted into provided grid layout. was (Author: scabanovich): GridLayout might do better than FormLayout, 'Browse' button makes 'Folder' controls to look somewhat lopsided. I wonder, why 'Add credentials...' is a link under 'Username:', I would suggest button 'Add...' or 'New...' to the right of its combo. Putting credentials in a group may work, but the component may also be made more flexible to be fit into any grid. Functionality may be moved from ChooseCredentialComposite to a new class ChooseCredentialComponent which will not inherit from Composite but implement method create(Composite) that will layout its controls into parent's grid. Then ChooseCredentialComposite may aggregate ChooseCredentialComponent and call create with itself as the parent. Other clients may either reuse ChooseCredentialComposite or instantiate ChooseCredentialComponent to call create with any composite. > various UI issues on new cdk server adapter > ------------------------------------------- > > Key: JBIDE-21161 > URL: https://issues.jboss.org/browse/JBIDE-21161 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Reporter: Max Rydahl Andersen > Assignee: Rob Stryker > Attachments: New_Server_and_Java_EE_-_Eclipse.png > > > the cDK server adapter page has some "weird" UI layout. > see attached. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-21161) various UI issues on new cdk server adapter

by Viacheslav Kabanovich (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21161?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich edited comment on JBIDE-21161 at 12/2/15 11:53 PM: ------------------------------------------------------------------------- GridLayout might do better than FormLayout, 'Browse' button makes 'Folder' controls to look somewhat lopsided. I wonder, why 'Add credentials...' is a link under 'Username:', I would suggest button 'Add...' or 'New...' to the right of its combo. Putting credentials in a group may work, but the component may also be made more flexible to be fit into any grid. Functionality may be moved from ChooseCredentialComposite to a new class ChooseCredentialComponent which will not inherit from Composite but implement method create(Composite) that will layout its controls into parent's grid. Then ChooseCredentialComposite may aggregate ChooseCredentialComponent and call create with itself as the parent. Other clients may either reuse ChooseCredentialComposite or instantiate ChooseCredentialComponent to call create with any composite. was (Author: scabanovich): GridLayout might do better than FormLayout, 'Browse' button makes 'Folder' controls to look somewhat lopsided. I wonder, why 'Add credentials...' is a link under 'Username:', I would suggest button 'Add...' or 'New...' to the right of its combo. Putting credentials in a group may work, but the component may also be made more flexible to be fit into any grid. Functionality may be moved form ChooseCredentialComposite to a new class ChooseCredentialComponent which will not inherit from Composite but implement method create(Composite) that will layout its controls into parent's grid. Then ChooseCredentialComposite may aggregate ChooseCredentialComponent and call create with itself as the parent. Other clients may either reuse ChooseCredentialComposite or instantiate ChooseCredentialComponent to call create with any composite. > various UI issues on new cdk server adapter > ------------------------------------------- > > Key: JBIDE-21161 > URL: https://issues.jboss.org/browse/JBIDE-21161 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Reporter: Max Rydahl Andersen > Assignee: Rob Stryker > Attachments: New_Server_and_Java_EE_-_Eclipse.png > > > the cDK server adapter page has some "weird" UI layout. > see attached. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-21161) various UI issues on new cdk server adapter

by Viacheslav Kabanovich (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21161?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich commented on JBIDE-21161: ----------------------------------------------- GridLayout might do better than FormLayout, 'Browse' button makes 'Folder' controls to look somewhat lopsided. I wonder, why 'Add credentials...' is a link under 'Username:', I would suggest button 'Add...' or 'New...' to the right of its combo. Putting credentials in a group may work, but the component may also be made more flexible to be fit into any grid. Functionality may be moved form ChooseCredentialComposite to a new class ChooseCredentialComponent which will not inherit from Composite but implement method create(Composite) that will layout its controls into parent's grid. Then ChooseCredentialComposite may aggregate ChooseCredentialComponent and call create with itself as the parent. Other clients may either reuse ChooseCredentialComposite or instantiate ChooseCredentialComponent to call create with any composite. > various UI issues on new cdk server adapter > ------------------------------------------- > > Key: JBIDE-21161 > URL: https://issues.jboss.org/browse/JBIDE-21161 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Reporter: Max Rydahl Andersen > Assignee: Rob Stryker > Attachments: New_Server_and_Java_EE_-_Eclipse.png > > > the cDK server adapter page has some "weird" UI layout. > see attached. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-21176) [CDK] installing cdk feature should install docker feature

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21176?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-21176: ------------------------------------ Yes, a feature REQUIREMENT is better than a feature INCLUDE because an include will attempt to create a source feature for all the things in the inclusion path, and since there's no docker sources in the TP, you'd need to source them from somewhere else. Or, as you discovered, REQUIRING upstream features is better. But I still think you would be best served by REQUIRING plugins via your MANIFEST.MF since you can then lock down specific version ranges and avoid unexpected nastiness should the o.e.lt.docker.feature change API unexpectedly or start including things that conflict w/ the rest of JBT. > [CDK] installing cdk feature should install docker feature > ---------------------------------------------------------- > > Key: JBIDE-21176 > URL: https://issues.jboss.org/browse/JBIDE-21176 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift, server, target-platform > Affects Versions: 4.3.1.Beta1 > Reporter: Rob Stryker > Assignee: Rob Stryker > Fix For: 4.3.1.Beta1 > > > CDK Feature should also install docker feature. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-21171) Need to remove bower / npm from jboss.tools.jsdt

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21171?page=com.atlassian.jira.plugi... ] Nick Boldt edited comment on JBIDE-21171 at 12/2/15 10:29 PM: -------------------------------------------------------------- So... we need to move some stuff out of o.j.t.jsdt and into the target platform (where it'll get the bits from eclipse.org) ? Can you give me a URL from which the eclipse.org stuff will come, and the list of features/plugins to add to the target platform(s) for JBT 4.4 / JBDS 10 ? was (Author: nickboldt): So... we need to move some stuff out of o.j.t.jsdt and into the target platform (where it'll get the bits from eclipse.org) ? > Need to remove bower / npm from jboss.tools.jsdt > ------------------------------------------------ > > Key: JBIDE-21171 > URL: https://issues.jboss.org/browse/JBIDE-21171 > Project: Tools (JBoss Tools) > Issue Type: Task > Components: build, nodejs > Affects Versions: 4.3.0.Final > Reporter: Ilya Buziuk > Assignee: Ilya Buziuk > Labels: new_and_noteworthy > Fix For: 4.4.0.Alpha1 > > > Assuming that bower / npm were moved to eclipse jsdt - https://git.eclipse.org/r/#/c/61336/ > Need to perform a cleanup in jboss.tools.jst.jsdt repo and remove related plugins / tests / features > Bower is in eclipse upstream and we probably will need reflect it in new & noteworthy -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-21171) Need to remove bower / npm from jboss.tools.jsdt

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21171?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-21171: ------------------------------------ So... we need to move some stuff out of o.j.t.jsdt and into the target platform (where it'll get the bits from eclipse.org) ? > Need to remove bower / npm from jboss.tools.jsdt > ------------------------------------------------ > > Key: JBIDE-21171 > URL: https://issues.jboss.org/browse/JBIDE-21171 > Project: Tools (JBoss Tools) > Issue Type: Task > Components: build, nodejs > Affects Versions: 4.3.0.Final > Reporter: Ilya Buziuk > Assignee: Ilya Buziuk > Labels: new_and_noteworthy > Fix For: 4.4.0.Alpha1 > > > Assuming that bower / npm were moved to eclipse jsdt - https://git.eclipse.org/r/#/c/61336/ > Need to perform a cleanup in jboss.tools.jst.jsdt repo and remove related plugins / tests / features > Bower is in eclipse upstream and we probably will need reflect it in new & noteworthy -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-21176) [CDK] installing cdk feature should install docker feature

by Rob Stryker (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21176?page=com.atlassian.jira.plugi... ] Rob Stryker commented on JBIDE-21176: ------------------------------------- Switched feature to do the following instead: {code} <requires> <import feature="org.eclipse.linuxtools.docker.feature"/> </requires> {code} This seems to function properly. > [CDK] installing cdk feature should install docker feature > ---------------------------------------------------------- > > Key: JBIDE-21176 > URL: https://issues.jboss.org/browse/JBIDE-21176 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift, server, target-platform > Affects Versions: 4.3.1.Beta1 > Reporter: Rob Stryker > Assignee: Rob Stryker > Fix For: 4.3.1.Beta1 > > > CDK Feature should also install docker feature. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-21176) [CDK] installing cdk feature should install docker feature

by Rob Stryker (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21176?page=com.atlassian.jira.plugi... ] Rob Stryker commented on JBIDE-21176: ------------------------------------- [~nickboldt] Pinging you for the advices. Because I need the advices. > [CDK] installing cdk feature should install docker feature > ---------------------------------------------------------- > > Key: JBIDE-21176 > URL: https://issues.jboss.org/browse/JBIDE-21176 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift, server, target-platform > Affects Versions: 4.3.1.Beta1 > Reporter: Rob Stryker > Assignee: Rob Stryker > Fix For: 4.3.1.Beta1 > > > CDK Feature should also install docker feature. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-21176) [CDK] installing cdk feature should install docker feature

by Rob Stryker (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21176?page=com.atlassian.jira.plugi... ] Rob Stryker updated JBIDE-21176: -------------------------------- Fix Version/s: 4.3.1.Beta1 > [CDK] installing cdk feature should install docker feature > ---------------------------------------------------------- > > Key: JBIDE-21176 > URL: https://issues.jboss.org/browse/JBIDE-21176 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift, server, target-platform > Affects Versions: 4.3.1.Beta1 > Reporter: Rob Stryker > Assignee: Rob Stryker > Fix For: 4.3.1.Beta1 > > > CDK Feature should also install docker feature. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 4 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-21176) [CDK] installing cdk feature should install docker feature

by Rob Stryker (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21176?page=com.atlassian.jira.plugi... ] Rob Stryker commented on JBIDE-21176: ------------------------------------- Adding the following to cdk.feature: {code} diff --git a/features/org.jboss.tools.openshift.cdk.feature/feature.xml b/features/org.jboss.tools.openshift.cdk.feature/feature.xml index 9271a16..354af4d 100755 --- a/features/org.jboss.tools.openshift.cdk.feature/feature.xml +++ b/features/org.jboss.tools.openshift.cdk.feature/feature.xml @@ -25,6 +25,11 @@ id="org.jboss.tools.openshift.feature" version="0.0.0"/> + <includes + id="org.eclipse.linuxtools.docker.feature" + version="0.0.0"/> + + <plugin id="org.jboss.tools.openshift.cdk.server" download-size="0" {code} However, on building, I get the following errors. {code} [INFO] org.jboss.tools.openshift.express.test.feature ..... SUCCESS [ 0.094 s] [INFO] org.jboss.tools.openshift.cdk.feature .............. FAILURE [ 0.143 s] [INFO] openshift.site ..................................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:19 min [INFO] Finished at: 2015-12-02T20:54:27-05:00 [INFO] Final Memory: 120M/1033M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-source-feature-plugin:0.24.0:source-feature (source-feature) on project org.jboss.tools.openshift.cdk.feature: Could not generate source feature for project MavenProject: org.jboss.tools.openshift.features:org.jboss.tools.openshift.cdk.feature:3.1.0-SNAPSHOT @ /home/rob/code/jbtools/github/jbosstools-openshift/features/org.jboss.tools.openshift.cdk.feature/pom.xml [ERROR] Missing sources for features [org.eclipse.linuxtools.docker.feature_1.2.0.201511162301] [ERROR] -> [Help 1] {code} > [CDK] installing cdk feature should install docker feature > ---------------------------------------------------------- > > Key: JBIDE-21176 > URL: https://issues.jboss.org/browse/JBIDE-21176 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift, server, target-platform > Affects Versions: 4.3.1.Beta1 > Reporter: Rob Stryker > Assignee: Rob Stryker > > CDK Feature should also install docker feature. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

10 years, 4 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues December 2015