[JBoss JIRA] (JBDS-3560) Arbitrary remote code execution with InvokerTransformer (COLLECTIONS-580)
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBDS-3560?page=com.atlassian.jira.plugin.... ]
Rob Stryker commented on JBDS-3560:
-----------------------------------
[~akazakov] Should this be 9.1.0.Beta2? Currently targeted 9.0.0.Beta2
> Arbitrary remote code execution with InvokerTransformer (COLLECTIONS-580)
> -------------------------------------------------------------------------
>
> Key: JBDS-3560
> URL: https://issues.jboss.org/browse/JBDS-3560
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Bug
> Components: upstream
> Affects Versions: 8.1.0.GA, 9.0.0.GA, 10.0.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 9.0.0.Beta2, 10.0.0.Alpha1
>
> Attachments: apache-commons-collections-in-JBDS7,8,9,10.png, apache-commons-collections-in-JBDS7,8,9,10_refs1.png, apache-commons-collections-in-JBDS7,8,9,10_refs10.png, apache-commons-collections-in-JBDS7,8,9,10_refs7.png, apache-commons-collections-in-JBDS7,8,9,10_refs8-IS-fuse.png, apache-commons-collections-in-JBDS7,8,9,10_refs8.png, apache-commons-collections-in-JBDS7,8,9,10_refs9.png, orbit.R20150519210750_vs_I20151117200049.log.txt, orbit.R20150519210750_vs_I20151117200049.log_onlyLatest.txt
>
>
> This is a container issue to wrap & track https://issues.apache.org/jira/browse/COLLECTIONS-580
> Problem is that JBDS 9 (and probably 8 and 10 too) include org.apache.commons.collections 3.2.0.v2013030210310, which is affected by COLLECTIONS-580 - Arbitrary remote code execution with InvokerTransformer
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-21298) 1 Test Failure(s) in JBIDE 4.3.1.Beta1 for runtime-detection component
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21298?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-21298:
--------------------------------
Fix Version/s: 4.3.1.Beta2
(was: 4.3.0.Beta2)
> 1 Test Failure(s) in JBIDE 4.3.1.Beta1 for runtime-detection component
> ----------------------------------------------------------------------
>
> Key: JBIDE-21298
> URL: https://issues.jboss.org/browse/JBIDE-21298
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: runtime-detection
> Affects Versions: 4.3.1.Beta1
> Reporter: Nick Boldt
> Assignee: Rob Stryker
> Priority: Critical
> Labels: testfailure
> Fix For: 4.3.1.Beta2, 4.4.0.Alpha1
>
>
> *1 Test Failure(s) in JBIDE 4.3.1.Beta1 for runtime-detection component:*
> http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-base_4.3.m...
> # [org.jboss.tools.runtime.test.RuntimeDetectionFrameworkTest|http://jenkins...] (failing for 5 builds)
> [Search for Test Failure JIRAs in JBIDE 4.3.1.Beta1 for runtime-detection component|https://issues.jboss.org/issues/?jql=labels+IN+%28%22testfailur...]
> -----
> * {color:red}org.jboss.tools.runtime.test.RuntimeDetectionFrameworkTest : testLoadSaveRuntimePaths{color} (failing for 5 builds)
>
> {code:title=http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-base_4.3.mars/62/testReport/org.jboss.tools.runtime.test/RuntimeDetectionFrameworkTest/testLoadSaveRuntimePaths}
> <case>
> <age>5</age>
> <className>org.jboss.tools.runtime.test.RuntimeDetectionFrameworkTest</className>
> <duration>0.0050</duration>
> <errorDetails>/qa/services/hudson/jboss-runtimes
> expected:<0> but was:<1></errorDetails>
> <errorStackTrace>junit.framework.AssertionFailedError: /qa/services/hudson/jboss-runtimes
> expected:<0> but was:<1>
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.failNotEquals(Assert.java:329)
> at junit.framework.Assert.assertEquals(Assert.java:78)
> at junit.framework.Assert.assertEquals(Assert.java:234)
> at junit.framework.TestCase.assertEquals(TestCase.java:401)
> at org.jboss.tools.runtime.test.RuntimeDetectionFrameworkTest.testLoadSaveRuntimePaths(RuntimeDetectionFrameworkTest.java:73)
> </errorStackTrace>
> <failedSince>58</failedSince>
> <name>testLoadSaveRuntimePaths</name>
> <skipped>false</skipped>
> <status>FAILED</status>
> </case>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-21205) Modify runtime detection to ensure a detector is only asked to initialize runtime definitions it created
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21205?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-21205:
--------------------------------
Fix Version/s: 4.4.0.Alpha1
> Modify runtime detection to ensure a detector is only asked to initialize runtime definitions it created
> --------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21205
> URL: https://issues.jboss.org/browse/JBIDE-21205
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: runtime-detection
> Affects Versions: 4.3.0.Beta2
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Priority: Minor
> Fix For: 4.4.0.Alpha1
>
>
> See https://issues.jboss.org/browse/JBIDE-21193 for some background.
> A runtime detector is asked to initialize all RuntimeDefinition objects, not just ones it created. While this "works" if you expect a detector to know all type-strings that it creates RuntimeDefinition objects using, it is still less than optimal and the workflow is a bit counter-intuitive.
> Suggestion is to add a new constructor to RuntimeDefinition and add abstract method for creating those definitions to AbstractRuntimeDetectorDelegate to instantiate these definitions.
> Care should be taken since this is all public API and used in Fuse, cdk, servertools, and other locations. It may not be possible to compel consumers to use the new API at all, and so the benefit may be zero.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-21199) AssertionFailedException invoking menu on a server.
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21199?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-21199:
-------------------------------------
Similar issue is JBIDE-21285
> AssertionFailedException invoking menu on a server.
> ---------------------------------------------------
>
> Key: JBIDE-21199
> URL: https://issues.jboss.org/browse/JBIDE-21199
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: server
> Affects Versions: 4.4.0.Alpha1
> Reporter: Viacheslav Kabanovich
> Assignee: Rob Stryker
> Priority: Minor
> Fix For: 4.3.1.Beta1, 4.4.0.Alpha1
>
>
> 1. Create a server with a JBoss runtime.
> 2. Make sure that context menu is invoked without exceptions.
> 3. Open Preferences/Server/Runtime Environments and rename the runtime environment bound to the server.
> 4. Invoke contex menu.
> Menu is opened, but there is logged exception:
> {code}
> !ENTRY org.eclipse.ui.navigator 4 2 2015-12-07 14:45:35.604
> !MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.ui.navigator".
> !STACK 0
> org.eclipse.core.runtime.AssertionFailedException: null argument:
> at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)
> at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:73)
> at org.eclipse.core.runtime.Path.initialize(Path.java:641)
> at org.eclipse.core.runtime.Path.<init>(Path.java:238)
> at org.eclipse.core.runtime.Path.<init>(Path.java:186)
> at org.jboss.tools.as.core.server.controllable.subsystems.internal.LocalDeploymentOptionsController.makeRelative(LocalDeploymentOptionsController.java:44)
> at org.jboss.tools.as.core.server.controllable.subsystems.internal.LocalDeploymentOptionsController.getDeployFolder(LocalDeploymentOptionsController.java:68)
> at org.jboss.tools.as.core.server.controllable.systems.AbstractJBossDeploymentOptionsController.getDeploymentsRootFolder(AbstractJBossDeploymentOptionsController.java:78)
> at org.jboss.ide.eclipse.as.ui.subsystems.internal.LocalExploreBehavior.getPath(LocalExploreBehavior.java:105)
> at org.jboss.ide.eclipse.as.ui.subsystems.internal.LocalExploreBehavior.getDeployDirectory(LocalExploreBehavior.java:62)
> at org.jboss.ide.eclipse.as.ui.subsystems.internal.LocalExploreBehavior.canExploreServer(LocalExploreBehavior.java:81)
> at org.jboss.ide.eclipse.as.ui.subsystems.internal.LocalExploreBehavior.canExplore(LocalExploreBehavior.java:34)
> at org.jboss.tools.as.wst.server.ui.xpl.ExploreActionProvider.fillContextMenu(ExploreActionProvider.java:102)
> at org.eclipse.ui.navigator.NavigatorActionService$2.run(NavigatorActionService.java:225)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.ui.navigator.NavigatorActionService.addCommonActionProviderMenu(NavigatorActionService.java:219)
> at org.eclipse.ui.navigator.NavigatorActionService.fillContextMenu(NavigatorActionService.java:174)
> at org.eclipse.ui.navigator.CommonNavigatorManager.fillContextMenu(CommonNavigatorManager.java:267)
> at org.eclipse.ui.navigator.CommonNavigatorManager$3.menuAboutToShow(CommonNavigatorManager.java:283)
> at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:333)
> at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:466)
> at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:461)
> at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:493)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:255)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1327)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1351)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1332)
> at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:198)
> at org.eclipse.swt.widgets.Display.runPopups(Display.java:3861)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3420)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
> {code}
> I think we should prevent that exception.
> 5. Open the server in editor. Its 'Runtime Environment' is empty, which means that server lost connection to the renamed environment. Can we do something to prevent it, or is it an upstream issue, or is it an expected behavior?
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-20738) JMX Navigator Refresh Command is running in main UI Thread
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20738?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-20738:
-------------------------------------
I think this jira is limited to the above stack traces, or similar code path. I think it's unlikely there are other code paths refreshing the elements in the view, and if they are, they're bugs in different code, so should be treated as different issues. I think the PR makes it clear that this code path is now executed in a job, so I'd just mark it as fixed unless you can replicate somehow.
> JMX Navigator Refresh Command is running in main UI Thread
> ----------------------------------------------------------
>
> Key: JBIDE-20738
> URL: https://issues.jboss.org/browse/JBIDE-20738
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jmx
> Affects Versions: 4.3.0.CR1
> Reporter: Denis Golovin
> Assignee: Rob Stryker
> Fix For: 4.3.1.Beta1, 4.4.0.Alpha1
>
>
> Refresh in JMX Navigator freezes UI because executed in main UI thread:
> {code}Thread [main] (Suspended (breakpoint at line 435 in org.jboss.tools.jmx.jvmmonitor.internal.core.ActiveJvm))
> owns: org.jboss.tools.jmx.local.internal.JvmConnectionWrapper (id=162)
> org.jboss.tools.jmx.jvmmonitor.internal.core.ActiveJvm.initialize(javax.management.remote.JMXServiceURL) line: 435
> org.jboss.tools.jmx.jvmmonitor.internal.core.ActiveJvm.initialize(java.lang.String, int) line: 465
> org.jboss.tools.jmx.jvmmonitor.internal.core.ActiveJvm.initialize() line: 445
> org.jboss.tools.jmx.jvmmonitor.internal.core.ActiveJvm.connect(int, boolean) line: 233
> org.jboss.tools.jmx.jvmmonitor.internal.core.ActiveJvm.connect(int) line: 213
> org.jboss.tools.jmx.local.internal.JvmConnectionWrapper.connect() line: 121
> org.jboss.tools.jmx.ui.internal.actions.RefreshAction.refreshObjectNode(java.lang.Object) line: 107
> org.jboss.tools.jmx.ui.internal.actions.RefreshAction.run() line: 153
> org.jboss.tools.jmx.ui.internal.actions.RefreshAction(org.eclipse.jface.action.Action).runWithEvent(org.eclipse.swt.widgets.Event) line: 473
> org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(org.eclipse.swt.widgets.Event, boolean) line: 595
> org.eclipse.jface.action.ActionContributionItem.access$2(org.eclipse.jface.action.ActionContributionItem, org.eclipse.swt.widgets.Event, boolean) line: 511
> org.eclipse.jface.action.ActionContributionItem$5.handleEvent(org.eclipse.swt.widgets.Event) line: 420
> org.eclipse.swt.widgets.EventTable.sendEvent(org.eclipse.swt.widgets.Event) line: 84
> org.eclipse.swt.widgets.Display.sendEvent(org.eclipse.swt.widgets.EventTable, org.eclipse.swt.widgets.Event) line: 4481
> org.eclipse.swt.widgets.MenuItem(org.eclipse.swt.widgets.Widget).sendEvent(org.eclipse.swt.widgets.Event) line: 1327
> org.eclipse.swt.widgets.Display.runDeferredEvents() line: 3819
> org.eclipse.swt.widgets.Display.readAndDispatch() line: 3430
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run() line: 1127
> org.eclipse.core.databinding.observable.Realm.runWithDefault(org.eclipse.core.databinding.observable.Realm, java.lang.Runnable) line: 337
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(org.eclipse.e4.ui.model.application.MApplicationElement, org.eclipse.e4.core.contexts.IEclipseContext) line: 1018
> org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(org.eclipse.e4.ui.model.application.MApplicationElement) line: 156
> org.eclipse.ui.internal.Workbench$5.run() line: 654
> org.eclipse.core.databinding.observable.Realm.runWithDefault(org.eclipse.core.databinding.observable.Realm, java.lang.Runnable) line: 337
> org.eclipse.ui.internal.Workbench.createAndRunWorkbench(org.eclipse.swt.widgets.Display, org.eclipse.ui.application.WorkbenchAdvisor) line: 598
> org.eclipse.ui.PlatformUI.createAndRunWorkbench(org.eclipse.swt.widgets.Display, org.eclipse.ui.application.WorkbenchAdvisor) line: 150
> org.eclipse.ui.internal.ide.application.IDEApplication.start(org.eclipse.equinox.app.IApplicationContext) line: 139
> org.eclipse.equinox.internal.app.EclipseAppHandle.run(java.lang.Object) line: 196
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(java.lang.Object) line: 134
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(java.lang.Object) line: 104
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(java.lang.Object) line: 380
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(java.lang.String[], java.lang.Runnable) line: 235
> sun.reflect.NativeMethodAccessorImpl.invoke0(java.lang.reflect.Method, java.lang.Object, java.lang.Object[]) line: not available [native method]
> sun.reflect.NativeMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) line: 62
> sun.reflect.DelegatingMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) line: 43
> java.lang.reflect.Method.invoke(java.lang.Object, java.lang.Object...) line: 497
> org.eclipse.equinox.launcher.Main.invokeFramework(java.lang.String[], java.net.URL[]) line: 669
> org.eclipse.equinox.launcher.Main.basicRun(java.lang.String[]) line: 608
> org.eclipse.equinox.launcher.Main.run(java.lang.String[]) line: 1515
> org.eclipse.equinox.launcher.Main.main(java.lang.String[]) line: 1488
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months