[JBoss JIRA] (JBIDE-21316) Creating artifact for non-batch project results in NPE
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21316?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21316:
-----------------------------------------------
[~akazakov], please take a look at the pull request.
> Creating artifact for non-batch project results in NPE
> ------------------------------------------------------
>
> Key: JBIDE-21316
> URL: https://issues.jboss.org/browse/JBIDE-21316
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: batch
> Affects Versions: 4.3.1.Beta1
> Reporter: Rastislav Wagner
> Assignee: Viacheslav Kabanovich
> Fix For: 4.3.1.Beta2, 4.4.0.Alpha1
>
>
> {code}
> java.lang.NullPointerException
> at org.jboss.tools.batch.internal.core.impl.PreferredPackageManager.savePreferredPackage(PreferredPackageManager.java:95)
> at org.jboss.tools.batch.ui.internal.wizard.NewBatchArtifactWizard.performFinish(NewBatchArtifactWizard.java:116)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:799)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:429)
> at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:619)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
> at org.eclipse.jface.window.Window.open(Window.java:803)
> at org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:269)
> at org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:290)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:252)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:234)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
> at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:493)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:486)
> at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
> at org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:343)
> at org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:160)
> at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:595)
> at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:511)
> at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:420)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBIDE-21374) EL var is not resolved correctly when value is set with bean method returning an array
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21374?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21374:
-----------------------------------------------
[~akazakov], please take a look at the pull request.
> EL var is not resolved correctly when value is set with bean method returning an array
> ---------------------------------------------------------------------------------------
>
> Key: JBIDE-21374
> URL: https://issues.jboss.org/browse/JBIDE-21374
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common/jst/core, jsf
> Affects Versions: 4.4.0.Alpha1
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
> Fix For: 4.4.0.Alpha1
>
>
> 1. Create a bean class with property returning array:
> {code}
> public SignOffStatus[] getStatuses() {
> return null;
> }
> {code}
> 2. Set collection value of an iterative tag with method call rather than property call
> {code}
> <p:selectOneMenu value="#{instancePage.instanceCriteria.status}">
> <f:selectItem itemLabel="--select--" itemValue="#{null}" />
> <f:selectItems value="#{appBean.getStatuses()}" var="stat" itemLabel="#{stat.label}" />
> </p:selectOneMenu>
> {code}
> 3. Failure: members of var are not resolved.
> If value is set with property call
> {code}
> value="#{appBean.statuses}"
> {code}
> and/or if method getStatuses() returns a collection type, then var members resolution works ok.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBIDE-21150) SSL certificate dialog: Provide a way to change one's mind about accepting an SSL certificate
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21150?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich edited comment on JBIDE-21150 at 12/24/15 12:45 AM:
--------------------------------------------------------------------------
[~fbricon], please take a look at the pull request.
Preference page 'OpenShift 3/SSL certificates' is added.
It displays list of untrusted SSL certificates with decisions made in "Untrusted SSL Certificate" dialog.
The decision can be changed by checkbox.
The decision can be deleted from the list, then as soon as a decision on the certificate is needed, dialog "Untrusted SSL Certificate" will appear again for it.
Text presentation of a certificate on the preference page is the same as in the dialog.
Only OpenShift 3 case is implemented for now. If you find the solution ok, then I will apply it to OpenShift 2 as well.
was (Author: scabanovich):
[~fbricon], please take a look at the pull request.
Preference page 'OpenShift 3/SSL certificates' is added.
It displays list of untrusted SSL certificates with decisions made in "Untrusted SSL Certificate" dialog.
The decision can be changed by checkbox.
The decision can be deleted item from the list, then as soon as a decision on certificate is needed, dialog "Untrusted SSL Certificate" will appear again.
Text presentation of a certificate on the preference page is the same as in the dialog.
Only OpenShift 3 case is implemented for now. If you find the solution ok, then I will apply it to OpenShift 2 as well.
> SSL certificate dialog: Provide a way to change one's mind about accepting an SSL certificate
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-21150
> URL: https://issues.jboss.org/browse/JBIDE-21150
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Jan Richter
> Labels: openshift_v2, openshift_v3
> Fix For: 4.3.1.Beta2
>
>
> The tooling will only give the user one chance to accept/deny the SSL certificate, which happens on start of the session. This is particularly annoying when for some reason the user denies the certificate (or just cancels the dialog) because the only way to reset it is to restart the IDE.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBIDE-21150) SSL certificate dialog: Provide a way to change one's mind about accepting an SSL certificate
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21150?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21150:
-----------------------------------------------
[~fbricon], please take a look at the pull request.
Preference page 'OpenShift 3/SSL certificates' is added.
It displays list of untrusted SSL certificates with decisions made in "Untrusted SSL Certificate" dialog.
The decision can be changed by checkbox.
The decision can be deleted item from the list, then as soon as a decision on certificate is needed, dialog "Untrusted SSL Certificate" will appear again.
Text presentation of a certificate on the preference page is the same as in the dialog.
Only OpenShift 3 case is implemented for now. If you find the solution ok, then I will apply it to OpenShift 2 as well.
> SSL certificate dialog: Provide a way to change one's mind about accepting an SSL certificate
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-21150
> URL: https://issues.jboss.org/browse/JBIDE-21150
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Jan Richter
> Labels: openshift_v2, openshift_v3
> Fix For: 4.3.1.Beta2
>
>
> The tooling will only give the user one chance to accept/deny the SSL certificate, which happens on start of the session. This is particularly annoying when for some reason the user denies the certificate (or just cancels the dialog) because the only way to reset it is to restart the IDE.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBIDE-21184) Deploy docker: "Resource Name" should not error (but "*" required) if empty
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21184?page=com.atlassian.jira.plugi... ]
Fred Bricon reassigned JBIDE-21184:
-----------------------------------
Assignee: Viacheslav Kabanovich
Resolution: Done
Applied in master / 4.3.x. Thanks [~scabanovich]!
> Deploy docker: "Resource Name" should not error (but "*" required) if empty
> ---------------------------------------------------------------------------
>
> Key: JBIDE-21184
> URL: https://issues.jboss.org/browse/JBIDE-21184
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Andre Dietisheim
> Assignee: Viacheslav Kabanovich
> Priority: Minor
> Labels: deploy_docker_wizard, openshift_v3
> Fix For: 4.3.1.Beta2
>
> Attachments: resource-name-empty.png
>
>
> how to reproduce:
> # EXEC: in explroer: open up context menu on an openshift 3 project and choose "Deploy Docker Image..."
> # ASSERT: Deploy Docker Image wizard pops up empty
> Result:
> The "Resource Name" field is decorated with an error marker, it should be decorated with a "*" which is used all across OpenShift when required values are missing/empty
> !resource-name-empty.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBIDE-21301) Preferences: path to OC binary is not shown on OpenShift 3 page if binary is on $PATH
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21301?page=com.atlassian.jira.plugi... ]
Fred Bricon reassigned JBIDE-21301:
-----------------------------------
Assignee: Viacheslav Kabanovich
Resolution: Done
Applied in master / 4.3.x. Thanks [~scabanovich]!
> Preferences: path to OC binary is not shown on OpenShift 3 page if binary is on $PATH
> -------------------------------------------------------------------------------------
>
> Key: JBIDE-21301
> URL: https://issues.jboss.org/browse/JBIDE-21301
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Assignee: Viacheslav Kabanovich
> Priority: Minor
> Labels: openshift_v3, preferences
> Fix For: 4.3.1.Beta2
>
>
> In JBIDE-21183 was implemented auto-lookup of 'oc' binary on $PATH. This works ok, but in Workbench Preference dialog on OpenShift 3 preference page where location to oc is shown and stored is not this path displayed in this case. If 'oc' binary is located on $PATH it should be also visible on OpenShift 3 preference page.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBIDE-21184) Deploy docker: "Resource Name" should not error (but "*" required) if empty
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21184?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21184:
-----------------------------------------------
[~fbricon],[~jcantrill], please take a look at the pull request.
> Deploy docker: "Resource Name" should not error (but "*" required) if empty
> ---------------------------------------------------------------------------
>
> Key: JBIDE-21184
> URL: https://issues.jboss.org/browse/JBIDE-21184
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: deploy_docker_wizard, openshift_v3
> Fix For: 4.3.1.Beta2
>
> Attachments: resource-name-empty.png
>
>
> how to reproduce:
> # EXEC: in explroer: open up context menu on an openshift 3 project and choose "Deploy Docker Image..."
> # ASSERT: Deploy Docker Image wizard pops up empty
> Result:
> The "Resource Name" field is decorated with an error marker, it should be decorated with a "*" which is used all across OpenShift when required values are missing/empty
> !resource-name-empty.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years