[JBoss JIRA] (JBIDE-17497) Servertools plugin heirarchy causes issues for clients
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17497?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen updated JBIDE-17497:
----------------------------------------
Fix Version/s: 4.3.0.Alpha2
(was: 4.3.0.Alpha1)
> Servertools plugin heirarchy causes issues for clients
> ------------------------------------------------------
>
> Key: JBIDE-17497
> URL: https://issues.jboss.org/browse/JBIDE-17497
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: server
> Affects Versions: 4.2.0.Beta2
> Reporter: Rob Stryker
> Priority: Critical
> Fix For: 4.3.0.Alpha2
>
> Attachments: 2014-06-02 19.07.bmml, 2014-06-02 19.07.png
>
>
> The plugin heirarchy of ASTools is better than it used to be, but not good enough for what current consumers of ASTools need it for.
> The problem is simple. There are 3 types of clients using ASTools API:
> 1) Those who need all of ASTools installed (including server adapter)
> 2) Those who only want access to interfaces, to use *if* server adapters is installed (do NOT want as.core force installed)
> 3) Those who create their own server adapters, want to use interfaces and some impl classes, but do not want as.core (server adapters) installed.
> Those of group 1 are no problem.
> Those of group 2 want as.wtp.core and as.wtp.ui to be minimal implementations with very few (near-zero) dependencies
> Those of group 3 want as.wtp.core and as.wtp.ui to provide as much functionality as possible, including things like zipping archives, or integration with download runtimes.
> An example of group 1 is jbosstools-central.
> An example of group 2 is ESB / BPEL
> An example of group 3 is FuseIDE
> Currently, there are classes in plugins positioned above as.core (ie, depend on as.core) that would be useful to FuseIDE (integration with stacks / runtimes / archives), but pushing these classes down into as.wtp.core / as.wtp.ui would mean the as.wtp.* plugins now require archives / stacks / yaml, and then so does bpel / esb.
> There needs to be another set of core/ui plugins for extenders or implementers that do NOT bring in the server adapters.
> Alternatively, we could move the server adapters out of as.core / as.ui and into two new higher-level plugins, as.serveradapter.core / as.serveradapter.ui, leaving as.core/as.ui as the new plugins to be extended by fuse-ide.
> There are of course other possible solutions, but all possible solutions basically require new plugins with substantial class movement.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 4 months
[JBoss JIRA] (JBIDE-18524) Avoid using multiple IDocuments when opening an FTL file
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18524?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-18524:
---------------------------------------------
this fell through cracks ... [~dgolovin] / [~ppalaga] is this something that makes sense to put in ?
> Avoid using multiple IDocuments when opening an FTL file
> --------------------------------------------------------
>
> Key: JBIDE-18524
> URL: https://issues.jboss.org/browse/JBIDE-18524
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: freemarker
> Affects Versions: 4.2.0.CR2
> Reporter: Peter Palaga
> Assignee: Denis Golovin
> Priority: Minor
> Fix For: 4.2.3.Beta1, 4.3.0.Alpha2
>
>
> This is a matter of effectiveness and getting in line with what is usual in other plugins:
> (1) In the FreeMarker {{Editor}} constructor, we currently create a per-{{Editor}} instance of {{DocumentProvider}}. {{Editor}}s should rather use a single {{DocumentProvider}} hosted in {{Plugin}}. This is how it is done in many other editors, see e.g. {{AntEditor.initializeEditor()}}, {{PropertiesFileEditor.initializeEditor()}}, {{ClassFileEditor()}}, etc.
> (2) {{Editor.init(IEditorSite, IEditorInput)}} is called twice from {{FreemarkerMultiPageEditor}} when opening an FTL file. This causes e.g. partitioning twice. Steps to verify: put a breakpoint on {{AbstractTextEditor.init(IEditorSite, IEditorInput)}} and open an FTL file. NOT OK: the breakpoint gets hit twice, ECPECTED: the breakpoint should be visited once only.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 4 months
[JBoss JIRA] (JBIDE-18524) Avoid using multiple IDocuments when opening an FTL file
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18524?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen reassigned JBIDE-18524:
-------------------------------------------
Assignee: Denis Golovin (was: Peter Palaga)
> Avoid using multiple IDocuments when opening an FTL file
> --------------------------------------------------------
>
> Key: JBIDE-18524
> URL: https://issues.jboss.org/browse/JBIDE-18524
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: freemarker
> Affects Versions: 4.2.0.CR2
> Reporter: Peter Palaga
> Assignee: Denis Golovin
> Priority: Minor
> Fix For: 4.2.3.Beta1, 4.3.0.Alpha2
>
>
> This is a matter of effectiveness and getting in line with what is usual in other plugins:
> (1) In the FreeMarker {{Editor}} constructor, we currently create a per-{{Editor}} instance of {{DocumentProvider}}. {{Editor}}s should rather use a single {{DocumentProvider}} hosted in {{Plugin}}. This is how it is done in many other editors, see e.g. {{AntEditor.initializeEditor()}}, {{PropertiesFileEditor.initializeEditor()}}, {{ClassFileEditor()}}, etc.
> (2) {{Editor.init(IEditorSite, IEditorInput)}} is called twice from {{FreemarkerMultiPageEditor}} when opening an FTL file. This causes e.g. partitioning twice. Steps to verify: put a breakpoint on {{AbstractTextEditor.init(IEditorSite, IEditorInput)}} and open an FTL file. NOT OK: the breakpoint gets hit twice, ECPECTED: the breakpoint should be visited once only.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 4 months
[JBoss JIRA] (JBIDE-18524) Avoid using multiple IDocuments when opening an FTL file
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18524?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen updated JBIDE-18524:
----------------------------------------
Fix Version/s: 4.2.3.Beta1
4.3.0.Alpha2
(was: 4.2.x)
(was: 4.3.0.Alpha1)
> Avoid using multiple IDocuments when opening an FTL file
> --------------------------------------------------------
>
> Key: JBIDE-18524
> URL: https://issues.jboss.org/browse/JBIDE-18524
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: freemarker
> Affects Versions: 4.2.0.CR2
> Reporter: Peter Palaga
> Assignee: Denis Golovin
> Priority: Minor
> Fix For: 4.2.3.Beta1, 4.3.0.Alpha2
>
>
> This is a matter of effectiveness and getting in line with what is usual in other plugins:
> (1) In the FreeMarker {{Editor}} constructor, we currently create a per-{{Editor}} instance of {{DocumentProvider}}. {{Editor}}s should rather use a single {{DocumentProvider}} hosted in {{Plugin}}. This is how it is done in many other editors, see e.g. {{AntEditor.initializeEditor()}}, {{PropertiesFileEditor.initializeEditor()}}, {{ClassFileEditor()}}, etc.
> (2) {{Editor.init(IEditorSite, IEditorInput)}} is called twice from {{FreemarkerMultiPageEditor}} when opening an FTL file. This causes e.g. partitioning twice. Steps to verify: put a breakpoint on {{AbstractTextEditor.init(IEditorSite, IEditorInput)}} and open an FTL file. NOT OK: the breakpoint gets hit twice, ECPECTED: the breakpoint should be visited once only.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 4 months