[JBoss JIRA] (JBIDE-19194) FeedHenry requires minimal-json, but it was removed from TP
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19194?page=com.atlassian.jira.plugi... ]
Mickael Istria updated JBIDE-19194:
-----------------------------------
Git Pull Request: https://github.com/jbosstools/jbosstools-target-platforms/pull/127 (was: https://github.com/jbosstools/jbosstools-aerogear/pull/115)
> FeedHenry requires minimal-json, but it was removed from TP
> -----------------------------------------------------------
>
> Key: JBIDE-19194
> URL: https://issues.jboss.org/browse/JBIDE-19194
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: target-platform
> Affects Versions: 4.2.3.Beta1, 4.3.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.2.3.Beta1, 4.3.0.Alpha1
>
>
> When moving Tern from the 4.42.x and 4.50.x target platforms into JST, we also moved minimal-json assuming nothing else required it.
> But turns out that Feedhenry (Aerogear) also needs minimal-json.
> So... we need to add that plugin back into the TPs, and make sure that the version we include works with both Aerogear/FeedHenry (0.9.2, same code base in both 4.2.3 and 4.3.0, currently) and JST/Tern (0.9.1 in JBT 4.2, 0.9.2 in JBT 4.3).
> [~maxandersen] [~gercan] [~dgolovin] [~akazakov]
> In JBT 4.2.0-2 we include Tern 0.6 and minimal-json 0.9.1.
> In JBT 4.2.3 we include Tern 0.7 and minimal-json 0.9.1.
> In JBT 4.3.0 we _currently_ include Tern 0.8 and minimal-json 0.9.2.
> Which version should we include in the target platforms for JBT 4.2.3 (4.42.0.Beta1) and JBT 4.3.0 (4.50.0.Alpha1) ?
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-19194) FeedHenry requires minimal-json, but it was removed from TP
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19194?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-19194:
----------------------------------------
Suggested Pull Request to reintroduce minimal-json in TP: https://github.com/jbosstools/jbosstools-target-platforms/pull/127
> FeedHenry requires minimal-json, but it was removed from TP
> -----------------------------------------------------------
>
> Key: JBIDE-19194
> URL: https://issues.jboss.org/browse/JBIDE-19194
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: target-platform
> Affects Versions: 4.2.3.Beta1, 4.3.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.2.3.Beta1, 4.3.0.Alpha1
>
>
> When moving Tern from the 4.42.x and 4.50.x target platforms into JST, we also moved minimal-json assuming nothing else required it.
> But turns out that Feedhenry (Aerogear) also needs minimal-json.
> So... we need to add that plugin back into the TPs, and make sure that the version we include works with both Aerogear/FeedHenry (0.9.2, same code base in both 4.2.3 and 4.3.0, currently) and JST/Tern (0.9.1 in JBT 4.2, 0.9.2 in JBT 4.3).
> [~maxandersen] [~gercan] [~dgolovin] [~akazakov]
> In JBT 4.2.0-2 we include Tern 0.6 and minimal-json 0.9.1.
> In JBT 4.2.3 we include Tern 0.7 and minimal-json 0.9.1.
> In JBT 4.3.0 we _currently_ include Tern 0.8 and minimal-json 0.9.2.
> Which version should we include in the target platforms for JBT 4.2.3 (4.42.0.Beta1) and JBT 4.3.0 (4.50.0.Alpha1) ?
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-19194) FeedHenry requires minimal-json, but it was removed from TP
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19194?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-19194:
----------------------------------------
Adding it to TP seems to be a cleaner, more standard and more reliable approach. I'll make a PR.
> FeedHenry requires minimal-json, but it was removed from TP
> -----------------------------------------------------------
>
> Key: JBIDE-19194
> URL: https://issues.jboss.org/browse/JBIDE-19194
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: target-platform
> Affects Versions: 4.2.3.Beta1, 4.3.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.2.3.Beta1, 4.3.0.Alpha1
>
>
> When moving Tern from the 4.42.x and 4.50.x target platforms into JST, we also moved minimal-json assuming nothing else required it.
> But turns out that Feedhenry (Aerogear) also needs minimal-json.
> So... we need to add that plugin back into the TPs, and make sure that the version we include works with both Aerogear/FeedHenry (0.9.2, same code base in both 4.2.3 and 4.3.0, currently) and JST/Tern (0.9.1 in JBT 4.2, 0.9.2 in JBT 4.3).
> [~maxandersen] [~gercan] [~dgolovin] [~akazakov]
> In JBT 4.2.0-2 we include Tern 0.6 and minimal-json 0.9.1.
> In JBT 4.2.3 we include Tern 0.7 and minimal-json 0.9.1.
> In JBT 4.3.0 we _currently_ include Tern 0.8 and minimal-json 0.9.2.
> Which version should we include in the target platforms for JBT 4.2.3 (4.42.0.Beta1) and JBT 4.3.0 (4.50.0.Alpha1) ?
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-7379) Importing / Exporting of AS servers ignore command line args, filesets, xpaths, and even runtimes
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-7379?page=com.atlassian.jira.plugin... ]
Rob Stryker commented on JBIDE-7379:
------------------------------------
Hi Paul: Any more work on this issue? I'd be interested to see if your API is extensible.
> Importing / Exporting of AS servers ignore command line args, filesets, xpaths, and even runtimes
> -------------------------------------------------------------------------------------------------
>
> Key: JBIDE-7379
> URL: https://issues.jboss.org/browse/JBIDE-7379
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.0.Beta1
> Reporter: Rob Stryker
> Assignee: Paul Richardson
> Fix For: 4.3.x
>
>
> Exporting of servers is incomplete. It does not export any saved filesets, xpaths, or custom launch configuration args.
> Importing of servers is also incomplete, not importing any of these elements. Also, while the servers themselves are imported, sometimes their runtimes are not created at all, and you get a server with no runtime. This has been very hard to track down, but no runtimeAdded event is ever fired, and in our code it looks as if they're not even created or looked for.
> This needs to be re-visited and tested extensively. I expect I will move import / export functionality into the AS plugin for now since hte o.j.t.runtime plugin already depends on AS. This will allow me to use classes already in the AS test suite for filesets and xpaths properly. I will keep the handler in the runtimes plugin but merely have it delegate to the functionality stored in the as plugin.
> It currently seems to be saving only servers and not the runtimes.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months