[JBoss JIRA] (JBIDE-19410) earlyaccess still not failing gracefully
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19410?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-19410:
---------------------------------------
{quote}By the line numbers exception is for code from jbosstools-4.2.x branch.
InstallationChecker.java#L101 fails because iusForFamily is null. Proposed PR doesn't deal with NPE. It will still reported the same way.{quote}
that is not right. I mixed it up with JBIDE-18542.
> earlyaccess still not failing gracefully
> ----------------------------------------
>
> Key: JBIDE-19410
> URL: https://issues.jboss.org/browse/JBIDE-19410
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Reporter: Max Rydahl Andersen
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.3.0.Alpha2
>
>
> start jboss tools in PDE and earlyaccess will pop up with error dialog that it had an error because it could not install things (which is expected when running in PDE)
> start jboss tools without network access and I sometime see it pop up - can't reprouce that consistently.
> but in short - seems like earlyaccess continues to want to tell users that something is wrong with early access even when it is not enabled but nor should it even if enabled. Show such error on the earlyaccess page rather than a blocking dialog.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (JBIDE-18542) NPE during "Check installation for Early Access"
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18542?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-18542:
---------------------------------------
Easiest manual way to replicate just assign null in code and run it. Question remains why sometimes null value was returned? Was it fixed?
> NPE during "Check installation for Early Access"
> ------------------------------------------------
>
> Key: JBIDE-18542
> URL: https://issues.jboss.org/browse/JBIDE-18542
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Affects Versions: 4.2.0.CR2
> Reporter: Rob Cernich
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.2.x, 4.3.0.Alpha2
>
>
> I got the following exception upon restart after updating to CR2 from the following site: http://download.jboss.org/jbosstools/updates/staging/luna/
> {noformat}
> java.lang.NullPointerException
> at org.jboss.tools.central.installation.InstallationChecker.getUnits(InstallationChecker.java:99)
> at org.jboss.tools.central.installation.InstallationChecker.getEarlyAccessUnits(InstallationChecker.java:79)
> at org.jboss.tools.central.installation.InstallationChecker.hasEarlyAccess(InstallationChecker.java:72)
> at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText$3.run(JBossCentralEditor.java:574)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (JBIDE-19410) earlyaccess still not failing gracefully
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19410?page=com.atlassian.jira.plugi... ]
Denis Golovin updated JBIDE-19410:
----------------------------------
Comment: was deleted
(was: easiest manual way to replicate just assign null in code and run it. Question remains why sometimes null value returned?)
> earlyaccess still not failing gracefully
> ----------------------------------------
>
> Key: JBIDE-19410
> URL: https://issues.jboss.org/browse/JBIDE-19410
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Reporter: Max Rydahl Andersen
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.3.0.Alpha2
>
>
> start jboss tools in PDE and earlyaccess will pop up with error dialog that it had an error because it could not install things (which is expected when running in PDE)
> start jboss tools without network access and I sometime see it pop up - can't reprouce that consistently.
> but in short - seems like earlyaccess continues to want to tell users that something is wrong with early access even when it is not enabled but nor should it even if enabled. Show such error on the earlyaccess page rather than a blocking dialog.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (JBIDE-18542) NPE during "Check installation for Early Access"
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18542?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-18542:
---------------------------------------
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
at org.eclipse.swt.SWT.error(SWT.java:4477)
at org.eclipse.swt.SWT.error(SWT.java:4392)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:139)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3793)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3431)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:648)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:592)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
at org.eclipse.equinox.launcher.Main.main(Main.java:1438)
Caused by: java.lang.NullPointerException
at org.jboss.tools.central.installation.InstallationChecker.getUnits(InstallationChecker.java:106)
at org.jboss.tools.central.installation.InstallationChecker.getEarlyAccessUnits(InstallationChecker.java:97)
at org.jboss.tools.central.installation.InstallationChecker.hasEarlyAccess(InstallationChecker.java:90)
at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText.updateTitle(JBossCentralEditor.java:654)
at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText.access$0(JBossCentralEditor.java:641)
at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText$3$1.run(JBossCentralEditor.java:584)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:136)
... 24 more
> NPE during "Check installation for Early Access"
> ------------------------------------------------
>
> Key: JBIDE-18542
> URL: https://issues.jboss.org/browse/JBIDE-18542
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Affects Versions: 4.2.0.CR2
> Reporter: Rob Cernich
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.2.x, 4.3.0.Alpha2
>
>
> I got the following exception upon restart after updating to CR2 from the following site: http://download.jboss.org/jbosstools/updates/staging/luna/
> {noformat}
> java.lang.NullPointerException
> at org.jboss.tools.central.installation.InstallationChecker.getUnits(InstallationChecker.java:99)
> at org.jboss.tools.central.installation.InstallationChecker.getEarlyAccessUnits(InstallationChecker.java:79)
> at org.jboss.tools.central.installation.InstallationChecker.hasEarlyAccess(InstallationChecker.java:72)
> at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText$3.run(JBossCentralEditor.java:574)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (JBIDE-19410) earlyaccess still not failing gracefully
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19410?page=com.atlassian.jira.plugi... ]
Denis Golovin updated JBIDE-19410:
----------------------------------
Comment: was deleted
(was: Proposed PR has the same problem Max mentioned:
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
at org.eclipse.swt.SWT.error(SWT.java:4477)
at org.eclipse.swt.SWT.error(SWT.java:4392)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:139)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3793)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3431)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:648)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:592)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
at org.eclipse.equinox.launcher.Main.main(Main.java:1438)
Caused by: java.lang.NullPointerException
at org.jboss.tools.central.installation.InstallationChecker.getUnits(InstallationChecker.java:106)
at org.jboss.tools.central.installation.InstallationChecker.getEarlyAccessUnits(InstallationChecker.java:97)
at org.jboss.tools.central.installation.InstallationChecker.hasEarlyAccess(InstallationChecker.java:90)
at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText.updateTitle(JBossCentralEditor.java:654)
at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText.access$0(JBossCentralEditor.java:641)
at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText$3$1.run(JBossCentralEditor.java:584)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:136)
... 24 more)
> earlyaccess still not failing gracefully
> ----------------------------------------
>
> Key: JBIDE-19410
> URL: https://issues.jboss.org/browse/JBIDE-19410
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Reporter: Max Rydahl Andersen
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.3.0.Alpha2
>
>
> start jboss tools in PDE and earlyaccess will pop up with error dialog that it had an error because it could not install things (which is expected when running in PDE)
> start jboss tools without network access and I sometime see it pop up - can't reprouce that consistently.
> but in short - seems like earlyaccess continues to want to tell users that something is wrong with early access even when it is not enabled but nor should it even if enabled. Show such error on the earlyaccess page rather than a blocking dialog.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (JBIDE-19410) earlyaccess still not failing gracefully
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19410?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-19410:
---------------------------------------
easiest manual way to replicate just assign null in code and run it. Question remains why sometimes null value returned?
> earlyaccess still not failing gracefully
> ----------------------------------------
>
> Key: JBIDE-19410
> URL: https://issues.jboss.org/browse/JBIDE-19410
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Reporter: Max Rydahl Andersen
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.3.0.Alpha2
>
>
> start jboss tools in PDE and earlyaccess will pop up with error dialog that it had an error because it could not install things (which is expected when running in PDE)
> start jboss tools without network access and I sometime see it pop up - can't reprouce that consistently.
> but in short - seems like earlyaccess continues to want to tell users that something is wrong with early access even when it is not enabled but nor should it even if enabled. Show such error on the earlyaccess page rather than a blocking dialog.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (JBIDE-19410) earlyaccess still not failing gracefully
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19410?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-19410:
---------------------------------------
Proposed PR has the same problem Max mentioned:
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
at org.eclipse.swt.SWT.error(SWT.java:4477)
at org.eclipse.swt.SWT.error(SWT.java:4392)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:139)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3793)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3431)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:648)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:592)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
at org.eclipse.equinox.launcher.Main.main(Main.java:1438)
Caused by: java.lang.NullPointerException
at org.jboss.tools.central.installation.InstallationChecker.getUnits(InstallationChecker.java:106)
at org.jboss.tools.central.installation.InstallationChecker.getEarlyAccessUnits(InstallationChecker.java:97)
at org.jboss.tools.central.installation.InstallationChecker.hasEarlyAccess(InstallationChecker.java:90)
at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText.updateTitle(JBossCentralEditor.java:654)
at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText.access$0(JBossCentralEditor.java:641)
at org.jboss.tools.central.editors.JBossCentralEditor$HeaderText$3$1.run(JBossCentralEditor.java:584)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:136)
... 24 more
> earlyaccess still not failing gracefully
> ----------------------------------------
>
> Key: JBIDE-19410
> URL: https://issues.jboss.org/browse/JBIDE-19410
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Reporter: Max Rydahl Andersen
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.3.0.Alpha2
>
>
> start jboss tools in PDE and earlyaccess will pop up with error dialog that it had an error because it could not install things (which is expected when running in PDE)
> start jboss tools without network access and I sometime see it pop up - can't reprouce that consistently.
> but in short - seems like earlyaccess continues to want to tell users that something is wrong with early access even when it is not enabled but nor should it even if enabled. Show such error on the earlyaccess page rather than a blocking dialog.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (JBIDE-15714) Dynamic content assist for AngularJS expressions in html files
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15714?page=com.atlassian.jira.plugi... ]
Alexey Kazakov commented on JBIDE-15714:
----------------------------------------
In order to provide this content assist we need to:
1. Initialize the browser
2. Refresh the browser if anything is changed on the page but before we execute our JS to get proposals.
Both tasks are asynchronous and take some time.
#1 can be solved by initializing the browser when the editor (even the source tab) is being opened (I don't like it) OR as Max suggested we could put a placeholder/message for the very first time when the Angular content assist in invoked (I like this idea better).
#2 can be solved if we enable the refreshing mechanism when the angular content assist is invoked the very first time for the page/editor. As soon as it's enabled we will refresh the browser after every change in the source.
So, we wouldn't see angular proposals only the first time the content assist is invoked.
> Dynamic content assist for AngularJS expressions in html files
> --------------------------------------------------------------
>
> Key: JBIDE-15714
> URL: https://issues.jboss.org/browse/JBIDE-15714
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: jsp/jsf/xml/html source editing
> Reporter: Alexey Kazakov
> Assignee: Alexey Kazakov
> Priority: Critical
> Labels: new_and_noteworthy
> Fix For: 4.3.0.Alpha2
>
> Attachments: Diagram.gliffy, vpe.png
>
>
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (JBIDE-19410) earlyaccess still not failing gracefully
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19410?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-19410:
---------------------------------------
In current PR error messages are "Location was not provisioned by p2" and "Unable to acquire the profile registry service."
Should we translate it from Eclipse p2 language to something user friendly?
> earlyaccess still not failing gracefully
> ----------------------------------------
>
> Key: JBIDE-19410
> URL: https://issues.jboss.org/browse/JBIDE-19410
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Reporter: Max Rydahl Andersen
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.3.0.Alpha2
>
>
> start jboss tools in PDE and earlyaccess will pop up with error dialog that it had an error because it could not install things (which is expected when running in PDE)
> start jboss tools without network access and I sometime see it pop up - can't reprouce that consistently.
> but in short - seems like earlyaccess continues to want to tell users that something is wrong with early access even when it is not enabled but nor should it even if enabled. Show such error on the earlyaccess page rather than a blocking dialog.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months