May 2015 - jbosstools-issues - Jboss List Archives

[JBoss JIRA] (JBIDE-19798) include buildinfo.json files inside source zips

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-19798?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-19798: ------------------------------- Sprint: Sprint #3 May 2015 > include buildinfo.json files inside source zips > ----------------------------------------------- > > Key: JBIDE-19798 > URL: https://issues.jboss.org/browse/JBIDE-19798 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Reporter: Nick Boldt > Assignee: Nick Boldt > Fix For: 4.3.0.Beta1 > > > Max asked: {quote} > [W]here are the build-info.json files to provide the info you were initially partially encoding into the file names ? > {quote} > I replied: {quote} > Adding json files will take more work as they're produced in a different mojo (GenerateRepositoryFacadeMojo.java, not FetchSourcesFromManifests.java), and I'm a bit hesitant to have one mojo depend on another. > Do you want that the FetchSourcesFromManifests will also FetchJSONFromUpstreamLatestBuildsFolders (hoping that no respins have happened between the start of the aggregate job and the time when the fetch starts) ? Or should I just include target/fullSite/all/repo/buildinfo.json into target/fullSite/all/jbosstools-src.zip ? > It's already included in the generated update site + update site zip, so I don't have a problem adding it to the src.zip too... except for the fact that we'll have cross-mojo dependencies. This will mean that the aggregate builds (JBT & JBDS) will depend on BOTH mojos, and that they can only be configured to run in a SPECIFIC order. Is that acceptable? > {quote} > (From JBIDE-19756) -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-19798) include buildinfo.json files inside source zips

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-19798?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-19798: ------------------------------- Fix Version/s: 4.3.0.Beta1 > include buildinfo.json files inside source zips > ----------------------------------------------- > > Key: JBIDE-19798 > URL: https://issues.jboss.org/browse/JBIDE-19798 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Reporter: Nick Boldt > Assignee: Nick Boldt > Fix For: 4.3.0.Beta1 > > > Max asked: {quote} > [W]here are the build-info.json files to provide the info you were initially partially encoding into the file names ? > {quote} > I replied: {quote} > Adding json files will take more work as they're produced in a different mojo (GenerateRepositoryFacadeMojo.java, not FetchSourcesFromManifests.java), and I'm a bit hesitant to have one mojo depend on another. > Do you want that the FetchSourcesFromManifests will also FetchJSONFromUpstreamLatestBuildsFolders (hoping that no respins have happened between the start of the aggregate job and the time when the fetch starts) ? Or should I just include target/fullSite/all/repo/buildinfo.json into target/fullSite/all/jbosstools-src.zip ? > It's already included in the generated update site + update site zip, so I don't have a problem adding it to the src.zip too... except for the fact that we'll have cross-mojo dependencies. This will mean that the aggregate builds (JBT & JBDS) will depend on BOTH mojos, and that they can only be configured to run in a SPECIFIC order. Is that acceptable? > {quote} > (From JBIDE-19756) -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-19814) sources zip should include local sources too (jbosstools-build-sites or jbdevstudio-product)

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-19814?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-19814: ------------------------------- Sprint: Sprint #3 May 2015 > sources zip should include local sources too (jbosstools-build-sites or jbdevstudio-product) > -------------------------------------------------------------------------------------------- > > Key: JBIDE-19814 > URL: https://issues.jboss.org/browse/JBIDE-19814 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Affects Versions: 4.3.0.Beta1 > Reporter: Nick Boldt > Assignee: Nick Boldt > Fix For: 4.3.0.Beta1 > > > If we change the way the jbosstools-src.zip is produced, such that in addition to upstream projects it ALSO includes the contents of jbosstools-build-sites too, then we can reuse that mojo for the jbdevstudio-product src.zip too, as it will ALSO include the 17 upstream JBT zips (from Github) and also the local JBDS sources. > This would mean a large chunk of ant code in jbdevstudio-product/sources/build.xml (if not all of it) could go away. Hooray for 1 solution spanning both projects and product! :D > Max also suggested that we use a clean copy of the sources just in case the build process makes them dirty: > {code} > git clone --depth=1 . clean-sources-dir && rm -rf clean-sources-dir/.git{code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-19798) include buildinfo.json files inside source zips

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-19798?page=com.atlassian.jira.plugi... ] Nick Boldt reassigned JBIDE-19798: ---------------------------------- Assignee: Nick Boldt > include buildinfo.json files inside source zips > ----------------------------------------------- > > Key: JBIDE-19798 > URL: https://issues.jboss.org/browse/JBIDE-19798 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Reporter: Nick Boldt > Assignee: Nick Boldt > > Max asked: {quote} > [W]here are the build-info.json files to provide the info you were initially partially encoding into the file names ? > {quote} > I replied: {quote} > Adding json files will take more work as they're produced in a different mojo (GenerateRepositoryFacadeMojo.java, not FetchSourcesFromManifests.java), and I'm a bit hesitant to have one mojo depend on another. > Do you want that the FetchSourcesFromManifests will also FetchJSONFromUpstreamLatestBuildsFolders (hoping that no respins have happened between the start of the aggregate job and the time when the fetch starts) ? Or should I just include target/fullSite/all/repo/buildinfo.json into target/fullSite/all/jbosstools-src.zip ? > It's already included in the generated update site + update site zip, so I don't have a problem adding it to the src.zip too... except for the fact that we'll have cross-mojo dependencies. This will mean that the aggregate builds (JBT & JBDS) will depend on BOTH mojos, and that they can only be configured to run in a SPECIFIC order. Is that acceptable? > {quote} > (From JBIDE-19756) -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-19756) jbosstools-src.zip has incomplete/misleading version info in folder names/structure

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-19756?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-19756: ------------------------------------ This commit fixes the fact that in the above screenshot I had jboss-devstudio-9.0.0.Beta1-v20150511-1448-installer-src instead of jboss-devstudio-9.0.0.Beta1-installer-src: https://github.com/jbdevstudio/jbdevstudio-product/commit/7e0d64bcd05c5ec... The remaining todo (build w/ mojo instead of ant) is here: JBIDE-19814 > jbosstools-src.zip has incomplete/misleading version info in folder names/structure > ----------------------------------------------------------------------------------- > > Key: JBIDE-19756 > URL: https://issues.jboss.org/browse/JBIDE-19756 > Project: Tools (JBoss Tools) > Issue Type: Feature Request > Components: build > Affects Versions: 4.3.0.Beta1 > Reporter: Max Rydahl Andersen > Assignee: Nick Boldt > Fix For: 4.3.0.Beta1 > > Attachments: jbide19756.png, jbide19756_final_JBDS-sourcesZip.png, jbide19756_jbds-sources-zip.png, jbide19756_new_subfolders_and_zipfile_name.png > > > Downloading latest jbosstools-src.zip from http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-bui... I see multiple files in root named: > <componentname>_<buildqualifier>_<sha1> > example: > jbosstools-javaee_Beta1-v20150501-0413-B767_149f9a46d5c676fd7119515e8b6aa796859955ad > A few issues with this: > a) it would have been nice unzipping would not create multiple root level folders. Maybe have a jbosstools-source folder as root ? > b) the buildqualifier is there but the version string for the component is not. Either put the full version string for that component (not overall jbosstools version) or just leave it as <component>-<sha> and have the root folder state the full version of jbosstools. since non-indulged user would not know this one had to do with 4.3.0.Beta1 or 4.2.3.Beta1 (for example). -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-19814) sources zip should include local sources too (jbosstools-build-sites or jbdevstudio-product)

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-19814?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-19814: ------------------------------- Fix Version/s: 4.3.0.Beta1 > sources zip should include local sources too (jbosstools-build-sites or jbdevstudio-product) > -------------------------------------------------------------------------------------------- > > Key: JBIDE-19814 > URL: https://issues.jboss.org/browse/JBIDE-19814 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Affects Versions: 4.3.0.Beta1 > Reporter: Nick Boldt > Fix For: 4.3.0.Beta1 > > > If we change the way the jbosstools-src.zip is produced, such that in addition to upstream projects it ALSO includes the contents of jbosstools-build-sites too, then we can reuse that mojo for the jbdevstudio-product src.zip too, as it will ALSO include the 17 upstream JBT zips (from Github) and also the local JBDS sources. > This would mean a large chunk of ant code in jbdevstudio-product/sources/build.xml (if not all of it) could go away. Hooray for 1 solution spanning both projects and product! :D > Max also suggested that we use a clean copy of the sources just in case the build process makes them dirty: > {code} > git clone --depth=1 . clean-sources-dir && rm -rf clean-sources-dir/.git{code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-19814) sources zip should include local sources too (jbosstools-build-sites or jbdevstudio-product)

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-19814?page=com.atlassian.jira.plugi... ] Nick Boldt reassigned JBIDE-19814: ---------------------------------- Assignee: Nick Boldt > sources zip should include local sources too (jbosstools-build-sites or jbdevstudio-product) > -------------------------------------------------------------------------------------------- > > Key: JBIDE-19814 > URL: https://issues.jboss.org/browse/JBIDE-19814 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Affects Versions: 4.3.0.Beta1 > Reporter: Nick Boldt > Assignee: Nick Boldt > Fix For: 4.3.0.Beta1 > > > If we change the way the jbosstools-src.zip is produced, such that in addition to upstream projects it ALSO includes the contents of jbosstools-build-sites too, then we can reuse that mojo for the jbdevstudio-product src.zip too, as it will ALSO include the 17 upstream JBT zips (from Github) and also the local JBDS sources. > This would mean a large chunk of ant code in jbdevstudio-product/sources/build.xml (if not all of it) could go away. Hooray for 1 solution spanning both projects and product! :D > Max also suggested that we use a clean copy of the sources just in case the build process makes them dirty: > {code} > git clone --depth=1 . clean-sources-dir && rm -rf clean-sources-dir/.git{code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-19814) sources zip should include local sources too (jbosstools-build-sites or jbdevstudio-product)

by Nick Boldt (JIRA)

Nick Boldt created JBIDE-19814: ---------------------------------- Summary: sources zip should include local sources too (jbosstools-build-sites or jbdevstudio-product) Key: JBIDE-19814 URL: https://issues.jboss.org/browse/JBIDE-19814 Project: Tools (JBoss Tools) Issue Type: Bug Components: build Affects Versions: 4.3.0.Beta1 Reporter: Nick Boldt If we change the way the jbosstools-src.zip is produced, such that in addition to upstream projects it ALSO includes the contents of jbosstools-build-sites too, then we can reuse that mojo for the jbdevstudio-product src.zip too, as it will ALSO include the 17 upstream JBT zips (from Github) and also the local JBDS sources. This would mean a large chunk of ant code in jbdevstudio-product/sources/build.xml (if not all of it) could go away. Hooray for 1 solution spanning both projects and product! :D Max also suggested that we use a clean copy of the sources just in case the build process makes them dirty: {code} git clone --depth=1 . clean-sources-dir && rm -rf clean-sources-dir/.git{code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-19813) Optimize incremental rebuild of CDI model

by Viacheslav Kabanovich (JIRA)

Viacheslav Kabanovich created JBIDE-19813: --------------------------------------------- Summary: Optimize incremental rebuild of CDI model Key: JBIDE-19813 URL: https://issues.jboss.org/browse/JBIDE-19813 Project: Tools (JBoss Tools) Issue Type: Enhancement Components: cdi Affects Versions: 4.3.0.Alpha2 Reporter: Viacheslav Kabanovich Assignee: Viacheslav Kabanovich Fix For: 4.3.0.Beta1 One of very common cases is when user modifies java code in editor and saves it. Java and CDI dependencies between classes make it generally a hard problem to do incremental rebuild, but if imports and super types are not changed, we do not need to reset all references to Java model objects in all CDI model objects, as it is done now 'to be on the safe side'. Request to JDT are time consuming and we can gain a lot if only changed CDI model objects reset references. It is not safe to try this optimization when imports or super types are changed, but they happen not so often as many minor changes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-19756) jbosstools-src.zip has incomplete/misleading version info in folder names/structure

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-19756?page=com.atlassian.jira.plugi... ] Nick Boldt closed JBIDE-19756. ------------------------------ Here's the new zip filename, root folder, and contents of the JBDS source zip. !jbide19756_final_JBDS-sourcesZip.png! I'll handle migrating the way we build this to a more consistent approach (less ant, more maven), and adding in the buildinfo.json file(s), in another jira. > jbosstools-src.zip has incomplete/misleading version info in folder names/structure > ----------------------------------------------------------------------------------- > > Key: JBIDE-19756 > URL: https://issues.jboss.org/browse/JBIDE-19756 > Project: Tools (JBoss Tools) > Issue Type: Feature Request > Components: build > Affects Versions: 4.3.0.Beta1 > Reporter: Max Rydahl Andersen > Assignee: Nick Boldt > Fix For: 4.3.0.Beta1 > > Attachments: jbide19756.png, jbide19756_final_JBDS-sourcesZip.png, jbide19756_jbds-sources-zip.png, jbide19756_new_subfolders_and_zipfile_name.png > > > Downloading latest jbosstools-src.zip from http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-bui... I see multiple files in root named: > <componentname>_<buildqualifier>_<sha1> > example: > jbosstools-javaee_Beta1-v20150501-0413-B767_149f9a46d5c676fd7119515e8b6aa796859955ad > A few issues with this: > a) it would have been nice unzipping would not create multiple root level folders. Maybe have a jbosstools-source folder as root ? > b) the buildqualifier is there but the version string for the component is not. Either put the full version string for that component (not overall jbosstools version) or just leave it as <component>-<sha> and have the root folder state the full version of jbosstools. since non-indulged user would not know this one had to do with 4.3.0.Beta1 or 4.2.3.Beta1 (for example). -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 10 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues May 2015