[JBoss JIRA] (JBIDE-19467) repository-utils :: FetchSourcesFromManifests should create its own source zip, not rely on publish.sh
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19467?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-19467:
------------------------------------
Done or rejected:
* -remove commented block about md5 generation-
* -investigate using truezip?-
* -use enum instead of two ints for CACHE_ZIPS, etc.-
* -make output filename more generic / parameterized, not just jbosstools-src.zip-
* -include buildinfo.json files in the zip-
Not sure if easily possible:
* get more properties into buildinfo.json for ALL builds (including those in _master branch, which currently show nulls)
** TARGET_PLATFORM_*
** BUILD_ID, BUILD_NUMBER, BUILD_ALIAS
** JOB_NAME
** jbosstools_site_stream ?
To discuss or still do:
* decide what to put in target/repository/ instead of target/fullSite/all/ ?
* compare SHA from buildinfo.json files w/ the value found in MANIFEST.MF files; if they don't match, break the build
> repository-utils :: FetchSourcesFromManifests should create its own source zip, not rely on publish.sh
> ------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-19467
> URL: https://issues.jboss.org/browse/JBIDE-19467
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.3.0.Alpha2
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Blocker
> Fix For: 4.3.0.Beta2
>
>
> In repository-utils, FetchSourcesFromManifests should create its own source zip, not rely on publish.sh. Because we no longer use publish.sh and don't want to have rsync.sh produce artifacts, only rsync them.
> Here's what publish.sh does:
> {code}
> # collect component zips from upstream aggregated build jobs
> if [[ ${JOB_NAME/.aggregate} != ${JOB_NAME} ]] && [[ -d ${WORKSPACE}/sources/aggregate/site/zips ]]; then
> mkdir -p ${STAGINGDIR}/components
> for z in $(find ${WORKSPACE}/sources/aggregate/site/zips -name "*updatesite-*.zip"); do
> # generate MD5 sum for zip (file contains only the hash, not the hash + filename)
> for m in $(md5sum ${z}); do if [[ $m != ${z} ]]; then echo $m > ${z}.MD5; fi; done
> mv $z ${z}.MD5 ${STAGINGDIR}/components
> done
> # TODO :: JBIDE-9870 When we have a -Update-Sources- zip, this can be removed
> mkdir -p ${STAGINGDIR}/all/sources
> # OLD: unpack component source zips like jbosstools-pi4soa-3.1_trunk-Sources-SNAPSHOT.zip or jbosstools-3.2_trunk.component--ws-Sources-SNAPSHOT.zip
> # NEW: JBIDE-16632: unpack component source zips like jbosstools-base_Alpha2-v20140221-1555-B437_184e18cc3ac7c339ce406974b6a4917f73909cc4_sources.zip
> for z in $(find ${WORKSPACE}/sources/aggregate/site/zips -name "*Sources*.zip" -o -name "*_sources.zip" -o -name "*-src.zip"); do
> zn=${z%*-Sources*.zip}; zn=${zn%*_sources.zip}; zn=${zn%*-src.zip}; zn=${zn#*--}; zn=${zn##*/}; zn=${zn#jbosstools-};
> # zn=${zn%_trunk}; zn=${zn%_stable_branch};
> mkdir -p ${STAGINGDIR}/all/sources/${zn}/
> # remove one level of folder nesting - don't want an extra jbosstools-base-184e18cc3ac7c339ce406974b6a4917f73909cc4 folder under jbosstools-base_Alpha2-v20140221-1555-B437_184e18cc3ac7c339ce406974b6a4917f73909cc4
> unzip -qq -o -d ${tmpdir}/${zn}/ $z
> mkdir -p ${STAGINGDIR}/all/sources/${zn}/
> mv ${tmpdir}/${zn}/jbosstools-*/* ${STAGINGDIR}/all/sources/${zn}/
> rm -fr ${tmpdir}/${zn}/
> done
> # add component sources into sources zip
> pushd ${STAGINGDIR}/all/sources
> zip ${STAGINGDIR}/all/${SRCSNAME} -q -r * -x hudson_workspace\* -x documentation\* -x download.jboss.org\* -x requirements\* \
> -x workingset\* -x labs\* -x build\* -x \*test\* -x \*target\* -x \*.class -x \*classes\* -x \*bin\* -x \*.zip \
> -x \*docs\* -x \*reference\* -x \*releng\* -x \*.git\* -x \*/lib/\*.jar -x \*getRemoteFile\*
> popd
> rm -fr ${STAGINGDIR}/all/sources
> z=${STAGINGDIR}/all/${SRCSNAME}; for m in $(md5sum ${z}); do if [[ $m != ${z} ]]; then echo $m > ${z}.MD5; fi; done
> # JBIDE-7444 get aggregate metadata xml properties file
> if [[ -f ${WORKSPACE}/sources/aggregate/site/zips/build.properties.all.xml ]]; then
> rsync -aq ${WORKSPACE}/sources/aggregate/site/zips/build.properties.all.xml ${STAGINGDIR}/logs/
> fi
> fi
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 10 months
[JBoss JIRA] (JBIDE-19997) Add possibility to select interface and abstract class in New Batch Artifact wizard
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19997?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-19997:
-----------------------------------------------
Though, I see as a possible problem that why not extend new batch artifact not from a custom abstract class but from any other concrete class that is already Batch artifact of the same type. Then, in a big application, the choice may be too long to be of help. Then, will we restrict the choice with abstract classes/interfaces only?
> Add possibility to select interface and abstract class in New Batch Artifact wizard
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-19997
> URL: https://issues.jboss.org/browse/JBIDE-19997
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: batch
> Affects Versions: 4.3.0.Beta1
> Reporter: Lucia Jelinkova
> Assignee: Viacheslav Kabanovich
> Fix For: 4.3.0.Beta2
>
>
> I think that in every bigger enterprise project you would have your own implementation of batch interfaces and abstract classes. So the possibility to select them in the New Batch Artifact wizard would be very useful.
> Maybe you could just put there interface and abstract class selection section from New Java Class wizard and pre-define the right batch classes?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 10 months
[JBoss JIRA] (JBDS-3374) Remove org.eclipse.cvs feature from JBDS
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3374?page=com.atlassian.jira.plugin.... ]
Nick Boldt commented on JBDS-3374:
----------------------------------
Slip to Beta2 and if no one puts forth a compelling case for this by then, I'll just reject the JIRA.
> Remove org.eclipse.cvs feature from JBDS
> ----------------------------------------
>
> Key: JBDS-3374
> URL: https://issues.jboss.org/browse/JBDS-3374
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Enhancement
> Components: installer
> Affects Versions: 9.0.0.Alpha1
> Reporter: Fred Bricon
> Assignee: Nick Boldt
> Fix For: 9.0.0.Beta2
>
>
> com.jboss.devstudio.core.feature/feature.xml declares
> {quote}
> <import feature="org.eclipse.cvs"/>
> {quote}
> I can't see any reason why we'd do that in 2015.
> Burr Sutter, Len DiMaggio, Max Rydahl Andersen : is there any client requirement about CVS support?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 10 months
[JBoss JIRA] (JBDS-3374) Remove org.eclipse.cvs feature from JBDS
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3374?page=com.atlassian.jira.plugin.... ]
Nick Boldt updated JBDS-3374:
-----------------------------
Fix Version/s: 9.0.0.Beta2
(was: 9.0.0.Beta1)
> Remove org.eclipse.cvs feature from JBDS
> ----------------------------------------
>
> Key: JBDS-3374
> URL: https://issues.jboss.org/browse/JBDS-3374
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Enhancement
> Components: installer
> Affects Versions: 9.0.0.Alpha1
> Reporter: Fred Bricon
> Assignee: Nick Boldt
> Fix For: 9.0.0.Beta2
>
>
> com.jboss.devstudio.core.feature/feature.xml declares
> {quote}
> <import feature="org.eclipse.cvs"/>
> {quote}
> I can't see any reason why we'd do that in 2015.
> Burr Sutter, Len DiMaggio, Max Rydahl Andersen : is there any client requirement about CVS support?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 10 months
[JBoss JIRA] (JBIDE-19387) improve integration of integration stack jars into staged JBT / JBDS sites
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19387?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-19387:
------------------------------------
Slip to Beta2 and assign to Paul since I can't do much until IS for Mars exists in a form that I can help integrate into JBT/JBDS staging.
BTW, [~pleacu] you could start publishing your bits into /mars/snapshots/ instead of /builds/staging/ if you wanted to follow our new dir structure pattern.
> improve integration of integration stack jars into staged JBT / JBDS sites
> --------------------------------------------------------------------------
>
> Key: JBIDE-19387
> URL: https://issues.jboss.org/browse/JBIDE-19387
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central, updatesite
> Affects Versions: 4.2.3.Beta1
> Reporter: Radim Hopp
> Assignee: Paul Leacu
> Fix For: 4.3.0.Beta2
>
>
> I have this error in error log after startup of JBT:
> {noformat:title=Cannot download bundle at http://download.jboss.org/jbosstools/discovery/staging/4.2.3.Beta1/plugin...: http://download.jboss.org/jbosstools/discovery/staging/4.2.3.Beta1/plugin...: http://download.jboss.org/jbosstools/discovery/staging/4.2.3.Beta1/plugin...
> at org.eclipse.equinox.internal.p2.transport.ecf.RepositoryStatusHelper.checkFileNotFound(RepositoryStatusHelper.java:297)
> at org.eclipse.equinox.internal.p2.transport.ecf.FileReader.checkException(FileReader.java:441)
> at org.eclipse.equinox.internal.p2.transport.ecf.FileReader.sendRetrieveRequest(FileReader.java:398)
> at org.eclipse.equinox.internal.p2.transport.ecf.FileReader.readInto(FileReader.java:322)
> at org.eclipse.equinox.internal.p2.transport.ecf.RepositoryTransport.download(RepositoryTransport.java:101)
> at org.eclipse.equinox.internal.p2.transport.ecf.RepositoryTransport.download(RepositoryTransport.java:156)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:483)
> at org.eclipse.mylyn.internal.discovery.core.util.P2TransportService.download(P2TransportService.java:84)
> at org.eclipse.mylyn.internal.discovery.core.util.WebUtil.download(WebUtil.java:157)
> at org.eclipse.mylyn.internal.discovery.core.util.WebUtil.download(WebUtil.java:66)
> at org.jboss.tools.project.examples.internal.discovery.xpl.RemoteExternalBundleDiscoveryStrategy$DownloadBundleJob.call(RemoteExternalBundleDiscoveryStrategy.java:223)
> at org.jboss.tools.project.examples.internal.discovery.xpl.RemoteExternalBundleDiscoveryStrategy$DownloadBundleJob.call(RemoteExternalBundleDiscoveryStrategy.java:1)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> http://download.jboss.org/jbosstools/discovery/staging/4.2.3.Beta1/jbosst... is pointing to non-existing http://download.jboss.org/jbosstools/discovery/staging/4.2.3.Beta1/plugin...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 10 months