[JBoss JIRA] (JBIDE-19181) correct naming of internal packages so that they're consistent across all openshift plugins
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19181?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-19181:
------------------------------------------
We went out of time for this in 4.3.0.Beta1. Postponing.
> correct naming of internal packages so that they're consistent across all openshift plugins
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-19181
> URL: https://issues.jboss.org/browse/JBIDE-19181
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Alpha1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.3.0.Beta2
>
>
> Internal packages across the openshift plugins are non-consistent:
> ex.
> org.jboss.tools.openshift.client: org.jboss.tools.openshift.client.internal
> org.jboss.tools.openshift.express.client: org.jboss.tools.openshift.express.client.internal
> the base is imho org.jboss.tools.openshift and thus internal packages should always be at org.jboss.tools.openshift.internal across plugins.
> For reference, here's the official Eclipse documentation on the topic: http://wiki.eclipse.org/index.php/Naming_Conventions#Java_Packages
> {quote}
> org.eclipse.jdt.internal.core.compiler - Correct usage
> org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow subproject name.
> org.eclipse.core.internal.resources - Correct usage
> org.eclipse.internal.core.resources - Incorrect. internal should never immediately follow org.eclipse.
> org.eclipse.core.resources.internal - Incorrect. internal should immediately follow Eclipse Platform component name.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 10 months
[JBoss JIRA] (JBIDE-19412) Cleanup ConnectionURL usage for v3 connections
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19412?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-19412:
-------------------------------------
Fix Version/s: 4.3.0.Beta2
(was: 4.3.0.Beta1)
> Cleanup ConnectionURL usage for v3 connections
> ----------------------------------------------
>
> Key: JBIDE-19412
> URL: https://issues.jboss.org/browse/JBIDE-19412
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Alpha2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.3.0.Beta2
>
>
> In ConnectionsRegistry connections are stored by ConnectionURL. ConnectionURL is also used to persist v2 connections. v3 connections on the other hand are persisted in their very own json format. We need to clean this discrepany/inconsistency. We should either only use ConnectionURL for v2 connections or also store v3 connections in the ConnectionURL format.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 10 months
[JBoss JIRA] (JBIDE-19412) Cleanup ConnectionURL usage for v3 connections
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19412?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-19412:
------------------------------------------
We went out of time for this in 4.3.0.Beta1. Postponing.
> Cleanup ConnectionURL usage for v3 connections
> ----------------------------------------------
>
> Key: JBIDE-19412
> URL: https://issues.jboss.org/browse/JBIDE-19412
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Alpha2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.3.0.Beta2
>
>
> In ConnectionsRegistry connections are stored by ConnectionURL. ConnectionURL is also used to persist v2 connections. v3 connections on the other hand are persisted in their very own json format. We need to clean this discrepany/inconsistency. We should either only use ConnectionURL for v2 connections or also store v3 connections in the ConnectionURL format.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 10 months
[JBoss JIRA] (JBIDE-19181) correct naming of internal packages so that they're consistent across all openshift plugins
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19181?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-19181:
-------------------------------------
Fix Version/s: 4.3.0.Beta2
(was: 4.3.0.Beta1)
> correct naming of internal packages so that they're consistent across all openshift plugins
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-19181
> URL: https://issues.jboss.org/browse/JBIDE-19181
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Alpha1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.3.0.Beta2
>
>
> Internal packages across the openshift plugins are non-consistent:
> ex.
> org.jboss.tools.openshift.client: org.jboss.tools.openshift.client.internal
> org.jboss.tools.openshift.express.client: org.jboss.tools.openshift.express.client.internal
> the base is imho org.jboss.tools.openshift and thus internal packages should always be at org.jboss.tools.openshift.internal across plugins.
> For reference, here's the official Eclipse documentation on the topic: http://wiki.eclipse.org/index.php/Naming_Conventions#Java_Packages
> {quote}
> org.eclipse.jdt.internal.core.compiler - Correct usage
> org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow subproject name.
> org.eclipse.core.internal.resources - Correct usage
> org.eclipse.internal.core.resources - Incorrect. internal should never immediately follow org.eclipse.
> org.eclipse.core.resources.internal - Incorrect. internal should immediately follow Eclipse Platform component name.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 10 months