[JBoss JIRA] (JBIDE-20366) Easymport should offer available m2e connectors when importing Maven projects
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20366?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-20366:
---------------------------------------------
that is separate issue. Tycho is just mentioned as example.
I'm +0 on including it, so I suggest open a separate issue and discuss it separately from the smartimport issue.
That new issue would be good if we actually had a list of what m2e connectors we already do include (I lost count ;/)
> Easymport should offer available m2e connectors when importing Maven projects
> -----------------------------------------------------------------------------
>
> Key: JBIDE-20366
> URL: https://issues.jboss.org/browse/JBIDE-20366
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: easymport
> Affects Versions: 4.3.0.Beta1
> Environment: JBDS 9.0.0.Beta2
> Reporter: Jiri Peterka
> Assignee: Mickael Istria
> Fix For: 4.3.0.CR1
>
>
> For example standard maven import offers tycho connector installation for a user. Easymport should provide the same user comfort as maven import does.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 7 months
[JBoss JIRA] (JBIDE-20365) Review possibility before final import
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20365?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-20365:
----------------------------------------
Do you know some realistic user-stories to illustrate each one of your points, with example project and why each of this option seems necessary?
About 1, it's going to be supported, but with some limitations. Indeed for some "strategies", the type of the parent may strongly impact how children are imported (for example, you don't want to import a folder that contains a .project if it's in the test data of an Eclipse test plugin), so there will be some limitation. However, the common case of a pure Maven project should work fine and make suggestions before running the import.
About 2, I don't believe users really want that. What they want is something that "just" works without tweaking. Also, it's doing more that setting natures, and leaving the ability to user to override some detection is also giving them ability to do wrong things that would leave them in a very worse state. But I do agree that ability to change project natures is interesting, but I don't think it's something that should be necessarily done at import. IMO, it's just something the IDE should provide at anytime. This is the story of Eclipse bug https://bugs.eclipse.org/102527 ; I've implemented a simple way to tweak natures without editing .project: https://github.com/jbosstools/jbosstools-playground#naturist-edit-project... . I believe this approach of 1st import, then see projects in actions, and then tweak them if necessary better matches user workflow.
About 3, that is planned and I'm working on it right now. However, it will probably have some limitations, similarly to 1.
> Review possibility before final import
> --------------------------------------
>
> Key: JBIDE-20365
> URL: https://issues.jboss.org/browse/JBIDE-20365
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: easymport
> Affects Versions: 4.3.0.Beta1
> Environment: JBDS 9.0.0.Beta2
> Reporter: Jiri Peterka
> Assignee: Mickael Istria
> Fix For: 4.3.0.CR1
>
>
> Currently projects are just imported and user cannot decide if he wants to accept result or not.
> There should be some some degree of flexibility:
> 1) projects will not imported until user decides during import review page
> 2) user should be able to change suggested nature of the imported projects during review for final import.
> 3) users should be able to select/deselect desired projects
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 7 months
[JBoss JIRA] (JBIDE-20366) Easymport should offer available m2e connectors when importing Maven projects
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20366?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-20366:
---------------------------------------------
not following why this is suggested to be only relevant for Tycho extensions ? I assume you mean it make sense for other Maven projects too, right ?
This is something the maven smart importer could do once the user have said Yes - I want to import these projects and then when that import has completed.
> Easymport should offer available m2e connectors when importing Maven projects
> -----------------------------------------------------------------------------
>
> Key: JBIDE-20366
> URL: https://issues.jboss.org/browse/JBIDE-20366
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: easymport
> Affects Versions: 4.3.0.Beta1
> Environment: JBDS 9.0.0.Beta2
> Reporter: Jiri Peterka
> Assignee: Mickael Istria
> Fix For: 4.3.0.CR1
>
>
> For example standard maven import offers tycho connector installation for a user. Easymport should provide the same user comfort as maven import does.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 7 months
[JBoss JIRA] (JBIDE-20366) Easymport should offer available m2e connectors when importing Maven projects
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20366?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-20366:
----------------------------------------
For this Tycho-specific use-case, the best thing, if we want to correctly support Tycho in JBT./JBDS, would be to include the m2e-tycho connectoir as a dependency.
cc [~maxandersen]
However, this is still a valid request for other items requiring Tycho extensions.
> Easymport should offer available m2e connectors when importing Maven projects
> -----------------------------------------------------------------------------
>
> Key: JBIDE-20366
> URL: https://issues.jboss.org/browse/JBIDE-20366
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: easymport
> Affects Versions: 4.3.0.Beta1
> Environment: JBDS 9.0.0.Beta2
> Reporter: Jiri Peterka
> Assignee: Mickael Istria
> Fix For: 4.3.0.CR1
>
>
> For example standard maven import offers tycho connector installation for a user. Easymport should provide the same user comfort as maven import does.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 7 months
[JBoss JIRA] (JBIDE-20481) EAP 7 server adapter
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20481?page=com.atlassian.jira.plugi... ]
Rob Stryker resolved JBIDE-20481.
---------------------------------
Resolution: Done
pushed to master along with unit tests
> EAP 7 server adapter
> --------------------
>
> Key: JBIDE-20481
> URL: https://issues.jboss.org/browse/JBIDE-20481
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: server
> Affects Versions: 4.3.0.CR1
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.3.0.CR1
>
>
> It'd be a good idea to begin making an EAP7 / WF10 server adapter pair, or at least preparing.
> Looking at the versions of jars that we care about for management commands, Jars in EAP7 current DR3 are:
> wildfly-controller-client-2.0.0.Alpha3.jar
> wildfly-protocol-2.0.0.Alpha3.jar
> jboss-dmr-1.3.0.Final.jar
> jboss-logging-3.2.1.Final.jar
> jboss-marshalling-1.4.10.Final.jar
> jboss-marshalling-river-1.4.10.Final.jar
> jboss-marshalling-river-1.4.10.Final.jar
> jboss-remoting-4.0.9.Final.jar
> jboss-sasl-1.0.5.Final.jar
> jboss-threads-2.2.0.Final.jar
> xnio-api-3.3.1.Final.jar
> xnio-nio-3.3.1.Final.jar
> These jars are identical to those in WF9-CR1 *except* for wildfly-protocol and wildfly-controller-client, which are at 1.0.0.CR1 in wf9. So wildfly-core (repository) has undergone a 'major' version bump, and is likely undergoing significant API cleanup. It would be smart to expect that we probably will require a new management plugin on our side to compensate.
> Also, it's worth noting that in WF8 / WF 8.1, these jars are actually versioned 8.0 / 8.1 respectively, and so the version has actually decreased as we've moved forward. I've brought this up on wildfly-dev, though it may be a bit late since WF is already ar RC3.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 7 months