[JBoss JIRA] (JBDS-3557) JBDS Installer should be EPL licensed
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3557?page=com.atlassian.jira.plugin.... ]
Nick Boldt commented on JBDS-3557:
----------------------------------
Max, nothing in the installer code is currently *GPL* - nor was it before I changed anything in this JIRA.
But I've reverted the stuff that was *LGPL* in *installer/src/panels/com/jboss/devstudio/core/installer/DiskSpaceCheckPanel.java* per your instructions in the PRs, and fixed the starting copyright date so it's back to 2009, when the code first appears in SVN: https://svn.jboss.org/repos/devstudio/branches/devstudio-1.1.x/rhds-insta...
So, now the only real change in this JIRA is in plugins/com.jboss.devstudio.core.project.examples/about.html, which now states an EPL license instead of an LGPL one. I trust since we wrote that plugin it's OK to change the license terms there, especially since there's nothing in the plugin from a source code perspective -- just a plugin.xml with some extension point being extended. If not, please let me know and I can revert that too.
> JBDS Installer should be EPL licensed
> -------------------------------------
>
> Key: JBDS-3557
> URL: https://issues.jboss.org/browse/JBDS-3557
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Enhancement
> Components: installer, legal
> Reporter: Ken Finnigan
> Assignee: Nick Boldt
> Fix For: 9.1.0.Beta2, 10.0.0.Alpha1
>
>
> For the Developer Platform to be able to bundle JBDS, it needs to be licensed as ASLv2 or EPL and not GPL
> Sources code in repository ether has Apache Licence or no license.
> IzPack distribution jar's and licenses:
> 1. kunstoff Look and Feel is under LGPL http://kunstoff.incors.com/archive/licence.php3
> 2. Birosoft Liquid Look and Feel
> The source code (except the files or methods mentioned below) of the look and feel is released under the LGPL (GNU Lesser General Public License),
> which you can view on http://www.gnu.org/copyleft/lesser.html.
> Some methods are marked as SUN proprietary, the LGPL does not apply for those methods.
> 3. JGoodies Karsten Lentzsch - BSD open source license http://www.jgoodies.com/downloads/libraries/
> 4. Metouia Look And Feel: a free pluggable look and feel for java - LGPLv2.1 http://grepcode.com/file/repo1.maven.org/maven2/net.sf.squirrel-sql.third...
> 5. Nimbus Look And Feel
> This library is free software; you can redistribute it and/or
> * modify it under the terms of the GNU Lesser General Public
> * License as published by the Free Software Foundation; either
> * version 2.1 of the License, or (at your option) any later version.
> 6. Substance Java Look and Feel (bundles several components with licenses listed below)
> 6.1 Copyright (c) 2005-2007, Kirill Grouchnikov and contributors
> All rights reserved.
> Redistribution and use in source and binary forms, with or without
> modification, are permitted provided that the following conditions are met:
> * Redistributions of source code must retain the above copyright
> notice, this list of conditions and the following disclaimer.
> * Redistributions in binary form must reproduce the above copyright
> notice, this list of conditions and the following disclaimer in the
> documentation and/or other materials provided with the distribution.
> * Neither the name of the Kirill Grouchnikov and contributors nor
> the names of its contributors may be used to endorse or promote products
> derived from this software without specific prior written permission.
> 6.2 Source code, documentation and binaries of the Quaqua Look and
> Feel (also called "this software") are subject to the GNU Lesser
> General Public License (LGPL).
> 6.3. MOZILLA PUBLIC LICENSE Version 1.1
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21464) Delete context menu of OpenShift elements is incorrect
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21464?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich edited comment on JBIDE-21464 at 1/18/16 11:28 AM:
-------------------------------------------------------------------------
'Delete' is one of most common actions in Eclipse, and in many views (Package Explorer, Project Explorer, Servers) it is presented in context menu with 'Delete' without dots and without specifying what is to be deleted, but with confirmation dialog. The confirmation is quite specific about the object to be deleted. Selection on which context menu is opened has an identifying icon and label. There may be pro and contra if one word 'Delete' for the menu item name is bettter or worse than a more specific name (one pro - it is easier to find in the long menu by the habitual look, the other - a specific name will make a user to stop and think if this action has more to it than standard Delete if developers went as far as to give it a different name), but it is the standard of Eclipse.
Now, Delete is bound to the global menu, and if we can customize name in context menu, we cannot do it with the global menu name.
I have found one example - 'Delete Log' in 'Error Log' view in context menu of an error message. This action deletes the entire log, not one message on which it is called, so that is a valid example of justified specific name, and what is notable is that 'Delete Log' is _not_ bound to the global 'Delete'.
was (Author: scabanovich):
'Delete' is one of most common actions in Eclipse, and in many views (Package Explorer, Project Explorer, Servers) it is presented in context menu with 'Delete' without dots and without specifying what is to be deleted, but with confirmation dialog. The confirmation is quite specific about the object to be deleted. Selection on which context menu is opened has an identifying icon and label. There may be pro and contra if one word 'Delete' for the menu item name is bettter or worse than a more specific name (one pro - it is easier to find in the long menu by the habitual look, the other - a specific name will make a user to stop and think if this action is actually has more to it than standard Delete if developers went as far as to give it a different name), but it is the standard of Eclipse.
Now, Delete is bound to the global menu, and if we can customize name in context menu, we cannot do it with the global menu name.
I have found one example - 'Delete Log' in 'Error Log' view in context menu of an error message. This action deletes the entire log, not one message on which it is called, so that is a valid example of justified specific name, and what is notable is that 'Delete Log' is _not_ bound to the global 'Delete'.
> Delete context menu of OpenShift elements is incorrect
> ------------------------------------------------------
>
> Key: JBIDE-21464
> URL: https://issues.jboss.org/browse/JBIDE-21464
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Marián Labuda
> Assignee: Viacheslav Kabanovich
> Labels: explorer, openshift_v2, openshift_v3
> Fix For: 4.3.1.Beta2
>
>
> Currently OpenShift tree items in OpenShift Explorer view have "Delete" context menu item. Previously it was more natural, because we had "Delete connection(s)..." "Delete domain..." etc., not it is all "Delete".
> If just plain "Delete" is considered as a good way to go, at least there should be three dots as suffix, because after click on the context menu Delete there is required user confirmation of deletion. So it should be at least "Delete...".
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21464) Delete context menu of OpenShift elements is incorrect
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21464?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21464:
-----------------------------------------------
'Delete' is one of most common actions in Eclipse, and in many views (Package Explorer, Project Explorer, Servers) it is presented in context menu with 'Delete' without dots and without specifying what is to be deleted, but with confirmation dialog. The confirmation is quite specific about the object to be deleted. Selection on which context menu is opened has an identifying icon and label. There may be pro and contra if one word 'Delete' for the menu item name is bettter or worse than a more specific name (one pro - it is easier to find in the long menu by the habitual look, the other - a specific name will make a user to stop and think if this action is actually has more to it than standard Delete if developers went as far as to give it a different name), but it is the standard of Eclipse.
Now, Delete is bound to the global menu, and if we can customize name in context menu, we cannot do it with the global menu name.
I have found one example - 'Delete Log' in 'Error Log' view in context menu of an error message. This action deletes the entire log, not one message on which it is called, so that is a valid example of justified specific name, and what is notable is that 'Delete Log' is _not_ bound to the global 'Delete'.
> Delete context menu of OpenShift elements is incorrect
> ------------------------------------------------------
>
> Key: JBIDE-21464
> URL: https://issues.jboss.org/browse/JBIDE-21464
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Marián Labuda
> Assignee: Viacheslav Kabanovich
> Labels: explorer, openshift_v2, openshift_v3
> Fix For: 4.3.1.Beta2
>
>
> Currently OpenShift tree items in OpenShift Explorer view have "Delete" context menu item. Previously it was more natural, because we had "Delete connection(s)..." "Delete domain..." etc., not it is all "Delete".
> If just plain "Delete" is considered as a good way to go, at least there should be three dots as suffix, because after click on the context menu Delete there is required user confirmation of deletion. So it should be at least "Delete...".
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21463) No error message pop up when attempt to port-forward to a port in use
by Xia Zhao (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21463?page=com.atlassian.jira.plugi... ]
Xia Zhao commented on JBIDE-21463:
----------------------------------
[~adietish] Sorry for confused you. Let me try to explain it clearer. Here are all my test steps in detail:
1. Prepare 2 applications which will deliver different HTML outputs on a same port 8080. Say pod1 in project1 will reurn string "I'm A" if you curl http://127.0.0.1/8080 after a successful port-forward operation, and pod2 in project2 will reutrn string "I'm B" if you curl http://127.0.0.1/8080 after a successful port-forward operation. (Let me know if you need the detailed application json files for these 2 projects)
2. Deploy these 2 applications sepereately into project1 and project2 of openshift
3. Login openshift with JBT (I used Jboss Developer Studio on Mac OS)
4. Inside JBT, go to project1, right click on pod1 (when this pod is running healty), port-forward it to local port 8080 --> This is used to make local 8080 port is now in use
5. curl http://127.0.0.1/8080, should return string "I'm A" in the result HTML file
6. If you go back to JBT, close the port-forward window in step #4, and revisit it , should still see from UI that port forwarding is in process
7. Now go to project2, right click on pod2 (when this pod is running healty), port-forward it to local port 8080 --> This should not be success since port 8080 is already in use, but no error message is popped up, and the Port Forward wizard pretended to be succeeded.
8. Close the port-forward window in step7, and revisit it for the 2nd time now, we can see from the UI that port forwarding is ended.
9. curl http://127.0.0.1/8080, still return string "I'm A" in the result HTML file, this means the port forward in step4 is still taking effect, and the attempt in step 6 had failed, this is the expected result here.
Please let me know if anything is still confusing you.
Thanks,
Xia
> No error message pop up when attempt to port-forward to a port in use
> ---------------------------------------------------------------------
>
> Key: JBIDE-21463
> URL: https://issues.jboss.org/browse/JBIDE-21463
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Environment: OpenShift 3 Tools: 3.1.0.Beta2-v20160114-1935-B149
> OS: Fedora 17 & MAC OS 10
> Reporter: Xia Zhao
> Assignee: Andre Dietisheim
> Labels: openshift_v3
>
> No error message pop up when attempt to port-forward to a port in use in Jboss Developer Studio. This issue does not repro in Eclipse on Mac OS.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21472) Server Adapter: Missing context menu item to show application details
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21472?page=com.atlassian.jira.plugi... ]
Fred Bricon updated JBIDE-21472:
--------------------------------
Fix Version/s: 4.3.1.CR1
> Server Adapter: Missing context menu item to show application details
> ---------------------------------------------------------------------
>
> Key: JBIDE-21472
> URL: https://issues.jboss.org/browse/JBIDE-21472
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Marián Labuda
> Labels: openshift_v2, server_adapter
> Fix For: 4.3.1.CR1
>
>
> In some commit context menu item to show application details of an OpenShift 2 application in OpenShift explorer view was changed from Application details to Properties, what is ok. But probably at same point context menu for properties/application details vanished from OpenShift 2 Server Adapter. There is no context menu "Properties" or "Application details" or any other.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21466) Don't scroll up the software/update list when Enable EA dialog is cancelled
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21466?page=com.atlassian.jira.plugi... ]
Fred Bricon reassigned JBIDE-21466:
-----------------------------------
Assignee: Mickael Istria
> Don't scroll up the software/update list when Enable EA dialog is cancelled
> ---------------------------------------------------------------------------
>
> Key: JBIDE-21466
> URL: https://issues.jboss.org/browse/JBIDE-21466
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: central
> Affects Versions: 4.3.1.Beta2
> Reporter: Jan Richter
> Assignee: Mickael Istria
> Priority: Optional
>
> Central -> software/update -> enable early access -> dialog opens.
> Now when the dialog is closed, the software list is refreshed and scrolls to the top. Can it stop doing that when the dialog is cancelled or closed otherwise than with the 'Yes' button? Nothing changes if I don't say yes, so there is no point in refreshing the list, right?
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21465) 'Disable some filters' option behaves strangely with 'Show installed'
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21465?page=com.atlassian.jira.plugi... ]
Fred Bricon reassigned JBIDE-21465:
-----------------------------------
Assignee: Mickael Istria
> 'Disable some filters' option behaves strangely with 'Show installed'
> ---------------------------------------------------------------------
>
> Key: JBIDE-21465
> URL: https://issues.jboss.org/browse/JBIDE-21465
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Affects Versions: 4.3.1.Beta2
> Reporter: Jan Richter
> Assignee: Mickael Istria
> Priority: Minor
> Attachments: filter.png, installed.png
>
>
> I've installed everything from central software/update -> now it says there is nothing to install and gives me an option to disable some filters. Clicking that produces the following dialog:
> !filter.png|thumbnail!
> The first strange part is, I actually need to uncheck the 'Show installed' checkbox in this dialog to show the installed plugins. It might be technically disabling the filter, but it looks weird.
> The second strange thing is, after 'disabling the filter' it shows the installed plugins, but the 'Show installed' checkbox is still unchecked.
> !installed.png|thumbnail!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21460) NPE at Show In Web Browser for OpenShift server if connection is not connected
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21460?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21460:
-----------------------------------------------
[~adietish], yes the message is better to be shown. Now the exception is caught by Eclipse and shown in standard "Problem occured". If it is an OpenShiftException, it may be ok. We have only to prevent NPE and show it in a nicer way, also taking into account that after cancelling 'sign in' the failure is quite expected.
> NPE at Show In Web Browser for OpenShift server if connection is not connected
> ------------------------------------------------------------------------------
>
> Key: JBIDE-21460
> URL: https://issues.jboss.org/browse/JBIDE-21460
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Viacheslav Kabanovich
> Fix For: 4.3.1.CR1
>
>
> 1. Create an OpenShift connection, do not choose save password/token.
> 2. Create an OpenShift server for the connection.
> 3. Close Eclipse with Server view active
> 4. Restart Eclipse, select Server view.
> 5. In context menu of the server, select Show In Web Browser.
> 6. 'Sign In' dialog appears, select cancel.
> (Note: First time when I got it, dialog did not appear, later I could not repeat steps that would skip the dialog.)
> 7. Failure: NPE while executing getWelcomePageUrl().
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months