[JBoss JIRA] (JBIDE-21460) NPE at Show In Web Browser for OpenShift server if connection is not connected
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21460?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich edited comment on JBIDE-21460 at 1/16/16 12:32 AM:
-------------------------------------------------------------------------
Possible solutions:
1. Just prevent NPE and return null in getWelcomePageUrl(). Disadvantage - action will do nothing silently.
2. While computing welcome page, find the cause of failure (e.g., 'not connected', 'error while retrieving resources', etc.), show message dialog with the problem.
[~adietish], what do you recommend?
was (Author: scabanovich):
Possible solutions:
1. Just prevent NPE and return null in getWelcomePageUrl().
Disadvantage - action will do nothing silently.
2. Together with (1), implement hasWelcomePage() as getWelcomePageUrl() != null, catch exception and return false if one caught.
Advantage - Menu item in context menu will be disabled.
Disadvantages - The cause remains unknown. It make take a long time to open context menu.
3. While computing welcome page, find the cause of failure (e.g., 'not connected', 'error while retrieving resources', etc.), show message dialog with the problem.
[~adietish], what do you recommend?
> NPE at Show In Web Browser for OpenShift server if connection is not connected
> ------------------------------------------------------------------------------
>
> Key: JBIDE-21460
> URL: https://issues.jboss.org/browse/JBIDE-21460
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Viacheslav Kabanovich
>
> 1. Create an OpenShift connection, do not choose save password/token.
> 2. Create an OpenShift server for the connection.
> 3. Close Eclipse with Server view active
> 4. Restart Eclipse, select Server view.
> 5. In context menu of the server, select Show In Web Browser.
> 6. 'Sign In' dialog appears, select cancel.
> (Note: First time when I got it, dialog did not appear, later I could not repeat steps that would skip the dialog.)
> 7. Failure: NPE while executing getWelcomePageUrl().
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21460) NPE at Show In Web Browser for OpenShift server if connection is not connected
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21460?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich updated JBIDE-21460:
------------------------------------------
Description:
1. Create an OpenShift connection, do not choose save password/token.
2. Create an OpenShift server for the connection.
3. Close Eclipse with Server view active
4. Restart Eclipse, select Server view.
5. In context menu of the server, select Show In Web Browser.
6. 'Sign In' dialog appears, select cancel.
(Note: First time when I got it, dialog did not appear, later I could not repeat steps that would skip the dialog.)
7. Failure: NPE while executing getWelcomePageUrl().
was:
1. Create an OpenShift connection, do not choose save password/token.
2. Create an OpenShift server for the connection.
3. Close Eclipse with Server view active
4. Restart Eclipse, select Server view.
5. In context menu of the server, select Show In Web Browser.
Failure: NPE while executing getWelcomePageUrl().
> NPE at Show In Web Browser for OpenShift server if connection is not connected
> ------------------------------------------------------------------------------
>
> Key: JBIDE-21460
> URL: https://issues.jboss.org/browse/JBIDE-21460
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Viacheslav Kabanovich
>
> 1. Create an OpenShift connection, do not choose save password/token.
> 2. Create an OpenShift server for the connection.
> 3. Close Eclipse with Server view active
> 4. Restart Eclipse, select Server view.
> 5. In context menu of the server, select Show In Web Browser.
> 6. 'Sign In' dialog appears, select cancel.
> (Note: First time when I got it, dialog did not appear, later I could not repeat steps that would skip the dialog.)
> 7. Failure: NPE while executing getWelcomePageUrl().
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21460) NPE at Show In Web Browser for OpenShift server if connection is not connected
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21460?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21460:
-----------------------------------------------
Possible solutions:
1. Just prevent NPE and return null in getWelcomePageUrl().
Disadvantage - action will do nothing silently.
2. Together with (1), implement hasWelcomePage() as getWelcomePageUrl() != null, catch exception and return false if one caught.
Advantage - Menu item in context menu will be disabled.
Disadvantages - The cause remains unknown. It make take a long time to open context menu.
3. While computing welcome page, find the cause of failure (e.g., 'not connected', 'error while retrieving resources', etc.), show message dialog with the problem.
[~adietish], what do you recommend?
> NPE at Show In Web Browser for OpenShift server if connection is not connected
> ------------------------------------------------------------------------------
>
> Key: JBIDE-21460
> URL: https://issues.jboss.org/browse/JBIDE-21460
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Viacheslav Kabanovich
>
> 1. Create an OpenShift connection, do not choose save password/token.
> 2. Create an OpenShift server for the connection.
> 3. Close Eclipse with Server view active
> 4. Restart Eclipse, select Server view.
> 5. In context menu of the server, select Show In Web Browser.
> Failure: NPE while executing getWelcomePageUrl().
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21460) NPE at Show In Web Browser for OpenShift server if connection is not connected
by Viacheslav Kabanovich (JIRA)
Viacheslav Kabanovich created JBIDE-21460:
---------------------------------------------
Summary: NPE at Show In Web Browser for OpenShift server if connection is not connected
Key: JBIDE-21460
URL: https://issues.jboss.org/browse/JBIDE-21460
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.3.1.Beta1
Reporter: Viacheslav Kabanovich
1. Create an OpenShift connection, do not choose save password/token.
2. Create an OpenShift server for the connection.
3. Close Eclipse with Server view active
4. Restart Eclipse, select Server view.
5. In context menu of the server, select Show In Web Browser.
Failure: NPE while executing getWelcomePageUrl().
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-20755) Import OpenShift Application wizard contains redundant validation mark
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20755?page=com.atlassian.jira.plugi... ]
Fred Bricon reassigned JBIDE-20755:
-----------------------------------
Fix Version/s: 4.4.0.Alpha1
Assignee: Snjezana Peco (was: Fred Bricon)
Resolution: Done
Applied fix in master and 4.3.x. Thanks again [~snjeza]!
> Import OpenShift Application wizard contains redundant validation mark
> ----------------------------------------------------------------------
>
> Key: JBIDE-20755
> URL: https://issues.jboss.org/browse/JBIDE-20755
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.CR1
> Reporter: Marián Labuda
> Assignee: Snjezana Peco
> Fix For: 4.3.1.Beta2, 4.4.0.Alpha1
>
> Attachments: validation_mark.png
>
>
> In Import OpenShift Application wizard is one validation mark (red cross) on a text widget for a git clone location in case of already imported such repo. But there is shown also another validation mark in the middle of checkbox label.
> !validation_mark.png!
> This one is redundant and also its rendering is performed only when mouse is moved over the checkbox or its label.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21410) Server adapter wizard: Improve source path validation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21410?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21410:
------------------------------------------
merged to jbosstools-4.3.x
> Server adapter wizard: Improve source path validation
> -----------------------------------------------------
>
> Key: JBIDE-21410
> URL: https://issues.jboss.org/browse/JBIDE-21410
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter_wizard
> Fix For: 4.3.1.Beta2
>
>
> First point: In New OpenShift 3 server adapter wizard there is a text label for Source path. Currently there is only not null validation, if there is no path, next button is disabled. Because the path filled in this text widget is local, it would be nice if there would be simple validation of existence of directory described in this text widget.
> Second point: validation message shown in header for empty source path is same as for the pod path "Please provide a path to deploy to on the pod.", what is not correct. This message should be different.
> Third point: it would be nice to have an asterisks on required fields, such as pod or source path.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21459) Server adapter wizard: Improve source path validation
by Andre Dietisheim (JIRA)
Andre Dietisheim created JBIDE-21459:
----------------------------------------
Summary: Server adapter wizard: Improve source path validation
Key: JBIDE-21459
URL: https://issues.jboss.org/browse/JBIDE-21459
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 4.3.1.Beta2
Reporter: Marián Labuda
Assignee: Andre Dietisheim
Fix For: 4.3.1.Beta2
First point: In New OpenShift 3 server adapter wizard there is a text label for Source path. Currently there is only not null validation, if there is no path, next button is disabled. Because the path filled in this text widget is local, it would be nice if there would be simple validation of existence of directory described in this text widget.
Second point: validation message shown in header for empty source path is same as for the pod path "Please provide a path to deploy to on the pod.", what is not correct. This message should be different.
Third point: it would be nice to have an asterisks on required fields, such as pod or source path.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21459) Server adapter wizard: Improve source path validation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21459?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21459:
------------------------------------------
cherry-picked to master
> Server adapter wizard: Improve source path validation
> -----------------------------------------------------
>
> Key: JBIDE-21459
> URL: https://issues.jboss.org/browse/JBIDE-21459
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter_wizard
> Fix For: 4.4.0.Alpha1
>
>
> First point: In New OpenShift 3 server adapter wizard there is a text label for Source path. Currently there is only not null validation, if there is no path, next button is disabled. Because the path filled in this text widget is local, it would be nice if there would be simple validation of existence of directory described in this text widget.
> Second point: validation message shown in header for empty source path is same as for the pod path "Please provide a path to deploy to on the pod.", what is not correct. This message should be different.
> Third point: it would be nice to have an asterisks on required fields, such as pod or source path.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21459) Server adapter wizard: Improve source path validation
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21459?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-21459:
-------------------------------------
Fix Version/s: 4.4.0.Alpha1
(was: 4.3.1.Beta2)
> Server adapter wizard: Improve source path validation
> -----------------------------------------------------
>
> Key: JBIDE-21459
> URL: https://issues.jboss.org/browse/JBIDE-21459
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter_wizard
> Fix For: 4.4.0.Alpha1
>
>
> First point: In New OpenShift 3 server adapter wizard there is a text label for Source path. Currently there is only not null validation, if there is no path, next button is disabled. Because the path filled in this text widget is local, it would be nice if there would be simple validation of existence of directory described in this text widget.
> Second point: validation message shown in header for empty source path is same as for the pod path "Please provide a path to deploy to on the pod.", what is not correct. This message should be different.
> Third point: it would be nice to have an asterisks on required fields, such as pod or source path.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months