[JBoss JIRA] (JBIDE-21428) Server adapter: cannot publish, cannot find "oc" executable
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21428?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21428:
------------------------------------------
[~scabanovich] your comments on #performDefault are insightful.
On the other hand I dont think that we should change OpenShiftCorePreferences.getOCBinaryLocation() as you suggested since this changes the scope of this class, it wont only get preference values any longer. I have a change pending where I added a lookup to the preferences in OCBinaryName (which I renamed to OCBinary). OCBinary would then become able to get the location from preferences or look it up in $PATH which seems more convenient to me.
I suggest that we mix your change in the preference page and my in OCBinary.
> Server adapter: cannot publish, cannot find "oc" executable
> -----------------------------------------------------------
>
> Key: JBIDE-21428
> URL: https://issues.jboss.org/browse/JBIDE-21428
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Priority: Blocker
> Fix For: 4.3.1.Beta2
>
> Attachments: could-not-sync-error.png, oc-binary-preferences.png
>
>
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21428) Server adapter: cannot publish, cannot find "oc" executable
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21428?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21428:
-----------------------------------------------
[~adietish], [~fbricon], please take a look at the pull request.
It turns out, that Eclipse preference input fields which we extend, always change instance value on performDefaults() and on any manual change, even if then it is returned manually to default! So, since it is important to have no instance value until it is changed from default, I changed performDefaults() and performOk() to clean it. I hope it may help.
> Server adapter: cannot publish, cannot find "oc" executable
> -----------------------------------------------------------
>
> Key: JBIDE-21428
> URL: https://issues.jboss.org/browse/JBIDE-21428
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Priority: Blocker
> Fix For: 4.3.1.Beta2
>
> Attachments: could-not-sync-error.png, oc-binary-preferences.png
>
>
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21290) CDK 2 is detected as version 1.0
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21290?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-21290:
--------------------------------
Component/s: upstream
> CDK 2 is detected as version 1.0
> --------------------------------
>
> Key: JBIDE-21290
> URL: https://issues.jboss.org/browse/JBIDE-21290
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, runtime-detection, upstream
> Affects Versions: 4.3.1.Beta1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Priority: Minor
> Fix For: 4.3.1.Beta2, 4.4.0.Alpha1
>
> Attachments: cdk-runtime-detection.png, Screenshot 2016-01-07 09.16.12.png
>
>
> When you detect CDK using runtime detection, it will show you the name cdk-v2 which clearly shows it's version 2 (this is actually just based on the folder it seems). But the Version column says Version 1.0.
> !cdk-runtime-detection.png!
> Could we change it to version 2?
> I know that this probably doesn't have any meaning right now - I noticed there is no runtime anymore, so the version is nowhere to be seen once you create the cdk server adapter. But it would still be nicer to show the correct version if possible.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21290) CDK 2 is detected as version 1.0
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21290?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-21290:
-------------------------------------
I've made a commit changing the hard-coded version to 2.0 for now, until upstream provides some sort of API.
> CDK 2 is detected as version 1.0
> --------------------------------
>
> Key: JBIDE-21290
> URL: https://issues.jboss.org/browse/JBIDE-21290
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, runtime-detection
> Affects Versions: 4.3.1.Beta1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Priority: Minor
> Fix For: 4.3.1.Beta2, 4.4.0.Alpha1
>
> Attachments: cdk-runtime-detection.png, Screenshot 2016-01-07 09.16.12.png
>
>
> When you detect CDK using runtime detection, it will show you the name cdk-v2 which clearly shows it's version 2 (this is actually just based on the folder it seems). But the Version column says Version 1.0.
> !cdk-runtime-detection.png!
> Could we change it to version 2?
> I know that this probably doesn't have any meaning right now - I noticed there is no runtime anymore, so the version is nowhere to be seen once you create the cdk server adapter. But it would still be nicer to show the correct version if possible.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months