[JBoss JIRA] (JBIDE-19975) v3 (Template) Application wizard: error markers for missing content should be consistent with rest of OpenShift tooling
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19975?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich edited comment on JBIDE-19975 at 1/5/16 11:43 PM:
------------------------------------------------------------------------
[~adietish], please take a look at the pull request for Edit Template Parameter dialog.
Resource Label wizard page was fixed with JBIDE-19010.
was (Author: scabanovich):
[~adietish], please take a look at the pull request for Edit Template Parameter dialog.
> v3 (Template) Application wizard: error markers for missing content should be consistent with rest of OpenShift tooling
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-19975
> URL: https://issues.jboss.org/browse/JBIDE-19975
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Andre Dietisheim
> Labels: application_wizard, openshift_v3
> Fix For: 4.3.x
>
> Attachments: edit-template-parameter-value.png, required-value-decoration.png
>
>
> # ASSERT: make sure that you have a connection to a v3 OpenShift server
> # EXEC: in OpenShift explorer: pick "New"->"Application" from the context menu of your v3 connection
> # ASSERT: new application wizard pops up, listing your project
> # EXEC: unfold your project to get a listing of the available templates and pick on. Hit "Next"
> # EXEC: in "Template Parameters" wizard page: select an entry without value and hit "Edit"
> # ASSERT: editing dialog pops up
> Result:
> !edit-template-parameter-value.png!
> "OK" button is enabled even though I didnt change anything. There isnt any decoration to the text field either that would require me to provide a value?
> # EXEC: provide some value and back in the wizard page hit "Next"
> # ASSERT: "Resource Labels" page shows up.
> # EXEC: Hit "Add"
> # ASSERT: dialog pops up so that I can create a new label
> Result:
> !required-value-decoration.png!
> The dialog decorates missing values with a red error marker.
> In OpenShift tooling we usually use "*" when required values are missing, not the error icon.
> Notice also the 2 additional error-decorations that are shown (there are 4 error decorations while we should have 2 only)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-19975) v3 (Template) Application wizard: error markers for missing content should be consistent with rest of OpenShift tooling
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19975?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-19975:
-----------------------------------------------
[~adietish], please take a look at the pull request for Edit Template Parameter dialog.
> v3 (Template) Application wizard: error markers for missing content should be consistent with rest of OpenShift tooling
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-19975
> URL: https://issues.jboss.org/browse/JBIDE-19975
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Andre Dietisheim
> Labels: application_wizard, openshift_v3
> Fix For: 4.3.x
>
> Attachments: edit-template-parameter-value.png, required-value-decoration.png
>
>
> # ASSERT: make sure that you have a connection to a v3 OpenShift server
> # EXEC: in OpenShift explorer: pick "New"->"Application" from the context menu of your v3 connection
> # ASSERT: new application wizard pops up, listing your project
> # EXEC: unfold your project to get a listing of the available templates and pick on. Hit "Next"
> # EXEC: in "Template Parameters" wizard page: select an entry without value and hit "Edit"
> # ASSERT: editing dialog pops up
> Result:
> !edit-template-parameter-value.png!
> "OK" button is enabled even though I didnt change anything. There isnt any decoration to the text field either that would require me to provide a value?
> # EXEC: provide some value and back in the wizard page hit "Next"
> # ASSERT: "Resource Labels" page shows up.
> # EXEC: Hit "Add"
> # ASSERT: dialog pops up so that I can create a new label
> Result:
> !required-value-decoration.png!
> The dialog decorates missing values with a red error marker.
> In OpenShift tooling we usually use "*" when required values are missing, not the error icon.
> Notice also the 2 additional error-decorations that are shown (there are 4 error decorations while we should have 2 only)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21399) Editor should be shown as dirty if saving of modified resource failed
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21399?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich edited comment on JBIDE-21399 at 1/5/16 7:45 PM:
-----------------------------------------------------------------------
Editor is saved in a separate job that can be executed while shown in modal dialog or in background depending on preference RUN_IN_BACKGROUND. The fix should be tested in both modes. Unfortunately, I cannot find this preference in Preferences dialog. OpenShiftResourceDocumentProvider.SaveOperation sets info.fCanBeSaved=false when doSaveDocument() returns, it can happen before or after job is completed. If in some use case SaveOperation is the last one to touch info.fCanBeSaved, the fix will not work.
Anyway, trying to fix the issue with setting info.fCanBeSaved and firing state changed event seems the best approach.
Maybe this can protect from uncertainty:
1. In the beginning of doSaveDocument create
final Exception[] exc = new Exception[1];
2. In catch block of jobs set
exc[0] = e;
3. In the end of doSaveDocument check:
if(exc[0] != null) {
throw new CoreException(
);
}
was (Author: scabanovich):
Editor is saved in a separate job that can be executed while shown in modal dialog or in background depending on preference RUN_IN_BACKGROUND. The fix should be tested in both modes. Unfortunately, I cannot find this preference in Preferences dialog. OpenShiftResourceDocumentProvider.SaveOperation sets info.fCanBeSaved=false when doSaveDocument() returns, it can happen before or after job is completed. If in some use case SaveOperation is the last one to touch info.fCanBeSaved, the fix will not work.
Anyway, trying to fix the issue with setting info.fCanBeSaved and firing state changed event seems the best approach.
> Editor should be shown as dirty if saving of modified resource failed
> ---------------------------------------------------------------------
>
> Key: JBIDE-21399
> URL: https://issues.jboss.org/browse/JBIDE-21399
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.Final
> Reporter: Marián Labuda
> Assignee: Fred Bricon
> Fix For: 4.3.1.Beta2
>
>
> After editing resource to inappropriate state and save it, there is an error that update of a resource failed but content of text editor is saved and its state does not reflect current state of resource on OS 3 server. If update of a resource was not successful, opened text editor with the given resource json should be still shown as dirty.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21399) Editor should be shown as dirty if saving of modified resource failed
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21399?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich edited comment on JBIDE-21399 at 1/5/16 7:37 PM:
-----------------------------------------------------------------------
Editor is saved in a separate job that can be executed while shown in modal dialog or in background depending on preference RUN_IN_BACKGROUND. The fix should be tested in both modes. Unfortunately, I cannot find this preference in Preferences dialog. OpenShiftResourceDocumentProvider.SaveOperation sets info.fCanBeSaved=false when doSaveDocument() returns, it can happen before or after job is completed. If in some use case SaveOperation is the last one to touch info.fCanBeSaved, the fix will not work.
Anyway, trying to fix the issue with setting info.fCanBeSaved and firing state changed event seems the best approach.
was (Author: scabanovich):
Editor is saved in a separate job that can be executed while shown in modal dialog or in background depending on preference RUN_IN_BACKGROUND. The fix should be tested in both modes. Unfortunately, I cannot find this preference in Preferences dialog. OpenShiftResourceDocumentProvider.SaveOperation sets info.fCanBeSaved=false when doSaveDocument() returns, it can happen before or after job is completed. If in some use case SaveOperation is the last one to touch info.fCanBeSaved, the fix willnot work.
> Editor should be shown as dirty if saving of modified resource failed
> ---------------------------------------------------------------------
>
> Key: JBIDE-21399
> URL: https://issues.jboss.org/browse/JBIDE-21399
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.Final
> Reporter: Marián Labuda
> Assignee: Fred Bricon
> Fix For: 4.3.1.Beta2
>
>
> After editing resource to inappropriate state and save it, there is an error that update of a resource failed but content of text editor is saved and its state does not reflect current state of resource on OS 3 server. If update of a resource was not successful, opened text editor with the given resource json should be still shown as dirty.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21399) Editor should be shown as dirty if saving of modified resource failed
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21399?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21399:
-----------------------------------------------
Editor is saved in a separate job that can be executed while shown in modal dialog or in background depending on preference RUN_IN_BACKGROUND. The fix should be tested in both modes. Unfortunately, I cannot find this preference in Preferences dialog. OpenShiftResourceDocumentProvider.SaveOperation sets info.fCanBeSaved=false when doSaveDocument() returns, it can happen before or after job is completed. If in some use case SaveOperation is the last one to touch info.fCanBeSaved, the fix willnot work.
> Editor should be shown as dirty if saving of modified resource failed
> ---------------------------------------------------------------------
>
> Key: JBIDE-21399
> URL: https://issues.jboss.org/browse/JBIDE-21399
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.Final
> Reporter: Marián Labuda
> Assignee: Fred Bricon
> Fix For: 4.3.1.Beta2
>
>
> After editing resource to inappropriate state and save it, there is an error that update of a resource failed but content of text editor is saved and its state does not reflect current state of resource on OS 3 server. If update of a resource was not successful, opened text editor with the given resource json should be still shown as dirty.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21290) CDK 2 is detected as version 1.0
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21290?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-21290:
-------------------------------------
If a patch is made to both DEVEX and the openshift-vagrant repositories, I can then let our tools inspect the .cdk file for the new property. I'll wait for the other two to have action first.
> CDK 2 is detected as version 1.0
> --------------------------------
>
> Key: JBIDE-21290
> URL: https://issues.jboss.org/browse/JBIDE-21290
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, runtime-detection
> Affects Versions: 4.3.1.Beta1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Priority: Minor
> Fix For: 4.3.1.Beta2, 4.4.0.Alpha1
>
> Attachments: cdk-runtime-detection.png
>
>
> When you detect CDK using runtime detection, it will show you the name cdk-v2 which clearly shows it's version 2 (this is actually just based on the folder it seems). But the Version column says Version 1.0.
> !cdk-runtime-detection.png!
> Could we change it to version 2?
> I know that this probably doesn't have any meaning right now - I noticed there is no runtime anymore, so the version is nowhere to be seen once you create the cdk server adapter. But it would still be nicer to show the correct version if possible.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21399) Editor should be shown as dirty if saving of modified resource failed
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21399?page=com.atlassian.jira.plugi... ]
Marián Labuda updated JBIDE-21399:
----------------------------------
Steps to Reproduce:
ASSERT: Have an OS 3 connection with project and application.
EXEC: Open Edit... from context menu of a resource, e.g. build config.
EXEC: Change e.g. namespace to something different and save editor
RESULT: Error of failed update is shown and text editor is saved.
EXPECTED RESULT: Error of failed update is shown and text editor is still shown as dirty.
was:
ASSERT: Have an OS 3 connection with project and application.
EXEC: Open Edit... from context menu of a resource, e.g. build config.
EXEC: Change e.g. namespace to something different and save editor
RESULT: Error of failed update is shown and text editor is saved.
EXPECTED RESULT: Error of failed update is shown and text editor is still shown as dirty or rollbacked to lates valid values.
> Editor should be shown as dirty if saving of modified resource failed
> ---------------------------------------------------------------------
>
> Key: JBIDE-21399
> URL: https://issues.jboss.org/browse/JBIDE-21399
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.Final
> Reporter: Marián Labuda
> Assignee: Fred Bricon
> Fix For: 4.3.1.Beta2
>
>
> After editing resource to inappropriate state and save it, there is an error that update of a resource failed but content of text editor is saved and its state does not reflect current state of resource on OS 3 server. If update of a resource was not successful, opened text editor with the given resource json should be still shown as dirty.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21399) Editor should be shown as dirty if saving of modified resource failed
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21399?page=com.atlassian.jira.plugi... ]
Marián Labuda commented on JBIDE-21399:
---------------------------------------
[~fbricon] yeah I agree with you. Leaving editor dirty is better choice.
> Editor should be shown as dirty if saving of modified resource failed
> ---------------------------------------------------------------------
>
> Key: JBIDE-21399
> URL: https://issues.jboss.org/browse/JBIDE-21399
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.Final
> Reporter: Marián Labuda
> Assignee: Fred Bricon
> Fix For: 4.3.1.Beta2
>
>
> After editing resource to inappropriate state and save it, there is an error that update of a resource failed but content of text editor is saved and its state does not reflect current state of resource on OS 3 server. If update of a resource was not successful, opened text editor with the given resource json should be still shown as dirty.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21399) Editor should be shown as dirty if saving of modified resource failed
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21399?page=com.atlassian.jira.plugi... ]
Fred Bricon commented on JBIDE-21399:
-------------------------------------
leaving the editor dirty on error makes total sense, however I disagree about rolling back to previous valid values. If the user made non-trivial changes and a simple typo made its content invalid, then it should be easily fixable. Since it'd be shown as dirty, it's implied reopening the resource would display the latest valid content.
> Editor should be shown as dirty if saving of modified resource failed
> ---------------------------------------------------------------------
>
> Key: JBIDE-21399
> URL: https://issues.jboss.org/browse/JBIDE-21399
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.Final
> Reporter: Marián Labuda
> Assignee: Fred Bricon
> Fix For: 4.3.1.Beta2
>
>
> After editing resource to inappropriate state and save it, there is an error that update of a resource failed but content of text editor is saved and its state does not reflect current state of resource on OS 3 server. If update of a resource was not successful, opened text editor with the given resource json should be still shown as dirty.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21407) staging/release guides should generate task jiras to remind releng to re-enable disabled jobs once staging or release is done
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21407?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-21407:
-------------------------------
Description:
Amend both staging and release guides such that disabled jobs are appropriately re-enabled at the correct time: once staging/release announcement emails are sent *if there's a planned future milestone*.
* re-enable job
* set correct github branch
* upversion dependencies (eg., releng scripts)
* upversion target platforms / Central version
* ...?
Verify this is correctly done for 4.3.1.Beta2, as that will also require the same on/off/on steps as were done for 4.3.1.Beta1 (JBIDE-21392).
was:
Amend both staging and release guides such that disabled jobs are appropriately re-enabled at the correct time: once staging/release announcement emails are sent *if there's a planned future milestone*.
Verify this is correctly done for 4.3.1.Beta2, as that will also require the same on/off/on steps as were done for 4.3.1.Beta1 (JBIDE-21392).
> staging/release guides should generate task jiras to remind releng to re-enable disabled jobs once staging or release is done
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21407
> URL: https://issues.jboss.org/browse/JBIDE-21407
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.3.1.Beta1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.3.1.Beta2
>
>
> Amend both staging and release guides such that disabled jobs are appropriately re-enabled at the correct time: once staging/release announcement emails are sent *if there's a planned future milestone*.
> * re-enable job
> * set correct github branch
> * upversion dependencies (eg., releng scripts)
> * upversion target platforms / Central version
> * ...?
> Verify this is correctly done for 4.3.1.Beta2, as that will also require the same on/off/on steps as were done for 4.3.1.Beta1 (JBIDE-21392).
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months