[JBoss JIRA] (JBIDE-23380) MOJO that fails build if manifest in .core plugin has .ui dependency
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23380?page=com.atlassian.jira.plugi... ]
Nick Boldt reassigned JBIDE-23380:
----------------------------------
Assignee: Rob Stryker
> MOJO that fails build if manifest in .core plugin has .ui dependency
> --------------------------------------------------------------------
>
> Key: JBIDE-23380
> URL: https://issues.jboss.org/browse/JBIDE-23380
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: build
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.4.2.AM3
>
>
> At a minimum, the mojo should:
> foreach plugin, if plugin ends in .core, check plugin/META-INF/MANIFEST for Dependencies manifest header, and verify .ui is not included in the dependencies at all.
> However, this minimum goal would not have solved the issue we are experiencing with foundation.checkup. The foundation.checkup plugin does not end in .core and so would be skipped by this simple algorithm.
> So... we may wish to check transitive dependencies *only in the same repo*. For example, foundation.core depends on foundation.checker, and foundation.checker is in the same repo, so foundation.checker should also be checked for ui deps or fail.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23380) MOJO that fails build if manifest in .core plugin has .ui dependency
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23380?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-23380:
-------------------------------
Fix Version/s: 4.4.2.AM3
> MOJO that fails build if manifest in .core plugin has .ui dependency
> --------------------------------------------------------------------
>
> Key: JBIDE-23380
> URL: https://issues.jboss.org/browse/JBIDE-23380
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: build
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.4.2.AM3
>
>
> At a minimum, the mojo should:
> foreach plugin, if plugin ends in .core, check plugin/META-INF/MANIFEST for Dependencies manifest header, and verify .ui is not included in the dependencies at all.
> However, this minimum goal would not have solved the issue we are experiencing with foundation.checkup. The foundation.checkup plugin does not end in .core and so would be skipped by this simple algorithm.
> So... we may wish to check transitive dependencies *only in the same repo*. For example, foundation.core depends on foundation.checker, and foundation.checker is in the same repo, so foundation.checker should also be checked for ui deps or fail.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23352) Deploy Docker Wizard: Default routing port selection need more info for users
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23352?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-23352:
-------------------------------------
Attachment: refdoc-services-2.png
refdoc-services-1.png
webui-deploy-docker-image.png
> Deploy Docker Wizard: Default routing port selection need more info for users
> -----------------------------------------------------------------------------
>
> Key: JBIDE-23352
> URL: https://issues.jboss.org/browse/JBIDE-23352
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Marián Labuda
> Labels: deploy_docker_wizard, openshift_v3
> Fix For: 4.4.2.AM3
>
> Attachments: no_route_selected.png, refdoc-services-1.png, refdoc-services-2.png, webui-deploy-docker-image.png
>
>
> In the wizard on wizard page Services & Routing Settings, there is a table with mapped ports. No port is selected by default , but OpenShift knows what to open.
> If there is only one port mapping, we could check it by default. If there are more port mappings, we could show a label/info/description what is gonna be done under the hood, so users will know what is happening.
> steps to reproduce:
> # EXEC: In Docker Explroer: pick an image and choose "Deploy to OpenShift..." in the context menu
> # EXEC: get to the "Services & Routing Settings" page
> !no_route_selected.png!
> It's not obvious to the user what the wizard will create: A service that "exposes" pod ports and a route that points to this service. Furthermore it's not obvious that without a "checked" (used by route) port, the route will round-robin through the available ports. Additionally we should show the user what ports are exposed by the pod, and which ones are ports that the user added while no explicit exposure is defined in the pod (so he's on his own, if there's nothing listening on them he'll have users face non-functional or no reposonses at all).
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23352) Deploy Docker Wizard: Default routing port selection need more info for users
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23352?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-23352 at 10/18/16 10:17 AM:
---------------------------------------------------------------------
As examples for explanations in our page I'd took screenshots in the webui, where you're told - for a given docker image that you want to deploy - that the ports are being load balanced (which is what happens in our ui when no route port is selected):
!webui-deploy-docker-image.png!
We could also explain that we will create a service and a route for the image. Then explaining what serivces and routes offer (the following is taken from the reference docs at https://docs.openshift.com/enterprise/3.0/architecture/core_concepts/pods...):
!refdoc-services-1.png!
!refdoc-services-2.png!
was (Author: adietish):
As examples for explanations in our page I'd took screenshots in the webui, where you're told - for a given docker image that you want to deploy - that the ports are being load balanced (which is what happens in our ui when no route port is selected):
!webui-deploy-docker-image.png!
We could also explain that we will create a service and a route for the image. Then explaining what serivces and routes offer:
!refdoc-services-1.png!
!refdoc-services-2.png!
> Deploy Docker Wizard: Default routing port selection need more info for users
> -----------------------------------------------------------------------------
>
> Key: JBIDE-23352
> URL: https://issues.jboss.org/browse/JBIDE-23352
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Marián Labuda
> Labels: deploy_docker_wizard, openshift_v3
> Fix For: 4.4.2.AM3
>
> Attachments: no_route_selected.png, refdoc-services-1.png, refdoc-services-2.png, webui-deploy-docker-image.png
>
>
> In the wizard on wizard page Services & Routing Settings, there is a table with mapped ports. No port is selected by default , but OpenShift knows what to open.
> If there is only one port mapping, we could check it by default. If there are more port mappings, we could show a label/info/description what is gonna be done under the hood, so users will know what is happening.
> steps to reproduce:
> # EXEC: In Docker Explroer: pick an image and choose "Deploy to OpenShift..." in the context menu
> # EXEC: get to the "Services & Routing Settings" page
> !no_route_selected.png!
> It's not obvious to the user what the wizard will create: A service that "exposes" pod ports and a route that points to this service. Furthermore it's not obvious that without a "checked" (used by route) port, the route will round-robin through the available ports. Additionally we should show the user what ports are exposed by the pod, and which ones are ports that the user added while no explicit exposure is defined in the pod (so he's on his own, if there's nothing listening on them he'll have users face non-functional or no reposonses at all).
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months