[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-23182 at 10/13/16 9:56 AM:
--------------------------------------------------------------------
merged [#1335|https://github.com/jbosstools/jbosstools-openshift/pull/1335]. Filed JBIDE-23324 so that we can implement the solution, that's based on the child cotext in the next sprint.
was (Author: adietish):
merged [#1335|https://github.com/jbosstools/jbosstools-openshift/pull/1335]. Keeping this opened and postponing it so that we can implement the solution, that's based on the child cotext in the next sprint.
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Labels: openshift_v3, pod_log_console
> Fix For: 4.4.2.AM2
>
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-23182:
-------------------------------------
Fix Version/s: (was: 4.4.2.AM3)
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Labels: openshift_v3, pod_log_console
> Fix For: 4.4.2.AM2
>
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-23182:
-------------------------------------
Sprint: devex #121 October 2016 (was: devex #122 October 2016)
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Labels: openshift_v3, pod_log_console
> Fix For: 4.4.2.AM2
>
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-23182:
-------------------------------------
Sprint: devex #122 October 2016 (was: devex #121 October 2016)
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Labels: openshift_v3, pod_log_console
> Fix For: 4.4.2.AM2, 4.4.2.AM3
>
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-23182:
-------------------------------------
Fix Version/s: 4.4.2.AM3
Sprint: devex #121 October 2016
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Labels: openshift_v3, pod_log_console
> Fix For: 4.4.2.AM2, 4.4.2.AM3
>
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-23182:
------------------------------------------
merged [#1335|https://github.com/jbosstools/jbosstools-openshift/pull/1335]. Keeping this opened and postponing it so that we can implement the solution, that's based on the child cotext in the next sprint.
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Labels: openshift_v3, pod_log_console
> Fix For: 4.4.2.AM2
>
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-23182 at 10/13/16 9:50 AM:
--------------------------------------------------------------------
[~bdshadow] nice catch, I'm not all sure but your suggestion sounds about right.
Reading your suggestion - which I tend to agree on - you'd replace the current PR with a "proper" solution that sets a child context, right?
The following code in HandlerUtil#getSelection hints to me that you're right - it gets the selection from the current context:
{code:title=HandlerUtils}
public static ISelection getCurrentSelection(ExecutionEvent event) {
Object o = getVariable(event, ISources.ACTIVE_CURRENT_SELECTION_NAME);
...
}
public static Object getVariable(ExecutionEvent event, String name) {
if (event.getApplicationContext() instanceof IEvaluationContext) {
Object var = ((IEvaluationContext) event.getApplicationContext()).getVariable(name);
...
{code}
was (Author: adietish):
[~bdshadow] nice catch, I'm not all sure but your suggestion sounds about right.
Reading your suggestion - which I tend to agree on - you'd replace the current PR with a "proper" solution that sets a child context, right?
The following code in HandlerUtil#getSelection hints to me that you're right - it gets the selection from the current context:
{code:title=HandlerUtils}
public static ISelection getCurrentSelection(ExecutionEvent event) {
Object o = getVariable(event, ISources.ACTIVE_CURRENT_SELECTION_NAME);
...
}
public static Object getVariable(ExecutionEvent event, String name) {
if (event.getApplicationContext() instanceof IEvaluationContext) {
Object var = ((IEvaluationContext) event.getApplicationContext()).getVariable(name);
...
{code}
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Labels: openshift_v3, pod_log_console
> Fix For: 4.4.2.AM2
>
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-23182 at 10/13/16 9:49 AM:
--------------------------------------------------------------------
[~bdshadow] nice catch, I'm not all sure but your suggestion sounds about right.
Reading your suggestion - which I tend to agree on - you'd replace the current PR with a "proper" solution that sets a child context, right?
The following code in HandlerUtil#getSelection hints to me that you're right - it gets the selection from the current context:
{code;title=HandlerUtils}
public static ISelection getCurrentSelection(ExecutionEvent event) {
Object o = getVariable(event, ISources.ACTIVE_CURRENT_SELECTION_NAME);
...
}
public static Object getVariable(ExecutionEvent event, String name) {
if (event.getApplicationContext() instanceof IEvaluationContext) {
Object var = ((IEvaluationContext) event.getApplicationContext()).getVariable(name);
...
{code}
was (Author: adietish):
[~bdshadow] nice catch, I'm not all sure but your suggestion sounds about right.
Reading your suggestion - which I tend to agree on - you'd replace the current PR with a "proper" solution that sets a child context, right?
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Labels: openshift_v3, pod_log_console
> Fix For: 4.4.2.AM2
>
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months
[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-23182 at 10/13/16 9:49 AM:
--------------------------------------------------------------------
[~bdshadow] nice catch, I'm not all sure but your suggestion sounds about right.
Reading your suggestion - which I tend to agree on - you'd replace the current PR with a "proper" solution that sets a child context, right?
The following code in HandlerUtil#getSelection hints to me that you're right - it gets the selection from the current context:
{code:title=HandlerUtils}
public static ISelection getCurrentSelection(ExecutionEvent event) {
Object o = getVariable(event, ISources.ACTIVE_CURRENT_SELECTION_NAME);
...
}
public static Object getVariable(ExecutionEvent event, String name) {
if (event.getApplicationContext() instanceof IEvaluationContext) {
Object var = ((IEvaluationContext) event.getApplicationContext()).getVariable(name);
...
{code}
was (Author: adietish):
[~bdshadow] nice catch, I'm not all sure but your suggestion sounds about right.
Reading your suggestion - which I tend to agree on - you'd replace the current PR with a "proper" solution that sets a child context, right?
The following code in HandlerUtil#getSelection hints to me that you're right - it gets the selection from the current context:
{code;title=HandlerUtils}
public static ISelection getCurrentSelection(ExecutionEvent event) {
Object o = getVariable(event, ISources.ACTIVE_CURRENT_SELECTION_NAME);
...
}
public static Object getVariable(ExecutionEvent event, String name) {
if (event.getApplicationContext() instanceof IEvaluationContext) {
Object var = ((IEvaluationContext) event.getApplicationContext()).getVariable(name);
...
{code}
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Labels: openshift_v3, pod_log_console
> Fix For: 4.4.2.AM2
>
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 5 months