[JBoss JIRA] (JBIDE-22803) Explorer: When OS projects are created and deleted, seems Openshift explorer restores non existing values
by Jeff Cantrill (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22803?page=com.atlassian.jira.plugi... ]
Jeff Cantrill commented on JBIDE-22803:
---------------------------------------
[~dbocharov] We should not be using version to detect enablement of a feature; this was a design decision made early on for the rest client. Typically we would try to figure out if a capability were supported instead of relying on version. I would suggest we 'try' to watch projects and fall back to our original mechanism if project watch is unsupported.
> Explorer: When OS projects are created and deleted, seems Openshift explorer restores non existing values
> ---------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-22803
> URL: https://issues.jboss.org/browse/JBIDE-22803
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Jeff MAURY
> Assignee: Dmitrii Bocharov
> Labels: explorer, openshift, openshift_v3
> Fix For: 4.4.2.AM2
>
> Attachments: after application creation.png, after build finished.png, Openshift Web Console.png, screenshot-1.png
>
>
> EXEC: create an Openshift project
> EXEC: expand it
> EXEC: Create an application in this project (nodejs-example)
> ASSERT: wait for the pod to be available
> EXEC: delete the Openshit project
> EXEC: create an Openshift project (using the same name. You may have to repeat this step as you may got error that it still exists)
> EXEC: expand it
> EXEC: Create an application in this project (nodejs-example)
> EXEC: expand the nodejs-example node
> ASSERT: you should see 2 pods the old one and the build pod you just created: [^screenshot-1.png]
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-23162) Deploy Image wizard: Double clicking an image while browsing a docker connection should close the dialog
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23162?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-23162:
-------------------------------------
Summary: Deploy Image wizard: Double clicking an image while browsing a docker connection should close the dialog (was: Double clicking an image while browsing a docker connection should close the dialog)
> Deploy Image wizard: Double clicking an image while browsing a docker connection should close the dialog
> --------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-23162
> URL: https://issues.jboss.org/browse/JBIDE-23162
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.1.Final
> Reporter: Jeff MAURY
> Labels: deploy_docker_wizard, openshift, openshift_v3
> Fix For: 4.4.2.AM2
>
>
> When deploying a Docker image to Openshift, a Docker connection can be browsed to select the image. But the dialog does not autoclose when the image is double clicked
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-23162) Deploy Docker wizard: Double clicking an image while browsing a docker connection should close the dialog
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23162?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-23162:
-------------------------------------
Summary: Deploy Docker wizard: Double clicking an image while browsing a docker connection should close the dialog (was: Deploy Image wizard: Double clicking an image while browsing a docker connection should close the dialog)
> Deploy Docker wizard: Double clicking an image while browsing a docker connection should close the dialog
> ---------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-23162
> URL: https://issues.jboss.org/browse/JBIDE-23162
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.1.Final
> Reporter: Jeff MAURY
> Labels: deploy_docker_wizard, openshift, openshift_v3
> Fix For: 4.4.2.AM2
>
>
> When deploying a Docker image to Openshift, a Docker connection can be browsed to select the image. But the dialog does not autoclose when the image is double clicked
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-23298) Build: jenkins and local build are failing for openshift
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23298?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-23298:
------------------------------------------
deployed lastest openshift-restclient-java to repository.jboss.org
merged PR into master
> Build: jenkins and local build are failing for openshift
> --------------------------------------------------------
>
> Key: JBIDE-23298
> URL: https://issues.jboss.org/browse/JBIDE-23298
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: openshift
> Affects Versions: 4.4.2.AM2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Priority: Blocker
> Labels: build
> Fix For: 4.4.2.AM2
>
>
> starting with [#1596|https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JBossTools/view/JBossTools_Master/job/jbosstools-openshift_master/1596/console]
> {code}
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.26.0:compile (default-compile) on project org.jboss.tools.openshift.core: Compilation failure: Compilation failure:
> [ERROR] /home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/internal/core/WatchManager.java:[303]
> [ERROR] Trace.debug("Watch received change in {0} state\n{1}", state, resource.toJson(false));
> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^
> [ERROR] Access restriction: The method 'JSONSerializeable.toJson(boolean)' is not API (restriction on classpath entry '/home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.client/lib/openshift-restclient-java-5.2.0-SNAPSHOT.jar')
> [ERROR] /home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/connection/Connection.java:[494]
> [ERROR] return client.get(resource.getKind(), resource.getName(), resource.getNamespace());
> [ERROR] ^^^^^^^^^^^^^^^^^^
> [ERROR] Access restriction: The method 'IKindable.getKind()' is not API (restriction on classpath entry '/home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.client/lib/openshift-restclient-java-5.2.0-SNAPSHOT.jar')
> [ERROR] /home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/connection/Connection.java:[496]
> [ERROR] return retryGet(e, resource.getKind(), resource.getName(), resource.getNamespace());
> [ERROR] ^^^^^^^^^^^^^^^^^^
> [ERROR] Access restriction: The method 'IKindable.getKind()' is not API (restriction on classpath entry '/home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.client/lib/openshift-restclient-java-5.2.0-SNAPSHOT.jar')
> [ERROR] /home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/connection/ConnectionNotFoundException.java:[26]
> [ERROR] super("Unable to find the connection for a {0} named {1}", resource.getKind(), resource.getName());
> [ERROR] ^^^^^^^^^^^^^^^^^^
> [ERROR] Access restriction: The method 'IKindable.getKind()' is not API (restriction on classpath entry '/home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.client/lib/openshift-restclient-java-5.2.0-SNAPSHOT.jar')
> [ERROR] /home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/server/PodDeploymentPathProvider.java:[100]
> [ERROR] String imageName = ModelNode.fromJSONString(istag.toJson()).get("image").get("metadata").get("name").asString();
> [ERROR] ^^^^^^^^^^^^^^
> [ERROR] Access restriction: The method 'JSONSerializeable.toJson()' is not API (restriction on classpath entry '/home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.client/lib/openshift-restclient-java-5.2.0-SNAPSHOT.jar')
> [ERROR] /home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/server/PodDeploymentPathProvider.java:[137]
> [ERROR] String imageStreamTagJson = imageStreamTag.toJson(true);
> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ERROR] Access restriction: The method 'JSONSerializeable.toJson(boolean)' is not API (restriction on classpath entry '/home/adietish/jboss-workspaces/jbosstools-github/jbosstools-openshift/plugins/org.jboss.tools.openshift.client/lib/openshift-restclient-java-5.2.0-SNAPSHOT.jar')
> [ERROR] 6 problems (6 errors)
> [ERROR] -> [Help 1]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-22803) Explorer: When OS projects are created and deleted, seems Openshift explorer restores non existing values
by Jeff Cantrill (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22803?page=com.atlassian.jira.plugi... ]
Jeff Cantrill commented on JBIDE-22803:
---------------------------------------
* I presume the openshift/version should be allowable by an anonymous user. I would expect that to be a bug.
* I think 101 is a client upgrade code related to using websockets and it maybe the rest client needs to be tweaked to support watching project. I might suggest playing with the Watch integration test in the REST client to confirm it works as expected
* There is a timeout from the server that drops websockets after a given time period (5 min i think) and requires clients to reconnect. The restclient does not handle any reconnect logic; all of it was pushed into jbt
> Explorer: When OS projects are created and deleted, seems Openshift explorer restores non existing values
> ---------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-22803
> URL: https://issues.jboss.org/browse/JBIDE-22803
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Jeff MAURY
> Assignee: Dmitrii Bocharov
> Labels: explorer, openshift, openshift_v3
> Fix For: 4.4.2.AM2
>
> Attachments: after application creation.png, after build finished.png, Openshift Web Console.png, screenshot-1.png
>
>
> EXEC: create an Openshift project
> EXEC: expand it
> EXEC: Create an application in this project (nodejs-example)
> ASSERT: wait for the pod to be available
> EXEC: delete the Openshit project
> EXEC: create an Openshift project (using the same name. You may have to repeat this step as you may got error that it still exists)
> EXEC: expand it
> EXEC: Create an application in this project (nodejs-example)
> EXEC: expand the nodejs-example node
> ASSERT: you should see 2 pods the old one and the build pod you just created: [^screenshot-1.png]
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-22803) Explorer: When OS projects are created and deleted, seems Openshift explorer restores non existing values
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22803?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov edited comment on JBIDE-22803 at 10/6/16 8:37 AM:
-------------------------------------------------------------------
[~adietish] tested on https://github.com/openshift/origin/releases/tag/v1.3.0 - everything is fine and i could get /openshift/version.
tested in OS v3.2.1.9-1-g2265530 with openshift-dev/devel user: User "openshift-dev" cannot "get" on "/version/openshift"
Tried to watch projects on the same v3.2.1.9-1-g2265530 which doesn't support the feature. What happens:
1) {code}WatchClient.WatchEndpoint.onFailure(IOException, Response) is called with:
_err.getClass()_ = "class java.net.ProtocolException"
_err.getMessage()_ = "Expected HTTP 101 response but was '200 OK'"
_response_ = "Response{protocol=http/1.1, code=200, message=OK, url=https://10.1.2.2:8443/oapi/v1/projects?watch=true&}"
_response.request()_ = Request{method=GET, url=https://10.1.2.2:8443/oapi/v1/projects?watch=true&, tag=Request{method=GET, url=https://10.1.2.2:8443/oapi/v1/projects?watch=true&, tag=null}}{code}
2) This onFailure calls listener.error(
3) WatchManager.WatchListener.error(Throwable) is called, which restart()s the request and that's why we repeatedly catch these 3 steps.
The first question is why is WatchClient.WatchEndpoint.onFailure is called. The status is OK [with code 200] and it isn't a Failure. WatchClient.WatchEndpoint.onFailure is an implementation of okhttp3.ws.WebSocketListener and i think that it's called by OS server. So i think it's a questions for OS devs why is it failure with non-failure status.
[~jcantrill] do you have any thoughts on this?
[~jcantrill] one question is about your comment: // TODO enhance fix to only check project once in the restart() method of Watch. What are the cases where watching needs to get restarted?
was (Author: dbocharov):
[~adietish] tested on https://github.com/openshift/origin/releases/tag/v1.3.0 - everything is fine and i could get /openshift/version.
tested in OS v3.2.1.9-1-g2265530 with openshift-dev/devel user: User "openshift-dev" cannot "get" on "/version/openshift"
Tried to watch projects on the same v3.2.1.9-1-g2265530 which doesn't support the feature. What happens:
1) WatchClient.WatchEndpoint.onFailure(IOException, Response) is called with:
{quote}_err.getClass()_ = "class java.net.ProtocolException"
_err.getMessage()_ = "Expected HTTP 101 response but was '200 OK'"
_response_ = "Response{protocol=http/1.1, code=200, message=OK, url=https://10.1.2.2:8443/oapi/v1/projects?watch=true&}"
_response.request()_ = Request{method=GET, url=https://10.1.2.2:8443/oapi/v1/projects?watch=true&, tag=Request{method=GET, url=https://10.1.2.2:8443/oapi/v1/projects?watch=true&, tag=null}}{quote}
2) This onFailure calls listener.error(
3) WatchManager.WatchListener.error(Throwable) is called, which restart()s the request and that's why we repeatedly catch these 3 steps.
The first question is why is WatchClient.WatchEndpoint.onFailure is called. The status is OK [with code 200] and it isn't a Failure. WatchClient.WatchEndpoint.onFailure is an implementation of okhttp3.ws.WebSocketListener and i think that it's called by OS server. So i think it's a questions for OS devs why is it failure with non-failure status.
[~jcantrill] do you have any thoughts on this?
[~jcantrill] one question is about your comment: // TODO enhance fix to only check project once in the restart() method of Watch. What are the cases where watching needs to get restarted?
> Explorer: When OS projects are created and deleted, seems Openshift explorer restores non existing values
> ---------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-22803
> URL: https://issues.jboss.org/browse/JBIDE-22803
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Jeff MAURY
> Assignee: Dmitrii Bocharov
> Labels: explorer, openshift, openshift_v3
> Fix For: 4.4.2.AM2
>
> Attachments: after application creation.png, after build finished.png, Openshift Web Console.png, screenshot-1.png
>
>
> EXEC: create an Openshift project
> EXEC: expand it
> EXEC: Create an application in this project (nodejs-example)
> ASSERT: wait for the pod to be available
> EXEC: delete the Openshit project
> EXEC: create an Openshift project (using the same name. You may have to repeat this step as you may got error that it still exists)
> EXEC: expand it
> EXEC: Create an application in this project (nodejs-example)
> EXEC: expand the nodejs-example node
> ASSERT: you should see 2 pods the old one and the build pod you just created: [^screenshot-1.png]
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-22803) Explorer: When OS projects are created and deleted, seems Openshift explorer restores non existing values
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22803?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov commented on JBIDE-22803:
------------------------------------------
[~adietish] tested on https://github.com/openshift/origin/releases/tag/v1.3.0 - everything is fine and i could get /openshift/version.
tested in OS v3.2.1.9-1-g2265530 with openshift-dev/devel user: User "openshift-dev" cannot "get" on "/version/openshift"
Tried to watch projects on the same v3.2.1.9-1-g2265530 which doesn't support the feature. What happens:
1) WatchClient.WatchEndpoint.onFailure(IOException, Response) is called with:
{quote}_err.getClass()_ = "class java.net.ProtocolException"
_err.getMessage()_ = "Expected HTTP 101 response but was '200 OK'"
_response_ = "Response{protocol=http/1.1, code=200, message=OK, url=https://10.1.2.2:8443/oapi/v1/projects?watch=true&}"
_response.request()_ = Request{method=GET, url=https://10.1.2.2:8443/oapi/v1/projects?watch=true&, tag=Request{method=GET, url=https://10.1.2.2:8443/oapi/v1/projects?watch=true&, tag=null}}{quote}
2) This onFailure calls listener.error(
3) WatchManager.WatchListener.error(Throwable) is called, which restart()s the request and that's why we repeatedly catch these 3 steps.
The first question is why is WatchClient.WatchEndpoint.onFailure is called. The status is OK [with code 200] and it isn't a Failure. WatchClient.WatchEndpoint.onFailure is an implementation of okhttp3.ws.WebSocketListener and i think that it's called by OS server. So i think it's a questions for OS devs why is it failure with non-failure status.
[~jcantrill] do you have any thoughts on this?
[~jcantrill] one question is about your comment: // TODO enhance fix to only check project once in the restart() method of Watch. What are the cases where watching needs to get restarted?
> Explorer: When OS projects are created and deleted, seems Openshift explorer restores non existing values
> ---------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-22803
> URL: https://issues.jboss.org/browse/JBIDE-22803
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Jeff MAURY
> Assignee: Dmitrii Bocharov
> Labels: explorer, openshift, openshift_v3
> Fix For: 4.4.2.AM2
>
> Attachments: after application creation.png, after build finished.png, Openshift Web Console.png, screenshot-1.png
>
>
> EXEC: create an Openshift project
> EXEC: expand it
> EXEC: Create an application in this project (nodejs-example)
> ASSERT: wait for the pod to be available
> EXEC: delete the Openshit project
> EXEC: create an Openshift project (using the same name. You may have to repeat this step as you may got error that it still exists)
> EXEC: expand it
> EXEC: Create an application in this project (nodejs-example)
> EXEC: expand the nodejs-example node
> ASSERT: you should see 2 pods the old one and the build pod you just created: [^screenshot-1.png]
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months