[JBoss JIRA] (JBIDE-23368) Deploy Docker Image: Replication controller does not contain mapped ports from Deploy Image Wizard
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23368?page=com.atlassian.jira.plugi... ]
Marián Labuda closed JBIDE-23368.
---------------------------------
Ok, closing this one as rejected, then.
> Deploy Docker Image: Replication controller does not contain mapped ports from Deploy Image Wizard
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-23368
> URL: https://issues.jboss.org/browse/JBIDE-23368
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.2.AM2
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Labels: deploy_docker_wizard, openshift_v3
> Fix For: 4.4.2.AM3
>
>
> When deploying a docker image via Deploy Docker Wizard to an OpenShift instance, there is a wizard page with mapping of pod ports to service ports. If I add a new port mapping there, it is propagated to a created Service. But created replication controller does not contain those new mappings (results into creating pods without those ports available)
> Either way this should be fixed, to also Replication Controller should contain mapped ports, because having a service which has mapped pod ports to service ports but pods itself does not have this port exposes is useless. Or having Add... button does not make sense there, or there is no known use case where it would be useful (existing mapping could be edited but a new one would be useless).
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 5 months
[JBoss JIRA] (JBIDE-23368) Deploy Docker Image: Replication controller does not contain mapped ports from Deploy Image Wizard
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23368?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-23368:
------------------------------------------
[~mlabuda] What we just discussed should get fixed in JBIDE-23352: https://issues.jboss.org/browse/JBIDE-23352?focusedCommentId=13317532&pag...
> Deploy Docker Image: Replication controller does not contain mapped ports from Deploy Image Wizard
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-23368
> URL: https://issues.jboss.org/browse/JBIDE-23368
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.2.AM2
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Labels: deploy_docker_wizard, openshift_v3
> Fix For: 4.4.2.AM3
>
>
> When deploying a docker image via Deploy Docker Wizard to an OpenShift instance, there is a wizard page with mapping of pod ports to service ports. If I add a new port mapping there, it is propagated to a created Service. But created replication controller does not contain those new mappings (results into creating pods without those ports available)
> Either way this should be fixed, to also Replication Controller should contain mapped ports, because having a service which has mapped pod ports to service ports but pods itself does not have this port exposes is useless. Or having Add... button does not make sense there, or there is no known use case where it would be useful (existing mapping could be edited but a new one would be useless).
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 5 months
[JBoss JIRA] (JBIDE-23467) Unnecessary GWT files
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23467?page=com.atlassian.jira.plugi... ]
Nick Boldt reassigned JBIDE-23467:
----------------------------------
Assignee: Fred Bricon
> Unnecessary GWT files
> ---------------------
>
> Key: JBIDE-23467
> URL: https://issues.jboss.org/browse/JBIDE-23467
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central, rpm
> Affects Versions: 4.4.2.AM3
> Environment: RHEL7 64bit
> rh-eclipse46-devstudio-10.2-0.20161103.1913.el7.x86_64.rpm
> Reporter: Lukáš Valach
> Assignee: Fred Bricon
> Priority: Minor
> Fix For: 4.4.2.Final
>
>
> GWT feature and plugin has been removed in [JBIDE-23414|https://issues.jboss.org/browse/JBIDE-23414], but there are still GWT files.
> {code}
> [lvalach@localhost rh]$ sudo find . -iname '*gwt*'
> ./rh-eclipse46/root/usr/share/eclipse/droplets/devstudio/eclipse/plugins/org.jboss.tools.central_2.1.2.v20160922-1945/icons/gwt_background.png
> ./rh-eclipse46/root/usr/share/eclipse/droplets/devstudio/eclipse/plugins/org.jboss.tools.central_2.1.2.v20160922-1945/org/jboss/tools/central/wizards/NewGwtProjectWizard.class
> {code}
> These files are unnecessary I guess.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 5 months
[JBoss JIRA] (JBIDE-23467) Unnecessary GWT files
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23467?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-23467:
-------------------------------
Fix Version/s: 4.4.2.Final
> Unnecessary GWT files
> ---------------------
>
> Key: JBIDE-23467
> URL: https://issues.jboss.org/browse/JBIDE-23467
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central, rpm
> Affects Versions: 4.4.2.AM3
> Environment: RHEL7 64bit
> rh-eclipse46-devstudio-10.2-0.20161103.1913.el7.x86_64.rpm
> Reporter: Lukáš Valach
> Assignee: Fred Bricon
> Priority: Minor
> Fix For: 4.4.2.Final
>
>
> GWT feature and plugin has been removed in [JBIDE-23414|https://issues.jboss.org/browse/JBIDE-23414], but there are still GWT files.
> {code}
> [lvalach@localhost rh]$ sudo find . -iname '*gwt*'
> ./rh-eclipse46/root/usr/share/eclipse/droplets/devstudio/eclipse/plugins/org.jboss.tools.central_2.1.2.v20160922-1945/icons/gwt_background.png
> ./rh-eclipse46/root/usr/share/eclipse/droplets/devstudio/eclipse/plugins/org.jboss.tools.central_2.1.2.v20160922-1945/org/jboss/tools/central/wizards/NewGwtProjectWizard.class
> {code}
> These files are unnecessary I guess.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 5 months
[JBoss JIRA] (JBIDE-23352) Deploy Docker Wizard: Default routing port selection need more info for users
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23352?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-23352:
------------------------------------------
We maybe also should get rid of the add/remove/edit ports capability. See the discussion here: https://issues.jboss.org/browse/JBIDE-23368?focusedCommentId=13317423&pag...
{quote}
This was originally added because even though an image metadata does not indicate an image will be listening on a port, it still could be. For example, a debug port is open but I did not explicitly declare it in the dockerfile. Adding still allows you to configure a service that will expose the port. However, Andre Dietisheim and I had a long discussion about this issue and I believe we agreed on doing one of the following:
* Remove the functionality all together to be consistent with the web ui
* Modify button desc, add text to explain the ramifications, update the table to make it obvious these ports are not exposed
I'm not certain what the right direction is other then we should probably follow the web and console as examples. You could always make the argument that a user can manually edit a service if an image does not explicitly expose ports. This seems reasonable to me.
{quote}
> Deploy Docker Wizard: Default routing port selection need more info for users
> -----------------------------------------------------------------------------
>
> Key: JBIDE-23352
> URL: https://issues.jboss.org/browse/JBIDE-23352
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Marián Labuda
> Labels: deploy_docker_wizard, openshift_v3
> Fix For: 4.4.2.AM3
>
> Attachments: no_route_selected.png, refdoc-services-1.png, refdoc-services-2.png, webui-deploy-docker-image.png
>
>
> In the wizard on wizard page Services & Routing Settings, there is a table with mapped ports. No port is selected by default , but OpenShift knows what to open.
> If there is only one port mapping, we could check it by default. If there are more port mappings, we could show a label/info/description what is gonna be done under the hood, so users will know what is happening.
> steps to reproduce:
> # EXEC: In Docker Explroer: pick an image and choose "Deploy to OpenShift..." in the context menu
> # EXEC: get to the "Services & Routing Settings" page
> !no_route_selected.png!
> It's not obvious to the user what the wizard will create: A service that "exposes" pod ports and a route that points to this service. Furthermore it's not obvious that without a "checked" (used by route) port, the route will round-robin through the available ports. Additionally we should show the user what ports are exposed by the pod, and which ones are ports that the user added while no explicit exposure is defined in the pod (so he's on his own, if there's nothing listening on them he'll have users face non-functional or no reposonses at all).
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 5 months
[JBoss JIRA] (JBIDE-23352) Deploy Docker Wizard: Default routing port selection need more info for users
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23352?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-23352 at 11/4/16 10:01 AM:
--------------------------------------------------------------------
We maybe also should get rid of the add/remove/edit ports capability. See the discussion here: https://issues.jboss.org/browse/JBIDE-23368?focusedCommentId=13317423&pag...
{quote}
This was originally added because even though an image metadata does not indicate an image will be listening on a port, it still could be. For example, a debug port is open but I did not explicitly declare it in the dockerfile. Adding still allows you to configure a service that will expose the port. However, Andre Dietisheim and I had a long discussion about this issue and I believe we agreed on doing one of the following:
* Remove the functionality all together to be consistent with the web ui
* Modify button desc, add text to explain the ramifications, update the table to make it obvious these ports are not exposed
I'm not certain what the right direction is other then we should probably follow the web and console as examples. You could always make the argument that a user can manually edit a service if an image does not explicitly expose ports. This seems reasonable to me.
{quote}
was (Author: adietish):
We maybe also should get rid of the add/remove/edit ports capability. See the discussion here: https://issues.jboss.org/browse/JBIDE-23368?focusedCommentId=13317423&pag...
{quote}
This was originally added because even though an image metadata does not indicate an image will be listening on a port, it still could be. For example, a debug port is open but I did not explicitly declare it in the dockerfile. Adding still allows you to configure a service that will expose the port. However, Andre Dietisheim and I had a long discussion about this issue and I believe we agreed on doing one of the following:
* Remove the functionality all together to be consistent with the web ui
* Modify button desc, add text to explain the ramifications, update the table to make it obvious these ports are not exposed
I'm not certain what the right direction is other then we should probably follow the web and console as examples. You could always make the argument that a user can manually edit a service if an image does not explicitly expose ports. This seems reasonable to me.
{quote}
> Deploy Docker Wizard: Default routing port selection need more info for users
> -----------------------------------------------------------------------------
>
> Key: JBIDE-23352
> URL: https://issues.jboss.org/browse/JBIDE-23352
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Marián Labuda
> Labels: deploy_docker_wizard, openshift_v3
> Fix For: 4.4.2.AM3
>
> Attachments: no_route_selected.png, refdoc-services-1.png, refdoc-services-2.png, webui-deploy-docker-image.png
>
>
> In the wizard on wizard page Services & Routing Settings, there is a table with mapped ports. No port is selected by default , but OpenShift knows what to open.
> If there is only one port mapping, we could check it by default. If there are more port mappings, we could show a label/info/description what is gonna be done under the hood, so users will know what is happening.
> steps to reproduce:
> # EXEC: In Docker Explroer: pick an image and choose "Deploy to OpenShift..." in the context menu
> # EXEC: get to the "Services & Routing Settings" page
> !no_route_selected.png!
> It's not obvious to the user what the wizard will create: A service that "exposes" pod ports and a route that points to this service. Furthermore it's not obvious that without a "checked" (used by route) port, the route will round-robin through the available ports. Additionally we should show the user what ports are exposed by the pod, and which ones are ports that the user added while no explicit exposure is defined in the pod (so he's on his own, if there's nothing listening on them he'll have users face non-functional or no reposonses at all).
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 5 months