[JBoss JIRA] (JBIDE-23624) clean up skipTests / swtbot.tests.skip references in integration tests
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23624?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-23624:
---------------------------------------
[~nickboldt], re "swtbot.test.skip is old and shouldnt exist anymore":
Yes, swtbot.test.skip was removed here last year:
JBQA-11696
https://github.com/jbosstools/jbosstools-integration-tests/pull/1095
I guess I missed the one occurrence in org.jboss.tools.easymport.ui.bot.test. Actually, there seems to be an explanation:
My PR to move everything to skipTests is from July 29, 2015. And the easymport commit was authored on July 28, 2015, it could have been committed later. Or I didn't have the latest master, who knows.
Fixed here:
https://github.com/jbosstools/jbosstools-integration-tests/pull/1683
And yes, skipTests should be removed and all tests should be run by default. But that will come later. I'm not sure what happens with things like <skip>${skipTests}</skip> for wget plugin if skipTests is not defined at all, but it might work.
> clean up skipTests / swtbot.tests.skip references in integration tests
> ----------------------------------------------------------------------
>
> Key: JBIDE-23624
> URL: https://issues.jboss.org/browse/JBIDE-23624
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Affects Versions: 4.4.2.Final
> Reporter: Nick Boldt
> Assignee: Rob Stryker
> Fix For: 4.4.3.AM1
>
>
> Rob said:
> {quote}
> swtbot.test.skip is old and shouldnt exist anymore {quote}
> {code}
> $➔ find.sh . "pom.xml" swtbot.test.skip
> ** [1] ./tests/org.jboss.tools.easymport.ui.bot.test/pom.xml **
> 14- <packaging>eclipse-test-plugin</packaging>
> 15- <properties>
> 16: <swtbot.test.skip>false</swtbot.test.skip>
> 17- <usage_reporting_enabled>false</usage_reporting_enabled>
> 18- <maven.test.failure.ignore>true</maven.test.failure.ignore>
> {code}
> Andre said:
> {quote}
> this seems to make no sense at all. These are tests. Why would you want to skip them by default?{quote}
> {code}
> ** [1] ./tests/org.jboss.tools.ui.bot.ext.test/pom.xml **
> 13-
> 14- <properties>
> 15: <skipTests>true</skipTests>
> 16- </properties>
> 17-</project>
> ** [2] ./tests/pom.xml **
> 22- <junitExtensionsProperties>-Dreddeer.close.shells=${reddeer.close.shells} -Dreddeer.close.welcome.screen=${reddeer.close.welcome.screen} -Dreddeer.disable.maven.download.repo.index.on.startup=${reddeer.disable.maven.download.repo.index.on.startup}</junitExtensionsProperties>
> 23- <integrationTestsSystemProperties>-Dswt.bot.test.record.screencast=${swt.bot.test.record.screencast} -Dorg.eclipse.swtbot.screenshots.dir=${project.build.directory}/screenshots -Dusage_reporting_enabled=false -Dcom.atlassian.connector.eclipse.monitor.usage.first.time=false -Dcom.atlassian.connector.eclipse.monitor.usage.enabled=false ${junitExtensionsProperties}</integrationTestsSystemProperties>
> 24: <skipTests>true</skipTests>
> 25- <test.installPath.OSX></test.installPath.OSX>
> 26- <devstudio.repository>https://devstudio.redhat.com/10.0/snapshots/updates/</devstudio.repository>
> {code}
> There are also three examples of hardcoding skipTests to false, for no obvious reason:
> {code}
> $➔ find.sh . "pom.xml" \<skipTests\>false
> ** [1] ./tests/org.jboss.ide.eclipse.as.ui.bot.test/pom.xml **
> 19- -->
> 20- <properties>
> 21: <skipTests>false</skipTests>
> 22- <usage_reporting_enabled>false</usage_reporting_enabled>
> 23- <!-- Maven configuration -->
> ** [2] ./tests/org.jboss.tools.arquillian.ui.bot.test/pom.xml **
> 14- <packaging>eclipse-test-plugin</packaging>
> 15- <properties>
> 16: <skipTests>false</skipTests>
> 17- <usage_reporting_enabled>false</usage_reporting_enabled>
> 18- <maven.test.failure.ignore>true</maven.test.failure.ignore>
> ** [3] ./tests/org.jboss.tools.examples.ui.bot.test/pom.xml **
> 30- <jbosstools.test.jboss-eap-7.x.url>http://download.eng.brq.redhat.com/released/JBEAP-7/7.0.0/jboss-eap-7.0.0...</jbosstools.test.jboss-eap-7.x.url>
> 31- <surefire.timeout>18000</surefire.timeout>
> 32: <skipTests>false</skipTests>
> 33- <deployOnServer>true</deployOnServer>
> 34- </properties>
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (JBIDE-20108) Cannot connect to remote server in JMX Navigator - Authentication fails
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20108?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-20108:
-------------------------------
Fix Version/s: 4.4.3.AM1
(was: 4.4.2.Final)
> Cannot connect to remote server in JMX Navigator - Authentication fails
> -----------------------------------------------------------------------
>
> Key: JBIDE-20108
> URL: https://issues.jboss.org/browse/JBIDE-20108
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jmx, server
> Affects Versions: 4.3.0.Beta1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.4.3.AM1
>
>
> When I try to connect to a remote server via JMX Navigator, it fails on authentication:
> {code}
> !ENTRY org.jboss.ide.eclipse.as.jmx.integration 4 0 2015-06-17 18:07:30.854
> !MESSAGE Error connecting to jmx for server JBoss EAP 6.4 marvin
> !STACK 1
> org.jboss.tools.jmx.core.JMXException: Authentication against the remote JBoss instance has failed. Please verify your management credentials in the server editor.
> at org.jboss.ide.eclipse.as.jmx.integration.JBoss71ServerConnection.createConnection(JBoss71ServerConnection.java:94)
> at org.jboss.ide.eclipse.as.jmx.integration.JBossServerConnection.run(JBossServerConnection.java:202)
> at org.jboss.ide.eclipse.as.jmx.integration.JBossServerConnection.run(JBossServerConnection.java:162)
> at org.jboss.ide.eclipse.as.jmx.integration.JBossServerConnection.connectToStartedServer(JBossServerConnection.java:332)
> at org.jboss.ide.eclipse.as.jmx.integration.JBossServerConnection.connect(JBossServerConnection.java:76)
> at org.jboss.tools.jmx.core.ConnectJob.run(ConnectJob.java:29)
> at org.jboss.tools.jmx.ui.internal.actions.DoubleClickAction$1.run(DoubleClickAction.java:71)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> Caused by: javax.security.sasl.SaslException: Authentication failed: the server presented no authentication mechanisms
> at org.jboss.remoting3.remote.ClientConnectionOpenListener$Capabilities.handleEvent(ClientConnectionOpenListener.java:388)
> at org.jboss.remoting3.remote.ClientConnectionOpenListener$Capabilities.handleEvent(ClientConnectionOpenListener.java:242)
> at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:72)
> at org.xnio.channels.TranslatingSuspendableChannel.handleReadable(TranslatingSuspendableChannel.java:189)
> at org.xnio.channels.TranslatingSuspendableChannel$1.handleEvent(TranslatingSuspendableChannel.java:103)
> at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:72)
> at org.xnio.channels.TranslatingSuspendableChannel.handleReadable(TranslatingSuspendableChannel.java:189)
> at org.xnio.ssl.JsseConnectedSslStreamChannel.handleReadable(JsseConnectedSslStreamChannel.java:183)
> at org.xnio.channels.TranslatingSuspendableChannel$1.handleEvent(TranslatingSuspendableChannel.java:103)
> at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:72)
> at org.xnio.nio.NioHandle.run(NioHandle.java:90)
> at org.xnio.nio.WorkerThread.run(WorkerThread.java:198)
> at ...asynchronous invocation...(Unknown Source)
> at org.jboss.remoting3.EndpointImpl.doConnect(EndpointImpl.java:270)
> at org.jboss.remoting3.EndpointImpl.doConnect(EndpointImpl.java:251)
> at org.jboss.remoting3.EndpointImpl.connect(EndpointImpl.java:349)
> at org.jboss.remoting3.EndpointImpl.connect(EndpointImpl.java:333)
> at org.jboss.remotingjmx.RemotingConnector.internalRemotingConnect(RemotingConnector.java:230)
> at org.jboss.remotingjmx.RemotingConnector.internalConnect(RemotingConnector.java:151)
> at org.jboss.remotingjmx.RemotingConnector.connect(RemotingConnector.java:102)
> at javax.management.remote.JMXConnectorFactory.connect(JMXConnectorFactory.java:270)
> at org.jboss.ide.eclipse.as.jmx.integration.JBoss71ServerConnection.createConnection(JBoss71ServerConnection.java:84)
> ... 7 more
> !SUBENTRY 1 org.jboss.ide.eclipse.as.core 4 0 2015-06-17 18:07:30.854
> !MESSAGE Authentication against the remote JBoss instance has failed. Please verify your management credentials in the server editor.
> !STACK 0
> javax.security.sasl.SaslException: Authentication failed: the server presented no authentication mechanisms
> at org.jboss.remoting3.remote.ClientConnectionOpenListener$Capabilities.handleEvent(ClientConnectionOpenListener.java:388)
> at org.jboss.remoting3.remote.ClientConnectionOpenListener$Capabilities.handleEvent(ClientConnectionOpenListener.java:242)
> at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:72)
> at org.xnio.channels.TranslatingSuspendableChannel.handleReadable(TranslatingSuspendableChannel.java:189)
> at org.xnio.channels.TranslatingSuspendableChannel$1.handleEvent(TranslatingSuspendableChannel.java:103)
> at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:72)
> at org.xnio.channels.TranslatingSuspendableChannel.handleReadable(TranslatingSuspendableChannel.java:189)
> at org.xnio.ssl.JsseConnectedSslStreamChannel.handleReadable(JsseConnectedSslStreamChannel.java:183)
> at org.xnio.channels.TranslatingSuspendableChannel$1.handleEvent(TranslatingSuspendableChannel.java:103)
> at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:72)
> at org.xnio.nio.NioHandle.run(NioHandle.java:90)
> at org.xnio.nio.WorkerThread.run(WorkerThread.java:198)
> at ...asynchronous invocation...(Unknown Source)
> at org.jboss.remoting3.EndpointImpl.doConnect(EndpointImpl.java:270)
> at org.jboss.remoting3.EndpointImpl.doConnect(EndpointImpl.java:251)
> at org.jboss.remoting3.EndpointImpl.connect(EndpointImpl.java:349)
> at org.jboss.remoting3.EndpointImpl.connect(EndpointImpl.java:333)
> at org.jboss.remotingjmx.RemotingConnector.internalRemotingConnect(RemotingConnector.java:230)
> at org.jboss.remotingjmx.RemotingConnector.internalConnect(RemotingConnector.java:151)
> at org.jboss.remotingjmx.RemotingConnector.connect(RemotingConnector.java:102)
> at javax.management.remote.JMXConnectorFactory.connect(JMXConnectorFactory.java:270)
> at org.jboss.ide.eclipse.as.jmx.integration.JBoss71ServerConnection.createConnection(JBoss71ServerConnection.java:84)
> at org.jboss.ide.eclipse.as.jmx.integration.JBossServerConnection.run(JBossServerConnection.java:202)
> at org.jboss.ide.eclipse.as.jmx.integration.JBossServerConnection.run(JBossServerConnection.java:162)
> at org.jboss.ide.eclipse.as.jmx.integration.JBossServerConnection.connectToStartedServer(JBossServerConnection.java:332)
> at org.jboss.ide.eclipse.as.jmx.integration.JBossServerConnection.connect(JBossServerConnection.java:76)
> at org.jboss.tools.jmx.core.ConnectJob.run(ConnectJob.java:29)
> at org.jboss.tools.jmx.ui.internal.actions.DoubleClickAction$1.run(DoubleClickAction.java:71)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> {code}
> This is different than JBIDE-19463 where the main problem was the missing runtime and we assumed that otherwise it would work.
> Note: I tried WildFly 8.2, WildFly 9.0.0.CR2, EAP 6.4 and all failed the same way.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (JBIDE-18912) Custom deploy dir with remote server using filesystem operations does not work
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18912?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-18912:
-------------------------------
Fix Version/s: 4.4.3.AM1
(was: 4.4.2.Final)
> Custom deploy dir with remote server using filesystem operations does not work
> ------------------------------------------------------------------------------
>
> Key: JBIDE-18912
> URL: https://issues.jboss.org/browse/JBIDE-18912
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: server
> Affects Versions: 4.2.1.CR1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Labels: help_wanted
> Fix For: 4.4.3.AM1
>
>
> This is a follow up of JBIDE-17180 and JBIDE-13445 which added the option to add a custom deployment directory if your remote server is using filesystem operations (for management api it's not relevant since the deployment happens directly, no directory is used).
> Unfortunately it does not work. It seems I haven't really tried it when reviewing those other JIRAs because there were other obstacles.
> I tried this several times and still could not get it to work.
> Perhaps it might be worth to try and get this in the final 4.2.1.Final build?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (JBIDE-22375) Improve HCR OpenShift
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22375?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-22375:
-------------------------------
Fix Version/s: 4.4.3.AM1
(was: 4.4.2.Final)
> Improve HCR OpenShift
> ---------------------
>
> Key: JBIDE-22375
> URL: https://issues.jboss.org/browse/JBIDE-22375
> Project: Tools (JBoss Tools)
> Issue Type: Epic
> Components: jmx, openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Fred Bricon
> Assignee: Rob Stryker
> Priority: Blocker
> Labels: openshift_v3, server_adapter
> Fix For: 4.4.3.AM1
>
>
> When enabling debug mode on an EAP server deployed on OpenShift, locally changing a class file will :
> - work sometimes when only the content of the method changed, but could fail in some other occasions with the Debugger saying the JDK is out of sync
> - will always fail if a method signature changed, the debugger saying JDK is out of sync
> Restarting the deployed module (with the .dodeploy flag) doesn't fixes the issue (as opposed to the same tweak ahen running on a local EAP server)
> This may be caused by running OpenJDK? Does it support the same level of debugging as Oracle JDK?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (JBIDE-21857) Hot code replacement doesn't work on OpenShift
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21857?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-21857:
-------------------------------
Fix Version/s: (was: 4.4.2.Final)
> Hot code replacement doesn't work on OpenShift
> ----------------------------------------------
>
> Key: JBIDE-21857
> URL: https://issues.jboss.org/browse/JBIDE-21857
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Fred Bricon
> Assignee: Rob Stryker
> Fix For: 4.4.3.AM1, 4.5.0.AM1
>
> Attachments: HCRFailure.zip, code-out-of-sync.png, hot-code-replace-failed.png, jmx-connected-adapter-synchronized.png
>
>
> When enabling debug mode on an EAP server deployed on OpenShift, locally changing a class file will :
> - work sometimes when only the content of the method changed, but could fail in some other occasions with the Debugger saying the JDK is out of sync
> - will always fail if a method signature changed, the debugger saying JDK is out of sync
> Restarting the deployed module (with the .dodeploy flag) doesn't fixes the issue (as opposed to the same tweak ahen running on a local EAP server)
> This may be caused by running OpenJDK? Does it support the same level of debugging as Oracle JDK?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (JBIDE-21857) Hot code replacement doesn't work on OpenShift
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21857?page=com.atlassian.jira.plugi... ]
Marián Labuda commented on JBIDE-21857:
---------------------------------------
Nope, fixVersion 4.4.2.Final should be removed from fix versions and keep this reopened until it is really resolved. We cant say "This is resolved for 4.4.2Final", that would be a lie.
> Hot code replacement doesn't work on OpenShift
> ----------------------------------------------
>
> Key: JBIDE-21857
> URL: https://issues.jboss.org/browse/JBIDE-21857
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Fred Bricon
> Assignee: Rob Stryker
> Fix For: 4.4.3.AM1, 4.5.0.AM1
>
> Attachments: HCRFailure.zip, code-out-of-sync.png, hot-code-replace-failed.png, jmx-connected-adapter-synchronized.png
>
>
> When enabling debug mode on an EAP server deployed on OpenShift, locally changing a class file will :
> - work sometimes when only the content of the method changed, but could fail in some other occasions with the Debugger saying the JDK is out of sync
> - will always fail if a method signature changed, the debugger saying JDK is out of sync
> Restarting the deployed module (with the .dodeploy flag) doesn't fixes the issue (as opposed to the same tweak ahen running on a local EAP server)
> This may be caused by running OpenJDK? Does it support the same level of debugging as Oracle JDK?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months