[JBoss JIRA] (JBIDE-23624) clean up skipTests / swtbot.tests.skip references in integration tests
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23624?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-23624:
---------------------------------------
[~adietish], I tried to track the origin of this down yesterday, but couldn't find where it was first introduced. Anyway, up until now, it didn't really matter. Integration tests were never run all together in one go. Mainly because there were always specifics on how to run a particular test bundle and also because it would simply take too long - a single test bundle can easily take one or several hours to run. Quite possibly the intention of having skipTests set by default was to ensure "mvn verify" on the repo works - to make it easier for someone else who tries to build our repo without knowing much about it.
Last year, there was an effort to work on making at least a subset of each test bundle just work (i.e. a smoke test), so that you can just run "mvn verify". But only some test bundles were completed.
Anyway, I welcome this initiative to improve things.
> clean up skipTests / swtbot.tests.skip references in integration tests
> ----------------------------------------------------------------------
>
> Key: JBIDE-23624
> URL: https://issues.jboss.org/browse/JBIDE-23624
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Affects Versions: 4.4.2.Final
> Reporter: Nick Boldt
> Assignee: Rob Stryker
> Fix For: 4.4.3.AM1
>
>
> Rob said:
> {quote}
> swtbot.test.skip is old and shouldnt exist anymore {quote}
> {code}
> $➔ find.sh . "pom.xml" swtbot.test.skip
> ** [1] ./tests/org.jboss.tools.easymport.ui.bot.test/pom.xml **
> 14- <packaging>eclipse-test-plugin</packaging>
> 15- <properties>
> 16: <swtbot.test.skip>false</swtbot.test.skip>
> 17- <usage_reporting_enabled>false</usage_reporting_enabled>
> 18- <maven.test.failure.ignore>true</maven.test.failure.ignore>
> {code}
> Andre said:
> {quote}
> this seems to make no sense at all. These are tests. Why would you want to skip them by default?{quote}
> {code}
> ** [1] ./tests/org.jboss.tools.ui.bot.ext.test/pom.xml **
> 13-
> 14- <properties>
> 15: <skipTests>true</skipTests>
> 16- </properties>
> 17-</project>
> ** [2] ./tests/pom.xml **
> 22- <junitExtensionsProperties>-Dreddeer.close.shells=${reddeer.close.shells} -Dreddeer.close.welcome.screen=${reddeer.close.welcome.screen} -Dreddeer.disable.maven.download.repo.index.on.startup=${reddeer.disable.maven.download.repo.index.on.startup}</junitExtensionsProperties>
> 23- <integrationTestsSystemProperties>-Dswt.bot.test.record.screencast=${swt.bot.test.record.screencast} -Dorg.eclipse.swtbot.screenshots.dir=${project.build.directory}/screenshots -Dusage_reporting_enabled=false -Dcom.atlassian.connector.eclipse.monitor.usage.first.time=false -Dcom.atlassian.connector.eclipse.monitor.usage.enabled=false ${junitExtensionsProperties}</integrationTestsSystemProperties>
> 24: <skipTests>true</skipTests>
> 25- <test.installPath.OSX></test.installPath.OSX>
> 26- <devstudio.repository>https://devstudio.redhat.com/10.0/snapshots/updates/</devstudio.repository>
> {code}
> There are also three examples of hardcoding skipTests to false, for no obvious reason:
> {code}
> $➔ find.sh . "pom.xml" \<skipTests\>false
> ** [1] ./tests/org.jboss.ide.eclipse.as.ui.bot.test/pom.xml **
> 19- -->
> 20- <properties>
> 21: <skipTests>false</skipTests>
> 22- <usage_reporting_enabled>false</usage_reporting_enabled>
> 23- <!-- Maven configuration -->
> ** [2] ./tests/org.jboss.tools.arquillian.ui.bot.test/pom.xml **
> 14- <packaging>eclipse-test-plugin</packaging>
> 15- <properties>
> 16: <skipTests>false</skipTests>
> 17- <usage_reporting_enabled>false</usage_reporting_enabled>
> 18- <maven.test.failure.ignore>true</maven.test.failure.ignore>
> ** [3] ./tests/org.jboss.tools.examples.ui.bot.test/pom.xml **
> 30- <jbosstools.test.jboss-eap-7.x.url>http://download.eng.brq.redhat.com/released/JBEAP-7/7.0.0/jboss-eap-7.0.0...</jbosstools.test.jboss-eap-7.x.url>
> 31- <surefire.timeout>18000</surefire.timeout>
> 32: <skipTests>false</skipTests>
> 33- <deployOnServer>true</deployOnServer>
> 34- </properties>
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 7 months
[JBoss JIRA] (JBIDE-23475) split ide-config.properties into multiple files
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23475?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-23475:
-------------------------------
Fix Version/s: 4.4.3.AM1
(was: 4.4.2.Final)
> split ide-config.properties into multiple files
> -------------------------------------------------
>
> Key: JBIDE-23475
> URL: https://issues.jboss.org/browse/JBIDE-23475
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: build, central, central-update
> Affects Versions: 4.4.2.AM3
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.4.3.AM1
>
>
> I'd like to split the contents of the current ide-config.properties file into multiple files so the content is easier to maintain via code generation.
> So, rather than 1 big file [1] we could split this into 5 files:
> * ide-config_4.4.snapshots.properties - contains the properties needed for jbosstools and devstudio CI builds (currently 4.4.2.Final and 10.2.0.GA)
> * ide-config_4.4.staging.properties - contains the properties needed for the latest jbosstools and devstudio staging build (currently 4.4.2.AM3 and 10.2.0.AM3)
> * ide-config_4.4.development.properties - contains the properties needed for the latest jbosstools and devstudio development build (currently 4.4.2.AM2 and 10.1.0.GA)
> * ide-config_4.4.stable.properties - contains the properties needed for the latest jbosstools and devstudio stable build (currently 4.4.1.Final and 10.1.0.GA)
> * ide-config.properties - contains all the other properties for 4.3.x and earlier releases
> [1] https://github.com/jbosstools/jbosstools-download.jboss.org/blob/master/j...
> By splitting this into smaller files, the contents that need to be changed every 3 weeks when we stage or release a build could be generated destructively, rather than having to worry about making changes w/ sed and not accidentally pushing in an invalid URL or value.
> From the central side of things, we would just want to treat all ide-config*.properties files as if they were pieces of a single file, and load them all into the same hash of properties we currently have from the single file.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 7 months
[JBoss JIRA] (JBDS-4070) DevStudio / external OpenShift fails deployment
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBDS-4070?page=com.atlassian.jira.plugin.... ]
Jeff MAURY updated JBDS-4070:
-----------------------------
Fix Version/s: 10.3.0.AM1
(was: 10.2.0.GA)
> DevStudio / external OpenShift fails deployment
> -----------------------------------------------
>
> Key: JBDS-4070
> URL: https://issues.jboss.org/browse/JBDS-4070
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 10.1.0.GA
> Environment: DevStudio as used with an external OpenShift
> Reporter: Rick Wagner
> Assignee: Jeff MAURY
> Labels: openshift_v3
> Fix For: 10.3.0.AM1
>
> Attachments: OSDeployRecreate.docx, eap-app-server-adapter-publish.png, eap-app-server-adapter-settings.png, kitchensink-ear-deployed-succcessfully.png, kitchensink-ear-projects.png, new-openshift-server-adapter.png
>
>
> If DevStudio (with Server Adapter configured for external OpenShift) is used to deploy an application developed in DevStudio, errors result.
> The reporting user shows indications additional 'deploy' directories are being synthesized as the binary target location. The log reports:
> 15:59:41,588 INFO [org.jboss.as.server.deployment.scanner] (DeploymentScanner-threads - 2) WFLYDS0010: Scan found incompletely copied file content for deployment /opt/eap/standalone/deployments/deploy/deploy/deploy/deploy/deploy/deploy/activemq-rar.rar.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 7 months