[JBoss JIRA] (ERT-428) On projects with builders JavaScript Validator and Validation xml files are validated twice and error markers are duplicated [EBZ#495625]
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/ERT-428?page=com.atlassian.jira.plugin.sy... ]
Victor Rubezhny resolved ERT-428.
---------------------------------
Fix Version/s: Neon.1 (4.6)
Resolution: Done
> On projects with builders JavaScript Validator and Validation xml files are validated twice and error markers are duplicated [EBZ#495625]
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ERT-428
> URL: https://issues.jboss.org/browse/ERT-428
> Project: Eclipse Release Train
> Issue Type: Task
> Components: JSDT
> Reporter: Friendly Jira Robot
> Assignee: Victor Rubezhny
> Labels: General, bzira
> Fix For: Neon.1 (4.6)
>
>
> When a project has enabled builders JavaScript Validator and Validation, org.eclipse.wst.xml.core.internal.validation.eclipse.Validator is called twice from org.eclipse.wst.validation.internal.ValManager and all results are summed. As the result, validation error messages are duplicated.
> ValBuilderJob.runInWorkspace() has a loop in which it repeats validation until getRequest() returns null. Then ValManager.validate(IProject,...) calls delete markers, but it works only for the first call, it is designed to accumulate markers created in multiple calls from ValBuilderJob during the same build.
> Two requests that make the same file to be validated twice come independently from
> 1) org.eclipse.wst.validation.internal.operations.ValidationBuilder
> 2) org.eclipse.wst.jsdt.internal.core.builder.JavaBuilder
> by method newBuild().
> When I disable JavaScript Validator in project properties in section Builders, there is no more duplication of markers.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 3 months
[JBoss JIRA] (JBIDE-23645) Remove org.jboss.tools.ui.bot.ext from integration tests
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23645?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-23645:
---------------------------------------
[~psrna], you said org.jboss.tools.jst.ui.bot can just be removed?
What about the others? We need to discuss those.
> Remove org.jboss.tools.ui.bot.ext from integration tests
> --------------------------------------------------------
>
> Key: JBIDE-23645
> URL: https://issues.jboss.org/browse/JBIDE-23645
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: integration-tests
> Affects Versions: 4.4.3.AM1
> Reporter: Martin Malina
> Assignee: Martin Malina
>
> org.jboss.tools.ui.bot.ext is an old and unmaintained test library. We should find out if/what tests still use it and fix those and ultimately remove bot.ext.
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/pl...
> This was previously discussed in JBIDE-23593 where I found the following tests that still use bot.ext.
> I found out that some tests still use bot.ext:
> {code}
> $ find . -iname 'manifest.mf' -path '*/META-INF/*'|xargs grep 'ui\.bot\.ext'|sed 's/:.*//'|uniq
> ./plugins/org.jboss.tools.jst.ui.bot/META-INF/MANIFEST.MF
> ./plugins/org.jboss.tools.ui.bot.ext/META-INF/MANIFEST.MF
> ./tests/org.jboss.tools.portlet.ui.bot.test/META-INF/MANIFEST.MF
> ./tests/org.jboss.tools.seam.ui.bot.test/META-INF/MANIFEST.MF
> ./tests/org.jboss.tools.ws.ui.bot.test/META-INF/MANIFEST.MF
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 3 months
[JBoss JIRA] (JBIDE-23645) Remove org.jboss.tools.ui.bot.ext from integration tests
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23645?page=com.atlassian.jira.plugi... ]
Martin Malina updated JBIDE-23645:
----------------------------------
Description:
org.jboss.tools.ui.bot.ext is an old and unmaintained test library. We should find out if/what tests still use it and fix those and ultimately remove bot.ext.
https://github.com/jbosstools/jbosstools-integration-tests/tree/master/pl...
This was previously discussed in JBIDE-23593 where I found the following tests that still use bot.ext.
I found out that some tests still use bot.ext:
{code}
$ find . -iname 'manifest.mf' -path '*/META-INF/*'|xargs grep 'ui\.bot\.ext'|sed 's/:.*//'|uniq
./plugins/org.jboss.tools.jst.ui.bot/META-INF/MANIFEST.MF
./plugins/org.jboss.tools.ui.bot.ext/META-INF/MANIFEST.MF
./tests/org.jboss.tools.portlet.ui.bot.test/META-INF/MANIFEST.MF
./tests/org.jboss.tools.seam.ui.bot.test/META-INF/MANIFEST.MF
./tests/org.jboss.tools.ws.ui.bot.test/META-INF/MANIFEST.MF
{code}
was:
org.jboss.tools.ui.bot.ext is an old and unmaintained test library. We should find out if/what tests still use it and fix those and ultimately remove bot.ext.
https://github.com/jbosstools/jbosstools-integration-tests/tree/master/pl...
> Remove org.jboss.tools.ui.bot.ext from integration tests
> --------------------------------------------------------
>
> Key: JBIDE-23645
> URL: https://issues.jboss.org/browse/JBIDE-23645
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: integration-tests
> Affects Versions: 4.4.3.AM1
> Reporter: Martin Malina
> Assignee: Martin Malina
>
> org.jboss.tools.ui.bot.ext is an old and unmaintained test library. We should find out if/what tests still use it and fix those and ultimately remove bot.ext.
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/pl...
> This was previously discussed in JBIDE-23593 where I found the following tests that still use bot.ext.
> I found out that some tests still use bot.ext:
> {code}
> $ find . -iname 'manifest.mf' -path '*/META-INF/*'|xargs grep 'ui\.bot\.ext'|sed 's/:.*//'|uniq
> ./plugins/org.jboss.tools.jst.ui.bot/META-INF/MANIFEST.MF
> ./plugins/org.jboss.tools.ui.bot.ext/META-INF/MANIFEST.MF
> ./tests/org.jboss.tools.portlet.ui.bot.test/META-INF/MANIFEST.MF
> ./tests/org.jboss.tools.seam.ui.bot.test/META-INF/MANIFEST.MF
> ./tests/org.jboss.tools.ws.ui.bot.test/META-INF/MANIFEST.MF
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 3 months