[JBoss JIRA] (JBIDE-21817) Partial lock of UI at start by Sign In Openshift dialog
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21817?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21817:
-----------------------------------------------
[~adietish], can you also reproduce it with Server adapter editor for v3, or is it only a v2 problem?
In an unclear way I see the problem in the modal dialog starting from editor that is in the process of loading at Eclipse start. I remember some deadlocks in this scenario. This one though has at least a way out with stop button, those other cases were always terrible blockers.
> Partial lock of UI at start by Sign In Openshift dialog
> -------------------------------------------------------
>
> Key: JBIDE-21817
> URL: https://issues.jboss.org/browse/JBIDE-21817
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Viacheslav Kabanovich
> Fix For: 4.3.1.CR1
>
> Attachments: jstack.txt, LockAtStart.png
>
>
> 1. Close Eclipse with
> - Server Editor for OpenShift 2 server adapter open;
> - password for an Opebshift 2 connection not saved in the secure storage;
> - OpenShift Explorer active (maybe not important).
> 2. Open Eclipse - Sign In to OpenShift wizard appears while the application window remains only partially loaded (see screenshot). Once this is reproduced, it is reproduced at each Eclipse start.
> 3. Enter password and finish.
> 4. Progress appears but job does not start (I checked it in debugger) - ui jobs are locked.
> 5. Only red button cancelling connection is active, press it, wizard is unlocked (null pointer exception is fixed in JBIDE-21707).
> 6. Press Cancel, wizard is closed, Application window completes loading. - That
> 7. Connection may be established by Refresh action.
> Stack trace that calls Sign In to Openshift wizard before main window is loaded, it shows that call is initiated by loading Server Editor:
> {code}
> Thread [main] (Suspended (breakpoint at line 274 in Window))
> WizardDialog(Window).<init>(IShellProvider) line: 274
> WizardDialog(Dialog).<init>(IShellProvider) line: 438
> WizardDialog(Dialog).<init>(Shell) line: 419
> WizardDialog(TrayDialog).<init>(Shell) line: 138
> WizardDialog(TitleAreaDialog).<init>(Shell) line: 130
> WizardDialog.<init>(Shell, IWizard) line: 308
> WizardUtils.openWizardDialog(IWizard, Shell) line: 242
> CredentialsPrompter$1.run() line: 44
> UISynchronizer(Synchronizer).syncExec(Runnable) line: 186
> UISynchronizer.syncExec(Runnable) line: 145
> Display.syncExec(Runnable) line: 4634
> CredentialsPrompter.promptAndAuthenticate(IConnection, Object) line: 33
> LazyCredentialsPrompter.promptAndAuthenticate(IConnection, Object) line: 39
> ExpressConnection.promptForCredentials() line: 284
> ExpressConnection.createUser() line: 218
> ExpressConnection.connect() line: 198
> ExpressServerUtils.getApplication(IServerAttributes) line: 161
> ExpressServerUtils.getDeployFolder(IServerAttributes) line: 251
> ExpressServerEditorSection.initWidgets() line: 117
> ExpressServerEditorSection.createSection(Composite) line: 100
> OverviewEditorPart(ServerEditorPart).insertSections(Composite, String) line: 327
> OverviewEditorPart.createPartControl(Composite) line: 279
> ServerEditor(MultiPageEditorPart).addPage(int, IEditorPart, IEditorInput) line: 244
> ServerEditor(MultiPageEditorPart).addPage(IEditorPart, IEditorInput) line: 214
> ServerEditor.createPages() line: 247
> ServerEditor(MultiPageEditorPart).createPartControl(Composite) line: 363
> CompatibilityEditor(CompatibilityPart).createPartControl(IWorkbenchPart, Composite) line: 151
> CompatibilityEditor.createPartControl(IWorkbenchPart, Composite) line: 99
> CompatibilityEditor(CompatibilityPart).create() line: 341
> NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]
> NativeMethodAccessorImpl.invoke(Object, Object[]) line: 62
> DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43
> Method.invoke(Object, Object...) line: 498
> MethodRequestor.execute() line: 56
> InjectorImpl.processAnnotated(Class<Annotation>, Object, Class<?>, PrimaryObjectSupplier, PrimaryObjectSupplier, ArrayList<Class<?>>) line: 925
> InjectorImpl.processAnnotated(Class<Annotation>, Object, Class<?>, PrimaryObjectSupplier, PrimaryObjectSupplier, ArrayList<Class<?>>) line: 906
> InjectorImpl.inject(Object, PrimaryObjectSupplier, PrimaryObjectSupplier) line: 148
> InjectorImpl.internalMake(Class<?>, PrimaryObjectSupplier, PrimaryObjectSupplier) line: 372
> InjectorImpl.make(Class<T>, PrimaryObjectSupplier) line: 291
> ContextInjectionFactory.make(Class<T>, IEclipseContext) line: 162
> ReflectionContributionFactory.createFromBundle(Bundle, IEclipseContext, IEclipseContext, URI) line: 105
> ReflectionContributionFactory.doCreate(String, IEclipseContext, IEclipseContext) line: 74
> ReflectionContributionFactory.create(String, IEclipseContext) line: 56
> ContributedPartRenderer.createWidget(MUIElement, Object) line: 129
> PartRenderingEngine.createWidget(MUIElement, Object) line: 976
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 652
> PartRenderingEngine.safeCreateGui(MUIElement) line: 758
> PartRenderingEngine.access$0(PartRenderingEngine, MUIElement) line: 729
> PartRenderingEngine$2.run() line: 723
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement) line: 707
> StackRenderer.showTab(MUIElement) line: 1306
> StackRenderer(LazyStackRenderer).postProcess(MUIElement) line: 103
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 670
> PartRenderingEngine.safeCreateGui(MUIElement) line: 758
> PartRenderingEngine.access$0(PartRenderingEngine, MUIElement) line: 729
> PartRenderingEngine$2.run() line: 723
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement) line: 707
> AreaRenderer(SWTPartRenderer).processContents(MElementContainer<MUIElement>) line: 72
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 666
> PartRenderingEngine$1.run() line: 537
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement, Object, IEclipseContext) line: 521
> ElementReferenceRenderer.createWidget(MUIElement, Object) line: 70
> PartRenderingEngine.createWidget(MUIElement, Object) line: 976
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 652
> PartRenderingEngine.safeCreateGui(MUIElement) line: 758
> PartRenderingEngine.access$0(PartRenderingEngine, MUIElement) line: 729
> PartRenderingEngine$2.run() line: 723
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement) line: 707
> SashRenderer(SWTPartRenderer).processContents(MElementContainer<MUIElement>) line: 72
> SashRenderer.processContents(MElementContainer<MUIElement>) line: 151
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 666
> PartRenderingEngine.safeCreateGui(MUIElement) line: 758
> PartRenderingEngine.access$0(PartRenderingEngine, MUIElement) line: 729
> PartRenderingEngine$2.run() line: 723
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement) line: 707
> SashRenderer(SWTPartRenderer).processContents(MElementContainer<MUIElement>) line: 72
> SashRenderer.processContents(MElementContainer<MUIElement>) line: 151
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 666
> PartRenderingEngine.safeCreateGui(MUIElement) line: 758
> PartRenderingEngine.access$0(PartRenderingEngine, MUIElement) line: 729
> PartRenderingEngine$2.run() line: 723
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement) line: 707
> SashRenderer(SWTPartRenderer).processContents(MElementContainer<MUIElement>) line: 72
> SashRenderer.processContents(MElementContainer<MUIElement>) line: 151
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 666
> PartRenderingEngine.safeCreateGui(MUIElement) line: 758
> PartRenderingEngine.access$0(PartRenderingEngine, MUIElement) line: 729
> PartRenderingEngine$2.run() line: 723
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement) line: 707
> PerspectiveRenderer(SWTPartRenderer).processContents(MElementContainer<MUIElement>) line: 72
> PerspectiveRenderer.processContents(MElementContainer<MUIElement>) line: 49
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 666
> PartRenderingEngine.safeCreateGui(MUIElement) line: 758
> PartRenderingEngine.access$0(PartRenderingEngine, MUIElement) line: 729
> PartRenderingEngine$2.run() line: 723
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement) line: 707
> PerspectiveStackRenderer.showTab(MUIElement) line: 82
> PerspectiveStackRenderer(LazyStackRenderer).postProcess(MUIElement) line: 103
> PerspectiveStackRenderer.postProcess(MUIElement) line: 63
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 670
> PartRenderingEngine.safeCreateGui(MUIElement) line: 758
> PartRenderingEngine.access$0(PartRenderingEngine, MUIElement) line: 729
> PartRenderingEngine$2.run() line: 723
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement) line: 707
> SashRenderer(SWTPartRenderer).processContents(MElementContainer<MUIElement>) line: 72
> SashRenderer.processContents(MElementContainer<MUIElement>) line: 151
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 666
> PartRenderingEngine.safeCreateGui(MUIElement) line: 758
> PartRenderingEngine.access$0(PartRenderingEngine, MUIElement) line: 729
> PartRenderingEngine$2.run() line: 723
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement) line: 707
> WBWRenderer(SWTPartRenderer).processContents(MElementContainer<MUIElement>) line: 72
> WBWRenderer.processContents(MElementContainer<MUIElement>) line: 614
> PartRenderingEngine.safeCreateGui(MUIElement, Object, IEclipseContext) line: 666
> PartRenderingEngine.safeCreateGui(MUIElement) line: 758
> PartRenderingEngine.access$0(PartRenderingEngine, MUIElement) line: 729
> PartRenderingEngine$2.run() line: 723
> SafeRunner.run(ISafeRunnable) line: 42
> PartRenderingEngine.createGui(MUIElement) line: 707
> PartRenderingEngine$4.run() line: 1066
> Realm.runWithDefault(Realm, Runnable) line: 336
> PartRenderingEngine.run(MApplicationElement, IEclipseContext) line: 1023
> E4Workbench.createAndRunUI(MApplicationElement) line: 157
> Workbench$5.run() line: 651
> Realm.runWithDefault(Realm, Runnable) line: 336
> Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 595
> PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 150
> IDEApplication.start(IApplicationContext) line: 138
> EclipseAppHandle.run(Object) line: 196
> EclipseAppLauncher.runApplication(Object) line: 134
> EclipseAppLauncher.start(Object) line: 104
> EclipseStarter.run(Object) line: 388
> EclipseStarter.run(String[], Runnable) line: 243
> NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]
> NativeMethodAccessorImpl.invoke(Object, Object[]) line: 62
> DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43
> Method.invoke(Object, Object...) line: 498
> Main.invokeFramework(String[], URL[]) line: 670
> Main.basicRun(String[]) line: 609
> Main.run(String[]) line: 1516
> Main.main(String[]) line: 1489
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21816) Table is not refreshed properly in SWT_GTK3
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21816?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21816:
-----------------------------------------------
[~snjeza], could you please also explain me a thing about that patch to SWT. To compute size of an invisible widget, it temporarily sets it visible, and after computing size returns current visibility. What if programmer wants to change visibility of a widget depending on user input in the dialog, and wants that when the widget is invisible it took no space. May not this patch enforce invisible widget creating an empty space with its computed size?
> Table is not refreshed properly in SWT_GTK3
> -------------------------------------------
>
> Key: JBIDE-21816
> URL: https://issues.jboss.org/browse/JBIDE-21816
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, upstream
> Affects Versions: 4.3.1.Beta2
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
> Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> This issue was found while testing JBIDE-21815 and description to that issue fits to what happens in SWT_GTK3 with table. Difference is that the other issue is caused by some model failures and can be reproduced on all OS, and this case is relevant only to SWT_GTK3 when wizard model works without failures.
> Steps for some generic wizard (Deploy Image to Openshift is an example).
> 1. Create a wizard with two pages. First page has some text input, second table. Content of table is refreshed on change of text input on the first page. Input object for the table is the same, only content provider returns new values. Table has scroll, and content should be large enough to make scroll appear (without scroll, the issue is not reproduced).
> 2. Change text input on the first page, and push 'Next->' to open the second page.
> 3. At the very first navigating to the second page, the content of the table is correct, as provided by the logic binding the text input and the table.
> 4. Go back to the first page and change text input.
> 5. Again navigate to the second page.
> 6. Failure - content of the table remains as it was for the previous text input.
> 7. Recovering - just pass mouse over the table, its data in cells passed is refreshed. That means that table model is refreshed, but rendering was not completed.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBDS-3666) Back off and retry if download fails
by Pete Muir (JIRA)
Pete Muir created JBDS-3666:
-------------------------------
Summary: Back off and retry if download fails
Key: JBDS-3666
URL: https://issues.jboss.org/browse/JBDS-3666
Project: Developer Studio (JBoss Developer Studio)
Issue Type: Story
Components: installer
Reporter: Pete Muir
We should back off and retry downloads when they fail, automatically. We should also off a manual retry button.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21816) Table is not refreshed properly in SWT_GTK3
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21816?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich edited comment on JBIDE-21816 at 3/4/16 10:16 AM:
------------------------------------------------------------------------
[~snjeza], patch to SWT for JBIDE-21072 treats computeSize. In this case, it is no problem with size, but with rendering table content. JBIDE-21072 described problem at the first visiting the page, in this case the first visiting is ok, the problem begins after going back and forward again.
was (Author: scabanovich):
[~snjeza], patch to SWT for JBIDE-21072 treats computeSize. In this case, it is no problem with size, but with rendering table content.
> Table is not refreshed properly in SWT_GTK3
> -------------------------------------------
>
> Key: JBIDE-21816
> URL: https://issues.jboss.org/browse/JBIDE-21816
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, upstream
> Affects Versions: 4.3.1.Beta2
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
> Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> This issue was found while testing JBIDE-21815 and description to that issue fits to what happens in SWT_GTK3 with table. Difference is that the other issue is caused by some model failures and can be reproduced on all OS, and this case is relevant only to SWT_GTK3 when wizard model works without failures.
> Steps for some generic wizard (Deploy Image to Openshift is an example).
> 1. Create a wizard with two pages. First page has some text input, second table. Content of table is refreshed on change of text input on the first page. Input object for the table is the same, only content provider returns new values. Table has scroll, and content should be large enough to make scroll appear (without scroll, the issue is not reproduced).
> 2. Change text input on the first page, and push 'Next->' to open the second page.
> 3. At the very first navigating to the second page, the content of the table is correct, as provided by the logic binding the text input and the table.
> 4. Go back to the first page and change text input.
> 5. Again navigate to the second page.
> 6. Failure - content of the table remains as it was for the previous text input.
> 7. Recovering - just pass mouse over the table, its data in cells passed is refreshed. That means that table model is refreshed, but rendering was not completed.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21816) Table is not refreshed properly in SWT_GTK3
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21816?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21816:
-----------------------------------------------
[~snjeza], patch to SWT for JBIDE-21072 treats computeSize. In this case, it is no problem with size, but with rendering table content.
> Table is not refreshed properly in SWT_GTK3
> -------------------------------------------
>
> Key: JBIDE-21816
> URL: https://issues.jboss.org/browse/JBIDE-21816
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, upstream
> Affects Versions: 4.3.1.Beta2
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
> Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> This issue was found while testing JBIDE-21815 and description to that issue fits to what happens in SWT_GTK3 with table. Difference is that the other issue is caused by some model failures and can be reproduced on all OS, and this case is relevant only to SWT_GTK3 when wizard model works without failures.
> Steps for some generic wizard (Deploy Image to Openshift is an example).
> 1. Create a wizard with two pages. First page has some text input, second table. Content of table is refreshed on change of text input on the first page. Input object for the table is the same, only content provider returns new values. Table has scroll, and content should be large enough to make scroll appear (without scroll, the issue is not reproduced).
> 2. Change text input on the first page, and push 'Next->' to open the second page.
> 3. At the very first navigating to the second page, the content of the table is correct, as provided by the logic binding the text input and the table.
> 4. Go back to the first page and change text input.
> 5. Again navigate to the second page.
> 6. Failure - content of the table remains as it was for the previous text input.
> 7. Recovering - just pass mouse over the table, its data in cells passed is refreshed. That means that table model is refreshed, but rendering was not completed.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21761) Port mapping validation is not correct
by Xavier Coulon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21761?page=com.atlassian.jira.plugi... ]
Xavier Coulon commented on JBIDE-21761:
---------------------------------------
ok, I'll follow [~fbricon]'s suggestion, then.
> Port mapping validation is not correct
> --------------------------------------
>
> Key: JBIDE-21761
> URL: https://issues.jboss.org/browse/JBIDE-21761
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Marián Labuda
> Assignee: Xavier Coulon
> Labels: docker, openshift_v3
> Fix For: 4.3.1.CR1
>
> Attachments: validation_msg.png
>
>
> In Deploy docker image on the page with port mapping when adding a new port mapping there is a validation error telling that correct format of pod is alphanumeric, what is wrong. See following image.
> !validation_msg.png!
> There should be allowed only numbers in range 0-65535. It is not only validation message but it allows to create also mapping to port e.g. "abc123" what should not be possible.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month