[JBoss JIRA] (JBIDE-21992) Deploy Docker Image wizard: "Deployment Configuration & Scalability" page has minor UI issues
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21992?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-21992 at 3/30/16 3:34 AM:
-------------------------------------------------------------------
[~scabanovich] gotcha, yes, I agree that button widths are far better now. Could you verify that all the other wizards that we have still look good?
A separator works for me, too as opposed to a group. I looked into the different "New wizards" and they apparently use separators, too.
Weird enough I see your "Replicas" being centered vertically while mine is not (you're on Ubuntu as far as I can see from your screenshots, while I'm on FC23. But this isnt the cause here. "Replicas" is centered with the spinner as soon as I change the GridData on the spinner:
{code}
.align(SWT.FILL, SWT.FILL)
{code}
to
{code}
.align(SWT.FILL, SWT.CENTER)
{code}
was (Author: adietish):
[~scabanovich] gotcha, yes, I agree that button widths are far better now. Could you verify that all the other wizards that we have still look good?
A separator works for me, too as opposed to a group. I looked into the different "New wizards" and they apparently use separators, too.
Weird enough I see your "Replicas" being centered vertically while mine is not (you're on Ubuntu as far as I can see from your screenshots, while I'm on FC23. I also see the button having the right griddata. Looks like another GTK3 issue? What is your GTK3 version?
> Deploy Docker Image wizard: "Deployment Configuration & Scalability" page has minor UI issues
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-21992
> URL: https://issues.jboss.org/browse/JBIDE-21992
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Andre Dietisheim
> Labels: deploy_docker_wizard
> Fix For: 4.4.0.Alpha1
>
> Attachments: deploy-config-scalability-page.png, DeploymentConfigLayout.png
>
>
> The ""Deployment Configuration & Scalability" wizard page when deploying a docker image has minor UI glitches that we should fix as you can see in the following screenshot. We should also maybe use 3 groups to distinguish the 3 settings cathegories in more obvious way.
> !deploy-config-scalability-page.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBIDE-21989) Show In - Web Browser from context menu of J2EE module on OS3 Server Adapter opens localhost
by Xavier Coulon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21989?page=com.atlassian.jira.plugi... ]
Xavier Coulon edited comment on JBIDE-21989 at 3/30/16 3:27 AM:
----------------------------------------------------------------
Also, shouldn't we have the actual hostname (eg: {{eap-app-sample.rhel-cdk.10.1.2.2.xip.io}}) for the parent server instead of {{localhost}} ? Unless an OpenShift service can have many routes ? (this question is in relation with JBIDE-21998).
Then, as far as LiveReload tooling is concerned, the OpenShift server and modules would behave exactly as regular, local or remote server and modules.
was (Author: xcoulon):
Also, shouldn't we have the actual hostname (eg: {{eap-app-sample.rhel-cdk.10.1.2.2.xip.io}}) for the parent server instead of {{localhost}} ? Unless an OpenShift service can have many routes ? (this question is in relation with JBIDE-21998)
> Show In - Web Browser from context menu of J2EE module on OS3 Server Adapter opens localhost
> --------------------------------------------------------------------------------------------
>
> Key: JBIDE-21989
> URL: https://issues.jboss.org/browse/JBIDE-21989
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Marián Labuda
> Assignee: Rob Stryker
> Priority: Critical
> Labels: openshift_v3, server_adapter
> Fix For: 4.3.1.CR1
>
>
> When selecting Show In - Web Browser from context menu of Java EE module under an OpenShift 3 connection, it opens a localhost, what is wrong (it does not use root). Such module can be e.g. jboss-kitchensink when using application based on eap s2i template with param CONTEXT_DIR kitchensink.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBIDE-21989) Show In - Web Browser from context menu of J2EE module on OS3 Server Adapter opens localhost
by Xavier Coulon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21989?page=com.atlassian.jira.plugi... ]
Xavier Coulon commented on JBIDE-21989:
---------------------------------------
Also, shouldn't we have the actual hostname (eg: {{eap-app-sample.rhel-cdk.10.1.2.2.xip.io}}) for the parent server instead of {{localhost}} ? Unless an OpenShift service can have many routes ? (this question is in relation with JBIDE-21998)
> Show In - Web Browser from context menu of J2EE module on OS3 Server Adapter opens localhost
> --------------------------------------------------------------------------------------------
>
> Key: JBIDE-21989
> URL: https://issues.jboss.org/browse/JBIDE-21989
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Marián Labuda
> Assignee: Rob Stryker
> Priority: Critical
> Labels: openshift_v3, server_adapter
> Fix For: 4.3.1.CR1
>
>
> When selecting Show In - Web Browser from context menu of Java EE module under an OpenShift 3 connection, it opens a localhost, what is wrong (it does not use root). Such module can be e.g. jboss-kitchensink when using application based on eap s2i template with param CONTEXT_DIR kitchensink.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBIDE-21992) Deploy Docker Image wizard: "Deployment Configuration & Scalability" page has minor UI issues
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21992?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21992:
------------------------------------------
[~scabanovich] gotcha, yes, I agree that button widths are far better now. Could you verify that all the other wizards that we have still look good?
A separator works for me, too as opposed to a group. I looked into the different "New wizards" and they apparently use separators, too.
Weird enough I see your "Replicas" being centered vertically while mine is not (you're on Ubuntu as far as I can see from your screenshots, while I'm on FC23. I also see the button having the right griddata. Looks like another GTK3 issue? What is your GTK3 version?
> Deploy Docker Image wizard: "Deployment Configuration & Scalability" page has minor UI issues
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-21992
> URL: https://issues.jboss.org/browse/JBIDE-21992
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Andre Dietisheim
> Labels: deploy_docker_wizard
> Fix For: 4.4.0.Alpha1
>
> Attachments: deploy-config-scalability-page.png, DeploymentConfigLayout.png
>
>
> The ""Deployment Configuration & Scalability" wizard page when deploying a docker image has minor UI glitches that we should fix as you can see in the following screenshot. We should also maybe use 3 groups to distinguish the 3 settings cathegories in more obvious way.
> !deploy-config-scalability-page.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBDS-3613) Support OpenShift 3.2
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBDS-3613?page=com.atlassian.jira.plugin.... ]
Marián Labuda closed JBDS-3613.
-------------------------------
In that case closing this one as verified and if any issue related to OSE 3.2 will raise we will address it in separate issue. So far tooling work nice with OSE 3.2.
> Support OpenShift 3.2
> ---------------------
>
> Key: JBDS-3613
> URL: https://issues.jboss.org/browse/JBDS-3613
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Epic
> Components: openshift
> Affects Versions: 9.1.0.Beta2
> Reporter: Max Rydahl Andersen
> Assignee: Fred Bricon
> Priority: Blocker
> Fix For: 9.1.0.CR1
>
>
> CDK will GA with OpenShift 3.2 we will need to support 3.2 in OpenShift tooling.
>
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (JBIDE-21996) Order of project in New OS3 Server Adapter wizard could be better
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21996?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich edited comment on JBIDE-21996 at 3/30/16 1:29 AM:
------------------------------------------------------------------------
That is what I have found.
1. Sorter for services tree viewer is ViewerSorter.
2. ViewerSorter compares items by label (in ViewerComparator.compare)
3. Label is received from label provider but only if it implements ILabelProvider, otherwise it just calls toString() on item.
4. Label provider for services tree viewer is ServicesViewLabelProvider that extends StyledCellLabelProvider which allows to efficiently update viewer cell but which _does not_ implement ILabelProvider.
5. So, sorter sorts by IProject.toString() which is implemented by calling toJson().
Proposed solution: override method ViewerComparator.compare(Viewer viewer, Object e1, Object e2).
[~adietish], please take a look at the pull request.
was (Author: scabanovich):
That is what I have found.
1. Sorter for services tree viewer is ViewerSorter.
2. ViewerSorter compares items by label (in ViewerComparator.compare)
3. Label is received from label provider but only if it implements ILabelProvider, otherwise it just calls toString() on item.
4. Label provider for services tree viewer is ServicesViewLabelProvider that extends StyledCellLabelProvider which allows to efficiently update viewer cell but which _does not_ implement ILabelProvider.
5. So, sorter sorts by IProject.toString() which is implemented by calling toJson().
Proposed solution: override method ViewerComparator.compare(Viewer viewer, Object e1, Object e2).
> Order of project in New OS3 Server Adapter wizard could be better
> -----------------------------------------------------------------
>
> Key: JBIDE-21996
> URL: https://issues.jboss.org/browse/JBIDE-21996
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter_wizard
>
> With latest changes to New OS3 Server Adapter wizard the current order of projects, listed on wizard page where service selection is done, is a bit strange. At first there are alphanumeric ordered projects with no services and therefore they are not useful for creation of a new OS3 Server Adapter and then there are projects with any service ordered in alphanumberic order. It results in following.
> Assume project aproject with no services, bproject with a service, c project with no services, d project with a service. Order on the wizard page is following:
> a
> c
> b
> d
> I think we are safe not to list projects with no services there or otherwise we should keep alphanumeric order regardless existence of a service under a project.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years