[JBoss JIRA] (JBIDE-22197) Icon in template Details of Local Template is not loaded for some templates file
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22197?page=com.atlassian.jira.plugi... ]
Fred Bricon commented on JBIDE-22197:
-------------------------------------
Caching / returning a default application image should be done in OpenShiftImages.getAppImage.
Come to think of if, we don't need the full stacktrace, but logging about the missing image (once per workspace startup), will get picked up by AERI. That way, we'll be able to know if we're missing others images.
> Icon in template Details of Local Template is not loaded for some templates file
> --------------------------------------------------------------------------------
>
> Key: JBIDE-22197
> URL: https://issues.jboss.org/browse/JBIDE-22197
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Aurélien Pupier
> Assignee: Jeff MAURY
> Priority: Minor
> Fix For: 4.4.0.Alpha1
>
> Attachments: quickstart-template.json, screenshot-1.png
>
>
> {noformat}
> java.io.FileNotFoundException: /icons/apps/java.png
> at org.eclipse.osgi.storage.url.bundleentry.Handler.findBundleEntry(Handler.java:37)
> at org.eclipse.osgi.storage.url.BundleResourceHandler.openConnection(BundleResourceHandler.java:169)
> at java.net.URL.openConnection(Unknown Source)
> at org.eclipse.osgi.storage.url.BundleURLConverter.toFileURL(BundleURLConverter.java:32)
> at org.eclipse.core.runtime.FileLocator.toFileURL(FileLocator.java:207)
> at org.eclipse.jface.resource.URLImageDescriptor.getFilePath(URLImageDescriptor.java:219)
> at org.eclipse.jface.resource.URLImageDescriptor.createImage(URLImageDescriptor.java:283)
> at org.eclipse.jface.resource.ImageDescriptor.createResource(ImageDescriptor.java:164)
> at org.eclipse.jface.resource.DeviceResourceManager.allocate(DeviceResourceManager.java:52)
> at org.eclipse.jface.resource.AbstractResourceManager.create(AbstractResourceManager.java:86)
> at org.eclipse.jface.resource.ResourceManager.createImageWithDefault(ResourceManager.java:192)
> at org.eclipse.jface.resource.ImageRegistry.get(ImageRegistry.java:214)
> at org.jboss.tools.openshift.internal.common.ui.ImageRepository.getImage(ImageRepository.java:85)
> at org.jboss.tools.openshift.internal.ui.OpenShiftImages.getAppImage(OpenShiftImages.java:62)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateDetailViews$TemplateDetailView.updateImage(TemplateDetailViews.java:106)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateDetailViews$TemplateDetailView.onVisible(TemplateDetailViews.java:102)
> at org.jboss.tools.openshift.internal.common.ui.detailviews.AbstractStackedDetailViews.showView(AbstractStackedDetailViews.java:90)
> at org.jboss.tools.openshift.internal.common.ui.detailviews.AbstractStackedDetailViews.showView(AbstractStackedDetailViews.java:79)
> at org.jboss.tools.openshift.internal.common.ui.detailviews.AbstractStackedDetailViews$1.handleValueChange(AbstractStackedDetailViews.java:73)
> at org.eclipse.core.databinding.observable.value.ValueChangeEvent.dispatch(ValueChangeEvent.java:63)
> at org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
> at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.fireValueChange(DecoratingObservableValue.java:57)
> at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.handleValueChange(DecoratingObservableValue.java:99)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBIDE-22197) Icon in template Details of Local Template is not loaded for some templates file
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22197?page=com.atlassian.jira.plugi... ]
Fred Bricon edited comment on JBIDE-22197 at 4/25/16 8:48 AM:
--------------------------------------------------------------
Caching / returning a default application image should be done in OpenShiftImages.getAppImage.
Come to think of it, we don't need the full stacktrace, but logging about the missing image (once per workspace startup), will get picked up by AERI. That way, we'll be able to know if we're missing others images.
was (Author: fbricon):
Caching / returning a default application image should be done in OpenShiftImages.getAppImage.
Come to think of if, we don't need the full stacktrace, but logging about the missing image (once per workspace startup), will get picked up by AERI. That way, we'll be able to know if we're missing others images.
> Icon in template Details of Local Template is not loaded for some templates file
> --------------------------------------------------------------------------------
>
> Key: JBIDE-22197
> URL: https://issues.jboss.org/browse/JBIDE-22197
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Aurélien Pupier
> Assignee: Jeff MAURY
> Priority: Minor
> Fix For: 4.4.0.Alpha1
>
> Attachments: quickstart-template.json, screenshot-1.png
>
>
> {noformat}
> java.io.FileNotFoundException: /icons/apps/java.png
> at org.eclipse.osgi.storage.url.bundleentry.Handler.findBundleEntry(Handler.java:37)
> at org.eclipse.osgi.storage.url.BundleResourceHandler.openConnection(BundleResourceHandler.java:169)
> at java.net.URL.openConnection(Unknown Source)
> at org.eclipse.osgi.storage.url.BundleURLConverter.toFileURL(BundleURLConverter.java:32)
> at org.eclipse.core.runtime.FileLocator.toFileURL(FileLocator.java:207)
> at org.eclipse.jface.resource.URLImageDescriptor.getFilePath(URLImageDescriptor.java:219)
> at org.eclipse.jface.resource.URLImageDescriptor.createImage(URLImageDescriptor.java:283)
> at org.eclipse.jface.resource.ImageDescriptor.createResource(ImageDescriptor.java:164)
> at org.eclipse.jface.resource.DeviceResourceManager.allocate(DeviceResourceManager.java:52)
> at org.eclipse.jface.resource.AbstractResourceManager.create(AbstractResourceManager.java:86)
> at org.eclipse.jface.resource.ResourceManager.createImageWithDefault(ResourceManager.java:192)
> at org.eclipse.jface.resource.ImageRegistry.get(ImageRegistry.java:214)
> at org.jboss.tools.openshift.internal.common.ui.ImageRepository.getImage(ImageRepository.java:85)
> at org.jboss.tools.openshift.internal.ui.OpenShiftImages.getAppImage(OpenShiftImages.java:62)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateDetailViews$TemplateDetailView.updateImage(TemplateDetailViews.java:106)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateDetailViews$TemplateDetailView.onVisible(TemplateDetailViews.java:102)
> at org.jboss.tools.openshift.internal.common.ui.detailviews.AbstractStackedDetailViews.showView(AbstractStackedDetailViews.java:90)
> at org.jboss.tools.openshift.internal.common.ui.detailviews.AbstractStackedDetailViews.showView(AbstractStackedDetailViews.java:79)
> at org.jboss.tools.openshift.internal.common.ui.detailviews.AbstractStackedDetailViews$1.handleValueChange(AbstractStackedDetailViews.java:73)
> at org.eclipse.core.databinding.observable.value.ValueChangeEvent.dispatch(ValueChangeEvent.java:63)
> at org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
> at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.fireValueChange(DecoratingObservableValue.java:57)
> at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.handleValueChange(DecoratingObservableValue.java:99)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBDS-3554) Integrate/Enable CodeRecommenders substring completion in JBDS 10
by Jan Richter (JIRA)
[ https://issues.jboss.org/browse/JBDS-3554?page=com.atlassian.jira.plugin.... ]
Jan Richter closed JBDS-3554.
-----------------------------
Verified with 10.0.0.Alpha1-B5227
> Integrate/Enable CodeRecommenders substring completion in JBDS 10
> -----------------------------------------------------------------
>
> Key: JBDS-3554
> URL: https://issues.jboss.org/browse/JBDS-3554
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Feature Request
> Components: p2-product, target-platform
> Reporter: Mickael Istria
> Assignee: Mickael Istria
> Fix For: 10.0.0.Alpha1
>
> Attachments: p2diff.log.txt
>
>
> Eclipse Mars release are shipped with CodeRecommenders enabled so that Java developers can benefit from substring completion and many others: https://www.eclipse.org/recommenders/manual/
> JBDS doesn't have it enabled by default when installing from installer. Since it provides a lot of value for Java developers, it should be on by default.
> *Project page/sources:* https://www.eclipse.org/recommenders/manual/
> *Version:* 2.2.4 (part of Mars)
> *License and owner:* EPL, Eclipse Community/CodeTrails
> *Original p2 repo:* included in Mars repository
> *JBoss mirror:* will use our Mars mirror
> *Include Sources:* No
> *Affected JBoss Tools components:* JBDS feature and product
> *Include in JBDS:* Yes (only, not in JBT as it's supposed to be available in upstream Eclipse)
> *Type of dependency:* distribution
> *List of bundles added/removed:*
> [^p2diff.log.txt]
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBIDE-22197) Icon in template Details of Local Template is not loaded for some templates file
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22197?page=com.atlassian.jira.plugi... ]
Jeff MAURY commented on JBIDE-22197:
------------------------------------
The stack trace is not from our side but from the Eclipse part that deals with image loading so there is nothing we can prevent this stacktrace.
I found that we have a cache but it seems to be populated but not used.
So I will do the following
* use the cache (so that stacktrace will be generated once for a specific image)
* add a Java image
* check that a default image is provided (I think this is the case but just make sure)
> Icon in template Details of Local Template is not loaded for some templates file
> --------------------------------------------------------------------------------
>
> Key: JBIDE-22197
> URL: https://issues.jboss.org/browse/JBIDE-22197
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Aurélien Pupier
> Assignee: Jeff MAURY
> Priority: Minor
> Fix For: 4.4.0.Alpha1
>
> Attachments: quickstart-template.json, screenshot-1.png
>
>
> {noformat}
> java.io.FileNotFoundException: /icons/apps/java.png
> at org.eclipse.osgi.storage.url.bundleentry.Handler.findBundleEntry(Handler.java:37)
> at org.eclipse.osgi.storage.url.BundleResourceHandler.openConnection(BundleResourceHandler.java:169)
> at java.net.URL.openConnection(Unknown Source)
> at org.eclipse.osgi.storage.url.BundleURLConverter.toFileURL(BundleURLConverter.java:32)
> at org.eclipse.core.runtime.FileLocator.toFileURL(FileLocator.java:207)
> at org.eclipse.jface.resource.URLImageDescriptor.getFilePath(URLImageDescriptor.java:219)
> at org.eclipse.jface.resource.URLImageDescriptor.createImage(URLImageDescriptor.java:283)
> at org.eclipse.jface.resource.ImageDescriptor.createResource(ImageDescriptor.java:164)
> at org.eclipse.jface.resource.DeviceResourceManager.allocate(DeviceResourceManager.java:52)
> at org.eclipse.jface.resource.AbstractResourceManager.create(AbstractResourceManager.java:86)
> at org.eclipse.jface.resource.ResourceManager.createImageWithDefault(ResourceManager.java:192)
> at org.eclipse.jface.resource.ImageRegistry.get(ImageRegistry.java:214)
> at org.jboss.tools.openshift.internal.common.ui.ImageRepository.getImage(ImageRepository.java:85)
> at org.jboss.tools.openshift.internal.ui.OpenShiftImages.getAppImage(OpenShiftImages.java:62)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateDetailViews$TemplateDetailView.updateImage(TemplateDetailViews.java:106)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateDetailViews$TemplateDetailView.onVisible(TemplateDetailViews.java:102)
> at org.jboss.tools.openshift.internal.common.ui.detailviews.AbstractStackedDetailViews.showView(AbstractStackedDetailViews.java:90)
> at org.jboss.tools.openshift.internal.common.ui.detailviews.AbstractStackedDetailViews.showView(AbstractStackedDetailViews.java:79)
> at org.jboss.tools.openshift.internal.common.ui.detailviews.AbstractStackedDetailViews$1.handleValueChange(AbstractStackedDetailViews.java:73)
> at org.eclipse.core.databinding.observable.value.ValueChangeEvent.dispatch(ValueChangeEvent.java:63)
> at org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
> at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.fireValueChange(DecoratingObservableValue.java:57)
> at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.handleValueChange(DecoratingObservableValue.java:99)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBIDE-22242) OpenShift Explorer: Reorganize context menus
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22242?page=com.atlassian.jira.plugi... ]
Fred Bricon updated JBIDE-22242:
--------------------------------
Fix Version/s: 4.4.0.Alpha2
> OpenShift Explorer: Reorganize context menus
> --------------------------------------------
>
> Key: JBIDE-22242
> URL: https://issues.jboss.org/browse/JBIDE-22242
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.0.Alpha1
> Reporter: Marián Labuda
> Priority: Critical
> Labels: explorer, openshift_v3, ux
> Fix For: 4.4.0.Alpha2
>
> Attachments: connection_cm.png, pod_cm.png, project_cm.png, service_cm.png
>
>
> It would be nice if we would have context menus of OpenShift elements in OpenShift Explorer view a bit reorganized, because at the moment some of them seems to be for me a bit messy (as least context menu of a service).
> See screenshots of context menus:
> connection
> !connection_cm.png!
> project
> !project_cm.png!
> service
> !service_cm.png!
> pod
> !pod_cm.png!
> Here is the guideline how should context menus look like
> https://wiki.eclipse.org/User_Interface_Guidelines#Context_Menus_2
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBIDE-22242) OpenShift Explorer: Reorganize context menus
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22242?page=com.atlassian.jira.plugi... ]
Fred Bricon commented on JBIDE-22242:
-------------------------------------
[~crobson] who can we ask from the Design team to help us figure out that mess?
> OpenShift Explorer: Reorganize context menus
> --------------------------------------------
>
> Key: JBIDE-22242
> URL: https://issues.jboss.org/browse/JBIDE-22242
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.0.Alpha1
> Reporter: Marián Labuda
> Priority: Critical
> Labels: explorer, openshift_v3, ux
> Fix For: 4.4.0.Alpha2
>
> Attachments: connection_cm.png, pod_cm.png, project_cm.png, service_cm.png
>
>
> It would be nice if we would have context menus of OpenShift elements in OpenShift Explorer view a bit reorganized, because at the moment some of them seems to be for me a bit messy (as least context menu of a service).
> See screenshots of context menus:
> connection
> !connection_cm.png!
> project
> !project_cm.png!
> service
> !service_cm.png!
> pod
> !pod_cm.png!
> Here is the guideline how should context menus look like
> https://wiki.eclipse.org/User_Interface_Guidelines#Context_Menus_2
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months