May 2016 - jbosstools-issues - Jboss List Archives

[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22426: ------------------------------------- Description: The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. {code:title=Connection#isConnected} public boolean isConnected(IProgressMonitor monitor) { client.setAuthorizationStrategy(getAuthorizationStrategy()); try { {code} {code:title=Connection#createResource} public <T extends IResource> T createResource(T resource) { try { if(client.getAuthorizationStrategy() == null) { client.setAuthorizationStrategy(getAuthorizationStrategy()); } return client.create(resource); {code} A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared with the authorization strategy: {code:title=com.openshift.internal.restclient.DefaultClient#equals} @Override public boolean equals(Object obj) { ... return ObjectUtils.equals(strategy, other.strategy); {code} the lookup for a connection for a given resource in ConnectionRegistryUtils#safeGetConnectionFor will therefore fail after a Connection#isConnected: {code:title=ConnectionsRegistryUtil#safeGetConnectionFor(IResource)} public static Connection safeGetConnectionFor(IResource resource) { Collection<Connection> all = ConnectionsRegistrySingleton.getInstance().getAll(Connection.class); for (Connection connection : all) { if(connection.ownsResource(resource)) { return connection; } } return null; } {code} was: The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. {code:title=Connection#isConnected} public boolean isConnected(IProgressMonitor monitor) { client.setAuthorizationStrategy(getAuthorizationStrategy()); try { {code} {code:title=Connection#createResource} public <T extends IResource> T createResource(T resource) { try { if(client.getAuthorizationStrategy() == null) { client.setAuthorizationStrategy(getAuthorizationStrategy()); } return client.create(resource); {code} A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared even with the authorization strategy: {code:title=com.openshift.internal.restclient.DefaultClient#equals} @Override public boolean equals(Object obj) { ... return ObjectUtils.equals(strategy, other.strategy); {code} > Connection: authorization strategy is always overwritten (in the client) upon #isConnected > ------------------------------------------------------------------------------------------- > > Key: JBIDE-22426 > URL: https://issues.jboss.org/browse/JBIDE-22426 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha3 > Reporter: Andre Dietisheim > Labels: connection, openshift_v3 > Fix For: 4.4.0.Alpha3 > > > The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. > {code:title=Connection#isConnected} > public boolean isConnected(IProgressMonitor monitor) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > try { > {code} > {code:title=Connection#createResource} > public <T extends IResource> T createResource(T resource) { > try { > if(client.getAuthorizationStrategy() == null) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > } > return client.create(resource); > {code} > A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared with the authorization strategy: > {code:title=com.openshift.internal.restclient.DefaultClient#equals} > @Override > public boolean equals(Object obj) { > ... > return ObjectUtils.equals(strategy, other.strategy); > {code} > the lookup for a connection for a given resource in ConnectionRegistryUtils#safeGetConnectionFor will therefore fail after a Connection#isConnected: > {code:title=ConnectionsRegistryUtil#safeGetConnectionFor(IResource)} > public static Connection safeGetConnectionFor(IResource resource) { > Collection<Connection> all = ConnectionsRegistrySingleton.getInstance().getAll(Connection.class); > for (Connection connection : all) { > if(connection.ownsResource(resource)) { > return connection; > } > } > return null; > } > {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22426: ------------------------------------- Description: The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. {code:title=Connection#isConnected} public boolean isConnected(IProgressMonitor monitor) { client.setAuthorizationStrategy(getAuthorizationStrategy()); try { {code} {code:title=Connection#createResource} public <T extends IResource> T createResource(T resource) { try { if(client.getAuthorizationStrategy() == null) { client.setAuthorizationStrategy(getAuthorizationStrategy()); } return client.create(resource); {code} A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared even with the authorization strategy: {code:title=com.openshift.internal.restclient.DefaultClient#equals} @Override public boolean equals(Object obj) { ... return ObjectUtils.equals(strategy, other.strategy); {code} was: The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. {code:title=Connection#isConnected} public boolean isConnected(IProgressMonitor monitor) { client.setAuthorizationStrategy(getAuthorizationStrategy()); try { {code} {code:title=Connection#createResource} public <T extends IResource> T createResource(T resource) { try { if(client.getAuthorizationStrategy() == null) { client.setAuthorizationStrategy(getAuthorizationStrategy()); } return client.create(resource); {code} > Connection: authorization strategy is always overwritten (in the client) upon #isConnected > ------------------------------------------------------------------------------------------- > > Key: JBIDE-22426 > URL: https://issues.jboss.org/browse/JBIDE-22426 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha3 > Reporter: Andre Dietisheim > Labels: connection, openshift_v3 > Fix For: 4.4.0.Alpha3 > > > The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. > {code:title=Connection#isConnected} > public boolean isConnected(IProgressMonitor monitor) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > try { > {code} > {code:title=Connection#createResource} > public <T extends IResource> T createResource(T resource) { > try { > if(client.getAuthorizationStrategy() == null) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > } > return client.create(resource); > {code} > A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared even with the authorization strategy: > {code:title=com.openshift.internal.restclient.DefaultClient#equals} > @Override > public boolean equals(Object obj) { > ... > return ObjectUtils.equals(strategy, other.strategy); > {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22380) New Application wizard: project is not preselected (nor can you select any) if launched from explorer

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22380?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-22380: ------------------------------------------ [~scabanovich] I see the problem that you found, but I'm not sure that it is the cause of this very issue since I cant reproduce it even with your steps. I therefore filed it to JBIDE-22426 > New Application wizard: project is not preselected (nor can you select any) if launched from explorer > ----------------------------------------------------------------------------------------------------- > > Key: JBIDE-22380 > URL: https://issues.jboss.org/browse/JBIDE-22380 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha1 > Reporter: Andre Dietisheim > Priority: Critical > Labels: application_wizard, openshift_v3 > Fix For: 4.4.0.Alpha3 > > Attachments: project-not-preselected.png > > -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22426: ------------------------------------- Labels: connection openshift_v3 (was: ) > Connection: authorization strategy is always overwritten (in the client) upon #isConnected > ------------------------------------------------------------------------------------------- > > Key: JBIDE-22426 > URL: https://issues.jboss.org/browse/JBIDE-22426 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha3 > Reporter: Andre Dietisheim > Labels: connection, openshift_v3 > Fix For: 4.4.0.Alpha3 > > > The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. > {code:title=Connection#isConnected} > public boolean isConnected(IProgressMonitor monitor) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > try { > {code} > {code:title=Connection#createResource} > public <T extends IResource> T createResource(T resource) { > try { > if(client.getAuthorizationStrategy() == null) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > } > return client.create(resource); > {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22426: ------------------------------------- Fix Version/s: 4.4.0.Alpha3 > Connection: authorization strategy is always overwritten (in the client) upon #isConnected > ------------------------------------------------------------------------------------------- > > Key: JBIDE-22426 > URL: https://issues.jboss.org/browse/JBIDE-22426 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha3 > Reporter: Andre Dietisheim > Fix For: 4.4.0.Alpha3 > > > The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. > {code:title=Connection#isConnected} > public boolean isConnected(IProgressMonitor monitor) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > try { > {code} > {code:title=Connection#createResource} > public <T extends IResource> T createResource(T resource) { > try { > if(client.getAuthorizationStrategy() == null) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > } > return client.create(resource); > {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected

by Andre Dietisheim (JIRA)

Andre Dietisheim created JBIDE-22426: ---------------------------------------- Summary: Connection: authorization strategy is always overwritten (in the client) upon #isConnected Key: JBIDE-22426 URL: https://issues.jboss.org/browse/JBIDE-22426 Project: Tools (JBoss Tools) Issue Type: Bug Components: openshift Affects Versions: 4.4.0.Alpha3 Reporter: Andre Dietisheim The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. {code:title=Connection#isConnected} public boolean isConnected(IProgressMonitor monitor) { client.setAuthorizationStrategy(getAuthorizationStrategy()); try { {code} {code:title=Connection#createResource} public <T extends IResource> T createResource(T resource) { try { if(client.getAuthorizationStrategy() == null) { client.setAuthorizationStrategy(getAuthorizationStrategy()); } return client.create(resource); {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22419) Deploy Docker Wizard: Connection info looks weird

by Viacheslav Kabanovich (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22419?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich commented on JBIDE-22419: ----------------------------------------------- It is supposed to be uneditable here because when connection is not set, we have the Sign in page. If connection is found, this page is only displaying info and lets user to see clearly what data is needed. I do not see anything weird in the opportunity to put cursor and copy text from it. Compare to Properties dialog for a folder on Ubuntu. Label 'Location:' is completely disabled, but you can put cursor in the location value, select it and copy. The same is true for Details view in Openshift wizards. > Deploy Docker Wizard: Connection info looks weird > ------------------------------------------------- > > Key: JBIDE-22419 > URL: https://issues.jboss.org/browse/JBIDE-22419 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha2 > Reporter: Marián Labuda > Priority: Minor > Labels: docker, openshift_v3 > Fix For: 4.4.x > > Attachments: docker_wizard.png > > > Connection info in Deploy Image to OpenShift wizard looks weird. It is a text widget but it looks like it is text area where it is supposed to be text typed, but it is disabled. It is also possible to put cursor there. This apply both for wizard opened via context menu of a docker image as well as for wizard opened from context menu of an OpenShift project. > !docker_wizard.png! -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22315) Application wizard: memory leak

by Viacheslav Kabanovich (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22315?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich commented on JBIDE-22315: ----------------------------------------------- Created an issue in Eclipse Bugzilla for MacOS https://bugs.eclipse.org/bugs/show_bug.cgi?id=494348 > Application wizard: memory leak > ------------------------------- > > Key: JBIDE-22315 > URL: https://issues.jboss.org/browse/JBIDE-22315 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha1 > Reporter: Viacheslav Kabanovich > Assignee: Viacheslav Kabanovich > Priority: Critical > Labels: application_wizard, openshift_v3 > Fix For: 4.4.0.Alpha2 > > > Each instance of the wizard with pages, models, data binding contexts, and all referenced objects, including openshift model objects remains in memory. Disposed are only SWT widgets, but even they are not ready for the garbage collector since they remain referenced by data binding contexts. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-21885) Properties: Remove "()" from context-menu name of Start Build

by Viacheslav Kabanovich (JIRA)

[ https://issues.jboss.org/browse/JBIDE-21885?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich commented on JBIDE-21885: ----------------------------------------------- Created an issue in Eclipse Bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=494343 > Properties: Remove "()" from context-menu name of Start Build > -------------------------------------------------------------- > > Key: JBIDE-21885 > URL: https://issues.jboss.org/browse/JBIDE-21885 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha1 > Environment: JBoss OpenShift 3 Tools 3.2.0.Alpha1-v20160316-2139-B1202 > OS: Fedora 22 & Windows 10 > Reporter: Xia Zhao > Assignee: Viacheslav Kabanovich > Priority: Minor > Labels: openshift_v3 > Fix For: 4.4.0.Alpha2 > > Attachments: build-config-properties-menu.png, start-build.png > > > The "()" from context-menu name of Start Build should be removed -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBDS-3898) Make sure eclipse JSON editor is included in devstudio

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBDS-3898?page=com.atlassian.jira.plugin.... ] Nick Boldt commented on JBDS-3898: ---------------------------------- We do not include the SDK feature in the current Alpha1 Target Platform. Should we? > Make sure eclipse JSON editor is included in devstudio > ------------------------------------------------------ > > Key: JBDS-3898 > URL: https://issues.jboss.org/browse/JBDS-3898 > Project: Red Hat Developer Studio (DevStudio) > Issue Type: Task > Components: target-platform > Reporter: Alexey Kazakov > Assignee: Nick Boldt > Priority: Blocker > Fix For: 10.0.0.Alpha3 > > > We should make sure JSON Editor is included in devstudio and JBT target platforms/Market place/installation. > [~vrubezhny] please provide all needed information for [~nickboldt] regarding this plugin. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues May 2016