[JBoss JIRA] (JBIDE-21121) Port Forwarding: Warning/error dialog should pop up if there is no oc binary when opening Port forwarding dialog
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21121?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21121:
------------------------------------------
I believe that we should have a consistent strategy of always verifying the path to the oc binary if we're up to use the binary (not just when port forwarding but also when streaming logs, rsync'ing, etc.)
> Port Forwarding: Warning/error dialog should pop up if there is no oc binary when opening Port forwarding dialog
> ----------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21121
> URL: https://issues.jboss.org/browse/JBIDE-21121
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Labels: openshift_v3, port_forwarding_wizard
> Fix For: 4.4.0.Alpha3
>
>
> OpenShift 3 port forwarding features requires 'oc' binary to be set up in tooling. It's done in Workbench preference dialog on page OpenShift 3. If there is no 'oc' binary set and user invokes a port forwarding dialog, it is opened and even Start All button is enabled. User finds out that it is not possible to perform only when he gets an error message upon clicking on Start All button describing the problem. There could be some warning/error dialog popped up before opening a port forwarding dialog if there is no 'oc' location set in preferences.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-21969) Show in Browser: route chooser should allow to user to choose route permanently
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21969?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21969:
------------------------------------------
When discussing with [~rob.stryker] I found out that a sever adapter is required to have a fixed host which we dont currently. We should therefore rethink the design as suggested in JBIDE-22051
> Show in Browser: route chooser should allow to user to choose route permanently
> -------------------------------------------------------------------------------
>
> Key: JBIDE-21969
> URL: https://issues.jboss.org/browse/JBIDE-21969
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Andre Dietisheim
> Assignee: Viacheslav Kabanovich
> Labels: openshift_v3, server_adapter
> Fix For: 4.4.0.Alpha3
>
> Attachments: route-chooser.png
>
>
> steps to reproduce:
> # ASSERT: have an apps with service and route running on OpenShift. Have it imported to your workspace
> # ASSERT: you need at least a 2nd route in the same project (ex. by having a 2nd app in the same project)
> # EXEC: launch New OpenShift 3 Server Adapter wizard
> # ASSERT: make sure that you have *Prompt for route when multiple routes available to show in browser* checked (no route permanently selected)
> # EXEC: create the adapter by picking service, local project etc.
> # EXEC: in the context menu of your new server adapter: pick Show In > Web Browser
> # ASSERT: Route chooser shows up (since there are several routes available)
> Result:
> There's no way to permanently choose a route. The route chooser will always show up (as long as I have several routes in the same project)
> !route-chooser.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-21668) Fix collection setters in ResourcesUIModel
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21668?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-21668:
-------------------------------
Story Points: 8
> Fix collection setters in ResourcesUIModel
> ------------------------------------------
>
> Key: JBIDE-21668
> URL: https://issues.jboss.org/browse/JBIDE-21668
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: openshift
> Affects Versions: 4.4.0.Alpha1
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
> Fix For: 4.4.x
>
>
> Created as follow up to JBIDE-21590.
> Collections setters in ResourcesUIModel, for instance
> {code}
> public void setBuildConfigs(Collection<IResourceUIModel> buildConfigs) {
> firePropertyChange(PROP_BUILD_CONFIGS, resources.get(ResourceKind.BUILD_CONFIG), resources.put(ResourceKind.BUILD_CONFIG, new ArrayList<>(buildConfigs)));
> }
> {code}
> fire incorrect newValue object, because java.util.Map.put(key, value) returns old object associated with the key, not the one just set.
> At this moment, this does not create any bugs, because these setters are still not used, all changes go through ResourcesUIModel.add, ResourcesUIModel.remove, ResourcesUIModel.update that have correct notification. But bugs may appear as soon as collection setters are used, so that they better be fixed, for instance this way :
> {code}
> public void setBuildConfigs(Collection<IResourceUIModel> buildConfigs) {
> setResourcesForKind(buildConfigs, ResourceKind.BUILD_CONFIG);
> }
> private void setResourcesForKind(Collection<IResourceUIModel> list, String kind) {
> List<IResourceUIModel> oldList = resources.get(kind);
> List<IResourceUIModel> newList = new ArrayList<IResourceUIModel>(list);
> resources.put(kind, newList);
> firePropertyChange(getProperty(kind), oldList, newList);
> }
> {code}
> and with use of private setResourcesForKind all other setters will remain one-liners.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-21969) Show in Browser: route chooser should allow to user to choose route permanently
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21969?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-21969:
-------------------------------------
Fix Version/s: 4.4.0.Alpha3
(was: 4.3.1.Final)
> Show in Browser: route chooser should allow to user to choose route permanently
> -------------------------------------------------------------------------------
>
> Key: JBIDE-21969
> URL: https://issues.jboss.org/browse/JBIDE-21969
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Andre Dietisheim
> Assignee: Viacheslav Kabanovich
> Labels: openshift_v3, server_adapter
> Fix For: 4.4.0.Alpha3
>
> Attachments: route-chooser.png
>
>
> steps to reproduce:
> # ASSERT: have an apps with service and route running on OpenShift. Have it imported to your workspace
> # ASSERT: you need at least a 2nd route in the same project (ex. by having a 2nd app in the same project)
> # EXEC: launch New OpenShift 3 Server Adapter wizard
> # ASSERT: make sure that you have *Prompt for route when multiple routes available to show in browser* checked (no route permanently selected)
> # EXEC: create the adapter by picking service, local project etc.
> # EXEC: in the context menu of your new server adapter: pick Show In > Web Browser
> # ASSERT: Route chooser shows up (since there are several routes available)
> Result:
> There's no way to permanently choose a route. The route chooser will always show up (as long as I have several routes in the same project)
> !route-chooser.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-21969) Show in Browser: route chooser should allow to user to choose route permanently
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21969?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-21969:
-------------------------------------
Fix Version/s: 4.3.1.Final
(was: 4.4.0.Alpha3)
> Show in Browser: route chooser should allow to user to choose route permanently
> -------------------------------------------------------------------------------
>
> Key: JBIDE-21969
> URL: https://issues.jboss.org/browse/JBIDE-21969
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Reporter: Andre Dietisheim
> Assignee: Viacheslav Kabanovich
> Labels: openshift_v3, server_adapter
> Fix For: 4.4.0.Alpha3
>
> Attachments: route-chooser.png
>
>
> steps to reproduce:
> # ASSERT: have an apps with service and route running on OpenShift. Have it imported to your workspace
> # ASSERT: you need at least a 2nd route in the same project (ex. by having a 2nd app in the same project)
> # EXEC: launch New OpenShift 3 Server Adapter wizard
> # ASSERT: make sure that you have *Prompt for route when multiple routes available to show in browser* checked (no route permanently selected)
> # EXEC: create the adapter by picking service, local project etc.
> # EXEC: in the context menu of your new server adapter: pick Show In > Web Browser
> # ASSERT: Route chooser shows up (since there are several routes available)
> Result:
> There's no way to permanently choose a route. The route chooser will always show up (as long as I have several routes in the same project)
> !route-chooser.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-21121) Port Forwarding: Warning/error dialog should pop up if there is no oc binary when opening Port forwarding dialog
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21121?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-21121:
-------------------------------
Story Points: 4
> Port Forwarding: Warning/error dialog should pop up if there is no oc binary when opening Port forwarding dialog
> ----------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21121
> URL: https://issues.jboss.org/browse/JBIDE-21121
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Labels: openshift_v3, port_forwarding_wizard
> Fix For: 4.4.0.Alpha3
>
>
> OpenShift 3 port forwarding features requires 'oc' binary to be set up in tooling. It's done in Workbench preference dialog on page OpenShift 3. If there is no 'oc' binary set and user invokes a port forwarding dialog, it is opened and even Start All button is enabled. User finds out that it is not possible to perform only when he gets an error message upon clicking on Start All button describing the problem. There could be some warning/error dialog popped up before opening a port forwarding dialog if there is no 'oc' location set in preferences.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-21420) Delete more OpenShift projects at once
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21420?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-21420:
-------------------------------
Story Points: 8
> Delete more OpenShift projects at once
> --------------------------------------
>
> Key: JBIDE-21420
> URL: https://issues.jboss.org/browse/JBIDE-21420
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Marián Labuda
> Assignee: Jeff MAURY
> Labels: explorer, new_and_noteworthy, openshift_v3
> Fix For: 4.4.x
>
>
> It would be nice to remove more projects at once. Currently I can only delete project by project by selecting and choosing delete in its context menu. I would like to select more projects and choose Delete project(s)... in theirs context menu as it is similar for OpenShift 2 domains.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-21828) OpenShift Explorer view flickers when refreshing a service
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21828?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21828:
------------------------------------------
[~jcantrill] I believe that you're the one with the most knowledge in this are since you also looked into the refresh problems. Can please you verify this?
> OpenShift Explorer view flickers when refreshing a service
> ----------------------------------------------------------
>
> Key: JBIDE-21828
> URL: https://issues.jboss.org/browse/JBIDE-21828
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Xavier Coulon
> Assignee: Jeff Cantrill
> Fix For: 4.4.0.Alpha3
>
> Attachments: Screenshot 2016-03-08 10.32.39.png
>
>
> When calling the "Refresh" command on a service, the tree view flickers because of too many refresh calls.
> Adding some traces revealed 25 calls to {{BaseExplorerContentProvider#refreshViewer(Object)}}, which seems way too much for a service with a single pod.
> Attachement: screenshot of the OpenShift Server view, showing 2 projects, one of which has 3 services.
> Custom/added logs in the console:
> {code}
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel@431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel@431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel@431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel@431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel@431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel@431dafbc
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/mongodb
> Refreshing viewer from sample/mongodb
> Refreshing viewer from sample/mongodb
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel@431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel@431dafbc
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months