[JBoss JIRA] (JBIDE-21657) set up jobs to handle building from PRs
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21657?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-21657:
----------------------------------------
As far as I know, the need for global push rights comes from either GitHub API or GitHub Pull Request Builder plugin. Whatever instance of Jenkins we use, we need a user with such permissions to automate votes on PR.
> set up jobs to handle building from PRs
> ---------------------------------------
>
> Key: JBIDE-21657
> URL: https://issues.jboss.org/browse/JBIDE-21657
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.3.1.Beta2, 4.4.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Critical
> Fix For: 4.4.0.Alpha3
>
>
> First experimental build:
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sit...
> Output:
> http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-bui...
> {code}
> "revision" : {
> "HEAD" : "bfe76fb3f3c34d68b873d0acf715e2145e4cb805",
> "currentBranch" : "HEAD",
> "knownReferences" : [{
> "name" : "origin",
> "url" : "git://github.com/jbosstools/jbosstools-build-sites.git",
> "ref" : "pr/221/merge"
> }]
> },
> {code}
> http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-bui...
> {code}
> #Fri Feb 05 16:42:42 EST 2016
> null\:merge=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> HEAD=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> {code}
> build log:
> {code}
> Started by upstream project "jbosstools-build-sites.aggregate.child-sites__pull-request_master" build number 1
> originally caused by:
> GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts.
> ...
> Fetching upstream changes from git://github.com/jbosstools/jbosstools-build-sites.git
> > git -c core.askpass=true fetch --tags --progress git://github.com/jbosstools/jbosstools-build-sites.git +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/remotes/origin/pr/*
> Checking out Revision bfe76fb3f3c34d68b873d0acf715e2145e4cb805 (refs/remotes/origin/pr/221/merge)
> > git config core.sparsecheckout # timeout=10
> > git checkout -f bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> {code}
> vars:
> {code}
> -DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
> -DghprbPullId=221
> -Dsha1=origin/pr/221/merge
> "-DghprbPullDescription=GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts."
> -DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22362) Server Adapter: Static changes done to nodejs application are not visible
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22362?page=com.atlassian.jira.plugi... ]
Marián Labuda commented on JBIDE-22362:
---------------------------------------
At first I thought this is some tooling issue, but after closer investigation I found out it is upstream bug.
> Server Adapter: Static changes done to nodejs application are not visible
> -------------------------------------------------------------------------
>
> Key: JBIDE-22362
> URL: https://issues.jboss.org/browse/JBIDE-22362
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, upstream
> Affects Versions: 4.4.0.Alpha2
> Reporter: Marián Labuda
> Priority: Critical
> Labels: openshift_v3, server_adapter
> Fix For: 4.4.0.Alpha3
>
>
> I am having an OpenShift application based either on nodejs-example or nodejs-mongodb-example template. Once application is up and running I create a new server adapter and perform changes in index.html. These changes are static and should be (?) immediately visible on OpenShift server, but they are not. I have checked whether changes were published, but rsync in console shows expected output also changes done manually on the server side to index.html are not visible in browser (even when cache overwritten is triggered - so there is no caching problem in browser). This seems to be upstream issues, but requires investigating.
> So far I have tried it on CDK OpenShift. It would be nice to test it on other OpenShift instances, also on templates using different base docker image.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22362) Server Adapter: Static changes done to nodejs application are not visible
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22362?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-22362:
-------------------------------------
Fix Version/s: 4.4.0.Alpha3
> Server Adapter: Static changes done to nodejs application are not visible
> -------------------------------------------------------------------------
>
> Key: JBIDE-22362
> URL: https://issues.jboss.org/browse/JBIDE-22362
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, upstream
> Affects Versions: 4.4.0.Alpha2
> Reporter: Marián Labuda
> Priority: Critical
> Labels: openshift_v3, server_adapter
> Fix For: 4.4.0.Alpha3
>
>
> I am having an OpenShift application based either on nodejs-example or nodejs-mongodb-example template. Once application is up and running I create a new server adapter and perform changes in index.html. These changes are static and should be (?) immediately visible on OpenShift server, but they are not. I have checked whether changes were published, but rsync in console shows expected output also changes done manually on the server side to index.html are not visible in browser (even when cache overwritten is triggered - so there is no caching problem in browser). This seems to be upstream issues, but requires investigating.
> So far I have tried it on CDK OpenShift. It would be nice to test it on other OpenShift instances, also on templates using different base docker image.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22362) Server Adapter: Static changes done to nodejs application are not visible
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22362?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-22362:
------------------------------------------
[~mlabuda] Did you find out if this is in upstream or tooling?
> Server Adapter: Static changes done to nodejs application are not visible
> -------------------------------------------------------------------------
>
> Key: JBIDE-22362
> URL: https://issues.jboss.org/browse/JBIDE-22362
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, upstream
> Affects Versions: 4.4.0.Alpha2
> Reporter: Marián Labuda
> Priority: Critical
> Labels: openshift_v3, server_adapter
>
> I am having an OpenShift application based either on nodejs-example or nodejs-mongodb-example template. Once application is up and running I create a new server adapter and perform changes in index.html. These changes are static and should be (?) immediately visible on OpenShift server, but they are not. I have checked whether changes were published, but rsync in console shows expected output also changes done manually on the server side to index.html are not visible in browser (even when cache overwritten is triggered - so there is no caching problem in browser). This seems to be upstream issues, but requires investigating.
> So far I have tried it on CDK OpenShift. It would be nice to test it on other OpenShift instances, also on templates using different base docker image.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22452) Application Wizard: Git reference text widget does not validate values
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22452?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-22452:
------------------------------------------
we could actually provide 2 types of validation:
* basic format validation
* validate the actual refs (even better but harder, needs to do remote calls)
I guess that basic format validation is good enough. Validating actual refs could be done later together with content assist
> Application Wizard: Git reference text widget does not validate values
> ----------------------------------------------------------------------
>
> Key: JBIDE-22452
> URL: https://issues.jboss.org/browse/JBIDE-22452
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.0.Alpha3
> Reporter: Marián Labuda
> Labels: application_wizard, openshift_v3
> Fix For: 4.4.0.Alpha3
>
>
> On the Build Configuration wizard page there is a text widget for git reference. Tooltip say there could be put branch, tag or commit. There is no validation at the moment. Although the field is optional, it would be nice if there is any value, it would be validated. Commits are hexadecimal values what is less restrictive then tags or branches. For tag and branches see reference at https://git-scm.com/docs/git-check-ref-format or use "git check-ref-format --help".
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months