[JBoss JIRA] (ERT-195) Generification of IJavaCompletionProposalComputer has type of computeContextInformation wrong [EBZ#493810]
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/ERT-195?page=com.atlassian.jira.plugin.sy... ]
Victor Rubezhny reassigned ERT-195:
-----------------------------------
Assignee: Victor Rubezhny
> Generification of IJavaCompletionProposalComputer has type of computeContextInformation wrong [EBZ#493810]
> ----------------------------------------------------------------------------------------------------------
>
> Key: ERT-195
> URL: https://issues.jboss.org/browse/ERT-195
> Project: Eclipse Release Train
> Issue Type: Task
> Components: JSDT
> Reporter: Friendly Jira Robot
> Assignee: Victor Rubezhny
> Labels: 3.8_RC2, General, bzira
> Fix For: Neon (4.6) RC2
>
>
> The return type of IJavaCompletionProposalComputer.computeContextInformation was recently changed from "List" to "List<ICompletionProposal>", it should have been "List<IContextInformation>".
> At the moment all the implementations of IJavaCompletionProposalComputer.computeContextInformation in the code base have return type still as "List" with unchecked conversions. That is why there is no compile error within JSDT on its own.
> Note that IJavaCompletionProposalComputer was originally copied from JDT.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ERT-195) Generification of IJavaCompletionProposalComputer has type of computeContextInformation wrong [EBZ#493810]
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/ERT-195?page=com.atlassian.jira.plugin.sy... ]
Victor Rubezhny resolved ERT-195.
---------------------------------
Resolution: Done
> Generification of IJavaCompletionProposalComputer has type of computeContextInformation wrong [EBZ#493810]
> ----------------------------------------------------------------------------------------------------------
>
> Key: ERT-195
> URL: https://issues.jboss.org/browse/ERT-195
> Project: Eclipse Release Train
> Issue Type: Task
> Components: JSDT
> Reporter: Friendly Jira Robot
> Assignee: Victor Rubezhny
> Labels: 3.8_RC2, General, bzira
> Fix For: Neon (4.6) RC2
>
>
> The return type of IJavaCompletionProposalComputer.computeContextInformation was recently changed from "List" to "List<ICompletionProposal>", it should have been "List<IContextInformation>".
> At the moment all the implementations of IJavaCompletionProposalComputer.computeContextInformation in the code base have return type still as "List" with unchecked conversions. That is why there is no compile error within JSDT on its own.
> Note that IJavaCompletionProposalComputer was originally copied from JDT.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ERT-198) Content assist displays only top level properties as proposals [EBZ#490639]
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/ERT-198?page=com.atlassian.jira.plugin.sy... ]
Victor Rubezhny reassigned ERT-198:
-----------------------------------
Assignee: Victor Rubezhny
> Content assist displays only top level properties as proposals [EBZ#490639]
> ---------------------------------------------------------------------------
>
> Key: ERT-198
> URL: https://issues.jboss.org/browse/ERT-198
> Project: Eclipse Release Train
> Issue Type: Task
> Components: WTP Source Editing
> Reporter: Friendly Jira Robot
> Assignee: Victor Rubezhny
> Labels: 3.8_RC2, bzira, wst.json
> Fix For: Neon (4.6) RC2
>
>
> When I invoke content assist on a JSON object, I expect to see the list of properties in the context of the selected object but I see a list of top level properties instead.
> I think the problem is in the JSONSchemaNode.walk() method, where the 'json' object that gets passed in is always the schema root, so the properties always correspond to that object.
> private static void walk(JsonObject json, JSONSchemaNode schemaNode) {
> Member member = null;
> JsonObject properties = (JsonObject) json.get("properties");
> if (properties != null) {
> Iterator<Member> members = properties.iterator();
> while (members.hasNext()) {
> member = members.next();
> schemaNode.addProperty(new JSONSchemaProperty(member.getName(),
> (JsonObject) member.getValue(), schemaNode));
> }
> }
> }
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ERT-198) Content assist displays only top level properties as proposals [EBZ#490639]
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/ERT-198?page=com.atlassian.jira.plugin.sy... ]
Victor Rubezhny reassigned ERT-198:
-----------------------------------
Assignee: Snjezana Peco (was: Victor Rubezhny)
> Content assist displays only top level properties as proposals [EBZ#490639]
> ---------------------------------------------------------------------------
>
> Key: ERT-198
> URL: https://issues.jboss.org/browse/ERT-198
> Project: Eclipse Release Train
> Issue Type: Task
> Components: WTP Source Editing
> Reporter: Friendly Jira Robot
> Assignee: Snjezana Peco
> Labels: 3.8_RC2, bzira, wst.json
> Fix For: Neon (4.6) RC2
>
>
> When I invoke content assist on a JSON object, I expect to see the list of properties in the context of the selected object but I see a list of top level properties instead.
> I think the problem is in the JSONSchemaNode.walk() method, where the 'json' object that gets passed in is always the schema root, so the properties always correspond to that object.
> private static void walk(JsonObject json, JSONSchemaNode schemaNode) {
> Member member = null;
> JsonObject properties = (JsonObject) json.get("properties");
> if (properties != null) {
> Iterator<Member> members = properties.iterator();
> while (members.hasNext()) {
> member = members.next();
> schemaNode.addProperty(new JSONSchemaProperty(member.getName(),
> (JsonObject) member.getValue(), schemaNode));
> }
> }
> }
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ERT-198) Content assist displays only top level properties as proposals [EBZ#490639]
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/ERT-198?page=com.atlassian.jira.plugin.sy... ]
Victor Rubezhny resolved ERT-198.
---------------------------------
Resolution: Done
> Content assist displays only top level properties as proposals [EBZ#490639]
> ---------------------------------------------------------------------------
>
> Key: ERT-198
> URL: https://issues.jboss.org/browse/ERT-198
> Project: Eclipse Release Train
> Issue Type: Task
> Components: WTP Source Editing
> Reporter: Friendly Jira Robot
> Assignee: Snjezana Peco
> Labels: 3.8_RC2, bzira, wst.json
> Fix For: Neon (4.6) RC2
>
>
> When I invoke content assist on a JSON object, I expect to see the list of properties in the context of the selected object but I see a list of top level properties instead.
> I think the problem is in the JSONSchemaNode.walk() method, where the 'json' object that gets passed in is always the schema root, so the properties always correspond to that object.
> private static void walk(JsonObject json, JSONSchemaNode schemaNode) {
> Member member = null;
> JsonObject properties = (JsonObject) json.get("properties");
> if (properties != null) {
> Iterator<Member> members = properties.iterator();
> while (members.hasNext()) {
> member = members.next();
> schemaNode.addProperty(new JSONSchemaProperty(member.getName(),
> (JsonObject) member.getValue(), schemaNode));
> }
> }
> }
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months