[JBoss JIRA] (JBDS-3898) Make sure eclipse JSON editor is included in devstudio
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/JBDS-3898?page=com.atlassian.jira.plugin.... ]
Victor Rubezhny commented on JBDS-3898:
---------------------------------------
[~nickboldt] Do not include SDK feature if it's not supposed to be in Target Platform. Having org.eclipse.wst.json_ui.feature should be enough to make it working
> Make sure eclipse JSON editor is included in devstudio
> ------------------------------------------------------
>
> Key: JBDS-3898
> URL: https://issues.jboss.org/browse/JBDS-3898
> Project: Red Hat Developer Studio (DevStudio)
> Issue Type: Task
> Components: target-platform
> Reporter: Alexey Kazakov
> Assignee: Nick Boldt
> Priority: Critical
> Fix For: 10.0.0.Alpha3
>
>
> We should make sure JSON Editor is included in devstudio and JBT target platforms/Market place/installation.
> [~vrubezhny] please provide all needed information for [~nickboldt] regarding this plugin.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBDS-3898) Make sure eclipse JSON editor is included in devstudio
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBDS-3898?page=com.atlassian.jira.plugin.... ]
Mickael Istria commented on JBDS-3898:
--------------------------------------
What's the difference between JBDS-3267 and this issue?
I believe we usually avoid SDK features as they're consuming space/bandwith at installation and it'stargetting plugin developers.
> Make sure eclipse JSON editor is included in devstudio
> ------------------------------------------------------
>
> Key: JBDS-3898
> URL: https://issues.jboss.org/browse/JBDS-3898
> Project: Red Hat Developer Studio (DevStudio)
> Issue Type: Task
> Components: target-platform
> Reporter: Alexey Kazakov
> Assignee: Nick Boldt
> Priority: Critical
> Fix For: 10.0.0.Alpha3
>
>
> We should make sure JSON Editor is included in devstudio and JBT target platforms/Market place/installation.
> [~vrubezhny] please provide all needed information for [~nickboldt] regarding this plugin.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-21668) Fix collection setters in ResourcesUIModel
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21668?page=com.atlassian.jira.plugi... ]
Fred Bricon commented on JBIDE-21668:
-------------------------------------
[~tmader] please take a look at this one
> Fix collection setters in ResourcesUIModel
> ------------------------------------------
>
> Key: JBIDE-21668
> URL: https://issues.jboss.org/browse/JBIDE-21668
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: openshift
> Affects Versions: 4.4.0.Alpha1
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
> Fix For: 4.4.x
>
>
> Created as follow up to JBIDE-21590.
> Collections setters in ResourcesUIModel, for instance
> {code}
> public void setBuildConfigs(Collection<IResourceUIModel> buildConfigs) {
> firePropertyChange(PROP_BUILD_CONFIGS, resources.get(ResourceKind.BUILD_CONFIG), resources.put(ResourceKind.BUILD_CONFIG, new ArrayList<>(buildConfigs)));
> }
> {code}
> fire incorrect newValue object, because java.util.Map.put(key, value) returns old object associated with the key, not the one just set.
> At this moment, this does not create any bugs, because these setters are still not used, all changes go through ResourcesUIModel.add, ResourcesUIModel.remove, ResourcesUIModel.update that have correct notification. But bugs may appear as soon as collection setters are used, so that they better be fixed, for instance this way :
> {code}
> public void setBuildConfigs(Collection<IResourceUIModel> buildConfigs) {
> setResourcesForKind(buildConfigs, ResourceKind.BUILD_CONFIG);
> }
> private void setResourcesForKind(Collection<IResourceUIModel> list, String kind) {
> List<IResourceUIModel> oldList = resources.get(kind);
> List<IResourceUIModel> newList = new ArrayList<IResourceUIModel>(list);
> resources.put(kind, newList);
> firePropertyChange(getProperty(kind), oldList, newList);
> }
> {code}
> and with use of private setResourcesForKind all other setters will remain one-liners.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months