[JBoss JIRA] (JBIDE-22657) smart import nullpointer
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22657?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-22657:
----------------------------------------
Seems like {code}new BufferedReader(new InputStreamReader(content, webXml.getCharset()));{code} returns null whereas there is an activation policy that makes that this like should only be run in case project contains a web.xml file... So in this case, the root cause seems to be that the JaxRS configurator gets enabled whereas it shouldn't.
In any case, we should also add null checks before the trying to close stream/reader.
> smart import nullpointer
> ------------------------
>
> Key: JBIDE-22657
> URL: https://issues.jboss.org/browse/JBIDE-22657
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: webservices
> Reporter: Max Rydahl Andersen
> Assignee: Mickael Istria
> Fix For: 4.4.1.M1, 4.5.0.M1
>
>
> when using smartimport to import https://github.com/maxandersen/imapfilter-docker.git from disk I got a NPE in jaxrs:
> {code}
> java.lang.NullPointerException
> at org.jboss.tools.ws.jaxrs.ui.internal.importer.JaxRsConfigurator.canConfigure(JaxRsConfigurator.java:66)
> at org.eclipse.ui.internal.wizards.datatransfer.SmartImportJob.importProjectAndChildrenRecursively(SmartImportJob.java:466)
> at org.eclipse.ui.internal.wizards.datatransfer.SmartImportJob.run(SmartImportJob.java:242)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22628) Zoom in / out functionality is not working with Visual Page Editor
by Ilya Buziuk (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22628?page=com.atlassian.jira.plugi... ]
Ilya Buziuk commented on JBIDE-22628:
-------------------------------------
[~viacheslav.kabanovich], I think it is ok (for now if one zoom in / out in html editor it will also affect vpe).
< What if we want independent zoom on Text and Preview, working by the same key?
Well, this sounds like a separate feature (having zoom in / out for preview mode working with cntrl + / -). Taking in consideration that vpe is in a deep support phase and everyone is focused on other areas it is not likely to happen
> Zoom in / out functionality is not working with Visual Page Editor
> --------------------------------------------------------------------
>
> Key: JBIDE-22628
> URL: https://issues.jboss.org/browse/JBIDE-22628
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: visual-page-editor-core
> Affects Versions: 4.4.0.Alpha2
> Reporter: Ilya Buziuk
> Assignee: Ilya Buziuk
> Labels: upstream
> Fix For: 4.4.x
>
>
> New zoom in / out functionality (Cntl + / -) which is available in Neon is not working in Visual Page Editor. The interesting thing, that if you do Zoom in / out in the html editor which supports this functionality and reopen file again in the Visual Editor the new scale will be adjusted
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22628) Zoom in / out functionality is not working with Visual Page Editor
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22628?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-22628:
-----------------------------------------------
[~ibuziuk], when Preview tab without text is selected, is it ok, that zoom will affect the text part without user seeing the effect? What if we want independent zoom on Text and Preview, working by the same key?
> Zoom in / out functionality is not working with Visual Page Editor
> --------------------------------------------------------------------
>
> Key: JBIDE-22628
> URL: https://issues.jboss.org/browse/JBIDE-22628
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: visual-page-editor-core
> Affects Versions: 4.4.0.Alpha2
> Reporter: Ilya Buziuk
> Assignee: Ilya Buziuk
> Labels: upstream
> Fix For: 4.4.x
>
>
> New zoom in / out functionality (Cntl + / -) which is available in Neon is not working in Visual Page Editor. The interesting thing, that if you do Zoom in / out in the html editor which supports this functionality and reopen file again in the Visual Editor the new scale will be adjusted
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBTIS-796) Unify versions of BPMN2 plugins
by Tomáš Sedmík (JIRA)
[ https://issues.jboss.org/browse/JBTIS-796?page=com.atlassian.jira.plugin.... ]
Tomáš Sedmík closed JBTIS-796.
------------------------------
Resolution: Won't Do
[~bbrodt] OK, thank you for clarification.
> Unify versions of BPMN2 plugins
> -------------------------------
>
> Key: JBTIS-796
> URL: https://issues.jboss.org/browse/JBTIS-796
> Project: JBoss Tools Integration Stack
> Issue Type: Enhancement
> Components: BPMN2
> Affects Versions: 4.3.1.Final
> Environment: JBDSIS 9.0.1.CR1
> Reporter: Tomáš Sedmík
>
> I noticed there are BPMN2 plugins in two versions. For example:
> - org.eclipse.bpmn2.editor - 1.2.1.Final-v20160218-1950-B212
> - org.eclipse.bpmn2.modeler.core - 1.2.4.Final-v20160330-1625-B110
> [~bbrodt] Is that correct? IMHO all plugins of a single component should be in the same version.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22628) Zoom in / out functionality is not working with Visual Page Editor
by Ilya Buziuk (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22628?page=com.atlassian.jira.plugi... ]
Ilya Buziuk commented on JBIDE-22628:
-------------------------------------
[~scabanovich], assuming that the issue is fixed upstream there is no need to change anything in VPE code (getAdapter already returns AbstractTextEditor). Overriding getSelectedPage does not break anything from the first glance, but it might cause some subtle issues, so I would rather leave it as is.
> Zoom in / out functionality is not working with Visual Page Editor
> --------------------------------------------------------------------
>
> Key: JBIDE-22628
> URL: https://issues.jboss.org/browse/JBIDE-22628
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: visual-page-editor-core
> Affects Versions: 4.4.0.Alpha2
> Reporter: Ilya Buziuk
> Assignee: Ilya Buziuk
> Labels: upstream
> Fix For: 4.4.x
>
>
> New zoom in / out functionality (Cntl + / -) which is available in Neon is not working in Visual Page Editor. The interesting thing, that if you do Zoom in / out in the html editor which supports this functionality and reopen file again in the Visual Editor the new scale will be adjusted
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22628) Zoom in / out functionality is not working with Visual Page Editor
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22628?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich edited comment on JBIDE-22628 at 6/27/16 10:20 AM:
-------------------------------------------------------------------------
[~ibuziuk], [~mickael_istria], yes, looking for adapter may help solve some cases, taking into account however that method getAdapter() should in its logic mimic getSelectedPage() - it should return AbstractTextEditor instance only when it is shown on the page. Currently, method getSelectedPage() returns the same instance of VpvEditorPart for any selected page. That does not look right to me and cannot be helpful for any feature. So, if the implementation of getSelectedPage() proposed by [~ibuziuk] solves the issue and does not break anything, I suggest applying it with or without the change to getAdapter().
was (Author: scabanovich):
[~ibuziuk], [~mickael_istria], yes, looking for adapter may help solve some cases, taking into account however that method getAdapter() should in its logic mimic getSelectedPage() - it should return AbstractTextEditor instance only when it is shown on the page. So, if the implementation of getSelectedPage() proposed by [~ibuziuk] solves the issue and does not break anything, I suggest applying it with or without the change to getAdapter().
> Zoom in / out functionality is not working with Visual Page Editor
> --------------------------------------------------------------------
>
> Key: JBIDE-22628
> URL: https://issues.jboss.org/browse/JBIDE-22628
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: visual-page-editor-core
> Affects Versions: 4.4.0.Alpha2
> Reporter: Ilya Buziuk
> Assignee: Ilya Buziuk
> Labels: upstream
> Fix For: 4.4.x
>
>
> New zoom in / out functionality (Cntl + / -) which is available in Neon is not working in Visual Page Editor. The interesting thing, that if you do Zoom in / out in the html editor which supports this functionality and reopen file again in the Visual Editor the new scale will be adjusted
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22669) SelectionBar widget returns incorrect visibility
by Rastislav Wagner (JIRA)
Rastislav Wagner created JBIDE-22669:
----------------------------------------
Summary: SelectionBar widget returns incorrect visibility
Key: JBIDE-22669
URL: https://issues.jboss.org/browse/JBIDE-22669
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: common/jst/core
Affects Versions: 4.4.0.Final
Reporter: Rastislav Wagner
Priority: Minor
Fix For: 4.4.1.M1
setVisible method doesnt call super.setVisible thus always returns true when called isVisible()
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22628) Zoom in / out functionality is not working with Visual Page Editor
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22628?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-22628:
-----------------------------------------------
[~ibuziuk], [~mickael_istria], yes, looking for adapter may help solve some cases, taking into account however that method getAdapter() should in its logic mimic getSelectedPage() - it should return AbstractTextEditor instance only when it is shown on the page. So, if the implementation of getSelectedPage() proposed by [~ibuziuk] solves the issue and does not break anything, I suggest applying it with or without the change to getAdapter().
> Zoom in / out functionality is not working with Visual Page Editor
> --------------------------------------------------------------------
>
> Key: JBIDE-22628
> URL: https://issues.jboss.org/browse/JBIDE-22628
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: visual-page-editor-core
> Affects Versions: 4.4.0.Alpha2
> Reporter: Ilya Buziuk
> Assignee: Ilya Buziuk
> Labels: upstream
> Fix For: 4.4.x
>
>
> New zoom in / out functionality (Cntl + / -) which is available in Neon is not working in Visual Page Editor. The interesting thing, that if you do Zoom in / out in the html editor which supports this functionality and reopen file again in the Visual Editor the new scale will be adjusted
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months