[JBoss JIRA] (JBIDE-21819) Freemarker syntax highlighting issues with square brackets syntax
by Daniel Dekany (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21819?page=com.atlassian.jira.plugi... ]
Daniel Dekany commented on JBIDE-21819:
---------------------------------------
The overhauled scanners of JBIDE-20180 (PR sent) happens to solve these. It's not to say that it makes square bracket syntax handling perfect (for example, if the syntax changes after you have opened the file, it won't re-scan the document automatically), but it solves the specific problems describe here.
> Freemarker syntax highlighting issues with square brackets syntax
> -----------------------------------------------------------------
>
> Key: JBIDE-21819
> URL: https://issues.jboss.org/browse/JBIDE-21819
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: freemarker
> Affects Versions: 4.3.0.Final
> Reporter: Kari Aliranta
> Fix For: LATER
>
>
> Ftl file (square syntax) highlighting seems to have two issues in the latest final, i.e.:
> 1. It needs user input to engage (except for interpolation tags, i.e. ${somevariable})
> 2. It is stopped by ${somevariable} tags that are NOT within brackets
> h2. Example
> This is best exemplified by following beginning of an actual ftl file:
> (*1*, *2* etc. with stars are my markings for referencing, and are NOT in actual FTL file)
> {code}
> *1*[#ftl attributes={"layout":"defaultLayout"} /]
> [#if cmpsContainer??]
> [#if cmpsContainer.getComponent('protocols')??]
> [#assign protocols = cmpsContainer.getComponent('protocols') /]
> [/#if]
> [/#if]
> *2*
> <script>head.load("${root}/lib/redbox.js");</script>
> *3*[(a)alerts.success placeholder="${defaultPlaceholder}" class="fade alert-fixed"]${uitags.assignmentRemoved}*4*[/(a)alerts.success]
> {code}
> The following happens:
> - When opening the file, the only things highlighted are the ${root} and ${uitags.assignmentRemoved} (considered "interpolation" in Freemarker syntax highlighting configuration)
> - You need to write anything at *1* to engage highlighting other syntax, in which case the highlighting runs up until *2*
> - You then need to write anything at *3* to continue highlighting, in which case the hightlighting stops at *4*, and you then need to write anything at *4* to make it continue
> - Note that the highlighting does NOT stop at ${defaultPlaceholder}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22574) Custom color of directives in eclipse plugin now working
by Daniel Dekany (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22574?page=com.atlassian.jira.plugi... ]
Daniel Dekany commented on JBIDE-22574:
---------------------------------------
This was "accidentally" fixed in JBIDE-20180, which already has a pull request.
> Custom color of directives in eclipse plugin now working
> --------------------------------------------------------
>
> Key: JBIDE-22574
> URL: https://issues.jboss.org/browse/JBIDE-22574
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: freemarker
> Environment: Eclipse Mars.2, FreeMarker IDE 1.5.100.Final-v20160603-0259-B419
> Reporter: Marcelo Marcelo
> Priority: Minor
> Attachments: freemarker-ide.png
>
>
> When using Freemarker IDE on eclipse, I would like to customize editor's colors, since I am using a dark theme and the editor is not readable with the default colors. However, changing the color for directives does not work as expected. It only change colors of closing tags.
> Example: <#list> remains dark blue (default color) but </#list> changes to the new color.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22659) Error marker information should come from the reconciler thread
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22659?page=com.atlassian.jira.plugi... ]
Alexey Kazakov reassigned JBIDE-22659:
--------------------------------------
Fix Version/s: 4.4.1.AM2
Assignee: Alexey Kazakov
Resolution: Done
Pushed to master. Thanks.
> Error marker information should come from the reconciler thread
> ---------------------------------------------------------------
>
> Key: JBIDE-22659
> URL: https://issues.jboss.org/browse/JBIDE-22659
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: freemarker
> Reporter: Daniel Dekany
> Assignee: Alexey Kazakov
> Fix For: 4.4.1.AM2
>
>
> The template is parsed with the actual FreeMarker parser, and the resulting exception (if any) is translated to an Eclipse error marker. The parsing happens asynchronously. This is fine so far. What's strange is that instead of relying on the standard reconciler mechanism, {{org.jboss.ide.eclipse.freemarker.editor.Editor}} tries to figure out when that information needs to be recalculated by examining the keydown events, instead of real change events. Thus it doesn't work if you are inserting text solely with mouse for example. Also the {{Editor}} tries to do this after each key stroke (unlike the reconciler mechanism, which waits until you stop typing for a moment). Also the asynchronous task execution it does has a flaw because of which sometimes ignores the last few changes.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22735) CDK Server adapter is not available in Quick Access bar when typing "cdk"
by Alexey Kazakov (JIRA)
Alexey Kazakov created JBIDE-22735:
--------------------------------------
Summary: CDK Server adapter is not available in Quick Access bar when typing "cdk"
Key: JBIDE-22735
URL: https://issues.jboss.org/browse/JBIDE-22735
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdk
Affects Versions: 4.4.0.Final
Reporter: Alexey Kazakov
Assignee: Rob Stryker
I guess this is a side effect of renaming "CDK Server Adapter" to "Container Development Environment".
We need to investigate if the only way to make the adapter available for "cdk" is to have "cdk" mentioned in the server type name.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22734) Please clarify CDK usage
by Rick Wagner (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22734?page=com.atlassian.jira.plugi... ]
Rick Wagner commented on JBIDE-22734:
-------------------------------------
[~mmalina] Thanks for that tip on the 'Run' button.
I like the idea of the brief note. That would have prevented me from taking this sub-optimal path.
> Please clarify CDK usage
> ------------------------
>
> Key: JBIDE-22734
> URL: https://issues.jboss.org/browse/JBIDE-22734
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk, docker
> Environment: CDK, as used in DevStudio and installed via Development Suite.
> Reporter: Rick Wagner
>
> * * This use case may be attributable to user error. Please weigh implementation cost accordingly. * *
> After using the Development Suite installer, the user arrives in a newly installed DevStudio instance but without clear instructions on how to use the CDK. In my first attempt, I relied upon previous CDK experience and went to a command-line to start the CDK with 'vagrant up'. This resulted in a failure of later DevStudio components.
> The proper trail is to go to the 'Servers' tab in DevStudio to bring up the environment. (Then DevStudio components like the Docker explorer will properly self-configure. This does *not* happen when the CDK is brought up manually as I had done.)
> Please consider, look for ways to prevent other users from taking a similar path. Thanks!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22269) Work with WildFly/EAP to generate unit tests on server installation layout
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22269?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-22269:
---------------------------------------
OK, thinking about it again, you're probably right that there may be a better place for this other than jbosstools-integration-tests, because this is not a bot test that requires a running eclipse at all. This is quite a simple test of the layout of EAP/WildFly. So I agree that there should be some better place for this - perhaps in the overall testsuite of EAP.
> Work with WildFly/EAP to generate unit tests on server installation layout
> --------------------------------------------------------------------------
>
> Key: JBIDE-22269
> URL: https://issues.jboss.org/browse/JBIDE-22269
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: server
> Affects Versions: 4.4.0.Alpha1
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.4.1.AM2
>
> Attachments: JBIDE-22269.mock.zip
>
>
> A task to track work on making sure changes to EAP don't inadvertently break tools when changing directory structure or important keys we read.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22269) Work with WildFly/EAP to generate unit tests on server installation layout
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22269?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-22269:
---------------------------------------
[~rob.stryker], what do you mean by official EAP test suite? If you mean something in EAP codebase, then there are no tests for layered products there. If you mean you want this to be in the set of tests EAP runs, that's what we want to do. The eap-devstudio tests that EAP QE runs as part of their testing live in the jbosstools-integration-tests repo.
I don't see how this is reactive, if it's eap qe who runs these tests with their EAP ER/DR builds.
> Work with WildFly/EAP to generate unit tests on server installation layout
> --------------------------------------------------------------------------
>
> Key: JBIDE-22269
> URL: https://issues.jboss.org/browse/JBIDE-22269
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: server
> Affects Versions: 4.4.0.Alpha1
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.4.1.AM2
>
> Attachments: JBIDE-22269.mock.zip
>
>
> A task to track work on making sure changes to EAP don't inadvertently break tools when changing directory structure or important keys we read.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22269) Work with WildFly/EAP to generate unit tests on server installation layout
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22269?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-22269:
-------------------------------------
I thought the purpose of this JIRA is to make sure that these tests get into the official EAP test suite.
Putting these tests in jbosstools-integration-tests means we will be *reactive* to changes in the upstream eap / wf. What we wanted was to be *proactive*. We wanted to be able to get faster warning if things have changed. Not us responding to their milestone releases *if* we manage to remember to update our tests in a timely fashion.
I don't think this is what we were looking for at all.
> Work with WildFly/EAP to generate unit tests on server installation layout
> --------------------------------------------------------------------------
>
> Key: JBIDE-22269
> URL: https://issues.jboss.org/browse/JBIDE-22269
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: server
> Affects Versions: 4.4.0.Alpha1
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.4.1.AM2
>
> Attachments: JBIDE-22269.mock.zip
>
>
> A task to track work on making sure changes to EAP don't inadvertently break tools when changing directory structure or important keys we read.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22734) Please clarify CDK usage
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22734?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-22734:
---------------------------------------
[~rob.stryker], maybe you missed that cdk was not started from the servers view at all. In that case neither OpenShift connection, nor Docker connection will be created.
[~rick_wagner], I would like to note that even if you start cdk from command line (and wait for it to start), you can then press the Run button in Servers view and the tools will detect it running already, will just mark it as Started and create the connections for you. Just in case you didn't know this.
I wonder how we can improve this. Perhaps at the end of the devsuite installer, just before devstudio is launched, we could briefly note that to start using CDK, you can start it from the Server view, once devstudio is launched?
> Please clarify CDK usage
> ------------------------
>
> Key: JBIDE-22734
> URL: https://issues.jboss.org/browse/JBIDE-22734
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk, docker
> Environment: CDK, as used in DevStudio and installed via Development Suite.
> Reporter: Rick Wagner
>
> * * This use case may be attributable to user error. Please weigh implementation cost accordingly. * *
> After using the Development Suite installer, the user arrives in a newly installed DevStudio instance but without clear instructions on how to use the CDK. In my first attempt, I relied upon previous CDK experience and went to a command-line to start the CDK with 'vagrant up'. This resulted in a failure of later DevStudio components.
> The proper trail is to go to the 'Servers' tab in DevStudio to bring up the environment. (Then DevStudio components like the Docker explorer will properly self-configure. This does *not* happen when the CDK is brought up manually as I had done.)
> Please consider, look for ways to prevent other users from taking a similar path. Thanks!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months