[JBoss JIRA] (JBIDE-22673) Need better duplicate IU detection when validating target platforms
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22673?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-22673:
----------------------------------------
I had a look and it seems like P2Resolver#resolve(....) doesn't fail in case of multiple versions of a singleton. We should find a way to turn this resolution result into a Provisioning action, that would then most likely fail.
> Need better duplicate IU detection when validating target platforms
> -------------------------------------------------------------------
>
> Key: JBIDE-22673
> URL: https://issues.jboss.org/browse/JBIDE-22673
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: build, target-platform
> Affects Versions: 4.4.0.Final
> Reporter: Nick Boldt
> Fix For: 4.4.1.AM1
>
>
> As discussed in JBIDE-22633, we have no way of knowing when the target platform SHOULD contain duplicate IUs, and when it should not.
> {quote}Problem is there's no way to identify easily which dupes are OK and which are not. I suppose I could crack open all the jars and see which are singletons...?
> Or add a whitelist?{quote}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22673) Need better duplicate IU detection when validating target platforms
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22673?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-22673:
----------------------------------------
I thought the TP resolution would fail when trying to resolve 2 different singletons. Maybe there's a flag for that to enable in the target-platform-validation-mojo
> Need better duplicate IU detection when validating target platforms
> -------------------------------------------------------------------
>
> Key: JBIDE-22673
> URL: https://issues.jboss.org/browse/JBIDE-22673
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: build, target-platform
> Affects Versions: 4.4.0.Final
> Reporter: Nick Boldt
> Fix For: 4.4.1.AM1
>
>
> As discussed in JBIDE-22633, we have no way of knowing when the target platform SHOULD contain duplicate IUs, and when it should not.
> {quote}Problem is there's no way to identify easily which dupes are OK and which are not. I suppose I could crack open all the jars and see which are singletons...?
> Or add a whitelist?{quote}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22689) enable baselineRepositories check to ensure timestamps increment for meta-changes too
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22689?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-22689:
----------------------------------------
Both aren't checking the same thing, so it makes sense to have different properties. Also, the tycho.baseline can have 4 different values, whereas the skip one is a boolean.
The first one verifies that we do not create some artifact with same fully-qualified versions and different content compared to last build, whereas the later one checks that we didn't forget to bump versions compared to previous release.
> enable baselineRepositories check to ensure timestamps increment for meta-changes too
> -------------------------------------------------------------------------------------
>
> Key: JBIDE-22689
> URL: https://issues.jboss.org/browse/JBIDE-22689
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.4.1.AM1
> Reporter: Nick Boldt
> Assignee: Mickael Istria
> Fix For: 4.4.1.AM2
>
>
> To make sure to report a problem if we need to upversion for a meta-change (eg., build configuration) and there's no accompanying new commit to force the timestamp to increment:
> From https://wiki.eclipse.org/Tycho/Reproducible_Version_Qualifiers
> {code:xml}
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> <version>${tycho.version}</version>
> <configuration>
> <baselineRepositories>
> <repository>
> <url>[some url]</url>
> </repository>
> </baselineRepositories>
> </configuration>
> </plugin>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22689) enable baselineRepositories check to ensure timestamps increment for meta-changes too
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22689?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-22689:
------------------------------------
I've added some inline doc (read: comments) into the parent pom to state more clearly that for THIS check, we can use *-Dtycho.baseline=disable*... unlike the other baseline check, which uses *-DskipBaselineComparison=true*. Because consistency. :(
> enable baselineRepositories check to ensure timestamps increment for meta-changes too
> -------------------------------------------------------------------------------------
>
> Key: JBIDE-22689
> URL: https://issues.jboss.org/browse/JBIDE-22689
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.4.1.AM1
> Reporter: Nick Boldt
> Assignee: Mickael Istria
> Fix For: 4.4.1.AM2
>
>
> To make sure to report a problem if we need to upversion for a meta-change (eg., build configuration) and there's no accompanying new commit to force the timestamp to increment:
> From https://wiki.eclipse.org/Tycho/Reproducible_Version_Qualifiers
> {code:xml}
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> <version>${tycho.version}</version>
> <configuration>
> <baselineRepositories>
> <repository>
> <url>[some url]</url>
> </repository>
> </baselineRepositories>
> </configuration>
> </plugin>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months