[JBoss JIRA] (JBIDE-23008) openshift.cdk.feature.source missing from JBT site; causes baseline check to fail
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23008?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-23008:
----------------------------------------
This rule is the conclusion of all discussions about require vs includes. It's not wrtten on documentation, but you can see this as a conclusion of several bugzilla tickets and mailing-list discussions (for example on the platform-releng-dev mailing-list).
Includes allow the included feature to be considered as internal and makes it not required to list it in the update-site category.xml. They get included transitively at build-time, whereas if they're marked as required, we need to make sure those are listed directly.
Decoupling is a good practice if there is value. Otherwise it's just adding complexity.
Using only plugins rather that feature would be a good thing IMO. But there are many other and so much legacy with features that make them eternal now.
PS: sorry for editing your post, I was willing to answer and tried a copy-pasted that turned out in an edit...
> openshift.cdk.feature.source missing from JBT site; causes baseline check to fail
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-23008
> URL: https://issues.jboss.org/browse/JBIDE-23008
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build, openshift, updatesite
> Affects Versions: 4.4.1.AM3
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.4.1.Final
>
>
> Since the weekend (after I published an AM3 build into /neon/staging/updates/):
> {code}
> [INFO] --- tycho-source-plugin:0.25.0:plugin-source (plugin-source) @ org.jboss.tools.openshift.cdk.server ---
> [INFO] Building jar: /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/target/org.jboss.tools.openshift.cdk.server-3.3.0-SNAPSHOT-sources.jar
> [INFO]
> [INFO] --- target-platform-configuration:0.25.0:target-platform (default-target-platform) @ org.jboss.tools.openshift.cdk.server ---
> [INFO]
> [INFO] --- tycho-packaging-plugin:0.25.0:package-plugin (default-package-plugin) @ org.jboss.tools.openshift.cdk.server ---
> [INFO] Building jar: /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/target/org.jboss.tools.openshift.cdk.server-3.3.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- tycho-p2-plugin:0.25.0:p2-metadata-default (default-p2-metadata-default) @ org.jboss.tools.openshift.cdk.server ---
> [WARNING] MavenProject: org.jboss.tools.openshift.plugins:org.jboss.tools.openshift.cdk.server:3.3.0-SNAPSHOT @ /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/pom.xml: baseline and build artifacts have same version but different contents
> [INFO] MavenProject: org.jboss.tools.openshift.plugins:org.jboss.tools.openshift.cdk.server:3.3.0-SNAPSHOT @ /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/pom.xml
> The main artifact has been replaced with the baseline version.
> The following attached artifacts are not present in the baseline and have been removed: [sources]{code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (JBIDE-22884) test failure in org.jboss.tools.vpe.jsp.test
by Ilya Buziuk (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22884?page=com.atlassian.jira.plugi... ]
Ilya Buziuk commented on JBIDE-22884:
-------------------------------------
[~nickboldt], [~akazakov] sounds good to me as a temporary solution if the jenkins setup is overhead.
> test failure in org.jboss.tools.vpe.jsp.test
> --------------------------------------------
>
> Key: JBIDE-22884
> URL: https://issues.jboss.org/browse/JBIDE-22884
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html-source-editing, visual-page-editor-core
> Affects Versions: 4.4.1.AM3
> Reporter: Nick Boldt
> Assignee: Ilya Buziuk
> Priority: Blocker
> Fix For: 4.4.1.Final
>
> Attachments: 22884.more.fail.txt, _view_.txt, _view_more.txt
>
>
> {code}
> 21:32:03 [INFO] org.jboss.tools.vpe.jsp.test ....................... FAILURE [ 01:00 h]
> 21:32:04 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.25.0:test (default-test) on project org.jboss.tools.vpe.jsp.test: An unexpected error occured while launching the test runtime (return code 143). See log for details. -> [Help 1]
> {code} -- http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-vpe_master...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (JBDS-3996) No installer jar as a result of jbdevstudio-product repo build
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3996?page=com.atlassian.jira.plugin.... ]
Nick Boldt updated JBDS-3996:
-----------------------------
Fix Version/s: 10.1.0.GA
> No installer jar as a result of jbdevstudio-product repo build
> --------------------------------------------------------------
>
> Key: JBDS-3996
> URL: https://issues.jboss.org/browse/JBDS-3996
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: build, installer
> Affects Versions: 10.1.0.AM3
> Reporter: Martin Malina
> Assignee: Nick Boldt
> Priority: Optional
> Fix For: 10.1.0.GA
>
>
> When I build the jbdevstudio-product git repo using {code}mvn clean verify -DskipTests{code}, I was expecting to have the installer jar created in installer/target/, but all I see is a installer-10.1.0-SNAPSHOT.zip , not the installer jar (which should be called devstudio*.jar).
> This was on mac and I did it because I wanted to verify this JIRA:
> JBDS-3986 support building devstudio on windows
> So I wanted to try this on another platform first.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (JBDS-3994) Local jbdevstudio-product build always fails to download sources
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3994?page=com.atlassian.jira.plugin.... ]
Nick Boldt updated JBDS-3994:
-----------------------------
Fix Version/s: 10.x
> Local jbdevstudio-product build always fails to download sources
> ----------------------------------------------------------------
>
> Key: JBDS-3994
> URL: https://issues.jboss.org/browse/JBDS-3994
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 10.1.0.AM3
> Environment: 1. No maven local repository;
> 2. latest master;
> 3. mvn clean install;
> 4. Windows 10 Home.
> Reporter: Denis Golovin
> Assignee: Nick Boldt
> Fix For: 10.x
>
>
> {code}[INFO] --- repository-utils:0.25.1-SNAPSHOT:generate-repository-facade (generate-facade) @ com.jboss.devstudio.core.site ---
> [WARNING] No C:\p\rh\jbds-releng\jbdevstudio-product\site\target\repository\web/site.css found; using default.
> [INFO] Building zip: C:\p\rh\jbds-releng\jbdevstudio-product\site\target\com.jboss.devstudio.core.site-10.1.0-SNAPSHOT.zip
> [INFO]
> [INFO] --- repository-utils:0.25.1-SNAPSHOT:fetch-sources-from-manifests (fetch-sources) @ com.jboss.devstudio.core.site ---
> [INFO] Downloaded: jbosstools-base_6ec1deba2610a94a14d160a7b54ae4f708c40044_sources.zip (23.6 M)
> [INFO] Downloaded: jbosstools-browsersim_019a66b4cef24d489c5bad2c0324477e32871222_sources.zip (3.2 M)
> [INFO] Downloaded: jbosstools-central_4cef5b7e1c70b213b372fcb5b7ba1c0834e5bff9_sources.zip (8.2 M)
> [INFO] Downloaded: jbosstools-forge_6beb7d3b3218e8b02d0497d38915574f9eaf8c1f_sources.zip (430.3 k)
> [INFO] Downloaded: jbosstools-freemarker_43ccb5369f1b9bdbd99466755af6158a3c39cea8_sources.zip (379.1 k)
> [INFO] Downloaded: jbosstools-hibernate_3e9fb83570c5c7c521f92d3f05c77b67355477d0_sources.zip (26.9 M)
> [INFO] Downloaded: jbosstools-javaee_a3e97d0495026b043ff151ac65412ba64bcfc1ff_sources.zip (46.2 M)
> [INFO] Downloaded: jbosstools-openshift_810571f6aff04eb4a4b0b986e9ad4c0f16796b25_sources.zip (1.8 M)
> [INFO] Downloaded: jbosstools-server_226292c9076be1a5e6f6779e6727fbc5d38af0be_sources.zip (34.6 M)
> [INFO] Downloaded: jbosstools-vpe_bd95b9c63a5b05bec19afe483f8224cf07c8aef8_sources.zip (3.5 M)
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] devstudio - Product, Installers .................... SUCCESS [ 0.708 s]
> [INFO] devstudio - Product Plugins - Core ................. SUCCESS [ 0.224 s]
> [INFO] com.jboss.devstudio.core ........................... SUCCESS [ 12.617 s]
> [INFO] com.jboss.devstudio.core.project.examples .......... SUCCESS [ 0.664 s]
> [INFO] com.jboss.devstudio.core.usage.branding ............ SUCCESS [ 0.823 s]
> [INFO] com.jboss.devstudio.core.central ................... SUCCESS [ 2.297 s]
> [INFO] com.jboss.devstudio.core.capabilities .............. SUCCESS [ 0.503 s]
> [INFO] devstudio - Product Features - Core ................ SUCCESS [ 0.073 s]
> [INFO] com.jboss.devstudio.core.feature ................... SUCCESS [ 1.305 s]
> [INFO] com.jboss.devstudio.core.feature.source ............ SUCCESS [ 1.219 s]
> [INFO] com.jboss.devstudio.core.capabilities.feature ...... SUCCESS [ 0.406 s]
> [INFO] com.jboss.devstudio.core.capabilities.feature.source SUCCESS [ 0.406 s]
> [INFO] com.jboss.devstudio.core.site ...................... FAILURE [04:26 min]
> [INFO] p2-director ........................................ SKIPPED
> [INFO] com.jboss.devstudio.core.p2.director ............... SKIPPED
> [INFO] p2-director ........................................ SKIPPED
> [INFO] installer .......................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 05:22 min
> [INFO] Finished at: 2016-08-10T19:36:46-07:00
> [INFO] Final Memory: 147M/1484M
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.jboss.tools.tycho-plugins:repository-utils:0.25.1-SNAPSHOT:fetch-sources-from-manifests (fetch-sources) on project com.jboss.devstudio.core.site: Problem occurred checking upstream buildinfo.json files!
> [ERROR]
> [ERROR] C:\p\rh\jbds-releng\jbdevstudio-product\site\target\buildinfo\buildinfo_jbosstools-build-sites.json
> [ERROR] contains 91249e8dd7f99e9b517cccf99b201dc263efe11a, but upstream jbosstools-build-sites project's MANIFEST.MF has Eclipse-SourceReferences
> [ERROR] commitId 337bd38cb5eb530dd039ddbbaa311fb36161e726.
> [ERROR]
> [ERROR] If you have locally built projects which are being aggregated here, ensure
> [ERROR] they are built from the latest SHA from HEAD, not a local topic branch.
> [ERROR]
> [ERROR] It's also possible that some recent changes have not yet been built upstream.
> [ERROR] If that's the case, trigger a build for the jbosstools-build-sites project
> [ERROR] to ensure that the latest commits have been built and can be aggregated here.{code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (JBIDE-23008) openshift.cdk.feature.source missing from JBT site; causes baseline check to fail
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23008?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-23008:
------------------------------------
Who wrote the rule? WHY include it? There's no need.
And decoupling them is Good Practice, IMHO.
Really, we could do away with most features and just use plugins to define dependencies. After all, I can add a featureless plugin to the update sites. (But RH Central and Eclipse Marketplace don't support installing plugins -- only features.)
> openshift.cdk.feature.source missing from JBT site; causes baseline check to fail
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-23008
> URL: https://issues.jboss.org/browse/JBIDE-23008
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build, openshift, updatesite
> Affects Versions: 4.4.1.AM3
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.4.1.Final
>
>
> Since the weekend (after I published an AM3 build into /neon/staging/updates/):
> {code}
> [INFO] --- tycho-source-plugin:0.25.0:plugin-source (plugin-source) @ org.jboss.tools.openshift.cdk.server ---
> [INFO] Building jar: /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/target/org.jboss.tools.openshift.cdk.server-3.3.0-SNAPSHOT-sources.jar
> [INFO]
> [INFO] --- target-platform-configuration:0.25.0:target-platform (default-target-platform) @ org.jboss.tools.openshift.cdk.server ---
> [INFO]
> [INFO] --- tycho-packaging-plugin:0.25.0:package-plugin (default-package-plugin) @ org.jboss.tools.openshift.cdk.server ---
> [INFO] Building jar: /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/target/org.jboss.tools.openshift.cdk.server-3.3.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- tycho-p2-plugin:0.25.0:p2-metadata-default (default-p2-metadata-default) @ org.jboss.tools.openshift.cdk.server ---
> [WARNING] MavenProject: org.jboss.tools.openshift.plugins:org.jboss.tools.openshift.cdk.server:3.3.0-SNAPSHOT @ /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/pom.xml: baseline and build artifacts have same version but different contents
> [INFO] MavenProject: org.jboss.tools.openshift.plugins:org.jboss.tools.openshift.cdk.server:3.3.0-SNAPSHOT @ /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/pom.xml
> The main artifact has been replaced with the baseline version.
> The following attached artifacts are not present in the baseline and have been removed: [sources]{code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (JBIDE-22884) test failure in org.jboss.tools.vpe.jsp.test
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22884?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-22884:
------------------------------------
Spoke with droble in #ci-ops-central and there's the potential to set up an unsupported Fedora24 slave in the new CI system. But that will require me to learn how to use all that stuff.
Shorter term, we could change the vpe job on jenkins.mw to build & publish, but NOT RUN TESTS, and then trigger a job on dev-platform-jenkins to just run the tests. WDYT?
> test failure in org.jboss.tools.vpe.jsp.test
> --------------------------------------------
>
> Key: JBIDE-22884
> URL: https://issues.jboss.org/browse/JBIDE-22884
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html-source-editing, visual-page-editor-core
> Affects Versions: 4.4.1.AM3
> Reporter: Nick Boldt
> Assignee: Ilya Buziuk
> Priority: Blocker
> Fix For: 4.4.1.Final
>
> Attachments: 22884.more.fail.txt, _view_.txt, _view_more.txt
>
>
> {code}
> 21:32:03 [INFO] org.jboss.tools.vpe.jsp.test ....................... FAILURE [ 01:00 h]
> 21:32:04 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.25.0:test (default-test) on project org.jboss.tools.vpe.jsp.test: An unexpected error occured while launching the test runtime (return code 143). See log for details. -> [Help 1]
> {code} -- http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-vpe_master...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months