[JBoss JIRA] (JBIDE-23275) Rename doesn't change fully qualified name in job.xml file
by Lukáš Valach (JIRA)
Lukáš Valach created JBIDE-23275:
------------------------------------
Summary: Rename doesn't change fully qualified name in job.xml file
Key: JBIDE-23275
URL: https://issues.jboss.org/browse/JBIDE-23275
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: batch
Affects Versions: 4.4.2.AM1
Environment: Fedora 24
Reporter: Lukáš Valach
Attachments: BatchRenameManualTest.zip
Refactoring doesn't modify job.xml when I renaming class which is referred in job.xml using the fully qualified name.
For example, when I have batchlet class
{code:java}
package test;
public class BatchletWithProperty extends AbstractBatchlet {
...
}
{code}
...and job.xml
{code:xml}
<job ...>
<step id="step1">
<batchlet ref="test.BatchletWithProperty"> <!-- linked using the fully qualified name -->
...
</batchlet>
</step>
...
</job>
{code}
...then, when I try to rename test.BatchletWithProperty the refactoring doesn't change fully qualified name in job.xml.
Renaming works properly when I refer to class using name coming from @Named annotation.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (ERT-427) Docker Image Build dialog wrong label [EBZ#502540]
by Friendly Jira Robot (JIRA)
Friendly Jira Robot created ERT-427:
---------------------------------------
Summary: Docker Image Build dialog wrong label [EBZ#502540]
Key: ERT-427
URL: https://issues.jboss.org/browse/ERT-427
Project: Eclipse Release Train
Issue Type: Task
Components: Linux Tools
Reporter: Friendly Jira Robot
Created attachment 264482
screenshot
In dialog "Docker Image Build Configuration" (accessible from right click on Dockerfile - "Package explorer" -> select Dockerfile -> "Run As" -> "Docker Image Build") is wrong label "Repository Name:", this label should be "Image Name:" or similar.
Docker Tooling:
2.2.0.201609282203
Eclipse:
Eclipse SDK
Version: Neon.1 (4.6.1)
Build id: M20160907-1200
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-23274) Rename of batch artefact should affect batch.xml file
by Lukáš Valach (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23274?page=com.atlassian.jira.plugi... ]
Lukáš Valach updated JBIDE-23274:
---------------------------------
Affects Version/s: 4.4.2.AM1
(was: 4.4.1.Final)
> Rename of batch artefact should affect batch.xml file
> -----------------------------------------------------
>
> Key: JBIDE-23274
> URL: https://issues.jboss.org/browse/JBIDE-23274
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: batch
> Affects Versions: 4.4.2.AM1
> Reporter: Lukáš Valach
> Attachments: BatchRenameManualTest.zip
>
>
> There are three ways how to refer batch artefact in job.xml file.
> * Using @Name annotation
> * Using fully qualified class name
> * Using batch.xml
> I noticed that the class name is not changed in batch.xml file during refactoring and the job.xml file become invalid for this reason.
> There is a way how to avoid this problem. User can check the "Update fully qualified names in non-Java text files" option in Rename window, but this solution is not intuitive/is not user friendly I think.
> In another case, when I don't use batch.xml and use the name comming from @Named annotation. The artefact is renamed in job.xml file even if the "Update fully qualified names in non-Java text files" option aren't selected. Non-Java text file (job.xml) is updated automatically in this case.
> There is attached project that you can use to reproduce this problem.
> [^BatchRenameManualTest.zip]. Just try to rename Writer class.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-23274) Rename of batch artefact should affect batch.xml file
by Lukáš Valach (JIRA)
Lukáš Valach created JBIDE-23274:
------------------------------------
Summary: Rename of batch artefact should affect batch.xml file
Key: JBIDE-23274
URL: https://issues.jboss.org/browse/JBIDE-23274
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: batch
Affects Versions: 4.4.1.Final
Reporter: Lukáš Valach
Attachments: BatchRenameManualTest.zip
There are three ways how to refer batch artefact in job.xml file.
* Using @Name annotation
* Using fully qualified class name
* Using batch.xml
I noticed that the class name is not changed in batch.xml file during refactoring and the job.xml file become invalid for this reason.
There is a way how to avoid this problem. User can check the "Update fully qualified names in non-Java text files" option in Rename window, but this solution is not intuitive/is not user friendly I think.
In another case, when I don't use batch.xml and use the name comming from @Named annotation. The artefact is renamed in job.xml file even if the "Update fully qualified names in non-Java text files" option aren't selected. Non-Java text file (job.xml) is updated automatically in this case.
There is attached project that you can use to reproduce this problem.
[^BatchRenameManualTest.zip]. Just try to rename Writer class.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBDS-4065) DevStudio 1.1 Installer unfriendly when 1.0 present
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBDS-4065?page=com.atlassian.jira.plugin.... ]
Martin Malina commented on JBDS-4065:
-------------------------------------
Correct me if I'm wrong, but it seems that in your existing workspace, cdk was already set up before your cleanup and new devsuite install.
Both path to Vagrantfile and path to vagrant are set up when the server adapter is created in devstudio and it is then stored in the workspace. (Credentials are stored in Eclipse Keychain - there should be one per user account.)
So if this was the case, it is kind of expected that when you set up a server adapter and then change your vagrant installation to a different directory, this server adapter will no longer work. It's true that we could possibly improve this so that vagrant is searched for each time it's needed - not just once during server adapter creation. But it could be a potentially expensive operation, so I'm not sure it's something we'd want.
> DevStudio 1.1 Installer unfriendly when 1.0 present
> ---------------------------------------------------
>
> Key: JBDS-4065
> URL: https://issues.jboss.org/browse/JBDS-4065
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: cdk, platform-installer
> Affects Versions: 10.1.0.GA
> Environment: Windows 10, DevSuite Installer 1.0 had been run
> Reporter: Rick Wagner
> Assignee: Rob Stryker
>
> When running the DevSuite 1.1 installer, DevStudio is not connected to the installed CDK.
> Observations:
> - All components removed before installation, does not help. (VirtualBox and Vagrant using Add/Remove programs, everything else directory-deleted, Environment variables cleaned).
> - DevStudio says it can't start the Container Development Environment server. ('Failed to find Vagrant!' reads the error). If I open Launch Configuration, it lists the Main as "C:\HashiCorp\Vagrant\bin\vagrant.exe", which is not in the installation directory.
> - It was noted that DevStudio marked itself 'completed' before Vagrant was installed. How does DevStudio know where Vagrant is?
> - It's noted that DevStudio 'remembers' user settings (i.e. CDK registration user/password) from previous attempts. Where is this information kept? I must've missed something in cleanup.
> - Tried full suite installation, then deleting DevStudio, then re-installing. (Hoping DevStudio would then find Vagrant in the right location, because it followed Vagrant's installation.) Result: No Container Development Environment server is present in 'server' view.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-23135) EAP 7.1 Server adapter
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23135?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-23135:
-------------------------------------
Everything seems to work, so all I did was a cosmetic change to the name strings to 7.x, but it's worth keeping this in mind in case the controller clients or protocol change more (it is a major version change). I tested for a while and so far haven't noticed anything going wrong.
I'm going to keep this open so I remember to check after each milestone.
[~mmalina] Can you please remember to use eap 7.1 when doing other arbitrary tests in the future? eap 7.1 or wf10.1 are what we should be testing generally.
> EAP 7.1 Server adapter
> ----------------------
>
> Key: JBIDE-23135
> URL: https://issues.jboss.org/browse/JBIDE-23135
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: server
> Reporter: Alexey Kazakov
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.4.2.AM3
>
>
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months