[JBoss JIRA] (JBIDE-25091) Edit resource limits wizard: setting memory resource limits errors if you use the 2 duplicate MiB entries
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25091?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov commented on JBIDE-25091:
------------------------------------------
[~adietish] i can't see an empty entry in the combo box in the web console
> Edit resource limits wizard: setting memory resource limits errors if you use the 2 duplicate MiB entries
> ---------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25091
> URL: https://issues.jboss.org/browse/JBIDE-25091
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Josef Kopriva
> Assignee: Andre Dietisheim
> Labels: edit_resource_limits_wizard, openshift_v3
> Fix For: 4.5.1.Final
>
> Attachments: edit-resource-limits.png, error-limit-must-be-equal-or-greater-than-request.png, image-2017-09-22-13-02-35-216.png, memory-limit-limit.png, memory-request-limit.png, request-resource-limit-combo.png, resource-limits-web-console.png
>
>
> When editing memory settings in dialog "Edit resource limits", there is a duplicate value MiB in the Combos for Memory > "Request" and Memory > "Limit":
> !edit-resource-limits.png!
> You can have setting the limits error inexplicably in the following way:
> # ASSERT: make sure that you have an application with a service, replication controller/deployment config running in OpenShift (ex. create one using the nodejs-mongo-persistent template)
> # EXEC: in OpenShift explorer: select the service for your application and pick "Edit resource limit" in the context menu for it
> # ASSERT: "Edit resource limit" dialog shows up
> # EXEC: set Memory > Request to 128 and pick the 1st MiB entry in the combo
> !memory-request-limit.png!
> # EXEC: set Memory > Limit to 512 and pick the 2nd MiB entry in the combo
> !memory-limit-limit.png!
> # EXEC: "Finish" the wizard
> Result:
> The wizard errors telling you that the limit must be equal or greater than the request:
> !error-limit-must-be-equal-or-greater-than-request.png!
> In the Eclipse log you find the following:
> {code}
> com.openshift.restclient.OpenShiftException: Exception trying to PUT https://192.168.64.12:8443/oapi/v1/namespaces/nodejs/deploymentconfigs/no... response code: 422 DeploymentConfig "nodejs-mongo-persistent" is invalid: spec.template.spec.containers[0].resources.limits: Invalid value: "512": must be greater than or equal to memory request
> at com.openshift.internal.restclient.okhttp.ResponseCodeInterceptor.createOpenShiftException(ResponseCodeInterceptor.java:114)
> at com.openshift.internal.restclient.okhttp.ResponseCodeInterceptor.intercept(ResponseCodeInterceptor.java:65)
> at okhttp3.RealCall$ApplicationInterceptorChain.proceed(RealCall.java:190)
> at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:163)
> at okhttp3.RealCall.execute(RealCall.java:57)
> at com.openshift.internal.restclient.DefaultClient.execute(DefaultClient.java:258)
> at com.openshift.internal.restclient.DefaultClient.execute(DefaultClient.java:222)
> at com.openshift.internal.restclient.DefaultClient.execute(DefaultClient.java:210)
> at com.openshift.internal.restclient.DefaultClient.update(DefaultClient.java:316)
> at org.jboss.tools.openshift.core.connection.Connection.updateResource(Connection.java:451)
> at org.jboss.tools.openshift.internal.ui.wizard.common.EditResourceLimitsHandler$EditResourceLimitsWizard$1.run(EditResourceLimitsHandler.java:117)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-23019) Integration tests (OpenShift): have them running automatically, continuously
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23019?page=com.atlassian.jira.plugi... ]
Josef Kopriva updated JBIDE-23019:
----------------------------------
Sprint: devex #123 November 2016, devex #128 February 2017, devex #130 April 2017, devex #139 October 2017 (was: devex #123 November 2016, devex #128 February 2017, devex #130 April 2017)
> Integration tests (OpenShift): have them running automatically, continuously
> ----------------------------------------------------------------------------
>
> Key: JBIDE-23019
> URL: https://issues.jboss.org/browse/JBIDE-23019
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: integration-tests, openshift
> Affects Versions: 4.4.1.AM3
> Reporter: Andre Dietisheim
> Assignee: Josef Kopriva
> Labels: integration_tests
> Fix For: 4.5.1.Final
>
>
> The integration tests suite is very lenghty to run and should thus be run in a continuous manner on our CI.
> There are several pain-points currently:
> - there's no dedicated OS instance to run them against
> - tests are not stable
> - etc.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25267) ITests: run by default if you build openshift
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25267?page=com.atlassian.jira.plugi... ]
Josef Kopriva updated JBIDE-25267:
----------------------------------
Description:
steps:
EXEC: run "mvn clean verify" in openshift root directory
Result:
cdk integration tests are run
Expected result:
cdk integration tests should not run
was:
steps:
EXEC: run "mvn clean verify" in openshift root directory
Result:
openshift integration tests are run
Expected result:
openshift integration tests should not run
> ITests: run by default if you build openshift
> ----------------------------------------------
>
> Key: JBIDE-25267
> URL: https://issues.jboss.org/browse/JBIDE-25267
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.Final
> Reporter: Andre Dietisheim
> Assignee: Ondrej Dockal
> Priority: Blocker
> Labels: integration_tests
> Fix For: 4.5.1.Final
>
>
> steps:
> EXEC: run "mvn clean verify" in openshift root directory
> Result:
> cdk integration tests are run
> Expected result:
> cdk integration tests should not run
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25092) Edit resource limits wizard: Move labels
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25092?page=com.atlassian.jira.plugi... ]
Josef Kopriva updated JBIDE-25092:
----------------------------------
Sprint: (was: devex #140 November 2017)
> Edit resource limits wizard: Move labels
> -----------------------------------------
>
> Key: JBIDE-25092
> URL: https://issues.jboss.org/browse/JBIDE-25092
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Josef Kopriva
> Assignee: Andre Dietisheim
> Priority: Minor
> Labels: edit_resource_limits_wizard, openshift_v3
> Fix For: 4.5.1.Final
>
> Attachments: edit-resource-limits.png
>
>
> Please move labels for CPU and memory a little bit up (reduce the vertical space btw. the text field & label and the upper border of the group they're in). The labels also miss the ":", which is the standard for widget labels in Eclipse.
> !edit-resource-limits.png!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25092) Edit resource limits wizard: Move labels
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25092?page=com.atlassian.jira.plugi... ]
Josef Kopriva closed JBIDE-25092.
---------------------------------
Labels are reworked and it looks much better, so closing.
Verified in:
Red Hat JBoss Developer Studio
Version: 11.1.0.GA
Build id: GA-v20171023-0421-B1441
Build date: 20171023-0421
> Edit resource limits wizard: Move labels
> -----------------------------------------
>
> Key: JBIDE-25092
> URL: https://issues.jboss.org/browse/JBIDE-25092
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Josef Kopriva
> Assignee: Andre Dietisheim
> Priority: Minor
> Labels: edit_resource_limits_wizard, openshift_v3
> Fix For: 4.5.1.Final
>
> Attachments: edit-resource-limits.png
>
>
> Please move labels for CPU and memory a little bit up (reduce the vertical space btw. the text field & label and the upper border of the group they're in). The labels also miss the ":", which is the standard for widget labels in Eclipse.
> !edit-resource-limits.png!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25108) Server adapter editor: can be saved even if there are errors
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25108?page=com.atlassian.jira.plugi... ]
Josef Kopriva closed JBIDE-25108.
---------------------------------
Closing: it works as expected, please follow linked JIRAs.
Verified in:
Red Hat JBoss Developer Studio
Version: 11.1.0.GA
Build id: GA-v20171023-0421-B1441
Build date: 20171023-0421
> Server adapter editor: can be saved even if there are errors
> ------------------------------------------------------------
>
> Key: JBIDE-25108
> URL: https://issues.jboss.org/browse/JBIDE-25108
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.5.1.Final
>
>
> # ASSERT: have a server editor for an application running on OpenShift
> # EXEC: open the editor
> # EXEC: uncheck "use image provided key" but no value for "Key" (which is an error)
> Result:
> editor gets dirty and can be saved
> Expected:
> editor does not get dirty and cannot be saved since it has errors
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months