[JBoss JIRA] (JBIDE-25228) target platform fix-version and targetToRepoMojo no longer able to find multiple IU versions
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25228?page=com.atlassian.jira.plugi... ]
Mickael Istria edited comment on JBIDE-25228 at 10/13/17 12:23 PM:
-------------------------------------------------------------------
;../So
{code:java}tpResolver.addDependency(ArtifactType.TYPE_INSTALLABLE_UNIT , unit.getId(), unit.getVersion());{code}
is most likely the cause of the issue. It should be something like
{code:java}
String version = unit.getVersion();
if (version == null || version.isEmpty()) {
version = "0.0.0";
} else if (!"0.0.0".equals(unit.getVersion()) {
version = '[' + unit.getVersion() + ',' + unit.getVersion() + ']';
}
tpResolver.addDependency(ArtifactType.TYPE_INSTALLABLE_UNIT , unit.getId(), version);
{code}
to make sure we lock to the resolved version and not to a range (just "1.6.0.xyz" actually means [1.6.0.xyz, 2.0.0) to p2 resolver IIRC)
was (Author: mickael_istria):
;../So
{code}tpResolver.addDependency(ArtifactType.TYPE_INSTALLABLE_UNIT , unit.getId(), unit.getVersion());{code}
is most likely the cause of the issue. It should be something like
{code}
String version = unit.getVersion();
if (version == null || version.isEmpty()) {
version = "0.0.0";
} else if ("0.0.0.equals(unit.getVersion()) {
version = '[' + unit.getVersion() + ',' + unit.getVersion() + ']';
}
tpResolver.addDependency(ArtifactType.TYPE_INSTALLABLE_UNIT , unit.getId(), version);
{code}
to make sure we lock to the resolved version and not to a range (just "1.6.0.xyz" actually means [1.6.0.xyz, 2.0.0) to p2 resolver IIRC)
> target platform fix-version and targetToRepoMojo no longer able to find multiple IU versions
> --------------------------------------------------------------------------------------------
>
> Key: JBIDE-25228
> URL: https://issues.jboss.org/browse/JBIDE-25228
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: target-platform
> Affects Versions: 4.5.1.Final
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Blocker
> Fix For: 4.5.1.Final
>
>
> With these recent changes [0], [1], target platform resolution is no longer able to fetch more than one version of an IU.
> We need apache.commons.codec 1.6.0.v201305230611, per the .target file [2], but only org.apache.commons.codec_1.9.0.v20170208-1614.jar is found in the update site [3], so the job [4] cannot perform an installation and validation of the TP fails.
> Is there a setting I can pass in to make TargetToRepo more greedy about pulling multiple versions of IUs?
> Note too that I was having problems last night getting the fix-version mojo to properly find and update the versions of WTP in the new 3.9.1a site, even when explicitly setting 0.0.0 to force it to search and update. Seems the target platform resolver will only pull the latest version of an IU, rather than an older one (a few WTP features have gone backwards in their timestamp). But it could also not resolve a version change from 3.3.600 [5] to 3.3.601 [6], so I had to update the version manually.
> [0] https://github.com/jbosstools/jbosstools-maven-plugins/commit/2b724eceadb...
> [1] https://github.com/jbosstools/jbosstools-maven-plugins/commit/ac4e492fab4...
> [2] https://github.com/jbosstools/jbosstools-target-platforms/blob/4.71.x/jbo...
> [3] http://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/4.7...
> [4] https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstoo...
> [5] https://github.com/jbosstools/jbosstools-target-platforms/blob/14ec465a9b...
> [6] https://github.com/jbosstools/jbosstools-target-platforms/blob/4.71.x/jbo...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25228) target platform fix-version and targetToRepoMojo no longer able to find multiple IU versions
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25228?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-25228:
----------------------------------------
;../So
{code}tpResolver.addDependency(ArtifactType.TYPE_INSTALLABLE_UNIT , unit.getId(), unit.getVersion());{code}
is most likely the cause of the issue. It should be something like
{code}
String version = unit.getVersion();
if (version == null || version.isEmpty()) {
version = "0.0.0";
} else if ("0.0.0.equals(unit.getVersion()) {
version = '[' + unit.getVersion() + ',' + unit.getVersion() + ']';
}
tpResolver.addDependency(ArtifactType.TYPE_INSTALLABLE_UNIT , unit.getId(), version);
{code}
to make sure we lock to the resolved version and not to a range (just "1.6.0.xyz" actually means [1.6.0.xyz, 2.0.0) to p2 resolver IIRC)
> target platform fix-version and targetToRepoMojo no longer able to find multiple IU versions
> --------------------------------------------------------------------------------------------
>
> Key: JBIDE-25228
> URL: https://issues.jboss.org/browse/JBIDE-25228
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: target-platform
> Affects Versions: 4.5.1.Final
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Blocker
> Fix For: 4.5.1.Final
>
>
> With these recent changes [0], [1], target platform resolution is no longer able to fetch more than one version of an IU.
> We need apache.commons.codec 1.6.0.v201305230611, per the .target file [2], but only org.apache.commons.codec_1.9.0.v20170208-1614.jar is found in the update site [3], so the job [4] cannot perform an installation and validation of the TP fails.
> Is there a setting I can pass in to make TargetToRepo more greedy about pulling multiple versions of IUs?
> Note too that I was having problems last night getting the fix-version mojo to properly find and update the versions of WTP in the new 3.9.1a site, even when explicitly setting 0.0.0 to force it to search and update. Seems the target platform resolver will only pull the latest version of an IU, rather than an older one (a few WTP features have gone backwards in their timestamp). But it could also not resolve a version change from 3.3.600 [5] to 3.3.601 [6], so I had to update the version manually.
> [0] https://github.com/jbosstools/jbosstools-maven-plugins/commit/2b724eceadb...
> [1] https://github.com/jbosstools/jbosstools-maven-plugins/commit/ac4e492fab4...
> [2] https://github.com/jbosstools/jbosstools-target-platforms/blob/4.71.x/jbo...
> [3] http://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/4.7...
> [4] https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstoo...
> [5] https://github.com/jbosstools/jbosstools-target-platforms/blob/14ec465a9b...
> [6] https://github.com/jbosstools/jbosstools-target-platforms/blob/4.71.x/jbo...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25228) target platform fix-version and targetToRepoMojo no longer able to find multiple IU versions
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25228?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-25228:
----------------------------------------
This is a bug in the Mojo for sure.
The buildLog is interesting: it shows that TP validation mentions org.apache.commons.codec 1.6.0.v201305230611 (good); then later the MirrorMojo talks about 1.9.0. It seems like either the change in MirrorMojo fails at properly resolve TP and decides to use 1.9.0 (and pass it to the code doing the mirroring), or the TP resolution is correct, but the mirror step ignores the version. I'll compare the TP Validation Mojo and the Mirror one and see whether it could be a few settings missing to the code doing the TP resolution.
> target platform fix-version and targetToRepoMojo no longer able to find multiple IU versions
> --------------------------------------------------------------------------------------------
>
> Key: JBIDE-25228
> URL: https://issues.jboss.org/browse/JBIDE-25228
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: target-platform
> Affects Versions: 4.5.1.Final
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Blocker
> Fix For: 4.5.1.Final
>
>
> With these recent changes [0], [1], target platform resolution is no longer able to fetch more than one version of an IU.
> We need apache.commons.codec 1.6.0.v201305230611, per the .target file [2], but only org.apache.commons.codec_1.9.0.v20170208-1614.jar is found in the update site [3], so the job [4] cannot perform an installation and validation of the TP fails.
> Is there a setting I can pass in to make TargetToRepo more greedy about pulling multiple versions of IUs?
> Note too that I was having problems last night getting the fix-version mojo to properly find and update the versions of WTP in the new 3.9.1a site, even when explicitly setting 0.0.0 to force it to search and update. Seems the target platform resolver will only pull the latest version of an IU, rather than an older one (a few WTP features have gone backwards in their timestamp). But it could also not resolve a version change from 3.3.600 [5] to 3.3.601 [6], so I had to update the version manually.
> [0] https://github.com/jbosstools/jbosstools-maven-plugins/commit/2b724eceadb...
> [1] https://github.com/jbosstools/jbosstools-maven-plugins/commit/ac4e492fab4...
> [2] https://github.com/jbosstools/jbosstools-target-platforms/blob/4.71.x/jbo...
> [3] http://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/4.7...
> [4] https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstoo...
> [5] https://github.com/jbosstools/jbosstools-target-platforms/blob/14ec465a9b...
> [6] https://github.com/jbosstools/jbosstools-target-platforms/blob/4.71.x/jbo...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill code is reviewed
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-24671:
------------------------------------
The bot doesn't need admin access. I updated my comment when I realized that even with protected master branch in jbosstools-fuse, I can still auto-updated root pom when it's time to move to a new parent pom version.
> [jbosstools-openshift] Block PRs for merge untill code is reviewed
> ------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Dmitrii Bocharov
> Fix For: 4.5.1.Final
>
> Attachments: bot-admin-openshift.png, protected-master-branch.png
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25221) [jbosstools-openshift] Block PRs for merge untill review (approved by other team members)
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25221?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-25221:
-------------------------------
Summary: [jbosstools-openshift] Block PRs for merge untill review (approved by other team members) (was: Block PRs for merge untill review (approved by other team members))
> [jbosstools-openshift] Block PRs for merge untill review (approved by other team members)
> -----------------------------------------------------------------------------------------
>
> Key: JBIDE-25221
> URL: https://issues.jboss.org/browse/JBIDE-25221
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Dmitrii Bocharov
> Assignee: Jeff MAURY
> Fix For: 4.5.1.Final
>
> Attachments: protected_branch_only_for_review.png
>
>
> There is a possibility in github to "protect" branch from merge based on the approval status, not on the Jenkins status as it is described in JBIDE-24439. See the attached image for details.
> [~adietish] and [~jeffmaury] agreed with this idea in the mattermost.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months