[JBoss JIRA] (JBIDE-25350) CDK server editor's launch configuration should not offers to edit some fields
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25350?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-25350:
--------------------------------
Fix Version/s: 4.5.2.AM2
(was: 4.5.x)
> CDK server editor's launch configuration should not offers to edit some fields
> ------------------------------------------------------------------------------
>
> Key: JBIDE-25350
> URL: https://issues.jboss.org/browse/JBIDE-25350
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk
> Affects Versions: 4.5.1.Final
> Reporter: Ondrej Dockal
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.2.AM2
>
>
> I noticed some inconsistent behavior in launch configuration dialog.
> 1. Server name change in server's editor do not result in changing of text "Name:" in launch configuration (should be, possibly a bug) and vice versa.
> 2. Change of Minishift Binary in editor results in change of "Location" in launch config, but not vice versa. This is not a bug, it is just confusing the user.
> I believe that it should not be possible to edit those two fields in launch configuration. First reason for this is that we already have a place where we can edit server's name and location (in cdk server editor) and other reason will be that if we will allow to edit those values, we must put validation in place. WDYT [~mmalina] [~rob.stryker] ?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 4 months
[JBoss JIRA] (JBDS-4592) Container Development Environment 3.2+ marked as started after minishift failure
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBDS-4592?page=com.atlassian.jira.plugin.... ]
Rob Stryker resolved JBDS-4592.
-------------------------------
Resolution: Rejected
Again, I believe the reason the server adapter is 'started' is because the command 'minishift status' returns that it is started.
I cannot debug your registration failures, and can't know what's causing them. But, my experience has been that when registration errors occur, the underlying minishift command (and virtualbox / kvm / etc) all think the VM is up and running. So my server adapter keeps the state that matches minishift status.
This is intentional. If I mark the server as stopped, but minishift status still thinks it's running, the next attempt to start the cdk will be a no-op, because the very first thing I'll do is check minishift status, which will tell me the cdk is up and running.
ONLY IF you can show me that the server adapter is 'started' but 'minishift status' shows its stopped, will this be a bug. Without proving that, this is intended behavior.
Closing. Please re-open if you can prove that the server adapter and the command line are out-of-sync or returning different things.
> Container Development Environment 3.2+ marked as started after minishift failure
> ---------------------------------------------------------------------------------
>
> Key: JBDS-4592
> URL: https://issues.jboss.org/browse/JBDS-4592
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: cdk, runtime
> Affects Versions: 11.1.0.GA
> Environment: Red Hat JBoss Developer Studio
> Version: 11.1.0.GA
> Build id: GA-v20171023-1808-B1449
> OS: Windows 10, v.10.0, x86_64 / win32
> Reporter: Denis Golovin
> Assignee: Rob Stryker
> Fix For: 11.2.0.AM2
>
> Attachments: image.png
>
>
> Running Latest DevStudio nightly I am getting error during CDK 3.2.0-rc.1 start in server console
> {code}-- Starting local OpenShift cluster using 'virtualbox' hypervisor ...
> -- Minishift VM will be configured with ...
> Memory: 4 GB
> vCPUs : 2
> Disk size: 20 GB
> -- Starting Minishift VM ....................................... OK
> -- Registering machine using subscription-manager
> Registration in progress ................. FAIL [41s]
> Error to register VM: ssh command error:
> command : sudo -E subscription-manager register --auto-attach --username user(a)gmail.com --password 'password'
> err : exit status 70
> output : Network error, unable to connect to server. Please see /var/log/rhsm/rhsm.log for more information.
> Registering to: subscription.rhsm.redhat.com:443/subscription
> The system has been registered with ID: e3f3d67d-c835-4f7c-a2e9-ac9d94b9e2ef {code}
> CDK is still marked as started in servers view.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 4 months
[JBoss JIRA] (JBDS-4592) Container Development Environment 3.2+ marked as started after minishift failure
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBDS-4592?page=com.atlassian.jira.plugin.... ]
Rob Stryker updated JBDS-4592:
------------------------------
Fix Version/s: 11.2.0.AM2
> Container Development Environment 3.2+ marked as started after minishift failure
> ---------------------------------------------------------------------------------
>
> Key: JBDS-4592
> URL: https://issues.jboss.org/browse/JBDS-4592
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: cdk, runtime
> Affects Versions: 11.1.0.GA
> Environment: Red Hat JBoss Developer Studio
> Version: 11.1.0.GA
> Build id: GA-v20171023-1808-B1449
> OS: Windows 10, v.10.0, x86_64 / win32
> Reporter: Denis Golovin
> Assignee: Rob Stryker
> Fix For: 11.2.0.AM2
>
> Attachments: image.png
>
>
> Running Latest DevStudio nightly I am getting error during CDK 3.2.0-rc.1 start in server console
> {code}-- Starting local OpenShift cluster using 'virtualbox' hypervisor ...
> -- Minishift VM will be configured with ...
> Memory: 4 GB
> vCPUs : 2
> Disk size: 20 GB
> -- Starting Minishift VM ....................................... OK
> -- Registering machine using subscription-manager
> Registration in progress ................. FAIL [41s]
> Error to register VM: ssh command error:
> command : sudo -E subscription-manager register --auto-attach --username user(a)gmail.com --password 'password'
> err : exit status 70
> output : Network error, unable to connect to server. Please see /var/log/rhsm/rhsm.log for more information.
> Registering to: subscription.rhsm.redhat.com:443/subscription
> The system has been registered with ID: e3f3d67d-c835-4f7c-a2e9-ac9d94b9e2ef {code}
> CDK is still marked as started in servers view.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 4 months
[JBoss JIRA] (JBIDE-25350) CDK server editor's launch configuration should not offers to edit some fields
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25350?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-25350:
-------------------------------------
https://github.com/jbosstools/jbosstools-openshift/pull/1625/files
This PR will make the command text field disabled, and remove the browse button.
It will also appear to rename the launch config with the name of the server. This is only cosmetic unless the user saves the change.
This PR will not (and cannot) disable the Text Field which allows the user to rename the launch configuration. My code has no ability to access those widgets, as they are not in any tab or tab group, but rather part of the container itself. We cannot access that text field to disable it.
> CDK server editor's launch configuration should not offers to edit some fields
> ------------------------------------------------------------------------------
>
> Key: JBIDE-25350
> URL: https://issues.jboss.org/browse/JBIDE-25350
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk
> Affects Versions: 4.5.1.Final
> Reporter: Ondrej Dockal
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.x
>
>
> I noticed some inconsistent behavior in launch configuration dialog.
> 1. Server name change in server's editor do not result in changing of text "Name:" in launch configuration (should be, possibly a bug) and vice versa.
> 2. Change of Minishift Binary in editor results in change of "Location" in launch config, but not vice versa. This is not a bug, it is just confusing the user.
> I believe that it should not be possible to edit those two fields in launch configuration. First reason for this is that we already have a place where we can edit server's name and location (in cdk server editor) and other reason will be that if we will allow to edit those values, we must put validation in place. WDYT [~mmalina] [~rob.stryker] ?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 4 months
[JBoss JIRA] (JBIDE-24804) UnsupportedOperationException below ResourceLabelsPageModel.dispose (thrown in Collections$UnmodifiableCollection.clear)
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24804?page=com.atlassian.jira.plugi... ]
Rob Stryker reassigned JBIDE-24804:
-----------------------------------
Assignee: Rob Stryker (was: Dmitrii Bocharov)
> UnsupportedOperationException below ResourceLabelsPageModel.dispose (thrown in Collections$UnmodifiableCollection.clear)
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24804
> URL: https://issues.jboss.org/browse/JBIDE-24804
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Assignee: Rob Stryker
> Fix For: 4.5.2.AM2
>
>
> The following problem was reported via the automated error reporting:
> Message:
> java.lang.UnsupportedOperationException: null
> at java.util.Collections$UnmodifiableCollection.clear(Collections.java:1074)
> at org.jboss.tools.openshift.internal.ui.wizard.common.ResourceLabelsPageModel.dispose(ResourceLabelsPageModel.java:87)
> at org.jboss.tools.openshift.internal.ui.wizard.deployimage.DeployImageWizardModel.dispose(DeployImageWizardModel.java:102)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.fromimage.ApplicationSourceFromImageModel.dispose(ApplicationSourceFromImageModel.java:267)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.NewApplicationWizard.dispose(NewApplicationWizard.java:189)
> at org.eclipse.jface.wizard.WizardDialog.hardClose(WizardDialog.java:837)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:798)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:423)
> at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:618)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> Bundles:
> | org.eclipse.jface | 3.12.2.v20170113-2113 | 3.12.2.v20170113-2113 |
> | org.eclipse.swt | 3.105.3.v20170228-0512 | 3.105.3.v20170228-0512 |
> | org.jboss.tools.openshift.ui | 3.3.3.v20170510-2204 | 3.3.3.v20170510-2204 |
> Operating Systems:
> | MacOSX | 10.12.5 | 10.12.5 |
> The above information is a snapshot of the collected data. Visit https://aer.ctrlflow.com/redhat/reviewers/#!/problems/5986d628e4b007cf146... for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 4 months
[JBoss JIRA] (JBIDE-24804) UnsupportedOperationException below ResourceLabelsPageModel.dispose (thrown in Collections$UnmodifiableCollection.clear)
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24804?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-24804:
--------------------------------
Fix Version/s: 4.5.2.AM2
(was: 4.5.x)
> UnsupportedOperationException below ResourceLabelsPageModel.dispose (thrown in Collections$UnmodifiableCollection.clear)
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24804
> URL: https://issues.jboss.org/browse/JBIDE-24804
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
> Assignee: Dmitrii Bocharov
> Fix For: 4.5.2.AM2
>
>
> The following problem was reported via the automated error reporting:
> Message:
> java.lang.UnsupportedOperationException: null
> at java.util.Collections$UnmodifiableCollection.clear(Collections.java:1074)
> at org.jboss.tools.openshift.internal.ui.wizard.common.ResourceLabelsPageModel.dispose(ResourceLabelsPageModel.java:87)
> at org.jboss.tools.openshift.internal.ui.wizard.deployimage.DeployImageWizardModel.dispose(DeployImageWizardModel.java:102)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.fromimage.ApplicationSourceFromImageModel.dispose(ApplicationSourceFromImageModel.java:267)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.NewApplicationWizard.dispose(NewApplicationWizard.java:189)
> at org.eclipse.jface.wizard.WizardDialog.hardClose(WizardDialog.java:837)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:798)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:423)
> at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:618)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> Bundles:
> | org.eclipse.jface | 3.12.2.v20170113-2113 | 3.12.2.v20170113-2113 |
> | org.eclipse.swt | 3.105.3.v20170228-0512 | 3.105.3.v20170228-0512 |
> | org.jboss.tools.openshift.ui | 3.3.3.v20170510-2204 | 3.3.3.v20170510-2204 |
> Operating Systems:
> | MacOSX | 10.12.5 | 10.12.5 |
> The above information is a snapshot of the collected data. Visit https://aer.ctrlflow.com/redhat/reviewers/#!/problems/5986d628e4b007cf146... for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 4 months
[JBoss JIRA] (JBIDE-25258) Integration Tests: Server adapter wizard and editor dont allow invalid devmode-/debug-port-key nor debug port value
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25258?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25258:
-------------------------------------
Story Points: 8
> Integration Tests: Server adapter wizard and editor dont allow invalid devmode-/debug-port-key nor debug port value
> -------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25258
> URL: https://issues.jboss.org/browse/JBIDE-25258
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter_editor, server_adapter_wizard
> Fix For: 4.5.2.AM2
>
> Attachments: server-adapter-wizard.png, server-adater-editor.png
>
>
> In JBIDE-25108 the server adapter wizard and -editor were changed so that they would only allow valid values for
> * devmode key
> * debug port key
> * debug port value
> The editor should not allow saving if there are invalid values, the wizard would not allow one to finish it.
> !server-adater-editor.png|thumbnail!
> !server-adapter-wizard.png|thumbnail!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 4 months