[JBoss JIRA] (JBIDE-23961) Server adapter: "Start/Restart in Debug" is broken for Nodejs
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23961?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-23961:
------------------------------------------
The cause for this is the following:
In JBIDE-22362 we always enabled DEV_MODE. When launching the debugger one finds the following code that checks if the debugging is enabled:
{code:title=OpenShiftDebugUtils#getDebuggingContext}
debugContext.setDebugEnabled(Boolean.parseBoolean(debugEnabled) || Boolean.parseBoolean(devModeEnabled));
{code}
Thus when the server adapter starts the debugger he erroneously thinks that debugging is already active and wont reenable it.
changing it to
{code}
debugContext.setDebugEnabled(Boolean.parseBoolean(debugEnabled));
{code}
But I'm very unsure about the side-effects. Maybe this now is only true for nodejs and will affect eap, too.
> Server adapter: "Start/Restart in Debug" is broken for Nodejs
> -------------------------------------------------------------
>
> Key: JBIDE-23961
> URL: https://issues.jboss.org/browse/JBIDE-23961
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.3.Final
> Reporter: Andre Dietisheim
> Priority: Critical
> Attachments: image-2017-02-16-23-30-21-709.png, server-adapter-erroneous-debugging-state.png
>
>
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (JBIDE-23961) Server adapter: "Start/Restart in Debug" is broken for Nodejs
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23961?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-23961:
-------------------------------------
Steps to Reproduce:
# ASSERT: have a nodejs application running in OpenShift, the project imported to your workspace and a server adapter created for it.
# EXEC: pick your server adapter for your nodejs application and choose "Restart in Debug" or "Debug" (depending on if the adapter already is started or not) from the context menu
Result:
!image-2017-02-16-23-30-21-709.png!
You get an error popping up that tells you that your server adapter could not be launched.
In the Eclipse log you'll spot the following:
{code}
java.lang.IllegalArgumentException: port out of range:-1
at java.net.InetSocketAddress.checkPort(InetSocketAddress.java:143)
at java.net.InetSocketAddress.<init>(InetSocketAddress.java:224)
at org.eclipse.wst.jsdt.chromium.debug.core.model.JavascriptVmEmbedderFactory.connectToStandalone(JavascriptVmEmbedderFactory.java:193)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.StandaloneV8LaunchType.createConnectionToRemote(StandaloneV8LaunchType.java:30)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.LaunchTypeBase.launch(LaunchTypeBase.java:69)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:1039)
at org.eclipse.debug.internal.ui.DebugUIPlugin$8.run(DebugUIPlugin.java:1256)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
{code}
Notice how the server adapter is in debugging state even though the debugger is not launched/attached:
!server-adapter-erroneous-debugging-state.png!
was:
# ASSERT: have a nodejs application running in OpenShift, the project imported to your workspace and a server adapter created for it.
# EXEC: pick your server adapter for your nodejs application and choose "Restart in Debug" from the context menu
Result:
!image-2017-02-16-23-30-21-709.png!
You get an error popping up that tells you that your server adapter could not be launched.
In the Eclipse log you'll spot the following:
{code}
java.lang.IllegalArgumentException: port out of range:-1
at java.net.InetSocketAddress.checkPort(InetSocketAddress.java:143)
at java.net.InetSocketAddress.<init>(InetSocketAddress.java:224)
at org.eclipse.wst.jsdt.chromium.debug.core.model.JavascriptVmEmbedderFactory.connectToStandalone(JavascriptVmEmbedderFactory.java:193)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.StandaloneV8LaunchType.createConnectionToRemote(StandaloneV8LaunchType.java:30)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.LaunchTypeBase.launch(LaunchTypeBase.java:69)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:1039)
at org.eclipse.debug.internal.ui.DebugUIPlugin$8.run(DebugUIPlugin.java:1256)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
{code}
Notice how the server adapter is in debugging state even though the debugger is not launched/attached:
!server-adapter-erroneous-debugging-state.png!
> Server adapter: "Start/Restart in Debug" is broken for Nodejs
> -------------------------------------------------------------
>
> Key: JBIDE-23961
> URL: https://issues.jboss.org/browse/JBIDE-23961
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.3.Final
> Reporter: Andre Dietisheim
> Priority: Critical
> Attachments: image-2017-02-16-23-30-21-709.png, server-adapter-erroneous-debugging-state.png
>
>
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (JBIDE-23961) Server adapter: "Restart in Debug" is broken for Nodejs
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23961?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-23961:
-------------------------------------
Steps to Reproduce:
# ASSERT: have a nodejs application running in OpenShift, the project imported to your workspace and a server adapter created for it.
# EXEC: pick your server adapter for your nodejs application and choose "Restart in Debug" from the context menu
Result:
!image-2017-02-16-23-30-21-709.png!
You get an error popping up that tells you that your server adapter could not be launched.
In the Eclipse log you'll spot the following:
{code}
java.lang.IllegalArgumentException: port out of range:-1
at java.net.InetSocketAddress.checkPort(InetSocketAddress.java:143)
at java.net.InetSocketAddress.<init>(InetSocketAddress.java:224)
at org.eclipse.wst.jsdt.chromium.debug.core.model.JavascriptVmEmbedderFactory.connectToStandalone(JavascriptVmEmbedderFactory.java:193)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.StandaloneV8LaunchType.createConnectionToRemote(StandaloneV8LaunchType.java:30)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.LaunchTypeBase.launch(LaunchTypeBase.java:69)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:1039)
at org.eclipse.debug.internal.ui.DebugUIPlugin$8.run(DebugUIPlugin.java:1256)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
{code}
Notice how the server adapter is in debugging state even though the debugger is not launched/attached:
!server-adapter-erroneous-debugging-state.png!
was:
# ASSERT: have a nodejs application running in OpenShift, the project imported to your workspace and a server adapter created for it.
# EXEC: pick your server adapter for your nodejs application and choose "Restart in Debug" from the context menu
Result:
!image-2017-02-16-23-30-21-709.png!
You get an error popping up that tells you that your server adapter could not be launched.
In the Eclipse log you'll spot the following:
{code}
java.lang.IllegalArgumentException: port out of range:-1
at java.net.InetSocketAddress.checkPort(InetSocketAddress.java:143)
at java.net.InetSocketAddress.<init>(InetSocketAddress.java:224)
at org.eclipse.wst.jsdt.chromium.debug.core.model.JavascriptVmEmbedderFactory.connectToStandalone(JavascriptVmEmbedderFactory.java:193)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.StandaloneV8LaunchType.createConnectionToRemote(StandaloneV8LaunchType.java:30)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.LaunchTypeBase.launch(LaunchTypeBase.java:69)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:1039)
at org.eclipse.debug.internal.ui.DebugUIPlugin$8.run(DebugUIPlugin.java:1256)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
{code}
Notice how the server adapter is in debugging state even though the debugger is not launched/attached
!server-adapter-erroneous-debugging-state.png!
> Server adapter: "Restart in Debug" is broken for Nodejs
> -------------------------------------------------------
>
> Key: JBIDE-23961
> URL: https://issues.jboss.org/browse/JBIDE-23961
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.3.Final
> Reporter: Andre Dietisheim
> Priority: Critical
> Attachments: image-2017-02-16-23-30-21-709.png, server-adapter-erroneous-debugging-state.png
>
>
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (JBIDE-23961) Server adapter: "Restart in Debug" is broken for Nodejs
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23961?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-23961:
-------------------------------------
Steps to Reproduce:
# ASSERT: have a nodejs application running in OpenShift, the project imported to your workspace and a server adapter created for it.
# EXEC: pick your server adapter for your nodejs application and choose "Restart in Debug" from the context menu
Result:
!image-2017-02-16-23-30-21-709.png!
You get an error popping up that tells you that your server adapter could not be launched.
In the Eclipse log you'll spot the following:
{code}
java.lang.IllegalArgumentException: port out of range:-1
at java.net.InetSocketAddress.checkPort(InetSocketAddress.java:143)
at java.net.InetSocketAddress.<init>(InetSocketAddress.java:224)
at org.eclipse.wst.jsdt.chromium.debug.core.model.JavascriptVmEmbedderFactory.connectToStandalone(JavascriptVmEmbedderFactory.java:193)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.StandaloneV8LaunchType.createConnectionToRemote(StandaloneV8LaunchType.java:30)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.LaunchTypeBase.launch(LaunchTypeBase.java:69)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:1039)
at org.eclipse.debug.internal.ui.DebugUIPlugin$8.run(DebugUIPlugin.java:1256)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
{code}
Notice how the server adapter is in debugging state even though the debugger is not launched/attached
!server-adapter-erroneous-debugging-state.png!
was:
# ASSERT: have a nodejs application running in OpenShift, the project imported to your workspace and a server adapter created for it.
# EXEC: pick your server adapter for your nodejs application and choose "Restart in Debug" from the context menu
Result:
!image-2017-02-16-23-30-21-709.png!
You get an error popping up that tells you that your server adapter could not be launched.
In the Eclipse log you'll spot the following:
{code}
java.lang.IllegalArgumentException: port out of range:-1
at java.net.InetSocketAddress.checkPort(InetSocketAddress.java:143)
at java.net.InetSocketAddress.<init>(InetSocketAddress.java:224)
at org.eclipse.wst.jsdt.chromium.debug.core.model.JavascriptVmEmbedderFactory.connectToStandalone(JavascriptVmEmbedderFactory.java:193)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.StandaloneV8LaunchType.createConnectionToRemote(StandaloneV8LaunchType.java:30)
at org.eclipse.wst.jsdt.chromium.debug.ui.launcher.LaunchTypeBase.launch(LaunchTypeBase.java:69)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:1039)
at org.eclipse.debug.internal.ui.DebugUIPlugin$8.run(DebugUIPlugin.java:1256)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
{code}
> Server adapter: "Restart in Debug" is broken for Nodejs
> -------------------------------------------------------
>
> Key: JBIDE-23961
> URL: https://issues.jboss.org/browse/JBIDE-23961
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.3.Final
> Reporter: Andre Dietisheim
> Priority: Critical
> Attachments: image-2017-02-16-23-30-21-709.png, server-adapter-erroneous-debugging-state.png
>
>
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (JBIDE-23623) problems running getProjectRootPomParents and createTaskJIRAs
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23623?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-23623:
------------------------------------
For me when I run this
{code}
mkdir /tmp/jbt.github
cd /tmp/jbt.github
git clone git@github.com:jbosstools/jbosstools-build-ci.git
cd jbosstools-build-ci
git checkout jbosstools-4.4.x
chmod +x util/getProjectRootPomParents.sh
/tmp/jbt.github/jbosstools-build-ci/util/getProjectRootPomParents.sh -updateRootPom -b jbosstools-4.4.3.x -b2 master -createBranch -pv 4.4.3.Final-SNAPSHOT -w1 /tmp/jbt.github -vjbt 4.4.3.Final -vds 10.3.0.GA -tpmin 4.60.2.Final -tpmax 4.60.2.Final -jirahost https://issues.jboss.org -jirauser YOUR_JIRA_USER -jirapwd YOUR_JIRA_PWD -p1 "aerogear::aerogear-hybrid arquillian base::foundation browsersim central forge freemarker hibernate javaee::jsf jst livereload openshift server vpe::visual-page-editor-core webservices integration-tests" -p2 "build build-sites::updatesite discovery::central-update devdoc download.jboss.org maven-plugins:build versionwatch" -p3 "artwork ci::build devdoc product::installer qa website"
{code}
I get `git push origin 4.4.3.x`, not master:
{code}
# >>> jbdevstudio-artwork <<<
# Create branch https://github.com/jbdevstudio/jbdevstudio-artwork/tree/jbosstools-4.4.3.x from master
pushd /tmp/jbt.github/jbdevstudio-artwork && git checkout master && git pull origin master
git checkout -b jbosstools-4.4.3.x && git push origin jbosstools-4.4.3.x
popd >/dev/null && echo ">>> https://github.com/jbdevstudio/jbdevstudio-artwork/tree/jbosstools-4.4.3.x"
# >>> jbdevstudio-ci <<<
# Create branch https://github.com/jbdevstudio/jbdevstudio-ci/tree/jbosstools-4.4.3.x from master
pushd /tmp/jbt.github/jbdevstudio-ci && git checkout master && git pull origin master
git checkout -b jbosstools-4.4.3.x && git push origin jbosstools-4.4.3.x
popd >/dev/null && echo ">>> https://github.com/jbdevstudio/jbdevstudio-ci/tree/jbosstools-4.4.3.x"
{code}
So... I'll try a similar op for the 4.4.x branch...
> problems running getProjectRootPomParents and createTaskJIRAs
> -------------------------------------------------------------
>
> Key: JBIDE-23623
> URL: https://issues.jboss.org/browse/JBIDE-23623
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.4.3.AM1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.4.4.AM1
>
> Attachments: jira.txt, prepare-am1.txt, run.log
>
>
> When Jeff ran the latest emailed instructions [0] for the 4.4.3.AM1 initialization [1], this happened:
> {quote}
> Remarks:
> the right command is git checkout jbosstools-4.4.x and not co jbosstools-4.4.x
> When I run the getProjectRootPomParents.sh script, the JIRAs are not created as createTaskJIRAs.py emits an error message (see run.log). What I do is to get the output using tee, filter the output (keeping only python commands) and then run this script (see jira.txt). Don't know why it does not fail this time.
> Would be safe to run `pwd`/util/getProjectRootPomParents.sh instead of ./util/getProjectRootPomParents.sh
> Jeff{quote}
> [0] https://issues.jboss.org/secure/attachment/12413688/prepare-am1.txt
> [1] https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/jbos...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (JBIDE-23961) Server adapter: "Restart in Debug" is broken for Nodejs
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23961?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-23961 at 2/16/17 6:01 PM:
-------------------------------------------------------------------
The problem occurrs in OpenShiftLaunchController#mapPortForwarding where it does the following:
{code}
Optional<PortPair> debugPort = ports.stream().filter(p -> remotePort == p.getRemotePort()).findFirst();
if (!debugPort.isPresent() || monitor.isCanceled()) {
return -1;
}
{code}
the only port pair that is being found hasnt got a matching remotePort:
"remotePort" is :8787 but p.getRemotePort() returns :8080, so the method return -1.
was (Author: adietish):
The problem occurrs in OpenShiftLaunchController#mapPortForwarding where it does the following:
{code}
Optional<PortPair> debugPort = ports.stream().filter(p -> remotePort == p.getRemotePort()).findFirst();
if (!debugPort.isPresent() || monitor.isCanceled()) {
return -1;
}
{code}
"remotePort" is :8787 but p.getRemotePort() returns :8080, so the method return -1.
> Server adapter: "Restart in Debug" is broken for Nodejs
> -------------------------------------------------------
>
> Key: JBIDE-23961
> URL: https://issues.jboss.org/browse/JBIDE-23961
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.3.Final
> Reporter: Andre Dietisheim
> Priority: Critical
> Attachments: image-2017-02-16-23-30-21-709.png
>
>
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (JBIDE-23961) Server adapter: "Restart in Debug" is broken for Nodejs
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23961?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-23961 at 2/16/17 5:57 PM:
-------------------------------------------------------------------
The problem occurrs in OpenShiftLaunchController#mapPortForwarding where it does the following:
{code}
Optional<PortPair> debugPort = ports.stream().filter(p -> remotePort == p.getRemotePort()).findFirst();
if (!debugPort.isPresent() || monitor.isCanceled()) {
return -1;
}
{code}
"remotePort" is :8787 but p.getRemotePort() returns :8080, so the method return -1.
was (Author: adietish):
The problem occurrs in OpenShiftLaunchController#mapPortForwarding where it does the following:
{code}
Optional<PortPair> debugPort = ports.stream().filter(p -> remotePort == p.getRemotePort()).findFirst();
if (!debugPort.isPresent() || monitor.isCanceled()) {
return -1;
}
{code}
"remotePort" is :8787 but p.getRemotePort() returns :8080, so -1 is returned.
> Server adapter: "Restart in Debug" is broken for Nodejs
> -------------------------------------------------------
>
> Key: JBIDE-23961
> URL: https://issues.jboss.org/browse/JBIDE-23961
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.3.Final
> Reporter: Andre Dietisheim
> Priority: Critical
> Attachments: image-2017-02-16-23-30-21-709.png
>
>
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (JBIDE-23961) Server adapter: "Restart in Debug" is broken for Nodejs
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23961?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-23961:
------------------------------------------
The problem occurrs in OpenShiftLaunchController#mapPortForwarding where it does the following:
{code}
Optional<PortPair> debugPort = ports.stream().filter(p -> remotePort == p.getRemotePort()).findFirst();
if (!debugPort.isPresent() || monitor.isCanceled()) {
return -1;
}
{code}
"remotePort" is :8787 but p.getRemotePort() returns :8080, so -1 is returned.
> Server adapter: "Restart in Debug" is broken for Nodejs
> -------------------------------------------------------
>
> Key: JBIDE-23961
> URL: https://issues.jboss.org/browse/JBIDE-23961
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.3.Final
> Reporter: Andre Dietisheim
> Priority: Critical
> Attachments: image-2017-02-16-23-30-21-709.png
>
>
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month