[JBoss JIRA] (JBIDE-23677) write maven enforcer test to ensure we set correct version of foundation.core (based on parent pom version)
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23677?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-23677 at 3/3/17 11:31 AM:
-------------------------------------------------------------
Quick workaround since I'll be AFK on PTO next week:
https://github.com/jbosstools/jbosstools-base/commit/0022689b29aa4012d71e...
A better fix might be to parse the parent pom version rather than the root pom version of jbosstools-base. But then we need to clean it to remove the qualifier/suffix (and *verify that the enforcer still works for devstudio version parsing too*):
{code}
diff --git a/foundation/plugins/org.jboss.tools.foundation.core/pom.xml b/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
index d073e4b..20a8cbf 100644
--- a/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
+++ b/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
@@ -44,7 +44,7 @@
<goal>parse-version</goal>
</goals>
<configuration>
- <versionString>${project.parent.parent.parent.version}</versionString>
+ <versionString>${project.parent.parent.parent.parent.version}</versionString>
</configuration>
</execution>
</executions>
@@ -87,7 +87,7 @@
<configuration>
<rules>
<foundationCoreVersionMatchesParentPom implementation="org.jboss.tools.releng.FoundationCoreVersionMatchesParentPom">
- <parentPomVersionBase>4.4.4.SNAPSHOT</parentPomVersionBase>
+ <!-- <parentPomVersionBase>4.4.4.SNAPSHOT</parentPomVersionBase> -->
<currentVersionProperties>src/org/jboss/tools/foundation/core/properties/internal/currentversion.properties</currentVersionProperties>
==>
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (foundation-core-default-version-check) @ org.jboss.tools.foundation.core ---
[WARNING] Rule 0: org.jboss.tools.releng.FoundationCoreVersionMatchesParentPom failed with message:
[ERROR] Invalid value of default.version = 4.4.4.Final for parent = 4.4.4.AM1.AM1-SNAPSHOT !
Must set default.version = 4.4.4.AM1.Final (or = 4.4.4.AM1.AM1) in this file:
/home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-base/foundation/plugins/org.jboss.tools.foundation.core/src/org/jboss/tools/foundation/core/properties/internal/currentversion.properties
{code}
was (Author: nickboldt):
Quick workaround since I'll be AFK on PTO next week:
https://github.com/jbosstools/jbosstools-base/commit/0022689b29aa4012d71e...
A better fix might be to parse the parent pom version rather than the root pom version of jbosstools-base. But then we need to clean it to remove the qualifier/suffix:
{code}
diff --git a/foundation/plugins/org.jboss.tools.foundation.core/pom.xml b/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
index d073e4b..20a8cbf 100644
--- a/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
+++ b/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
@@ -44,7 +44,7 @@
<goal>parse-version</goal>
</goals>
<configuration>
- <versionString>${project.parent.parent.parent.version}</versionString>
+ <versionString>${project.parent.parent.parent.parent.version}</versionString>
</configuration>
</execution>
</executions>
@@ -87,7 +87,7 @@
<configuration>
<rules>
<foundationCoreVersionMatchesParentPom implementation="org.jboss.tools.releng.FoundationCoreVersionMatchesParentPom">
- <parentPomVersionBase>4.4.4.SNAPSHOT</parentPomVersionBase>
+ <!-- <parentPomVersionBase>4.4.4.SNAPSHOT</parentPomVersionBase> -->
<currentVersionProperties>src/org/jboss/tools/foundation/core/properties/internal/currentversion.properties</currentVersionProperties>
==>
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (foundation-core-default-version-check) @ org.jboss.tools.foundation.core ---
[WARNING] Rule 0: org.jboss.tools.releng.FoundationCoreVersionMatchesParentPom failed with message:
[ERROR] Invalid value of default.version = 4.4.4.Final for parent = 4.4.4.AM1.AM1-SNAPSHOT !
Must set default.version = 4.4.4.AM1.Final (or = 4.4.4.AM1.AM1) in this file:
/home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-base/foundation/plugins/org.jboss.tools.foundation.core/src/org/jboss/tools/foundation/core/properties/internal/currentversion.properties
{code}
> write maven enforcer test to ensure we set correct version of foundation.core (based on parent pom version)
> ------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-23677
> URL: https://issues.jboss.org/browse/JBIDE-23677
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build, foundation
> Affects Versions: 4.4.3.AM1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.4.4.AM1, 4.5.0.AM1
>
>
> Wrong version of foundation.core detected. Should be 4.4.3, not 4.4.2.
> https://github.com/jbosstools/jbosstools-base/blob/master/foundation/plug...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (JBIDE-23677) write maven enforcer test to ensure we set correct version of foundation.core (based on parent pom version)
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23677?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-23677:
------------------------------------
Quick workaround since I'll be AFK on PTO next week:
https://github.com/jbosstools/jbosstools-base/commit/0022689b29aa4012d71e...
A better fix might be to parse the parent pom version rather than the root pom version of jbosstools-base. But then we need to clean it to remove the qualifier/suffix:
{code}
diff --git a/foundation/plugins/org.jboss.tools.foundation.core/pom.xml b/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
index d073e4b..20a8cbf 100644
--- a/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
+++ b/foundation/plugins/org.jboss.tools.foundation.core/pom.xml
@@ -44,7 +44,7 @@
<goal>parse-version</goal>
</goals>
<configuration>
- <versionString>${project.parent.parent.parent.version}</versionString>
+ <versionString>${project.parent.parent.parent.parent.version}</versionString>
</configuration>
</execution>
</executions>
@@ -87,7 +87,7 @@
<configuration>
<rules>
<foundationCoreVersionMatchesParentPom implementation="org.jboss.tools.releng.FoundationCoreVersionMatchesParentPom">
- <parentPomVersionBase>4.4.4.SNAPSHOT</parentPomVersionBase>
+ <!-- <parentPomVersionBase>4.4.4.SNAPSHOT</parentPomVersionBase> -->
<currentVersionProperties>src/org/jboss/tools/foundation/core/properties/internal/currentversion.properties</currentVersionProperties>
==>
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (foundation-core-default-version-check) @ org.jboss.tools.foundation.core ---
[WARNING] Rule 0: org.jboss.tools.releng.FoundationCoreVersionMatchesParentPom failed with message:
[ERROR] Invalid value of default.version = 4.4.4.Final for parent = 4.4.4.AM1.AM1-SNAPSHOT !
Must set default.version = 4.4.4.AM1.Final (or = 4.4.4.AM1.AM1) in this file:
/home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-base/foundation/plugins/org.jboss.tools.foundation.core/src/org/jboss/tools/foundation/core/properties/internal/currentversion.properties
{code}
> write maven enforcer test to ensure we set correct version of foundation.core (based on parent pom version)
> ------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-23677
> URL: https://issues.jboss.org/browse/JBIDE-23677
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build, foundation
> Affects Versions: 4.4.3.AM1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.4.4.AM1, 4.5.0.AM1
>
>
> Wrong version of foundation.core detected. Should be 4.4.3, not 4.4.2.
> https://github.com/jbosstools/jbosstools-base/blob/master/foundation/plug...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (JBIDE-24010) build: bump plugin version to comply with baseline check
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24010?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-24010:
------------------------------------------
merged both PR to jbosstools-4.4.x and master respectively.
Resolving and Closing since nothing for QE to verify.
> build: bump plugin version to comply with baseline check
> --------------------------------------------------------
>
> Key: JBIDE-24010
> URL: https://issues.jboss.org/browse/JBIDE-24010
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Andre Dietisheim
> Priority: Blocker
> Fix For: 4.4.4.AM1, 4.5.0.AM1
>
>
> {code}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:1.0.0:compare-version-with-baselines
> (default) on project org.jboss.tools.openshift.client: Version have moved backwards for
> (org.jboss.tools.openshift.client/3.3.2.AM1-v20170224-1533-B1868).
> Baseline has 3.3.2.Final-v20170217-1414-B33) with delta: 0.0.0
> {code} -- https://jenkins.hosts.mwqe.eng.bos.redhat.com/hudson/view/DevStudio/view/...
> Solution: upversion your client plugin or make it not use the BUILD_ALIAS in its version (so it's only got a timestamp).
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (JBTIS-1053) Add nexus-staging-maven-plugin to JBTIS TP pom
by Paul Leacu (JIRA)
Paul Leacu created JBTIS-1053:
---------------------------------
Summary: Add nexus-staging-maven-plugin to JBTIS TP pom
Key: JBTIS-1053
URL: https://issues.jboss.org/browse/JBTIS-1053
Project: JBoss Tools Integration Stack
Issue Type: Bug
Components: target-platform
Affects Versions: 10.0.1.GA-TP
Reporter: Paul Leacu
Assignee: Paul Leacu
Add the nexus-staging-maven-plugin from org.sonatype.plugins to enable staging to the releases repo.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (JBIDE-23882) Automate test of installation of software from Red Hat Central into devstudio RPM
by Lukáš Valach (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23882?page=com.atlassian.jira.plugi... ]
Lukáš Valach edited comment on JBIDE-23882 at 3/3/17 8:46 AM:
--------------------------------------------------------------
Second job for Integration Stack: [rpm_rh_central_IS_test.weekly|https://dev-platform-jenkins.rhev-ci-vms.en...]
The script, as it is now written, expects that the update site contains *devstudio-directory.xml*. Hope it isn't problem when I use
\[1\] https://devstudio.redhat.com/10.0/development/updates/integration-stack/d... *10.1.0.GA/*
instead of
\[2\] https://devstudio.redhat.com/10.0/development/updates/integration-stack/d...
[~nickboldt], please let me know I you want me to rework the script to me able to work with \[2\]. I see that the update site contains compositeContent.xml which is pointing to 10.1.0.GA/ directory which contains devstudio-directory.xml, so I can use compositeContent.xml to fix this problem.
----
I have fixed bug that causes problems during installation of some features. PR \[3\]
\[3\] https://github.com/jbdevstudio/jbdevstudio-qa/pull/130
The list of repositories which p2direct are using during the installation of each RH Central item consists of $CENTRAL_URL and URL stored in 'siteUrl' attribute (in plugin.jar/plugin xml). Newly the variable in 'siteUrl' if any will be substituted with update site URL delivered from plugin.jar location. So the p2director is now able to find everything they need in proper version.
was (Author: lvalach):
Second job for Integration Stack: [rpm_rh_central_IS_test.weekly|https://dev-platform-jenkins.rhev-ci-vms.en...]
The script, as it is now written, expects that the update site contains *devstudio-directory.xml*. Hope it isn't problem when I use
\[1\] https://devstudio.redhat.com/10.0/development/updates/integration-stack/d... *10.1.0.GA/*
instead of
\[2\] https://devstudio.redhat.com/10.0/development/updates/integration-stack/d...
[~nickboldt], please let me know I you want me to rework the script to me able to work with \[1\]. I see that the update site contains compositeContent.xml which is pointing to 10.1.0.GA/ directory which contains devstudio-directory.xml, so I can use compositeContent.xml to fix this problem.
----
I have fixed bug that causes problems during installation of some features. PR \[3\]
\[3\] https://github.com/jbdevstudio/jbdevstudio-qa/pull/130
The list of repositories which p2direct are using during the installation of each RH Central item consists of $CENTRAL_URL and URL stored in 'siteUrl' attribute (in plugin.jar/plugin xml). Newly the variable in 'siteUrl' if any will be substituted with update site URL delivered from plugin.jar location. So the p2director is now able to find everything they need in proper version.
> Automate test of installation of software from Red Hat Central into devstudio RPM
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-23882
> URL: https://issues.jboss.org/browse/JBIDE-23882
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: qa
> Environment: RHEL7, devstudio RPM
> Reporter: Lukáš Valach
> Assignee: Lukáš Valach
> Fix For: 4.4.4.AM1
>
>
> We need to catch problems like in JBDS-4263.
> [~lvalach] said: {quote}
> I think I should automate test of installation from Central, because this procedure is quite time consuming.
> {quote}
> [~nickboldt] said: {quote}
> before you do that might want to look at the existing automated tests we have:
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-install-g....
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-install-p....
> of course those are not based on rpm installs, but on eclipse platform binary or JEE packages. We could try modifying both p2director (headless) and install-grinder (head w/ swt) scripts to support doing an rpm install too... not sure how since that would require running as root
> maybe you could just use the scripts to automate the process of doing the installs AFTER you have rpm installed locally
> so ... partial automation
> {quote}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (JBDS-4263) Problems after install from Red Hat Central into rh-eclipse46-devstudio
by Lukáš Valach (JIRA)
[ https://issues.jboss.org/browse/JBDS-4263?page=com.atlassian.jira.plugin.... ]
Lukáš Valach commented on JBDS-4263:
------------------------------------
Thank you Nick it is more clear for me now. The tests are passing except the PMD.
> Problems after install from Red Hat Central into rh-eclipse46-devstudio
> -----------------------------------------------------------------------
>
> Key: JBDS-4263
> URL: https://issues.jboss.org/browse/JBDS-4263
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: rpm
> Affects Versions: 10.3.0.AM2
> Reporter: Nick Boldt
> Assignee: Lukáš Valach
> Fix For: 10.4.0.AM1
>
> Attachments: build_31_eclipse_log.zip, build_32_eclipse_log.zip, build_33_eclipse_log.zip, home_eclipse.txt, opt_rh.txt, rh-eclipse46-devstudio-10.4-0.20170227.0853.el7_20170227-0512_install_PMD.txt, rh-eclipse46-devstudio10.3-0.20170206.0203.el7.log.Jboss_Data_Virtualization_Developement_form_IS_repo_strict.txt
>
>
> The installation of software from Red Hat Central causes errors in the log. Some functionality may be broken. We have to test installation of all the stuff from the central and fix the problems.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months