[JBoss JIRA] (JBIDE-24375) Remove PowerMock usage in tests
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24375?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov commented on JBIDE-24375:
------------------------------------------
[~aurelien.pupier] powermock is used in several more places: https://github.com/jbosstools/jbosstools-openshift/search?utf8=%E2%9C%93&...
I really don't want to remove PowerMockito. I spent 2 weeks in trying to create tests from the link above without PowerMockito and without big refactoring of the existing code, but i didn't succeed. The biggest difficulty is to test WatchManager - we had lots of problem with it and it needed to be covered with tests, that's why i created it.
I 100% agree that code needs refactoring to be "testable", but the functionality is very sensitive there, and i don't think it worth someone's else 2 weeks be spent for refactoring. So if you really want to get rid of the PowerMockito at all and have idea how to leave all the tests from the link working, i would be very glad to review the PR :) (firstly i also had thoughts that it was easy, but when started coding tests - bumped into lots of problems)
> Remove PowerMock usage in tests
> -------------------------------
>
> Key: JBIDE-24375
> URL: https://issues.jboss.org/browse/JBIDE-24375
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: openshift
> Affects Versions: 4.4.4.AM3
> Reporter: Aurélien Pupier
>
> I create this issue to gather ideas to get rid of it.
> see https://github.com/jbosstools/jbosstools-openshift/blob/cf544dbec4baa87c6...
> from why i understand, PowerMock is used only to mock a singleton access in a static method.
> The reasonable seems to avoid static method: OpenShiftServerUtils. If we are using an instanciation for this class, then, the call to create the Watcher can be extracted in a method and this method would be classically mockable with Mockito.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (JBDS-4105) Provide m2e connector for io.fabric8:fabric8-maven-plugin
by Aurélien Pupier (JIRA)
[ https://issues.jboss.org/browse/JBDS-4105?page=com.atlassian.jira.plugin.... ]
Aurélien Pupier commented on JBDS-4105:
---------------------------------------
yes it is still relevant. The Fabric8-maven-plugin is embedding m2e metadata just to "ignore" the phase so it only avoids to have marker to say that it is not supported but it is doing absolutely nothing.
> Provide m2e connector for io.fabric8:fabric8-maven-plugin
> ---------------------------------------------------------
>
> Key: JBDS-4105
> URL: https://issues.jboss.org/browse/JBDS-4105
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Feature Request
> Components: maven
> Reporter: Aurélien Pupier
> Fix For: 11.0.0.AM1
>
>
> iPaas Fuse is heavily using fabric8-maven-plugin. it will be nice to provide a m2e connector to have a better integration.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (JBIDE-24375) Remove PowerMock usage in tests
by Aurélien Pupier (JIRA)
Aurélien Pupier created JBIDE-24375:
---------------------------------------
Summary: Remove PowerMock usage in tests
Key: JBIDE-24375
URL: https://issues.jboss.org/browse/JBIDE-24375
Project: Tools (JBoss Tools)
Issue Type: Task
Components: openshift
Affects Versions: 4.4.4.AM3
Reporter: Aurélien Pupier
I create this issue to gather ideas to get rid of it.
see https://github.com/jbosstools/jbosstools-openshift/blob/cf544dbec4baa87c6...
from why i understand, PowerMock is used only to mock a singleton access in a static method.
The reasonable seems to avoid static method: OpenShiftServerUtils. If we are using an instanciation for this class, then, the call to create the Watcher can be extracted in a method and this method would be classically mockable with Mockito.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (JBIDE-24301) Error While Executing jbosstools-openshift-4.4.3
by jyoti tumsare (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24301?page=com.atlassian.jira.plugi... ]
jyoti tumsare commented on JBIDE-24301:
---------------------------------------
As you told me, I build https://github.com/jboss-reddeer/reddeer source code and add org.jboss.reddeer.go plugin in eclipse-plugin folder.
> Error While Executing jbosstools-openshift-4.4.3
> ------------------------------------------------
>
> Key: JBIDE-24301
> URL: https://issues.jboss.org/browse/JBIDE-24301
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build, openshift
> Affects Versions: 4.4.3.Final
> Reporter: jyoti tumsare
> Assignee: Dmitrii Bocharov
> Fix For: 4.4.4.Final
>
> Attachments: issues.PNG, issues.txt
>
>
> To build jbosstools-openshift-4.4.3 I followed following steps
> 1. I clone jbosstools-base and jbosstools-server which are required for the building jbosstools-openshift-4.4.3.
> 2. while executing the jbosstools-base I got error "Missing requirement: org.jboss.tools.common.core 3.8.3.qualifier requires 'bundle org.jboss.tools.foundation.core 1.3.3' but it could not be found".
> 3. I build the org.jboss.tools.foundation.core 1.3.3 plugin and add into eclipse plugin folder and restart the eclipse IDE still facing the isuue.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months