[JBoss JIRA] (JBIDE-24399) For JBIDE 4.4.4.Final: Find Missing Commits From master for jbosstools-4.4.x [Base]
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24399?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-24399:
--------------------------------
Fix Version/s: 4.4.4.Final
> For JBIDE 4.4.4.Final: Find Missing Commits From master for jbosstools-4.4.x [Base]
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-24399
> URL: https://issues.jboss.org/browse/JBIDE-24399
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: common, foundation, usage
> Reporter: Jeff MAURY
> Assignee: Jeff MAURY
> Priority: Blocker
> Labels: task
> Fix For: 4.4.4.Final
>
>
> For JBIDE 4.4.4.Final [Base]: Ensure all commits pushed to master have either been made in jbosstools-4.4.x, or are intentionally excluded from jbosstools-4.4.x.
> Below are listed all commits made to master that have not been found in jbosstools-4.4.x. It is possible these commits do exist in jbosstools-4.4.x, but the patches are not identical. It is also possible that the commits made in master are not relevant to jbosstools-4.4.x or should not be applied.
> If there are no commits listed below, please close (do not resolve) this issue.
> Otherwise:
> 1) Click on each link below.
> 2) Evaluate whether the given commit *should* be in jbosstools-4.4.x
> 3) If it should be in jbosstools-4.4.x, please find out why it is not in jbosstools-4.4.x. You may need to browse jbosstools-4.4.x's commit log to find a commit that should match.
> 4) If you cannot find a matching commit, and it *should* be committed to jbosstools-4.4.x, please cherry-pick that commit to jbosstools-4.4.x or otherwise merge it in.
> 5) In comments, please indicate any suspicious commits (ie, commits not related to simple version changes), whether it exists in jbosstools-4.4.x, whether you have successfully merged it in now, or whether it is not intended to be committed to jbosstools-4.4.x or is inappropriate for jbosstools-4.4.x.
> 6) When all complete, please close (do not resolve) this issue.
>
> Folder: jbosstools-base at https://github.com/jbosstools/jbosstools-base
> Searching for commits present in master and missing from jbosstools-4.4.x
> Commit hash "722dac" is the last common ancestor of master and jbosstools-4.4.x
> 722dac is 18 commits ago in branch jbosstools-4.4.x
> 722dac is 19 commits ago in branch master
> Commits missing from jbosstools-4.4.x that are in master:
> Curious Patches:
> * missing: JBIDE-23833-more-complete-solution-to-remove-JIRA-support-from-org.jboss.tools.common.mylyn-including-removing-test-in-common-tests-org.jboss.tools.common.mylyn.test-src-org-jboss-tools-common-mylyn-test-RepositoryTest.java-and-bumping-all-containing-features-too-568 https://github.com/jbosstools/jbosstools-base/commit/178187840622aab9f287...
> Master-only patches that are verified master-only:
> * missing: JBIDE-24074-bump-plugin-version https://github.com/jbosstools/jbosstools-base/commit/6c847228f78b091feb4f...
> ** possible match: https://github.com/jbosstools/jbosstools-base/commit/17f9990bc11020e561a5...
> *** Inspect the difference between the two patches: http://sprunge.us/iJWU
> * missing: JBIDE-24081-bump-feature-plugin-version https://github.com/jbosstools/jbosstools-base/commit/d99a2f1174b1e4bbd2a9...
> ** possible match: https://github.com/jbosstools/jbosstools-base/commit/bcc7f29dc37479aa8591...
> *** Inspect the difference between the two patches: http://sprunge.us/TeCf
> * missing: Revert-JBIDE-24343-comment-bump-up-to-parent-pom-version-4.4.4.Final-SNAPSHOT-close https://github.com/jbosstools/jbosstools-base/commit/569f8bbd655368e0d0fd...
> * missing: JBIDE-24343-comment-bump-up-to-parent-pom-version-4.4.4.Final-SNAPSHOT-close https://github.com/jbosstools/jbosstools-base/commit/642a7b9710ef3d4506ae...
> * missing: Upversion-common-foundation-and-runtime https://github.com/jbosstools/jbosstools-base/commit/2a07e015961cb537b107...
> * missing: JBIDE-23677-use-parent-pom-to-define-jbosstools.version-currentversion.properties-not-root-pom-566 https://github.com/jbosstools/jbosstools-base/commit/cc566c72423f97f2b6d0...
> * missing: bump-foundation-plugins-org.jboss.tools.foundation.core-src-org-jboss-tools-foundation-core-properties-internal-currentversion.properties-to-4.5.0.Final https://github.com/jbosstools/jbosstools-base/commit/0a02f12e893f4365aeb8...
> * missing: JBIDE-23677-temporary-workaround-to-move-foundation.core-to-correct-version-4.5.0.AM1 https://github.com/jbosstools/jbosstools-base/commit/0afb3a71186a738efb7f...
> * missing: JBIDE-24014-fix-versions-in-master-branch-bump-to-1.4.0-SNAPSHOT-in-changed-plugins-features-559 https://github.com/jbosstools/jbosstools-base/commit/6f11308a03e390fd1a59...
> * missing: JBIDE-23967-compile-failed-migration-needed-to-Oxygen.0.M5-554 https://github.com/jbosstools/jbosstools-base/commit/8571dc1811b4c06492e3...
> * missing: JBIDE-23946-comment-bump-up-to-parent-pom-version-4.5.0.AM1-SNAPSHOT-close https://github.com/jbosstools/jbosstools-base/commit/a8a42e5d22269d310a11...
> [Search for all task JIRA|https://issues.jboss.org//issues/?jql=%28%28project+in+%28JBDS%29+an...], or [Search for Base task JIRA|https://issues.jboss.org//issues/?jql=%28%28project+in+%28JBDS%29+an...]
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (JBIDE-24399) For JBIDE 4.4.4.Final: Find Missing Commits From master for jbosstools-4.4.x [Base]
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24399?page=com.atlassian.jira.plugi... ]
Rob Stryker closed JBIDE-24399.
-------------------------------
Resolution: Done
These patches all seem clean.
> For JBIDE 4.4.4.Final: Find Missing Commits From master for jbosstools-4.4.x [Base]
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-24399
> URL: https://issues.jboss.org/browse/JBIDE-24399
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: common, foundation, usage
> Reporter: Jeff MAURY
> Assignee: Jeff MAURY
> Priority: Blocker
> Labels: task
> Fix For: 4.4.4.Final
>
>
> For JBIDE 4.4.4.Final [Base]: Ensure all commits pushed to master have either been made in jbosstools-4.4.x, or are intentionally excluded from jbosstools-4.4.x.
> Below are listed all commits made to master that have not been found in jbosstools-4.4.x. It is possible these commits do exist in jbosstools-4.4.x, but the patches are not identical. It is also possible that the commits made in master are not relevant to jbosstools-4.4.x or should not be applied.
> If there are no commits listed below, please close (do not resolve) this issue.
> Otherwise:
> 1) Click on each link below.
> 2) Evaluate whether the given commit *should* be in jbosstools-4.4.x
> 3) If it should be in jbosstools-4.4.x, please find out why it is not in jbosstools-4.4.x. You may need to browse jbosstools-4.4.x's commit log to find a commit that should match.
> 4) If you cannot find a matching commit, and it *should* be committed to jbosstools-4.4.x, please cherry-pick that commit to jbosstools-4.4.x or otherwise merge it in.
> 5) In comments, please indicate any suspicious commits (ie, commits not related to simple version changes), whether it exists in jbosstools-4.4.x, whether you have successfully merged it in now, or whether it is not intended to be committed to jbosstools-4.4.x or is inappropriate for jbosstools-4.4.x.
> 6) When all complete, please close (do not resolve) this issue.
>
> Folder: jbosstools-base at https://github.com/jbosstools/jbosstools-base
> Searching for commits present in master and missing from jbosstools-4.4.x
> Commit hash "722dac" is the last common ancestor of master and jbosstools-4.4.x
> 722dac is 18 commits ago in branch jbosstools-4.4.x
> 722dac is 19 commits ago in branch master
> Commits missing from jbosstools-4.4.x that are in master:
> Curious Patches:
> * missing: JBIDE-23833-more-complete-solution-to-remove-JIRA-support-from-org.jboss.tools.common.mylyn-including-removing-test-in-common-tests-org.jboss.tools.common.mylyn.test-src-org-jboss-tools-common-mylyn-test-RepositoryTest.java-and-bumping-all-containing-features-too-568 https://github.com/jbosstools/jbosstools-base/commit/178187840622aab9f287...
> Master-only patches that are verified master-only:
> * missing: JBIDE-24074-bump-plugin-version https://github.com/jbosstools/jbosstools-base/commit/6c847228f78b091feb4f...
> ** possible match: https://github.com/jbosstools/jbosstools-base/commit/17f9990bc11020e561a5...
> *** Inspect the difference between the two patches: http://sprunge.us/iJWU
> * missing: JBIDE-24081-bump-feature-plugin-version https://github.com/jbosstools/jbosstools-base/commit/d99a2f1174b1e4bbd2a9...
> ** possible match: https://github.com/jbosstools/jbosstools-base/commit/bcc7f29dc37479aa8591...
> *** Inspect the difference between the two patches: http://sprunge.us/TeCf
> * missing: Revert-JBIDE-24343-comment-bump-up-to-parent-pom-version-4.4.4.Final-SNAPSHOT-close https://github.com/jbosstools/jbosstools-base/commit/569f8bbd655368e0d0fd...
> * missing: JBIDE-24343-comment-bump-up-to-parent-pom-version-4.4.4.Final-SNAPSHOT-close https://github.com/jbosstools/jbosstools-base/commit/642a7b9710ef3d4506ae...
> * missing: Upversion-common-foundation-and-runtime https://github.com/jbosstools/jbosstools-base/commit/2a07e015961cb537b107...
> * missing: JBIDE-23677-use-parent-pom-to-define-jbosstools.version-currentversion.properties-not-root-pom-566 https://github.com/jbosstools/jbosstools-base/commit/cc566c72423f97f2b6d0...
> * missing: bump-foundation-plugins-org.jboss.tools.foundation.core-src-org-jboss-tools-foundation-core-properties-internal-currentversion.properties-to-4.5.0.Final https://github.com/jbosstools/jbosstools-base/commit/0a02f12e893f4365aeb8...
> * missing: JBIDE-23677-temporary-workaround-to-move-foundation.core-to-correct-version-4.5.0.AM1 https://github.com/jbosstools/jbosstools-base/commit/0afb3a71186a738efb7f...
> * missing: JBIDE-24014-fix-versions-in-master-branch-bump-to-1.4.0-SNAPSHOT-in-changed-plugins-features-559 https://github.com/jbosstools/jbosstools-base/commit/6f11308a03e390fd1a59...
> * missing: JBIDE-23967-compile-failed-migration-needed-to-Oxygen.0.M5-554 https://github.com/jbosstools/jbosstools-base/commit/8571dc1811b4c06492e3...
> * missing: JBIDE-23946-comment-bump-up-to-parent-pom-version-4.5.0.AM1-SNAPSHOT-close https://github.com/jbosstools/jbosstools-base/commit/a8a42e5d22269d310a11...
> [Search for all task JIRA|https://issues.jboss.org//issues/?jql=%28%28project+in+%28JBDS%29+an...], or [Search for Base task JIRA|https://issues.jboss.org//issues/?jql=%28%28project+in+%28JBDS%29+an...]
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (JBIDE-19182) Incremental Publish after Full Publish WRT dodeploy markers
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19182?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-19182:
--------------------------------
Fix Version/s: 4.5.0.AM1
(was: 4.4.4.Final)
> Incremental Publish after Full Publish WRT dodeploy markers
> -----------------------------------------------------------
>
> Key: JBIDE-19182
> URL: https://issues.jboss.org/browse/JBIDE-19182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: server
> Affects Versions: 4.2.0.Final
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.5.0.AM1
>
>
> THis issue is opened in regards to comments by [~dlmiles] on https://issues.jboss.org/browse/JBIDE-18862
> I am saying you should block all 'deployment directory' file modifications when you know the AS is busy using the 'deployment directory' to "deploy" (a.k.a. starting) or "undeploy" (a.k.a. stopping) of a module (or the AS itself is starting/stopping in certain scenarios). Ideally you use a file watcher API when available so there is no busy/wait loop adding additional milliseconds of delays because the wait part is never instant.
> But in an example scenario where you perform a Full Publish then 2 additional Incremental Publish ops immediately after, there is no reason to block the incrementals if you know the AS has not picked up the original Full Publish yet. You can effectively merge those two incrementals into the full publish operation behind the back of the AS.
> But you are presented with a race scenario, you have already laid down the *.dodeploy at the end of the original Full Publish. So Eclipse needs to effectively notice that scenario exists, revoke and remember that instruction to the AS in an atomic way (what I mean by this is Eclipse knows for sure if it cancelled it in time, or if it was too late and the AS got to the full publish first and started deploying).
> You need to do this so Eclipse can make file change modifications to the 'deployment directory' again.
> Once Eclipse has completed the file change operations, if takes that remembered state and puts back the *.dodeploy file (even though this is an Incremental Publish operation). You can think of this like a "save state" and "restore state" pattern if that helps. Or you can think of this like the Eclipse target goal state for the AS (such as "AS:started" and "module.abc:started") is compared to the actual AS state (such as "AS: started" and "module.abc:stopped"), and Eclipse then brings them into alignment to do this it realizes it needs to lay down the *.dodeploy marker file (even though this is an incremental publish).
> I think with the current marker file arrangements there maybe a tiny window of time where Eclipse IDE will get things wrong in respect of the AS ? But maybe ensuring both Eclipse IDE and the AS check the return value of the file delete for *.dodeploy whomever was successful in deleting the file wins, whichever party got the error "No Such File" loses and performs a rollback/cleanup of the situation to ensure it tries again soon.
> So you can speak for the JBIDE side but can someone check the AS side ? File#delete(new File("foobar.dodeploy")) != true. The AS has to delete the command instruction file before it starts to process that command, but after it has laid down a state change file (*.isdeploying).
> One of the goals of the marker files is that at no point in time is there a snapshot of the files that exist in the directory; that would leave an observer to interpret the wrong state. For example deleting one marker file before laying down the next would be bad, because there is a snapshot of time when no state marker file exists in the directory, leaving the observer to interpret that nothing is happening with that module. The alternative is to lay both the new file first then delete the old one, now there is a window of time when 2 marker files indicate state for 1 module, this is good and valid since the observer can clearly see the correct state.
> So if you got here and are still with me, then you can see how things should only slow down, when they need to slow down.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (JBIDE-22375) Improve HCR OpenShift
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22375?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-22375:
--------------------------------
Fix Version/s: 4.5.0.AM1
(was: 4.4.4.Final)
> Improve HCR OpenShift
> ---------------------
>
> Key: JBIDE-22375
> URL: https://issues.jboss.org/browse/JBIDE-22375
> Project: Tools (JBoss Tools)
> Issue Type: Epic
> Components: jmx, openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Fred Bricon
> Assignee: Rob Stryker
> Priority: Blocker
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.0.AM1
>
>
> When enabling debug mode on an EAP server deployed on OpenShift, locally changing a class file will :
> - work sometimes when only the content of the method changed, but could fail in some other occasions with the Debugger saying the JDK is out of sync
> - will always fail if a method signature changed, the debugger saying JDK is out of sync
> Restarting the deployed module (with the .dodeploy flag) doesn't fixes the issue (as opposed to the same tweak ahen running on a local EAP server)
> This may be caused by running OpenJDK? Does it support the same level of debugging as Oracle JDK?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (JBDS-3866) vagrant up failed due to rsync error, eclipse tooling confused about state of cdk server
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBDS-3866?page=com.atlassian.jira.plugin.... ]
Rob Stryker closed JBDS-3866.
-----------------------------
Resolution: Out of Date
Closing... I haven't seen QE mention any problems like this.
> vagrant up failed due to rsync error, eclipse tooling confused about state of cdk server
> ----------------------------------------------------------------------------------------
>
> Key: JBDS-3866
> URL: https://issues.jboss.org/browse/JBDS-3866
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 9.1.0.Beta1
> Environment: Windows 7/64 bit.
> (previous installs of CDK and dependencies)
> Reporter: Robert Terzi
> Assignee: Rob Stryker
> Fix For: 10.4.0.GA
>
>
> vagrant up through the CDK server tooling failed because of an rsync problem. The tooling lost track of the state of the vagrant box. The vagrant box couldn't be stopped from inside of Eclipse.
> The vagrant up failed because of an error with rsync. Something was confused about the user's home directory. It was trying to write to /home/username/.ssh, however, $HOME isn't /home/username, it's /cygdrive/c/Users/username, so /home/username/ doesn't exist.
> The CDK server was shown as 'Started, Sychronized'.
> The error message appeared in the server console tab. However the stop button wouldn't work. Provisioning had never finished so the OpenShift connection wasn't working either.
> Synchronized seems misleading here, since no files had been sync'd yet.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (JBIDE-21857) Hot code replacement doesn't work on OpenShift
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21857?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-21857:
--------------------------------
Fix Version/s: 4.5.0.AM1
(was: 4.4.4.Final)
> Hot code replacement doesn't work on OpenShift
> ----------------------------------------------
>
> Key: JBIDE-21857
> URL: https://issues.jboss.org/browse/JBIDE-21857
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Fred Bricon
> Assignee: Rob Stryker
> Fix For: 4.5.0.AM1
>
> Attachments: HCRFailure.zip, code-out-of-sync.png, hot-code-replace-failed.png, jmx-connected-adapter-synchronized.png
>
>
> When enabling debug mode on an EAP server deployed on OpenShift, locally changing a class file will :
> - work sometimes when only the content of the method changed, but could fail in some other occasions with the Debugger saying the JDK is out of sync
> - will always fail if a method signature changed, the debugger saying JDK is out of sync
> Restarting the deployed module (with the .dodeploy flag) doesn't fixes the issue (as opposed to the same tweak ahen running on a local EAP server)
> This may be caused by running OpenJDK? Does it support the same level of debugging as Oracle JDK?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months