[JBoss JIRA] (JBIDE-23869) ClassCastException with Jolokia connection
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23869?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-23869:
-------------------------------------
https://github.com/rhuss/jolokia/pull/326
I've submitted a patch that will include the whole json response in all 3 circumstances.
> ClassCastException with Jolokia connection
> ------------------------------------------
>
> Key: JBIDE-23869
> URL: https://issues.jboss.org/browse/JBIDE-23869
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jmx, openshift
> Reporter: Aurélien Pupier
> Assignee: Jeff MAURY
> Labels: jmx, jolokia, openshift
> Fix For: 4.5.0.AM2
>
> Attachments: failure.png, image-2017-02-06-13-54-27-708.png
>
>
> !image-2017-02-06-13-54-27-708.png|thumbnail!
> {noformat}
> !ENTRY org.eclipse.core.jobs 4 2 2017-02-06 13:52:39.767
> !MESSAGE An internal error occurred during: "Connect Job".
> !STACK 0
> java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Long
> at org.jolokia.client.request.ValidatingResponseExtractor.extract(ValidatingResponseExtractor.java:58)
> at org.jolokia.client.J4pClient.execute(J4pClient.java:195)
> at org.jolokia.client.J4pClient.execute(J4pClient.java:168)
> at org.jolokia.client.J4pClient.execute(J4pClient.java:117)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable(JolokiaConnectionWrapper.java:315)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.connect(JolokiaConnectionWrapper.java:111)
> at org.jboss.tools.jmx.core.ConnectJob.run(ConnectJob.java:29)
> at org.jboss.tools.jmx.ui.internal.actions.DoubleClickAction$1.run(DoubleClickAction.java:71)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-23869) ClassCastException with Jolokia connection
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23869?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-23869:
--------------------------------
Fix Version/s: 4.5.0.AM2
(was: 4.5.0.AM1)
> ClassCastException with Jolokia connection
> ------------------------------------------
>
> Key: JBIDE-23869
> URL: https://issues.jboss.org/browse/JBIDE-23869
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jmx, openshift
> Reporter: Aurélien Pupier
> Assignee: Jeff MAURY
> Labels: jmx, jolokia, openshift
> Fix For: 4.5.0.AM2
>
> Attachments: failure.png, image-2017-02-06-13-54-27-708.png
>
>
> !image-2017-02-06-13-54-27-708.png|thumbnail!
> {noformat}
> !ENTRY org.eclipse.core.jobs 4 2 2017-02-06 13:52:39.767
> !MESSAGE An internal error occurred during: "Connect Job".
> !STACK 0
> java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Long
> at org.jolokia.client.request.ValidatingResponseExtractor.extract(ValidatingResponseExtractor.java:58)
> at org.jolokia.client.J4pClient.execute(J4pClient.java:195)
> at org.jolokia.client.J4pClient.execute(J4pClient.java:168)
> at org.jolokia.client.J4pClient.execute(J4pClient.java:117)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable(JolokiaConnectionWrapper.java:315)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.connect(JolokiaConnectionWrapper.java:111)
> at org.jboss.tools.jmx.core.ConnectJob.run(ConnectJob.java:29)
> at org.jboss.tools.jmx.ui.internal.actions.DoubleClickAction$1.run(DoubleClickAction.java:71)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-24438) Server adapter: JMX connection is not working for OpenShift instance
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24438?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-24438:
-------------------------------------
I'm sorry, but I really don't understand the steps to replicate here. What do you mean by "connect to open.paas.redhat.com with server adapters" ??
Do you mean create an openshift connection to open.paas.redhat.com and then create a server adapter from one of the projects there? Which project?
What is open.paas.redhat.com? Is it the same as openshift.io? What credentials does this use? I'm a bit confused here.
> Server adapter: JMX connection is not working for OpenShift instance
> ---------------------------------------------------------------------
>
> Key: JBIDE-24438
> URL: https://issues.jboss.org/browse/JBIDE-24438
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.4.Final
> Reporter: Aurélien Pupier
> Assignee: Rob Stryker
> Labels: jmx, jolokia, openshift_v3, server_adapter
> Fix For: 4.5.0.AM1
>
>
> such as open.paas.redhat.com
> {noformat}
> java.io.IOException: org.jolokia.client.exception.J4pTimeoutException: Read timeout while request https://open.paas.redhat.com:8443/api/v1/namespaces/fis-test/pods/https:c...: Connect to open.paas.redhat.com:8443 [open.paas.redhat.com/10.29.67.214, open.paas.redhat.com/10.29.67.200, open.paas.redhat.com/10.29.67.238] failed: connect timed out
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable(JolokiaConnectionWrapper.java:324)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.connect(JolokiaConnectionWrapper.java:113)
> at org.jboss.tools.jmx.core.ConnectJob.run(ConnectJob.java:29)
> at org.jboss.tools.jmx.ui.internal.actions.DoubleClickAction$1.run(DoubleClickAction.java:71)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> Caused by: org.jolokia.client.exception.J4pTimeoutException: Read timeout while request https://open.paas.redhat.com:8443/api/v1/namespaces/fis-test/pods/https:c...: Connect to open.paas.redhat.com:8443 [open.paas.redhat.com/10.29.67.214, open.paas.redhat.com/10.29.67.200, open.paas.redhat.com/10.29.67.238] failed: connect timed out
> at org.jolokia.client.J4pClient.mapException(J4pClient.java:330)
> at org.jolokia.client.J4pClient.execute(J4pClient.java:198)
> at org.jolokia.client.J4pClient.execute(J4pClient.java:168)
> at org.jolokia.client.J4pClient.execute(J4pClient.java:117)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable(JolokiaConnectionWrapper.java:311)
> ... 4 more
> Caused by: org.apache.http.conn.ConnectTimeoutException: Connect to open.paas.redhat.com:8443 [open.paas.redhat.com/10.29.67.214, open.paas.redhat.com/10.29.67.200, open.paas.redhat.com/10.29.67.238] failed: connect timed out
> at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:150)
> at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:353)
> at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:380)
> at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236)
> at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
> at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
> at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
> at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
> at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)
> at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:107)
> at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:55)
> at org.jolokia.client.J4pClient.execute(J4pClient.java:190)
> ... 7 more
> Caused by: java.net.SocketTimeoutException: connect timed out
> at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
> at java.net.DualStackPlainSocketImpl.socketConnect(Unknown Source)
> at java.net.AbstractPlainSocketImpl.doConnect(Unknown Source)
> at java.net.AbstractPlainSocketImpl.connectToAddress(Unknown Source)
> at java.net.AbstractPlainSocketImpl.connect(Unknown Source)
> at java.net.PlainSocketImpl.connect(Unknown Source)
> at java.net.SocksSocketImpl.connect(Unknown Source)
> at java.net.Socket.connect(Unknown Source)
> at sun.security.ssl.SSLSocketImpl.connect(Unknown Source)
> at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:337)
> at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:141)
> ... 18 more
> {noformat}
> we can notice that the url used is https://open.paas.redhat.com:8443/api/v1/namespaces/fis-test/pods/https:c...
> It should not contain the port 8443
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-24285) Java coredump when starting jboss server from Eclipse
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24285?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-24285:
--------------------------------
Component/s: upstream
> Java coredump when starting jboss server from Eclipse
> -----------------------------------------------------
>
> Key: JBIDE-24285
> URL: https://issues.jboss.org/browse/JBIDE-24285
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: server, upstream
> Environment: Windows 7
> System memory 24GB - memory checked and no issues found.
> JDK 1.8.0_121 x64
> JBoss EAP 6.4
> Eclipse Neon.3 with JBoss server support installed (Not full JBoss Developer Studio)
> Reporter: Beirti O'Nunain
> Assignee: Rob Stryker
> Fix For: 4.5.0.AM1
>
> Attachments: hs_err_pid53068.log, hs_err_pid58832.log
>
>
> Intermittently, when starting a JBoss server from the "servers" view in Debug mode, the process coredumps shortly after starting the application. (3rd party application provided by Calypso) I've not seen this with non-jboss processes yet.
> Problematic frame always points to jvm.dll (same frame 0x68637). Logs attached.
> I've started the JBoss process with -Xcheck:jni but unfortunately the console is full of noise from
> WARNING: JNI local refs: zu, exceeds capacity: zu
> which causes the process to timeout on startup due to massively slowing down the startup. You can add this flag locally to see full logs
> Have also tried bumping Xmx/Xms from 1g to 4g but still getting the same issue. This issue does not occur if I start the server in 'run' mode instead of 'debug'.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBDS-4420) DevSuite 1.4 Mac installer Java Install Instructions.
by Robert Terzi (JIRA)
[ https://issues.jboss.org/browse/JBDS-4420?page=com.atlassian.jira.plugin.... ]
Robert Terzi commented on JBDS-4420:
------------------------------------
According to https://docs.oracle.com/javase/8/docs/technotes/guides/install/mac_jre.html
Installing a JRE from Oracle will not update java -version symlinks or add java to your path. To be able to do this, you need to install the JDK.
> DevSuite 1.4 Mac installer Java Install Instructions.
> -----------------------------------------------------
>
> Key: JBDS-4420
> URL: https://issues.jboss.org/browse/JBDS-4420
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: installer
> Environment: DevSuite Installer 1.4, online installer, Mac OS 10.10.5.
> Reporter: Robert Terzi
>
> Running the DevSuite 1.4 online installer on Mac OS, there are several problems with the instructions to install Java:
> # There is a link that is shown to "download from +this location+. The link doesn't work and it is impossible to find out where +this location+ is supposed to point to.
> # The instructions say that Java 1.8 is required, but they appear under an unchecked OpenJDK 1.8 box. It doesn't make it clear, why you can't just click the OpenJDK box.
> # The instructions don't indicate if you need a JDK or JRE.
> # It looks like it is trying to get you to download and install Oracle Java 1.8 but doesn't ever say that.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-19342) Update code to cope with generics added to org.eclipse.core.runtime package API
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19342?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-19342:
-------------------------------------
This seems a more overall problem than a specific one for components. Assigned to Jeff.
> Update code to cope with generics added to org.eclipse.core.runtime package API
> --------------------------------------------------------------------------------
>
> Key: JBIDE-19342
> URL: https://issues.jboss.org/browse/JBIDE-19342
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: aerogear-hybrid, archives, batch, bean-validation, birt, browsersim, cdi, cdi-extensions, central, common, cordovasim, forge, hibernate, integration-platform, jmx, jsf, jsp/jsf/xml/html-source-editing
> Affects Versions: 4.3.0.Alpha2
> Reporter: Fred Bricon
> Assignee: Jeff MAURY
> Priority: Minor
> Fix For: 4.5.0.AM1
>
>
> We need to detect and address any part of our code affected by generics added to the org.eclipse.core.runtime package API.
> From https://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg11590.html :
> {quote}
> See https://bugs.eclipse.org/bugs/show_bug.cgi?id=442021
> Markus Keller wrote up an nice summary of what consumers should do to fix any warnings that may be caused by this change at https://bugs.eclipse.org/bugs/show_bug.cgi?id=442021#c25
> Here is a copy of the recommendations if you are going to compile against the latest version of org.eclipse.equinox.common:
> 1. In MANIFEST.MF, update your Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.11.0,4.0.0)", or org.eclipse.equinox.common;bundle-version="[3.7.0,4.0.0)", or update your Import-Package: org.eclipse.core.runtime; version="[3.5,4.0)"
> 2. If your bundle re-exports one of these bundles, then you also have to make sure the minor version is incremented.
> 3. Remove unnecessary casts (Clean Up, or Problems view > Quick Fix > Select All)
> 4. Update implementations of IAdaptable#getAdapter(Class<T>), unless you override another implementation of that method that still uses the old signature.
> Typical change:
> Old:
> {code}
> public Object getAdapter(Class adapter) {
> if (ICompilationUnit.class.equals(adapter))
> return getCompilationUnit();
> return null;
> }
> {code}
> New:
> {code}
> public <T> T getAdapter(Class<T> adapter) {
> if (ICompilationUnit.class.equals(adapter))
> return adapter.cast(getCompilationUnit());
> return null;
> }
> {code}
> 5. Update implementations of IAdapterFactory
> Hint for 4. & 5.:
> - Open Type Hierarchy on IAdaptable, etc.
> - In the view menu, select a working set that contains your projects
> - In the methods list of the Type Hierarchy view, select the methods, and then click the first toolbar button (Lock View and Show Members in Hierarchy)
> {quote}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBDS-4418) DevSuite 1.4 Mac fails installing CDK
by Robert Terzi (JIRA)
[ https://issues.jboss.org/browse/JBDS-4418?page=com.atlassian.jira.plugin.... ]
Robert Terzi commented on JBDS-4418:
------------------------------------
According to https://docs.oracle.com/javase/8/docs/technotes/guides/install/mac_jre.html
"Installing a JRE from Oracle will not update java -version symlinks or add java to your path. To be able to do this, you need to install the JDK."
> DevSuite 1.4 Mac fails installing CDK
> -------------------------------------
>
> Key: JBDS-4418
> URL: https://issues.jboss.org/browse/JBDS-4418
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: installer
> Environment: Mac OS X 10.10.5, DevSuite 1.4.0 online installer.
> Reporter: Robert Terzi
> Attachments: install.log
>
>
> The DevSuite 1.4 installer failed while installing CDK. There are two problems
> # When an install fails and the installer can't make any progress, the flow stops. There is no prompt, no clues how to get help, find a log, etc. The user's only option is to give up and close the window.
> # the CDK install failed. It's not clear why, attaching /Applications/DevelopmentSuite/install.log. But looking at the logs it looks like there may be permission errors. There were no prompts related to needing to run as root, or password requests, etc. If it is permissions, it just silently fails.
> # Also, given that this is macOS, why is the installer trying to Windows admin commands (to add the user to "Hyper-V administrators")? (This should possibly be a separate bug.)
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-24484) deprecate jbosstools projects / move to Central ?
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24484?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-24484 at 5/31/17 4:07 PM:
-------------------------------------------------------------
[EDITED] Based on today's Cabal call & Rob/Jeff's comments below, the first pass plan for AM2 will be:
* jbosstools-freemarker: Move to Central; stop building; just include the bits from JBT 4.4.4.Final
* jbosstools-arquillian: Already in Central: JBT Central and devstudio Central EA. Move out of EA so it's in the same place for both JBT/devstudio.
* jbosstools-aerogear: Already in Central; also in Additional/Mobile catgs; stop building; just include the bits from JBT 4.4.4.Final
Then for AM3, if we want, we could also do this:
* jbosstools-livereload: Move to Central? [~jeffmaury] to talk to [~akazakov]
* jbosstools-xulrunner: Included in JBT/devstudio but uncategorized; move to Central? [~jeffmaury] to talk to [~akazakov]
* jbosstools-browsersim: Already in Central; remove from JBT/devstudio Core Tools? [~jeffmaury] to talk to [~akazakov]
See also https://docs.google.com/spreadsheets/d/1PTep1KGK2DVbmaWGwQOPhtbSsyROL_PY6...
was (Author: nickboldt):
Based on today's Cabal call, the first pass plan for AM2 will be:
* jbosstools-freemarker: Move to Central; stop building; just include the bits from JBT 4.4.4.Final
* jbosstools-arquillian: Already in Central: JBT Central and devstudio Central EA. Move out of EA so it's in the same place for both JBT/devstudio.
Then for AM3, if we want, we could also do this:
* jbosstools-livereload: Move to Central? [~jeffmaury] to talk to [~akazakov]
* jbosstools-xulrunner: Included in JBT/devstudio but uncategorized; move to Central? [~jeffmaury] to talk to [~akazakov]
* jbosstools-browsersim: Already in Central; remove from JBT/devstudio Core Tools? [~jeffmaury] to talk to [~akazakov]
> deprecate jbosstools projects / move to Central ?
> -------------------------------------------------
>
> Key: JBIDE-24484
> URL: https://issues.jboss.org/browse/JBIDE-24484
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.5.0.AM2
>
>
> With the upcoming plan for devstudio 11 / jbosstools 4.5, it may be time to consider moving parts of jbosstools / devstudio out of the Core Tools category and into Central as optional installs. Then in future we can deprecate them / remove them.
> Here's the list of projects in jbosstools:
> https://github.com/jbosstools/jbosstools-devdoc/blob/master/list_of_proje...
> https://issues.jboss.org/projects/JBIDE?selectedItem=com.atlassian.jira.j...
> Once we have an idea of which projects could be moved/removed/deprecated, we can open subtasks for those projects.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-24484) deprecate jbosstools projects / move to Central ?
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24484?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-24484 at 5/31/17 4:05 PM:
-------------------------------------------------------------
Based on today's Cabal call, the first pass plan for AM2 will be:
* jbosstools-freemarker: Move to Central; stop building; just include the bits from JBT 4.4.4.Final
* jbosstools-arquillian: Already in Central: JBT Central and devstudio Central EA. Move out of EA so it's in the same place for both JBT/devstudio.
Then for AM3, if we want, we could also do this:
* jbosstools-livereload: Move to Central? [~jeffmaury] to talk to [~akazakov]
* jbosstools-xulrunner: Included in JBT/devstudio but uncategorized; move to Central? [~jeffmaury] to talk to [~akazakov]
* jbosstools-browsersim: Already in Central; remove from JBT/devstudio Core Tools? [~jeffmaury] to talk to [~akazakov]
was (Author: nickboldt):
Based on today's Cabal call, the first pass plan for AM2 will be:
* jbosstools-freemarker: Move to Central; stop building; just include the bits from JBT 4.4.4.Final
* jbosstools-arquillian: Already in Central: JBT Central and devstudio Central EA. Move out of EA so it's in the same place for both JBT/devstudio.
* jbosstools-browsersim: Already in Central; remove from JBT/devstudio Core Tools.
Then for AM3, if we want, we could also do this:
* jbosstools-livereload: Move to Central? [~jeffmaury] to talk to [~akazakov]
* jbosstools-xulrunner: Included in JBT/devstudio but uncategorized; move to Central? [~jeffmaury] to talk to [~akazakov]
> deprecate jbosstools projects / move to Central ?
> -------------------------------------------------
>
> Key: JBIDE-24484
> URL: https://issues.jboss.org/browse/JBIDE-24484
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.5.0.AM2
>
>
> With the upcoming plan for devstudio 11 / jbosstools 4.5, it may be time to consider moving parts of jbosstools / devstudio out of the Core Tools category and into Central as optional installs. Then in future we can deprecate them / remove them.
> Here's the list of projects in jbosstools:
> https://github.com/jbosstools/jbosstools-devdoc/blob/master/list_of_proje...
> https://issues.jboss.org/projects/JBIDE?selectedItem=com.atlassian.jira.j...
> Once we have an idea of which projects could be moved/removed/deprecated, we can open subtasks for those projects.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-19342) Update code to cope with generics added to org.eclipse.core.runtime package API
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19342?page=com.atlassian.jira.plugi... ]
Rob Stryker reassigned JBIDE-19342:
-----------------------------------
Assignee: Jeff MAURY
> Update code to cope with generics added to org.eclipse.core.runtime package API
> --------------------------------------------------------------------------------
>
> Key: JBIDE-19342
> URL: https://issues.jboss.org/browse/JBIDE-19342
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: aerogear-hybrid, archives, batch, bean-validation, birt, browsersim, cdi, cdi-extensions, central, common, cordovasim, forge, hibernate, integration-platform, jmx, jsf, jsp/jsf/xml/html-source-editing
> Affects Versions: 4.3.0.Alpha2
> Reporter: Fred Bricon
> Assignee: Jeff MAURY
> Priority: Minor
> Fix For: 4.5.0.AM1
>
>
> We need to detect and address any part of our code affected by generics added to the org.eclipse.core.runtime package API.
> From https://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg11590.html :
> {quote}
> See https://bugs.eclipse.org/bugs/show_bug.cgi?id=442021
> Markus Keller wrote up an nice summary of what consumers should do to fix any warnings that may be caused by this change at https://bugs.eclipse.org/bugs/show_bug.cgi?id=442021#c25
> Here is a copy of the recommendations if you are going to compile against the latest version of org.eclipse.equinox.common:
> 1. In MANIFEST.MF, update your Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.11.0,4.0.0)", or org.eclipse.equinox.common;bundle-version="[3.7.0,4.0.0)", or update your Import-Package: org.eclipse.core.runtime; version="[3.5,4.0)"
> 2. If your bundle re-exports one of these bundles, then you also have to make sure the minor version is incremented.
> 3. Remove unnecessary casts (Clean Up, or Problems view > Quick Fix > Select All)
> 4. Update implementations of IAdaptable#getAdapter(Class<T>), unless you override another implementation of that method that still uses the old signature.
> Typical change:
> Old:
> {code}
> public Object getAdapter(Class adapter) {
> if (ICompilationUnit.class.equals(adapter))
> return getCompilationUnit();
> return null;
> }
> {code}
> New:
> {code}
> public <T> T getAdapter(Class<T> adapter) {
> if (ICompilationUnit.class.equals(adapter))
> return adapter.cast(getCompilationUnit());
> return null;
> }
> {code}
> 5. Update implementations of IAdapterFactory
> Hint for 4. & 5.:
> - Open Type Hierarchy on IAdaptable, etc.
> - In the view menu, select a working set that contains your projects
> - In the methods list of the Type Hierarchy view, select the methods, and then click the first toolbar button (Lock View and Show Members in Hierarchy)
> {quote}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months