[JBoss JIRA] (JBIDE-24522) Incremental deployment for WF11/EAP7.1 - only redeploy if necessary
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24522?page=com.atlassian.jira.plugi... ]
Rob Stryker resolved JBIDE-24522.
---------------------------------
Resolution: Done
Closing this. Please open any other more specific issues you find. I'm open to new solutions but I'd prefer focussed jiras on this topic rather than one large over-arching one. So let's take the broken situations one by one and see if we can get them fixed.
> Incremental deployment for WF11/EAP7.1 - only redeploy if necessary
> -------------------------------------------------------------------
>
> Key: JBIDE-24522
> URL: https://issues.jboss.org/browse/JBIDE-24522
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: server
> Affects Versions: 4.5.0.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.5.0.AM1
>
>
> As discussed with Rob, JBIDE-23784 added support for incremental deployment over management API for WildFly 11 / EAP 7.1. But it does not actually deploy incrementally. It will still redeploy the whole module on the server. The improvement that was done in that JIRA is that now the whole project is not copied over to the server every time there is a change - now only the changes are being sent. But the whole module is still redeployed.
> So I think it's worth looking into if it's possible to improve this further so that the module is not always redeployed on the server.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-24522) Incremental deployment for WF11/EAP7.1 - only redeploy if necessary
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24522?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-24522:
-------------------------------------
So I made a patch to fix this. It... works... a bit better than before. Changes to only an index.html will not initiate a redeployment. However, if the server is in debug mode, and you try to change a class file, and you have a breakpoint set there, it won't work properly, at all.
I'll be pinging the EAP team to help me debug it asap. For now, a proper workaround is to change the "Application Reload Behavior" field in the server editor to something like "\.jar$|\.class$" AND disable the breakpoint, then refresh the webpage, then enable the breakpoint to debug it.
This will force a redeploy to occur if any class files have changed. Why the normal remote debugger isn't working is very difficult to tell.
Either way, this definitely improves the situation. It may make sense to change the default pattern to be "\.jar$|\.class$" all the time. But I'm hesitatn to do that until I know what effect it would have on other situations.
> Incremental deployment for WF11/EAP7.1 - only redeploy if necessary
> -------------------------------------------------------------------
>
> Key: JBIDE-24522
> URL: https://issues.jboss.org/browse/JBIDE-24522
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: server
> Affects Versions: 4.5.0.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.5.0.AM1
>
>
> As discussed with Rob, JBIDE-23784 added support for incremental deployment over management API for WildFly 11 / EAP 7.1. But it does not actually deploy incrementally. It will still redeploy the whole module on the server. The improvement that was done in that JIRA is that now the whole project is not copied over to the server every time there is a change - now only the changes are being sent. But the whole module is still redeployed.
> So I think it's worth looking into if it's possible to improve this further so that the module is not always redeployed on the server.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-24547) Refactor ITests settings in parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24547?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-24547 at 6/7/17 3:27 PM:
------------------------------------------------------------
I would suggest that if you want different defaults when running itests, that the itests root pom set that different default.
For example:
https://github.com/jbosstools/jbosstools-server/pull/516
Otherwise I don't see a way to have useUIThread = true AND false in the same parent pom property.
Or, you could use the `mvn clean verify -P ITests` to enable the ITests profile in parent pom [1] which sets *useUIThread = false*, but that will also set the property false for unit tests too.
[1] https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml...
It's probably best to set the values you want at the itests/pom.xml level, so you override the default set for running unit tests.
was (Author: nickboldt):
I would suggest that if you want different defaults when running itests, that the itests root pom set that different default.
For example:
https://github.com/jbosstools/jbosstools-server/pull/516
Otherwise I don't see a way to have useUIThread = true AND false in the same parent pom property.
Or, you could use the `mvn clean verify -P ITests` to enable the ITests profile in parent pom which sets *useUIThread = false*, but that will also set the property false for unit tests too.
It's probably best to set the values you want at the itests/pom.xml level, so you override the default set for running unit tests.
> Refactor ITests settings in parent pom
> --------------------------------------
>
> Key: JBIDE-24547
> URL: https://issues.jboss.org/browse/JBIDE-24547
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build, integration-tests
> Reporter: Pavol Srna
> Assignee: Pavol Srna
> Fix For: 4.5.0.AM1
>
>
> It is desired that single 'mvn clean verify' command will run *unit tests* and *integration tests* in a single run. Parent pom should hold all shared settings across jbosstools repositories (e.g pluginCustomization, useUIThread etc ).
> The problem is that unit tests require useUIThread=true, but integration tests the opposite. We need to come with a solution where we share the settings in parent pom.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-24547) Refactor ITests settings in parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24547?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-24547:
------------------------------------
I would suggest that if you want different defaults when running itests, that the itests root pom set that different default.
For example:
https://github.com/jbosstools/jbosstools-server/pull/516
Otherwise I don't see a way to have useUIThread = true AND false in the same parent pom property.
Or, you could use the `mvn clean verify -P ITests` to enable the ITests profile in parent pom which sets *useUIThread = false*, but that will also set the property false for unit tests too.
It's probably best to set the values you want at the itests/pom.xml level, so you override the default set for running unit tests.
> Refactor ITests settings in parent pom
> --------------------------------------
>
> Key: JBIDE-24547
> URL: https://issues.jboss.org/browse/JBIDE-24547
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build, integration-tests
> Reporter: Pavol Srna
> Assignee: Pavol Srna
> Fix For: 4.5.0.AM1
>
>
> It is desired that single 'mvn clean verify' command will run *unit tests* and *integration tests* in a single run. Parent pom should hold all shared settings across jbosstools repositories (e.g pluginCustomization, useUIThread etc ).
> The problem is that unit tests require useUIThread=true, but integration tests the opposite. We need to come with a solution where we share the settings in parent pom.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-24547) Refactor ITests settings in parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24547?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-24547:
-------------------------------
Fix Version/s: 4.5.0.AM1
> Refactor ITests settings in parent pom
> --------------------------------------
>
> Key: JBIDE-24547
> URL: https://issues.jboss.org/browse/JBIDE-24547
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build, integration-tests
> Reporter: Pavol Srna
> Assignee: Pavol Srna
> Fix For: 4.5.0.AM1
>
>
> It is desired that single 'mvn clean verify' command will run *unit tests* and *integration tests* in a single run. Parent pom should hold all shared settings across jbosstools repositories (e.g pluginCustomization, useUIThread etc ).
> The problem is that unit tests require useUIThread=true, but integration tests the opposite. We need to come with a solution where we share the settings in parent pom.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months