[JBoss JIRA] (JBIDE-24184) Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24184?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-24184:
-------------------------------------
Sprint: devex #133 Jun 2017 (was: devex #132 May 2017)
> Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24184
> URL: https://issues.jboss.org/browse/JBIDE-24184
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.4.AM2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.0.AM1
>
>
> to turn on/off debugging and dev_mode for an app, one needs to set env variables. The keys that are used to set the values are all defined in the docker image labels (inspectable by doing {code}docker inspect <docker-image-id>{code}:
> * nodejs
> {code}
> "Labels": {
> ...
> "com.redhat.dev-mode": "DEV_MODE:false",
> "com.redhat.dev-mode.port": "DEBUG_PORT:5858",
> ...
> {code}
> * eap
> {code}
> "Labels": {
> ...
> "com.redhat.dev-mode": "DEBUG:true",
> "com.redhat.dev-mode.port": "DEBUG_PORT:8787",
> ...
> {code}
> Our code on the other hand is hard-coding these, not reading the keys from the docker image:
> {code}
> public class OpenShiftDebugUtils {
> private static final String DEBUG_KEY = "DEBUG";
> private static final String DEBUG_PORT_KEY = "DEBUG_PORT";
> ...
> {code}
> {code}
> public class OpenShiftLaunchController extends AbstractSubsystemController
> implements ISubsystemController, ILaunchServerController {
> ...
> private static final String DEV_MODE = "DEV_MODE"; //$NON-NLS-1$
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-24547) Refactor ITests settings in parent pom
by Pavol Srna (JIRA)
Pavol Srna created JBIDE-24547:
----------------------------------
Summary: Refactor ITests settings in parent pom
Key: JBIDE-24547
URL: https://issues.jboss.org/browse/JBIDE-24547
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build, integration-tests
Reporter: Pavol Srna
It is desired that single 'mvn clean verify' command will run *unit tests* and *integration tests* in a single run. Parent pom should hold all shared settings across jbosstools repositories (e.g pluginCustomization, useUIThread etc ).
The problem is that unit tests require useUIThread=true, but integration tests the opposite. We need to come with a solution where we share the settings in parent pom.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-24547) Refactor ITests settings in parent pom
by Pavol Srna (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24547?page=com.atlassian.jira.plugi... ]
Pavol Srna reassigned JBIDE-24547:
----------------------------------
Assignee: Pavol Srna
> Refactor ITests settings in parent pom
> --------------------------------------
>
> Key: JBIDE-24547
> URL: https://issues.jboss.org/browse/JBIDE-24547
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build, integration-tests
> Reporter: Pavol Srna
> Assignee: Pavol Srna
>
> It is desired that single 'mvn clean verify' command will run *unit tests* and *integration tests* in a single run. Parent pom should hold all shared settings across jbosstools repositories (e.g pluginCustomization, useUIThread etc ).
> The problem is that unit tests require useUIThread=true, but integration tests the opposite. We need to come with a solution where we share the settings in parent pom.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-24497) Refactor devstudio-byoe and devstudio-ui-central tests
by Lukáš Valach (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24497?page=com.atlassian.jira.plugi... ]
Lukáš Valach updated JBIDE-24497:
---------------------------------
Description: There is code repetition in devstudio-byoe and devstudio-ui-central and tests are not stable enough. They should be able to deal with remediation page and all other troubles they can meet during installation. All troubles (if any) should be logged, not ignored. (was: Devstudio-ui-central \[1\] test installs all the stuff from RH Central. It may happen that a remediation page appear during the installation.
We need to improve test to make it able to catch/report and deal with remediation page.
\[1\] https://github.com/jbdevstudio/jbdevstudio-qa/tree/master/devstudio-ui-ce...)
> Refactor devstudio-byoe and devstudio-ui-central tests
> ------------------------------------------------------
>
> Key: JBIDE-24497
> URL: https://issues.jboss.org/browse/JBIDE-24497
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: integration-tests, qa
> Affects Versions: 4.5.0.AM1
> Reporter: Lukáš Valach
> Assignee: Lukáš Valach
> Fix For: 4.5.0.AM2
>
>
> There is code repetition in devstudio-byoe and devstudio-ui-central and tests are not stable enough. They should be able to deal with remediation page and all other troubles they can meet during installation. All troubles (if any) should be logged, not ignored.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months