[JBoss JIRA] (JBIDE-19822) Explorer: Refactor to properly handle object change notifications
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19822?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-19822:
-------------------------------------
Labels: explorer openshift_v3 (was: )
> Explorer: Refactor to properly handle object change notifications
> -----------------------------------------------------------------
>
> Key: JBIDE-19822
> URL: https://issues.jboss.org/browse/JBIDE-19822
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Jeff Cantrill
> Assignee: Andre Dietisheim
> Labels: explorer, openshift_v3
> Fix For: 4.5.0.AM1
>
>
> The content provider associated OpenShift Explorer view currently, manually refreshes the view in certain situations. Additionally there is not a way to provide the same refresh mechanism for classes that don't implement IRefreshable. Propose to refactor the model and view so that the model does not have a direct reference to the view and incorporate a way to handle classes that don't inherit from ObservablePojo (e.g. IResource)
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-19822) Explorer: Refactor to properly handle object change notifications
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19822?page=com.atlassian.jira.plugi... ]
Andre Dietisheim resolved JBIDE-19822.
--------------------------------------
Assignee: Andre Dietisheim
Resolution: Done
Automatic updates are implemented. Resolving.
> Explorer: Refactor to properly handle object change notifications
> -----------------------------------------------------------------
>
> Key: JBIDE-19822
> URL: https://issues.jboss.org/browse/JBIDE-19822
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Jeff Cantrill
> Assignee: Andre Dietisheim
> Fix For: 4.5.0.AM1
>
>
> The content provider associated OpenShift Explorer view currently, manually refreshes the view in certain situations. Additionally there is not a way to provide the same refresh mechanism for classes that don't implement IRefreshable. Propose to refactor the model and view so that the model does not have a direct reference to the view and incorporate a way to handle classes that don't inherit from ObservablePojo (e.g. IResource)
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-19812) Refactor IConnection to be agnostic of authorization specifics
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19812?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-19812:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.5.0.AM1)
> Refactor IConnection to be agnostic of authorization specifics
> --------------------------------------------------------------
>
> Key: JBIDE-19812
> URL: https://issues.jboss.org/browse/JBIDE-19812
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Jeff Cantrill
> Labels: openshift_v3
> Fix For: 4.5.x
>
>
> The auth scheme can change in v3. A plain IConnection should be able to be refactored to support the auth details as an interface and details like get/set password, username, etc should be moved to those interface implementations.
> {code}
> public interface IConnection {
> ...
> public String getUsername();
> public void setUsername(String username);
> public String getPassword();
> public void setPassword(String password);
> public void setRememberPassword(boolean rememberPassword);
>
> public boolean isRememberPassword();
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-19594) SSL callback: provide meaningful hostname verifier, stop always accepting hostnames
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19594?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-19594:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.5.0.AM1)
> SSL callback: provide meaningful hostname verifier, stop always accepting hostnames
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-19594
> URL: https://issues.jboss.org/browse/JBIDE-19594
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Alpha2
> Reporter: Andre Dietisheim
> Fix For: 4.5.x
>
>
> We're currently using an SSL callback that will allow users to get informed and act upon "faulty" certificates (ex. self-signed ones) and mismatches btw. the host we're talking to and the one that is referenced in the ssl certificate:
> {code:title=com.openshift.client.IHttpClient.ISSLCertificateCallback}
> public interface ISSLCertificateCallback {
> public boolean allowCertificate(X509Certificate[] chain);
> public boolean allowHostname(String hostname, SSLSession session);
> }
> {code}
> The callback that we are using in JBT is presenting a dialog in case the jdk cannot verify the certificate (ex. self signed certificates) and allows the user to accept/deny it.
> In case the jdk cannot verify the hostname (the host we're talking to is not matching the host that's referenced in the certificate) we're currently always accepting the hostname:
> {code:title=org.jboss.tools.openshift.express.internal.ui.wizard.connection.SSLCertificateCallback}
> @Override
> public boolean allowHostname(String hostname, SSLSession sslSession) {
> return true;
> }
> {code}
> We should find a meaningfull implementation of such a verification that does not simply always accept it. A first idea would be to present the mismatch to the user and allow it to accept/refute it.
> This issue came up JBIDE-19581 when there was no callback installed which made the hostname verification fail as in jdk. When fetching the quickstarts OSJC is reaching out to https://hub.openshift.com (https://hub.openshift.com/api/v1/quickstarts/promoted.json) while the ssl certificate presented only covers openshift.redhat.com:
> {code}
> * Server certificate:
> * subject: CN=openshift.redhat.com,O=Red Hat Inc.,L=Raleigh,ST=North Carolina,C=US
> * start date: Jul 23 00:00:00 2014 GMT
> * expire date: Jul 27 12:00:00 2017 GMT
> * common name: openshift.redhat.com
> * issuer: CN=DigiCert SHA2 High Assurance Server CA,OU=www.digicert.com,O=DigiCert Inc,C=US
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-19594) SSL callback: provide meaningful hostname verifier, stop always accepting hostnames
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19594?page=com.atlassian.jira.plugi... ]
Andre Dietisheim reassigned JBIDE-19594:
----------------------------------------
Assignee: Andre Dietisheim
> SSL callback: provide meaningful hostname verifier, stop always accepting hostnames
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-19594
> URL: https://issues.jboss.org/browse/JBIDE-19594
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Alpha2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.5.x
>
>
> We're currently using an SSL callback that will allow users to get informed and act upon "faulty" certificates (ex. self-signed ones) and mismatches btw. the host we're talking to and the one that is referenced in the ssl certificate:
> {code:title=com.openshift.client.IHttpClient.ISSLCertificateCallback}
> public interface ISSLCertificateCallback {
> public boolean allowCertificate(X509Certificate[] chain);
> public boolean allowHostname(String hostname, SSLSession session);
> }
> {code}
> The callback that we are using in JBT is presenting a dialog in case the jdk cannot verify the certificate (ex. self signed certificates) and allows the user to accept/deny it.
> In case the jdk cannot verify the hostname (the host we're talking to is not matching the host that's referenced in the certificate) we're currently always accepting the hostname:
> {code:title=org.jboss.tools.openshift.express.internal.ui.wizard.connection.SSLCertificateCallback}
> @Override
> public boolean allowHostname(String hostname, SSLSession sslSession) {
> return true;
> }
> {code}
> We should find a meaningfull implementation of such a verification that does not simply always accept it. A first idea would be to present the mismatch to the user and allow it to accept/refute it.
> This issue came up JBIDE-19581 when there was no callback installed which made the hostname verification fail as in jdk. When fetching the quickstarts OSJC is reaching out to https://hub.openshift.com (https://hub.openshift.com/api/v1/quickstarts/promoted.json) while the ssl certificate presented only covers openshift.redhat.com:
> {code}
> * Server certificate:
> * subject: CN=openshift.redhat.com,O=Red Hat Inc.,L=Raleigh,ST=North Carolina,C=US
> * start date: Jul 23 00:00:00 2014 GMT
> * expire date: Jul 27 12:00:00 2017 GMT
> * common name: openshift.redhat.com
> * issuer: CN=DigiCert SHA2 High Assurance Server CA,OU=www.digicert.com,O=DigiCert Inc,C=US
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-20125) Import wizard, application wizard: use easy import, not our custom facility
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20125?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-20125:
-------------------------------------
Labels: import_wizard openshift_v3 (was: openshift_v3)
> Import wizard, application wizard: use easy import, not our custom facility
> ---------------------------------------------------------------------------
>
> Key: JBIDE-20125
> URL: https://issues.jboss.org/browse/JBIDE-20125
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Andre Dietisheim
> Labels: import_wizard, openshift_v3
> Fix For: 4.5.x
>
> Original Estimate: 1 week
> Remaining Estimate: 1 week
>
> The current impl of the import wizard in v2 and v3 is using a custom import logic where it launches m2e for repositories that have a pom.xml and "General project" for all the others. In JBDS-3285 [~mickael_istria] contributed a new Easy import facility for Eclipse that we should use instead of our own minimalistic, custom made approach
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-19960) Import wizard: Should be able to specify "Working set" when importing project
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19960?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-19960:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.5.0.AM1)
> Import wizard: Should be able to specify "Working set" when importing project
> -----------------------------------------------------------------------------
>
> Key: JBIDE-19960
> URL: https://issues.jboss.org/browse/JBIDE-19960
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Jeff Cantrill
> Priority: Minor
> Labels: import_wizard, openshift_v3
> Fix For: 4.5.x
>
>
> # ASSERT: make sure that you have package explorer set to display working sets and "Other Projects" disabled (unchecked)
> # EXEC: launch import wizard
> # EXEC: check if you can see you project once the import is finished.
> Result:
> You cannot spot your project since it was imported to "Other Projects" which is disabled.
> We should allow users to specify a working set when importing a new project via Import wizard.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (JBIDE-20125) Import wizard, application wizard: use easy import, not our custom facility
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20125?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-20125:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.5.0.AM1)
> Import wizard, application wizard: use easy import, not our custom facility
> ---------------------------------------------------------------------------
>
> Key: JBIDE-20125
> URL: https://issues.jboss.org/browse/JBIDE-20125
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Andre Dietisheim
> Labels: openshift_v3
> Fix For: 4.5.x
>
> Original Estimate: 1 week
> Remaining Estimate: 1 week
>
> The current impl of the import wizard in v2 and v3 is using a custom import logic where it launches m2e for repositories that have a pom.xml and "General project" for all the others. In JBDS-3285 [~mickael_istria] contributed a new Easy import facility for Eclipse that we should use instead of our own minimalistic, custom made approach
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months