[JBoss JIRA] (JBIDE-24273) CDK3 server adapter editor: can save editor even if "Minishift Location" is invalid
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24273?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-24273:
---------------------------------------
I have a comment about this. I have a few arguments in favor of the old behavior. First is that when I start devstudio for the first time, there will already be a cdk3 adapter created because ~/.minishift was found. But this adapter will have an empty minishift binary location. So you can see that in any case you cannot rely on a valid binary being always set. And secondly, even if a binary is valid at the time of the dialog saving, you can remove or change it at a later time. So in my opinion this does not bring much value - I think the decorator is enough. Furthermore, I don't like the popup. Normally, when you have a validation, usually it's in a dialog where you will just disable the Finish or Next button, but of course that's not an option here.
I just wanted to add my $0.02. I'm not saying that you need to revert this or something.
> CDK3 server adapter editor: can save editor even if "Minishift Location" is invalid
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-24273
> URL: https://issues.jboss.org/browse/JBIDE-24273
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.4.4.AM3
> Reporter: Andre Dietisheim
> Assignee: Rob Stryker
> Fix For: 4.5.0.AM2
>
>
> # ASSERT: have a non-executable file ready
> # ASSERT: have a cdk3/minishift server adapter
> # EXEC: open server editor for your cdk3/minishift adapter
> # EXEC: for "Minishift Location" hit "Browse" and choose your non-executable file
> # ASSERT: error decoration appears
> # EXEC: hit "Save"
> Result:
> The server adapter is saved even though the minishift location is erroneous
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-24125) Import wizard: adapt ITs to changes introduced in JBIDE-24048
by Radim Hopp (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24125?page=com.atlassian.jira.plugi... ]
Radim Hopp updated JBIDE-24125:
-------------------------------
Sprint: devex #135 July 2017
> Import wizard: adapt ITs to changes introduced in JBIDE-24048
> -------------------------------------------------------------
>
> Key: JBIDE-24125
> URL: https://issues.jboss.org/browse/JBIDE-24125
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.4.AM2
> Reporter: Andre Dietisheim
> Assignee: Radim Hopp
> Fix For: 4.5.x
>
>
> In JBIDE-24048 changes have been done to the import wizard. We should change the ITs to cover these changes.
> @rhopp @bdshadow can you please test this since it's a rather larger change and provides changes in how it behaves?
> * Validations were extended:
> ** is the existing clone destination a git repo?
> ** is the existing clone destination a clone of the source that is used in OpenShift?
> * We now also ask the user if he wants to checkout the correct branch (the one that's used in OpenShift) in the existing git repo
> * UI was slightly changed according to requests made in JBIDE-21935
> * We now also close the wizard dialog before executing the import. This should allow the user to continue working.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-24679) Adopt webservices itests
by Pavol Srna (JIRA)
Pavol Srna created JBIDE-24679:
----------------------------------
Summary: Adopt webservices itests
Key: JBIDE-24679
URL: https://issues.jboss.org/browse/JBIDE-24679
Project: Tools (JBoss Tools)
Issue Type: Task
Components: integration-tests, webservices
Reporter: Pavol Srna
Fix For: 4.5.0.Final
jnovak has left Red Hat, new QE component owner will need:
- get familiar with the code
- fix failing itests
- fix jenkins jobs
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months