[JBoss JIRA] (JBIDE-24184) Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24184?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24184 at 7/12/17 8:21 PM:
-------------------------------------------------------------------
There are issues for nodejs template based applications left in the [PR|https://github.com/jbosstools/jbosstools-openshift/pull/1518#issuecomm...]. I opted for postponing it to 4.5.0.Final
I could fix a part of it (the replication controller is now found once the build is finished) but couldnt resolve the whole issue (launching a server adapter for a freshly created app, that is based on the "nodejs-mongo-persistent" template, fails to start up. It complains that it doesnt find any matching replication controller). This very fact needs to be confirmed by QE/tester though.
I also think that it needs more serious testing since there's larger refactoring involved.
was (Author: adietish):
There are issues for nodejs template based applications left in the [PR|https://github.com/jbosstools/jbosstools-openshift/pull/1518#issuecomm...]. I opted for postponing it to 4.5.0.Final
I could fix a part of it but couldnt resolve the whole issue (launching a server adapter for a freshly created app, that is based on the "nodejs-mongo-persistent" template, fails to start up. It complains that it doesnt find any matching replication controller. Relaunching it once the build is fully finished works fine in my tests. This very fact needs to be confirmed by QE/tester though).
I also think that it needs more serious testing since there's larger refactoring involved.
> Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24184
> URL: https://issues.jboss.org/browse/JBIDE-24184
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.4.AM2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.0.Final
>
>
> to turn on/off debugging and dev_mode for an app, one needs to set env variables. The keys that are used to set the values are all defined in the docker image labels (inspectable by doing {code}docker inspect <docker-image-id>{code}:
> * nodejs
> {code}
> "Labels": {
> ...
> "com.redhat.dev-mode": "DEV_MODE:false",
> "com.redhat.dev-mode.port": "DEBUG_PORT:5858",
> ...
> {code}
> * eap
> {code}
> "Labels": {
> ...
> "com.redhat.dev-mode": "DEBUG:true",
> "com.redhat.dev-mode.port": "DEBUG_PORT:8787",
> ...
> {code}
> Our code on the other hand is hard-coding these, not reading the keys from the docker image:
> {code}
> public class OpenShiftDebugUtils {
> private static final String DEBUG_KEY = "DEBUG";
> private static final String DEBUG_PORT_KEY = "DEBUG_PORT";
> ...
> {code}
> {code}
> public class OpenShiftLaunchController extends AbstractSubsystemController
> implements ISubsystemController, ILaunchServerController {
> ...
> private static final String DEV_MODE = "DEV_MODE"; //$NON-NLS-1$
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-24184) Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24184?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24184 at 7/12/17 8:19 PM:
-------------------------------------------------------------------
There are issues for nodejs template based applications left in the [PR|https://github.com/jbosstools/jbosstools-openshift/pull/1518#issuecomm...]. I opted for postponing it to 4.5.0.Final
I could fix a part of it but couldnt resolve the whole issue (launching a server adapter for a freshly created app, that is based on the "nodejs-mongo-persistent" template, fails to start up. It complains that it doesnt find any matching replication controller. Relaunching it once the build is fully finished works fine in my tests. This very fact needs to be confirmed by QE/tester though).
I also think that it needs more serious testing since there's larger refactoring involved.
was (Author: adietish):
There are issues for nodejs template based applications left in the [PR|https://github.com/jbosstools/jbosstools-openshift/pull/1518#issuecomm...]. I could fix a part of it but couldnt for resolve the whole issue. I also think that it needs more serious testing since there's larger refactoring involved. It should get merged as early as possible in the upcoming sprint. Postponing to 4.5.0.Final
> Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24184
> URL: https://issues.jboss.org/browse/JBIDE-24184
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.4.AM2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.0.Final
>
>
> to turn on/off debugging and dev_mode for an app, one needs to set env variables. The keys that are used to set the values are all defined in the docker image labels (inspectable by doing {code}docker inspect <docker-image-id>{code}:
> * nodejs
> {code}
> "Labels": {
> ...
> "com.redhat.dev-mode": "DEV_MODE:false",
> "com.redhat.dev-mode.port": "DEBUG_PORT:5858",
> ...
> {code}
> * eap
> {code}
> "Labels": {
> ...
> "com.redhat.dev-mode": "DEBUG:true",
> "com.redhat.dev-mode.port": "DEBUG_PORT:8787",
> ...
> {code}
> Our code on the other hand is hard-coding these, not reading the keys from the docker image:
> {code}
> public class OpenShiftDebugUtils {
> private static final String DEBUG_KEY = "DEBUG";
> private static final String DEBUG_PORT_KEY = "DEBUG_PORT";
> ...
> {code}
> {code}
> public class OpenShiftLaunchController extends AbstractSubsystemController
> implements ISubsystemController, ILaunchServerController {
> ...
> private static final String DEV_MODE = "DEV_MODE"; //$NON-NLS-1$
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-24184) Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24184?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-24184:
------------------------------------------
There are issues for nodejs template based applications left in the [PR|https://github.com/jbosstools/jbosstools-openshift/pull/1518#issuecomm...]. I could fix a part of it but couldnt for resolve the whole issue. I also think that it needs more serious testing since there's larger refactoring involved. It should get merged as early as possible in the upcoming sprint. Postponing to 4.5.0.Final
> Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24184
> URL: https://issues.jboss.org/browse/JBIDE-24184
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.4.AM2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.0.Final
>
>
> to turn on/off debugging and dev_mode for an app, one needs to set env variables. The keys that are used to set the values are all defined in the docker image labels (inspectable by doing {code}docker inspect <docker-image-id>{code}:
> * nodejs
> {code}
> "Labels": {
> ...
> "com.redhat.dev-mode": "DEV_MODE:false",
> "com.redhat.dev-mode.port": "DEBUG_PORT:5858",
> ...
> {code}
> * eap
> {code}
> "Labels": {
> ...
> "com.redhat.dev-mode": "DEBUG:true",
> "com.redhat.dev-mode.port": "DEBUG_PORT:8787",
> ...
> {code}
> Our code on the other hand is hard-coding these, not reading the keys from the docker image:
> {code}
> public class OpenShiftDebugUtils {
> private static final String DEBUG_KEY = "DEBUG";
> private static final String DEBUG_PORT_KEY = "DEBUG_PORT";
> ...
> {code}
> {code}
> public class OpenShiftLaunchController extends AbstractSubsystemController
> implements ISubsystemController, ILaunchServerController {
> ...
> private static final String DEV_MODE = "DEV_MODE"; //$NON-NLS-1$
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-24184) Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24184?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-24184:
-------------------------------------
Fix Version/s: 4.5.0.Final
(was: 4.5.0.AM2)
> Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24184
> URL: https://issues.jboss.org/browse/JBIDE-24184
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.4.AM2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.0.Final
>
>
> to turn on/off debugging and dev_mode for an app, one needs to set env variables. The keys that are used to set the values are all defined in the docker image labels (inspectable by doing {code}docker inspect <docker-image-id>{code}:
> * nodejs
> {code}
> "Labels": {
> ...
> "com.redhat.dev-mode": "DEV_MODE:false",
> "com.redhat.dev-mode.port": "DEBUG_PORT:5858",
> ...
> {code}
> * eap
> {code}
> "Labels": {
> ...
> "com.redhat.dev-mode": "DEBUG:true",
> "com.redhat.dev-mode.port": "DEBUG_PORT:8787",
> ...
> {code}
> Our code on the other hand is hard-coding these, not reading the keys from the docker image:
> {code}
> public class OpenShiftDebugUtils {
> private static final String DEBUG_KEY = "DEBUG";
> private static final String DEBUG_PORT_KEY = "DEBUG_PORT";
> ...
> {code}
> {code}
> public class OpenShiftLaunchController extends AbstractSubsystemController
> implements ISubsystemController, ILaunchServerController {
> ...
> private static final String DEV_MODE = "DEV_MODE"; //$NON-NLS-1$
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (ERT-517) Add basic security for running images [EBZ#519581]
by Friendly Jira Robot (JIRA)
Friendly Jira Robot created ERT-517:
---------------------------------------
Summary: Add basic security for running images [EBZ#519581]
Key: ERT-517
URL: https://issues.jboss.org/browse/ERT-517
Project: Eclipse Release Train
Issue Type: Task
Components: Linux Tools
Reporter: Friendly Jira Robot
Fix For: Oxygen.1 (4.7)
In a blog by Daniel Walsh, it was recommended that Containers be run with readonly root fs (--readonly). That said, to run most Containers successfully, this option also required accessing /run and /tmp in tmpfs (--tmpfs /run --tmpfs /tmp).
A basic security option should be added to the Run Image Wizard to support:
--readonly --tmpfs /run --tmpfs /tmp
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (ERT-516) Add basic security for running images [EBZ#519581]
by Friendly Jira Robot (JIRA)
Friendly Jira Robot created ERT-516:
---------------------------------------
Summary: Add basic security for running images [EBZ#519581]
Key: ERT-516
URL: https://issues.jboss.org/browse/ERT-516
Project: Eclipse Release Train
Issue Type: Task
Components: Linux Tools
Reporter: Friendly Jira Robot
Fix For: Oxygen.1 (4.7)
In a blog by Daniel Walsh, it was recommended that Containers be run with readonly root fs (--readonly). That said, to run most Containers successfully, this option also required accessing /run and /tmp in tmpfs (--tmpfs /run --tmpfs /tmp).
A basic security option should be added to the Run Image Wizard to support:
--readonly --tmpfs /run --tmpfs /tmp
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-19604) Save Password in New Openshift Application Wizard is annoying
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19604?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-19604:
--------------------------------
Labels: openshift_v2 openshift_v3 (was: openshift_v2)
> Save Password in New Openshift Application Wizard is annoying
> -------------------------------------------------------------
>
> Key: JBIDE-19604
> URL: https://issues.jboss.org/browse/JBIDE-19604
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.Alpha2
> Environment: Linux, x86_64, Open JDK 7
> Reporter: Denis Golovin
> Assignee: Rob Stryker
> Labels: openshift_v2, openshift_v3
> Fix For: 4.5.0.AM2
>
> Attachments: openshif-save-password.mp4
>
>
> Selected "Save Password" option in wizard triggers secure storage login that cannot be canceled in on click. This dialog keeps coming back after Cancel is pressed (three or more times). After reopening wizard first Security Storage Login pops up that I have to Cancel it several times (see attached video).
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-23862) Server adapter: if "oc" in preferences is set to path with a " " syncing fails
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23862?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-23862:
-------------------------------------
This really seems like a bug to me in 'oc'. The original issue was that you couldn't find or run oc. Once that was "fixed", the next issue was that oc couldn't launch rsync properly because it was not escaping the spaces.
I've pinged hardy to get some info on the topic.
> Server adapter: if "oc" in preferences is set to path with a " " syncing fails
> ------------------------------------------------------------------------------
>
> Key: JBIDE-23862
> URL: https://issues.jboss.org/browse/JBIDE-23862
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.3.Final
> Reporter: Andre Dietisheim
> Assignee: Dmitrii Bocharov
> Labels: oc_binary, openshift_v3
> Fix For: 4.5.0.Final
>
> Attachments: ProcessMain.java, error-in-rsync-for-macos.png
>
>
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months