[JBoss JIRA] (JBIDE-24877) CDK 2 detection results in CDK 3 adapter creation
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24877?page=com.atlassian.jira.plugi... ]
Martin Malina updated JBIDE-24877:
----------------------------------
Priority: Minor (was: Major)
> CDK 2 detection results in CDK 3 adapter creation
> -------------------------------------------------
>
> Key: JBIDE-24877
> URL: https://issues.jboss.org/browse/JBIDE-24877
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Priority: Minor
>
> As described by [~odockal] in JBIDE-24447:
> When you start devstudio and it finds cdk 2 installed inside ../../../cdk/ relative to eclipse's config, it will create a cdk 3 server instead of cdk 2.
> This relative path normally translate to a structure like this:
> $SOME_DIR/devstudio
> $SOME_DIR/cdk/YOUR/CDK/2/SOMEWHERE/INSIDE/HERE
> BUT... this will only happen in a special situation where you have CDK 2 installed where devstudio looks for it (see above) AND you set up the MINISHIFT_HOME env var to point to your CDK 3 home when you start devstudio.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24877) CDK 2 detection results in CDK 3 adapter creation
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24877?page=com.atlassian.jira.plugi... ]
Ondrej Dockal commented on JBIDE-24877:
---------------------------------------
This is pretty rare situation. I might suggest even to lower the priority..
> CDK 2 detection results in CDK 3 adapter creation
> -------------------------------------------------
>
> Key: JBIDE-24877
> URL: https://issues.jboss.org/browse/JBIDE-24877
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
>
> As described by [~odockal] in JBIDE-24447:
> When you start devstudio and it finds cdk 2 installed inside ../../../cdk/ relative to eclipse's config, it will create a cdk 3 server instead of cdk 2.
> This relative path normally translate to a structure like this:
> $SOME_DIR/devstudio
> $SOME_DIR/cdk/YOUR/CDK/2/SOMEWHERE/INSIDE/HERE
> BUT... this will only happen in a special situation where you have CDK 2 installed where devstudio looks for it (see above) AND you set up the MINISHIFT_HOME env var to point to your CDK 3 home when you start devstudio.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24877) CDK 2 detection results in CDK 3 adapter creation
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24877?page=com.atlassian.jira.plugi... ]
Martin Malina updated JBIDE-24877:
----------------------------------
Steps to Reproduce:
1. Install devstudio into a $DIR
2. Make sure cdk 2 is installed somewhere in $DIR/../cdk
3. Have CDK 3 installed in MINISHIFT_HOME
3. Start devstudio with MINISHIFT_HOME set up
CDK 3 server will be created pointing to your CDK 2 location.
The correct thing would be to have CDK 2 server pointing to your CDK 2 location and another CDK 3 server pointing to MINISHIFT_HOME.
was:
1. Install devstudio into a $DIR
2. Make sure cdk 2 is installed somewhere in $DIR/../cdk
3. Start devstudio
CDK 3 server will be created pointing to your CDK 2 location.
> CDK 2 detection results in CDK 3 adapter creation
> -------------------------------------------------
>
> Key: JBIDE-24877
> URL: https://issues.jboss.org/browse/JBIDE-24877
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
>
> As described by [~odockal] in JBIDE-24447:
> When you start devstudio and it finds cdk 2 installed inside ../../../cdk/ relative to eclipse's config, it will create a cdk 3 server instead of cdk 2.
> This relative path normally translate to a structure like this:
> $SOME_DIR/devstudio
> $SOME_DIR/cdk/YOUR/CDK/2/SOMEWHERE/INSIDE/HERE
> BUT... this will only happen in a special situation where you have CDK 2 installed where devstudio looks for it (see above) AND you set up the MINISHIFT_HOME env var to point to your CDK 3 home when you start devstudio.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24877) CDK 2 detection results in CDK 3 adapter creation
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24877?page=com.atlassian.jira.plugi... ]
Martin Malina updated JBIDE-24877:
----------------------------------
Description:
As described by [~odockal] in JBIDE-24447:
When you start devstudio and it finds cdk 2 installed inside ../../../cdk/ relative to eclipse's config, it will create a cdk 3 server instead of cdk 2.
This relative path normally translate to a structure like this:
$SOME_DIR/devstudio
$SOME_DIR/cdk/YOUR/CDK/2/SOMEWHERE/INSIDE/HERE
BUT... this will only happen in a special situation where you have CDK 2 installed where devstudio looks for it (see above) AND you set up the MINISHIFT_HOME env var to point to your CDK 3 home when you start devstudio.
was:
As described by [~odockal] in JBIDE-24447:
When you start devstudio and it finds cdk 2 installed inside ../../../cdk/ relative to eclipse's config, it will create a cdk 3 server instead of cdk 2.
This relative path normally translate to a structure like this:
$SOME_DIR/devstudio
$SOME_DIR/cdk/YOUR/CDK/2/SOMEWHERE/INSIDE/HERE
> CDK 2 detection results in CDK 3 adapter creation
> -------------------------------------------------
>
> Key: JBIDE-24877
> URL: https://issues.jboss.org/browse/JBIDE-24877
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.1.AM1
> Reporter: Martin Malina
> Assignee: Rob Stryker
>
> As described by [~odockal] in JBIDE-24447:
> When you start devstudio and it finds cdk 2 installed inside ../../../cdk/ relative to eclipse's config, it will create a cdk 3 server instead of cdk 2.
> This relative path normally translate to a structure like this:
> $SOME_DIR/devstudio
> $SOME_DIR/cdk/YOUR/CDK/2/SOMEWHERE/INSIDE/HERE
> BUT... this will only happen in a special situation where you have CDK 2 installed where devstudio looks for it (see above) AND you set up the MINISHIFT_HOME env var to point to your CDK 3 home when you start devstudio.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24447) Look for minishift configuration in MINISHIFT_HOME
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24447?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-24447:
---------------------------------------
I created a bug for this - that cdk 3 is created when cdk 2 is detected: JBIDE-24877 I haven't tried it myself yet.
> Look for minishift configuration in MINISHIFT_HOME
> --------------------------------------------------
>
> Key: JBIDE-24447
> URL: https://issues.jboss.org/browse/JBIDE-24447
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: runtime-detection
> Affects Versions: 4.4.4.Final
> Reporter: Jan Richter
> Assignee: Rob Stryker
> Fix For: 4.5.x
>
> Attachments: cdk2_x_RD.png, cdk3_minishift_home.png
>
>
> One can use the MINISHIFT_HOME variable to save minishift configuration somewhere else than in ~/.minishift
> It would be nice if runtime detection looked there if the variable is configured.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24877) CDK 2 detection results in CDK 3 adapter creation
by Martin Malina (JIRA)
Martin Malina created JBIDE-24877:
-------------------------------------
Summary: CDK 2 detection results in CDK 3 adapter creation
Key: JBIDE-24877
URL: https://issues.jboss.org/browse/JBIDE-24877
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdk
Affects Versions: 4.5.1.AM1
Reporter: Martin Malina
Assignee: Rob Stryker
As described by [~odockal] in JBIDE-24447:
When you start devstudio and it finds cdk 2 installed inside ../../../cdk/ relative to eclipse's config, it will create a cdk 3 server instead of cdk 2.
This relative path normally translate to a structure like this:
$SOME_DIR/devstudio
$SOME_DIR/cdk/YOUR/CDK/2/SOMEWHERE/INSIDE/HERE
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24447) Look for minishift configuration in MINISHIFT_HOME
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24447?page=com.atlassian.jira.plugi... ]
Ondrej Dockal edited comment on JBIDE-24447 at 8/18/17 5:37 AM:
----------------------------------------------------------------
So, I would like to make it clear.
> CDK 2 is automatically detected by checking the running eclipse's configuration location and going to the relative path Platform.getOS().equals(Platform.OS_MACOSX) ? "../../../" : "") + "../../../cdk/"; This is typically where the installer would install the older runtimes. It then scans that folder for stuff.
Alright, then it is explained why cdk 2.x is detected ([~mmalina] I have CDK 2.x configured in /home/odockal/Programs/cdk, so it seems like luck here). I have no problem with that. The thing is that runtime-detection finds path of CDK 2.x and use it in *CDK 3* server adapter which is bug in my opinion. CDK 2.x server adapter should be created, not CDK 3, right? Note that CDK3 server adapter is created only on fresh start (new workspace) and iff MINISHIFT_HOME env. var is set. If it is not set, then CDK 2.x is created (which seems correct).
was (Author: odockal):
So, I would like to make it clear.
> CDK 2 is automatically detected by checking the running eclipse's configuration location and going to the relative path Platform.getOS().equals(Platform.OS_MACOSX) ? "../../../" : "") + "../../../cdk/"; This is typically where the installer would install the older runtimes. It then scans that folder for stuff.
Alright, then it is explained why cdk 2.x is detected ([~mmalina] I have CDK 2.x set on that path, so it is alright). I have no problem with that. The thing is that runtime-detection finds path of CDK 2.x and use it in *CDK 3* server adapter which is bug in my opinion. CDK 2.x server adapter should be created, not CDK 3, right? Notice that CDK3 server adapter is created only on fresh start (new workspace) and if MINISHIFT_HOME env. var is set. If not set, then CDK 2.x is created (which seems corret).
> Look for minishift configuration in MINISHIFT_HOME
> --------------------------------------------------
>
> Key: JBIDE-24447
> URL: https://issues.jboss.org/browse/JBIDE-24447
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: runtime-detection
> Affects Versions: 4.4.4.Final
> Reporter: Jan Richter
> Assignee: Rob Stryker
> Fix For: 4.5.x
>
> Attachments: cdk2_x_RD.png, cdk3_minishift_home.png
>
>
> One can use the MINISHIFT_HOME variable to save minishift configuration somewhere else than in ~/.minishift
> It would be nice if runtime detection looked there if the variable is configured.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24447) Look for minishift configuration in MINISHIFT_HOME
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24447?page=com.atlassian.jira.plugi... ]
Ondrej Dockal commented on JBIDE-24447:
---------------------------------------
So, I would like to make it clear.
> CDK 2 is automatically detected by checking the running eclipse's configuration location and going to the relative path Platform.getOS().equals(Platform.OS_MACOSX) ? "../../../" : "") + "../../../cdk/"; This is typically where the installer would install the older runtimes. It then scans that folder for stuff.
Alright, then it is explained why cdk 2.x is detected ([~mmalina] I have CDK 2.x set on that path, so it is alright). I have no problem with that. The thing is that runtime-detection finds path of CDK 2.x and use it in *CDK 3* server adapter which is bug in my opinion. CDK 2.x server adapter should be created, not CDK 3, right? Notice that CDK3 server adapter is created only on fresh start (new workspace) and if MINISHIFT_HOME env. var is set. If not set, then CDK 2.x is created (which seems corret).
> Look for minishift configuration in MINISHIFT_HOME
> --------------------------------------------------
>
> Key: JBIDE-24447
> URL: https://issues.jboss.org/browse/JBIDE-24447
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: runtime-detection
> Affects Versions: 4.4.4.Final
> Reporter: Jan Richter
> Assignee: Rob Stryker
> Fix For: 4.5.x
>
> Attachments: cdk2_x_RD.png, cdk3_minishift_home.png
>
>
> One can use the MINISHIFT_HOME variable to save minishift configuration somewhere else than in ~/.minishift
> It would be nice if runtime detection looked there if the variable is configured.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24796) Starting of CDK 3 Server Adapter with Minishift Home that differs from ~/.minishift prevents OS tooling to create proper connection and links it to default project
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24796?page=com.atlassian.jira.plugi... ]
Ondrej Dockal commented on JBIDE-24796:
---------------------------------------
Verified on my side too. I tried both steps that led to bug and both are non-reproducible now.
Devstudio 11.1.0.AM1, Build id: AM1-v20170817-0703-B817.
> Starting of CDK 3 Server Adapter with Minishift Home that differs from ~/.minishift prevents OS tooling to create proper connection and links it to default project
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24796
> URL: https://issues.jboss.org/browse/JBIDE-24796
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, openshift
> Affects Versions: 4.5.0.Final
> Environment: Fedora
> Reporter: Ondrej Dockal
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.AM1
>
> Attachments: cdk3_sa-manual_correct-mhome.png, cdk3_sa-manual_wrong-mhome2.png
>
>
> In the first case I would understand that if you change you minishift home (in server editor) and then you start server adapter, you will get some mess... Although, I would like to see a validation of minishift home here. We are checking minishit binary, why not to check minishift home (in this case for existence of the folder). See
> !cdk3_sa-manual_wrong-mhome2.png|thumbnail!
> In the second case comes the bug. Even if I have set MINISHIFT_HOME folder, called setup-cdk that configured everything in that folder and put this folder as Minishift Home, CDK3 Server Adapter is not respecting that location. Or it is maybe OS tooling, not sure here. Solution here would be a check that verifies minishift's home set in CDK server editor corresponds with the one that minishift binary uses, if it is possible (from the side of binary) - but that seems not to be an option here as minishift/cdk stored everything in config that resides in MINISHIFT_HOME or ~/.minishift folder. See
> !cdk3_sa-manual_correct-mhome.png|thumbnail!
> Cc: [~adietish] [~rob.stryker].
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24796) Starting of CDK 3 Server Adapter with Minishift Home that differs from ~/.minishift prevents OS tooling to create proper connection and links it to default project
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24796?page=com.atlassian.jira.plugi... ]
Ondrej Dockal closed JBIDE-24796.
---------------------------------
> Starting of CDK 3 Server Adapter with Minishift Home that differs from ~/.minishift prevents OS tooling to create proper connection and links it to default project
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24796
> URL: https://issues.jboss.org/browse/JBIDE-24796
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, openshift
> Affects Versions: 4.5.0.Final
> Environment: Fedora
> Reporter: Ondrej Dockal
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.AM1
>
> Attachments: cdk3_sa-manual_correct-mhome.png, cdk3_sa-manual_wrong-mhome2.png
>
>
> In the first case I would understand that if you change you minishift home (in server editor) and then you start server adapter, you will get some mess... Although, I would like to see a validation of minishift home here. We are checking minishit binary, why not to check minishift home (in this case for existence of the folder). See
> !cdk3_sa-manual_wrong-mhome2.png|thumbnail!
> In the second case comes the bug. Even if I have set MINISHIFT_HOME folder, called setup-cdk that configured everything in that folder and put this folder as Minishift Home, CDK3 Server Adapter is not respecting that location. Or it is maybe OS tooling, not sure here. Solution here would be a check that verifies minishift's home set in CDK server editor corresponds with the one that minishift binary uses, if it is possible (from the side of binary) - but that seems not to be an option here as minishift/cdk stored everything in config that resides in MINISHIFT_HOME or ~/.minishift folder. See
> !cdk3_sa-manual_correct-mhome.png|thumbnail!
> Cc: [~adietish] [~rob.stryker].
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months