[JBoss JIRA] (JBIDE-18521) On RHEL7, Browsersim cannot use the SWT Browser (GTK2) as the browser engine
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18521?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov updated JBIDE-18521:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.4.x)
> On RHEL7, Browsersim cannot use the SWT Browser (GTK2) as the browser engine
> ----------------------------------------------------------------------------
>
> Key: JBIDE-18521
> URL: https://issues.jboss.org/browse/JBIDE-18521
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: browsersim
> Affects Versions: 4.2.0.CR2
> Environment: RHEL7
> Java 1.7
> Java 1.8
> Reporter: Len DiMaggio
> Assignee: Ilya Buziuk
> Fix For: 4.5.x
>
> Attachments: screenshot_JBIDE-18521.png
>
>
> Steps to reproduce:
> * Configure Browsersim to use either Oracle 1.7 or 1.8 JDK on RHEL7
> * Open Browsersim
> * Right-click to open the Browsersim context menu
> * Observe the "please install webkitgtk to to use SWT.WebKit.engine" error
> (See attached screenshot)
> The webkitgtk package does not exist for RHEL7 - webkitgtk3 is installed in RHEL7 OOTB.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-22756) Connection: varioius weirdness in token/password
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22756?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov updated JBIDE-22756:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.4.x)
> Connection: varioius weirdness in token/password
> -------------------------------------------------
>
> Key: JBIDE-22756
> URL: https://issues.jboss.org/browse/JBIDE-22756
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Andre Dietisheim
> Labels: connection
> Fix For: 4.5.x
>
>
> The lifecycle of the token is rather weird and needs a consistent logic:
> When connecting via wizard the token is set in the connection wizard:
> {code:title=ConnectionWizardPageModel#connect}
> ...
> try {
> IConnection connection = createConnection(connectionFactory, connectionAuthenticationProvider);
> ...
> {code}
> {code:title=ConnectionWizardPageModel#createConnection}
> ...
> if (authProvider != null) {
> authProvider.update(connection); // sets the token
> }
> ...
> {code}
> {code:title=BearTokenAuthenticationProvider#update}
> ...
> connection.setAuthScheme(IAuthorizationContext.AUTHSCHEME_OAUTH);
> connection.setToken(tokenObservable.getValue());
> connection.setRememberToken(rememberTokenObservable.getValue());
> ...
> {code}
> {code:title=Connection#connect}
> if(authorize()) {
> ...
> {code}
> {code:title=Connection#authorized}
> ...
> if (context.isAuthorized()) {
> String username = context.getUser().getName();
> String token = context.getToken();
> updateAuthorized(username, token);
> } else {
> ...
> {code}
> The token is then fetched from client and set to the connection
> {code:title=Connection#updateAuthorized}
> setToken(token);
> ...
> {code}
> and the password is cleared
> {code:Connectoin#savePasswordOrToken}
> } else if (IAuthorizationContext.AUTHSCHEME_OAUTH.equals(getAuthScheme())){
> boolean success = saveOrClear(SECURE_STORAGE_TOKEN_KEY, this.token, isRememberToken());
> if(success) {
> //Avoid second secure storage prompt.
> //Token is stored, password should be cleared.
> clearPassword();
> {code}
> I suspect the aim here is to clear existing password in secure storage if the user is switching password->token based auth (and vice versa)
> The opposite is then not fully congruent. The token is only cleared in secure storage, not in Connection instance var
> {code:title=Connection#savePasswordOrToken}
> if (IAuthorizationContext.AUTHSCHEME_BASIC.equals(getAuthScheme())) {
> boolean success = saveOrClear(SECURE_STORAGE_PASSWORD_KEY, this.password, isRememberPassword());
> if (success) {
> //Avoid second secure storage prompt.
> // Password is stored, token should be cleared.
> clearToken();
> }
> {code:Connection#clearToken}
> // dont clear the token instance var: JBIDE-22594
> setRememberToken(false);
> saveOrClear(SECURE_STORAGE_TOKEN_KEY, null, false);
> {code}
> I suspect that we should only clear in secure storage, not in the Connection instance as we see in JBIDE-22594 (for the opposite case where we dont clear the token in the Connection instance). But then one has to keep in mind that all auth is token based. Even if you auth via password initially, the auth is then switched to token based once the authorization succeeded and we got a token:
> {code:title=Connection#updateAuthorized}
> setToken(token);
> if (IAuthorizationContext.AUTHSCHEME_OAUTH.equalsIgnoreCase(getAuthScheme())) {
> setUsername(username);
> }
> // force auth strategy to token if authorized
> TokenAuthorizationStrategy tokenStrategy = new TokenAuthorizationStrategy(token, username);
> client.setAuthorizationStrategy(tokenStrategy);
> {code}
> Another issue is that the connection and the auth schemeare both stored in different classes. The connection is stored via
> {code:title=ConnectionPersistency#persist}
> preferences.saveConnections(connections.keySet().toArray(new String[] {}));
> ...
> {code}
> while the auth scheme is stored in Connection#saveAuthSchemePreference:
> {code:title=Connection#connect}
> saveAuthSchemePreference();
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-23173) Missing validation of @SecurityParameterBinding
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23173?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov updated JBIDE-23173:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.4.x)
> Missing validation of @SecurityParameterBinding
> -----------------------------------------------
>
> Key: JBIDE-23173
> URL: https://issues.jboss.org/browse/JBIDE-23173
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdi-extensions
> Affects Versions: 4.4.1.Final
> Reporter: Lukáš Valach
> Fix For: 4.5.x
>
> Attachments: SecurityBindingType-Log.txt, securityParameterBinding.zip
>
>
> CDI extension DeltaSpike allows to create custom @SecurityParameterBinding types.
> These types allows to inject parameters values from the method invocation to authorizer bean. (See [documentation of Deltaspike/Security Module|https://deltaspike.apache.org/documentation/security.html#Simplein...]).
> When I create my own security parameter
> {code:java}
> @SecurityParameterBinding
> public @interface MySecurityParameter {
> }
> {code}
> ...and authorizer
> {code:java}
> public class CustomAuthorizer {
>
> @Secures
> @CustomSecurityBinding()
> public boolean check(@MySecurityParameter String parameter) {
> return true;
> }
> }
> {code}
> ...then I can secure some methods, but these methods must have appropriate input parameter with correct type and with the annotation
> {code:java}
> public class SecuredBean {
> //OK
> @CustomSecurityBinding()
> public SecuredBean doSomething(@MySecurityParameter String parameter) {
> return null;
> }
>
> //Not-OK (Missing @MySecurityParameter annotation)
> @CustomSecurityBinding()
> public SecuredBean doSomething2(String parameter) {
> return null;
> }
>
> //Not-OK (Bad type - Integer)
> @CustomSecurityBinding()
> public SecuredBean doSomething3(@MySecurityParameter Integer parameter) {
> return null;
> }
> }
> {code}
> Methods doSomething 2 and 3 cause an exception "SecurityDefinitionException: No matching authorizer found for security". Validator doesn't detect any problems.
> The attached project can be use to reproduce this issue [^securityParameterBinding.zip].
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-22344) ConcurrentModificationException below JaxrsResource.createWorkingCopy (thrown in HashMap$HashIterator.nextNode)
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22344?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov updated JBIDE-22344:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.4.x)
> ConcurrentModificationException below JaxrsResource.createWorkingCopy (thrown in HashMap$HashIterator.nextNode)
> ---------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-22344
> URL: https://issues.jboss.org/browse/JBIDE-22344
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: webservices
> Affects Versions: 4.3.1.Final
> Reporter: Automated Error Reporting Bot
> Assignee: Xavier Coulon
> Fix For: 4.5.x
>
>
> The following problem was reported via the automated error reporting:
> Message:
> {noformat}
> java.util.ConcurrentModificationException: null
> at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429)
> at java.util.HashMap$EntryIterator.next(HashMap.java:1463)
> at java.util.HashMap$EntryIterator.next(HashMap.java:1461)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.domain.JaxrsResource.createWorkingCopy(JaxrsResource.java:232)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.domain.JaxrsResource.createWorkingCopy(JaxrsResource.java:1)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.domain.JaxrsBaseElement.getWorkingCopy(JaxrsBaseElement.java:176)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.domain.JaxrsResource.getWorkingCopy(JaxrsResource.java:244)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.domain.JaxrsResource.getWorkingCopy(JaxrsResource.java:1)
> at org.jboss.tools.ws.jaxrs.ui.internal.validation.JaxrsMetamodelValidator.validate(JaxrsMetamodelValidator.java:413)
> at org.jboss.tools.common.validation.AsYouTypeValidatorManager.validate(AsYouTypeValidatorManager.java:183)
> at org.jboss.tools.common.validation.AsYouTypeValidatorManager.validateString(AsYouTypeValidatorManager.java:205)
> at org.jboss.tools.common.validation.AsYouTypeValidatorManager.validateString(AsYouTypeValidatorManager.java:200)
> at org.jboss.tools.common.validation.java.JavaDirtyRegionProcessor.endProcessing(JavaDirtyRegionProcessor.java:498)
> at org.eclipse.wst.sse.ui.internal.reconcile.DirtyRegionProcessor$BackgroundThread.run(DirtyRegionProcessor.java:697)
> {noformat}
> Bundles:
> | org.eclipse.wst.sse.ui | 1.3.401.v201510130005 | 1.3.401.v201510130005 |
> | org.jboss.tools.common.validation | 3.7.1.Final-v20160408-2358-B112 | 3.7.1.Final-v20160408-2358-B112 |
> | org.jboss.tools.ws.jaxrs.core | 1.8.1.Final-v20160331-0952-B76 | 1.8.1.Final-v20160331-0952-B76 |
> | org.jboss.tools.ws.jaxrs.ui | 1.8.1.Final-v20160331-0952-B76 | 1.8.1.Final-v20160331-0952-B76 |
> Operating Systems:
> | Linux | 4.4.8.fc23 | 4.4.8.fc23 |
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/5729593fe4b0a54983...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-22652) Wrong theme color in showlist menu
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22652?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov updated JBIDE-22652:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.4.x)
> Wrong theme color in showlist menu
> ----------------------------------
>
> Key: JBIDE-22652
> URL: https://issues.jboss.org/browse/JBIDE-22652
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: upstream
> Affects Versions: 4.4.0.Final
> Environment: Fedora 24,
> devstudio:
> Build id: GA-v20160603-1025-B5510,
> Build date: 20160603-1025,
> OpenJDK Runtime Environment (build 1.8.0_91-b14)
> Reporter: Ondrej Dockal
> Fix For: 4.5.x
>
> Attachments: swtgtk3_0.png, swtgtk3_1.png
>
>
> Show list menu of hidden tabs in editor appears to have wrong color theme. This changes with usage of webkitgtk lib, SWT_GTK3=0(1), used theme is default GTK.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-17281) parent/pom.xml build/plugins should reference plugins defined build/pluginManagement
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17281?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov updated JBIDE-17281:
-------------------------------------
Fix Version/s: 4.5.x
(was: 4.4.x)
> parent/pom.xml build/plugins should reference plugins defined build/pluginManagement
> ------------------------------------------------------------------------------------
>
> Key: JBIDE-17281
> URL: https://issues.jboss.org/browse/JBIDE-17281
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.2.0.Beta2
> Reporter: Denis Golovin
> Assignee: Denis Golovin
> Priority: Optional
> Fix For: 4.5.x
>
>
> The Idea is to move all what we have in build/plugins to build/pluginManagement and leave only plugins with groupId and artifactid in build/plugins. It would let to do further clean up and reduce clutter in jbosstools modules like:
> - remove <version>${tychoVersion}</version>
> - move jacoco plugin to tests/pom.xml
> - move update site manipulations to site/pom.xml
> - move ant task runner configuration to parent/pom.xml#pluginManagement node for easy reuse
> - etc.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months