[JBoss JIRA] (JBDS-4495) Missing CDI features
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBDS-4495?page=com.atlassian.jira.plugin.... ]
Martin Malina commented on JBDS-4495:
-------------------------------------
[~rpdavis], I think we need your decision here as a PM. We think that cdi as a whole was removed by mistake because Nick had the impression that cdi = seam 3 and seam 3 was agreed to be removed. So we believe org.jboss.tools.cdi.feature and org.jboss.tools.maven.cdi.feature should be put back in, but we are not sure about org.jboss.tools.cdi.deltaspike.feature . If we simply want to correct the once approved removal of seam 3, then we should put org.jboss.tools.cdi.deltaspike.feature back in too. But we might as well take this opportunity and consider what to do about this feature.
> Missing CDI features
> --------------------
>
> Key: JBDS-4495
> URL: https://issues.jboss.org/browse/JBDS-4495
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: build, cdi
> Affects Versions: 11.0.0.GA
> Reporter: Lukáš Valach
> Assignee: Jeff MAURY
> Priority: Blocker
> Fix For: 11.0.0.GA
>
> Attachments: No_CDI_Plugins.png
>
>
> I have installed devstudio-11.0.0.GA-v20170801-0412-B670-installer-standalone.jar and I don't see any CDI functionality. It seems that CDI related plugins wasn't installed.
> Help->About->Installation Detains->Plugins, Search for "CDI", there is nothing.
> !No_CDI_Plugins.png|thumbnail!
> JBoss Tools seems to be ok.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBDS-4495) Missing CDI features
by Pavol Srna (JIRA)
[ https://issues.jboss.org/browse/JBDS-4495?page=com.atlassian.jira.plugin.... ]
Pavol Srna edited comment on JBDS-4495 at 8/8/17 9:07 AM:
----------------------------------------------------------
I agree that *.cdi.seam should be deprecated and that we should keep org.jboss.tools.cdi.feature and org.jboss.tools.maven.cdi.feature, however a decision has to be made by PM.
was (Author: psrna):
I agree that *.cdi.seam should be deprecated and that we should keep org.jboss.tools.cdi.feature and org.jboss.tools.maven.cdi.feature, however a decision have to be made by PM.
> Missing CDI features
> --------------------
>
> Key: JBDS-4495
> URL: https://issues.jboss.org/browse/JBDS-4495
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: build, cdi
> Affects Versions: 11.0.0.GA
> Reporter: Lukáš Valach
> Assignee: Jeff MAURY
> Priority: Blocker
> Fix For: 11.0.0.GA
>
> Attachments: No_CDI_Plugins.png
>
>
> I have installed devstudio-11.0.0.GA-v20170801-0412-B670-installer-standalone.jar and I don't see any CDI functionality. It seems that CDI related plugins wasn't installed.
> Help->About->Installation Detains->Plugins, Search for "CDI", there is nothing.
> !No_CDI_Plugins.png|thumbnail!
> JBoss Tools seems to be ok.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBDS-4495) Missing CDI features
by Pavol Srna (JIRA)
[ https://issues.jboss.org/browse/JBDS-4495?page=com.atlassian.jira.plugin.... ]
Pavol Srna commented on JBDS-4495:
----------------------------------
I agree that *.cdi.seam should be deprecated and that we should keep org.jboss.tools.cdi.feature and org.jboss.tools.maven.cdi.feature, however a decision have to be made by PM.
> Missing CDI features
> --------------------
>
> Key: JBDS-4495
> URL: https://issues.jboss.org/browse/JBDS-4495
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: build, cdi
> Affects Versions: 11.0.0.GA
> Reporter: Lukáš Valach
> Assignee: Jeff MAURY
> Priority: Blocker
> Fix For: 11.0.0.GA
>
> Attachments: No_CDI_Plugins.png
>
>
> I have installed devstudio-11.0.0.GA-v20170801-0412-B670-installer-standalone.jar and I don't see any CDI functionality. It seems that CDI related plugins wasn't installed.
> Help->About->Installation Detains->Plugins, Search for "CDI", there is nothing.
> !No_CDI_Plugins.png|thumbnail!
> JBoss Tools seems to be ok.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBDS-4495) Missing CDI features
by Rastislav Wagner (JIRA)
[ https://issues.jboss.org/browse/JBDS-4495?page=com.atlassian.jira.plugin.... ]
Rastislav Wagner edited comment on JBDS-4495 at 8/8/17 9:06 AM:
----------------------------------------------------------------
We should keep org.jboss.tools.cdi.feature and org.jboss.tools.maven.cdi.feature in JBT and remove only *cdi.seam features.
However Im not sure what we want to do about org.jboss.tools.cdi.deltaspike.feature. Deltaspike is a collection of extensions for CDI (something like cdi.seam). I would vote for *not* deprecating deltaspike .
[~rpdavis]] Can you please decide what to do with Deltaspike feature ?
was (Author: rawagner):
We should keep org.jboss.tools.cdi.feature and org.jboss.tools.maven.cdi.feature in JBT and remove only *cdi.seam features.
However Im not sure what we want to do about org.jboss.tools.cdi.deltaspike.feature. Deltaspike is a collection of extensions for CDI (something like cdi.seam).
> Missing CDI features
> --------------------
>
> Key: JBDS-4495
> URL: https://issues.jboss.org/browse/JBDS-4495
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: build, cdi
> Affects Versions: 11.0.0.GA
> Reporter: Lukáš Valach
> Assignee: Jeff MAURY
> Priority: Blocker
> Fix For: 11.0.0.GA
>
> Attachments: No_CDI_Plugins.png
>
>
> I have installed devstudio-11.0.0.GA-v20170801-0412-B670-installer-standalone.jar and I don't see any CDI functionality. It seems that CDI related plugins wasn't installed.
> Help->About->Installation Detains->Plugins, Search for "CDI", there is nothing.
> !No_CDI_Plugins.png|thumbnail!
> JBoss Tools seems to be ok.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-24439) Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24439?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-24439:
-------------------------------
Fix Version/s: LATER
(was: 4.5.x)
> Block PRs for merge untill the Jenkins build is successful
> ----------------------------------------------------------
>
> Key: JBIDE-24439
> URL: https://issues.jboss.org/browse/JBIDE-24439
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Fix For: LATER
>
>
> As discussed in this thread [1], we'd like to implement *Protected Branches* and
> *Required Status Checks* [2] for some jbosstools-* projects.
> [1] http://lists.jboss.org/pipermail/jbosstools-dev/2017-May/011948.html
> [2] https://help.github.com/articles/defining-the-mergeability-of-pull-requests/
> We will therefore need to document some requirements in jbosstools-devdoc about how to properly submit PRs when version-bumping is required:
> {quote}Make sure if your PR requires a version bump that the PR includes TWO commits. One for the change, and one for the version bump. That way the pair of commits can be built in the PR build and verify it works, AND when cherry picking the commit across branches, you can pick only the change and not the version-bump commit too.
> {quote}
> And we need to decide if we want to do what Fuse Tools does and require that PRs be reviewed before they can be merged, if we're ready to have that additional overhead on every PR.
> [~jeffmaury] as project lead can you state which project(s) you'd like to see changed in github, and which ones should be changed as such:
> * jbosstools-_____
> ** Protected Branch = master
> ** Required Status Check(s) = ....? (which checks do we want)
> ** PR reviews required = [true/false]
> From that list of projects / requirements, we can then create subtask JIRAs to track the workj & the changes.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-24439) Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24439?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-24439:
------------------------------------
On today's retrospective call w/ feedback from Jeff, Rob, Nick, Andre, no one wants this, so I've postponed it to LATER.
> Block PRs for merge untill the Jenkins build is successful
> ----------------------------------------------------------
>
> Key: JBIDE-24439
> URL: https://issues.jboss.org/browse/JBIDE-24439
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Fix For: LATER
>
>
> As discussed in this thread [1], we'd like to implement *Protected Branches* and
> *Required Status Checks* [2] for some jbosstools-* projects.
> [1] http://lists.jboss.org/pipermail/jbosstools-dev/2017-May/011948.html
> [2] https://help.github.com/articles/defining-the-mergeability-of-pull-requests/
> We will therefore need to document some requirements in jbosstools-devdoc about how to properly submit PRs when version-bumping is required:
> {quote}Make sure if your PR requires a version bump that the PR includes TWO commits. One for the change, and one for the version bump. That way the pair of commits can be built in the PR build and verify it works, AND when cherry picking the commit across branches, you can pick only the change and not the version-bump commit too.
> {quote}
> And we need to decide if we want to do what Fuse Tools does and require that PRs be reviewed before they can be merged, if we're ready to have that additional overhead on every PR.
> [~jeffmaury] as project lead can you state which project(s) you'd like to see changed in github, and which ones should be changed as such:
> * jbosstools-_____
> ** Protected Branch = master
> ** Required Status Check(s) = ....? (which checks do we want)
> ** PR reviews required = [true/false]
> From that list of projects / requirements, we can then create subtask JIRAs to track the workj & the changes.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-24671:
-------------------------------
Fix Version/s: LATER
(was: 4.5.1.AM1)
> [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: LATER
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (JBIDE-24439) Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24439?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-24439:
-------------------------------
Fix Version/s: 4.5.x
(was: 4.5.1.AM1)
> Block PRs for merge untill the Jenkins build is successful
> ----------------------------------------------------------
>
> Key: JBIDE-24439
> URL: https://issues.jboss.org/browse/JBIDE-24439
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Fix For: 4.5.x
>
>
> As discussed in this thread [1], we'd like to implement *Protected Branches* and
> *Required Status Checks* [2] for some jbosstools-* projects.
> [1] http://lists.jboss.org/pipermail/jbosstools-dev/2017-May/011948.html
> [2] https://help.github.com/articles/defining-the-mergeability-of-pull-requests/
> We will therefore need to document some requirements in jbosstools-devdoc about how to properly submit PRs when version-bumping is required:
> {quote}Make sure if your PR requires a version bump that the PR includes TWO commits. One for the change, and one for the version bump. That way the pair of commits can be built in the PR build and verify it works, AND when cherry picking the commit across branches, you can pick only the change and not the version-bump commit too.
> {quote}
> And we need to decide if we want to do what Fuse Tools does and require that PRs be reviewed before they can be merged, if we're ready to have that additional overhead on every PR.
> [~jeffmaury] as project lead can you state which project(s) you'd like to see changed in github, and which ones should be changed as such:
> * jbosstools-_____
> ** Protected Branch = master
> ** Required Status Check(s) = ....? (which checks do we want)
> ** PR reviews required = [true/false]
> From that list of projects / requirements, we can then create subtask JIRAs to track the workj & the changes.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months