August 2017 - jbosstools-issues - Jboss List Archives

[JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

by Dmitrii Bocharov (JIRA)

[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugi... ] Dmitrii Bocharov commented on JBIDE-24797: ------------------------------------------ I totally agree to do it. We can commit it to https://github.com/jbosstools/jbosstools-devdoc. Are you agree? Also then we need to pay attention to it during the review > Code formatter: define and hook code formatting enforcement for github PRs > -------------------------------------------------------------------------- > > Key: JBIDE-24797 > URL: https://issues.jboss.org/browse/JBIDE-24797 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.0.Final > Reporter: Andre Dietisheim > Fix For: 4.5.1.AM1 > > > Code formatting differs across developers. We should be at least consistent since odd formatting makes reading code more difficult for obvious reasons. > The most prominent differences I am aware of are > * use spaces vs tabs > * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): > {code} > if(XX){ > {code} > vs > {code} > if (XX) { > {code} > * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: > {code} > public void method() { > int i = 0; > i++; > i +=2; > {code} > * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] > {code} > class Listener { > int i = 0; > public void method() { > } > } > {code} > * multiple empty lines for no obvious reason like shown [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...] > {code} > public class ZZ { > int i = 0; > i++ > } > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

by Dmitrii Bocharov (JIRA)

[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugi... ] Dmitrii Bocharov updated JBIDE-24797: ------------------------------------- Component/s: devdoc (was: openshift) > Code formatter: define and hook code formatting enforcement for github PRs > -------------------------------------------------------------------------- > > Key: JBIDE-24797 > URL: https://issues.jboss.org/browse/JBIDE-24797 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: devdoc > Affects Versions: 4.5.0.Final > Reporter: Andre Dietisheim > Fix For: 4.5.1.AM1 > > > Code formatting differs across developers. We should be at least consistent since odd formatting makes reading code more difficult for obvious reasons. > The most prominent differences I am aware of are > * use spaces vs tabs > * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): > {code} > if(XX){ > {code} > vs > {code} > if (XX) { > {code} > * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: > {code} > public void method() { > int i = 0; > i++; > i +=2; > {code} > * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] > {code} > class Listener { > int i = 0; > public void method() { > } > } > {code} > * multiple empty lines for no obvious reason like shown [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...] > {code} > public class ZZ { > int i = 0; > i++ > } > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

by Dmitrii Bocharov (JIRA)

[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugi... ] Dmitrii Bocharov reassigned JBIDE-24797: ---------------------------------------- Assignee: Dmitrii Bocharov > Code formatter: define and hook code formatting enforcement for github PRs > -------------------------------------------------------------------------- > > Key: JBIDE-24797 > URL: https://issues.jboss.org/browse/JBIDE-24797 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: devdoc > Affects Versions: 4.5.0.Final > Reporter: Andre Dietisheim > Assignee: Dmitrii Bocharov > Fix For: 4.5.1.AM1 > > > Code formatting differs across developers. We should be at least consistent since odd formatting makes reading code more difficult for obvious reasons. > The most prominent differences I am aware of are > * use spaces vs tabs > * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): > {code} > if(XX){ > {code} > vs > {code} > if (XX) { > {code} > * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: > {code} > public void method() { > int i = 0; > i++; > i +=2; > {code} > * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] > {code} > class Listener { > int i = 0; > public void method() { > } > } > {code} > * multiple empty lines for no obvious reason like shown [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...] > {code} > public class ZZ { > int i = 0; > i++ > } > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-24797: ------------------------------------- Description: Code formatting differs across developers. We should be at least consistent since odd formatting makes reading code more difficult for obvious reasons. The most prominent differences I am aware of are * use spaces vs tabs * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): {code} if(XX){ {code} vs {code} if (XX) { {code} * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: {code} public void method() { int i = 0; i++; i +=2; {code} * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] {code} class Listener { int i = 0; public void method() { } } {code} * multiple empty lines for no obvious reason like shown [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...] {code} public class ZZ { int i = 0; i++ } {code} was: Code formatting differs across developers. We should be at least consistent since odd formatting makes reading code more difficult for obvious reasons. The most prominent differences I am aware of are * use spaces vs tabs * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): {code} if(XX){ {code} vs {code} if (XX) { {code} * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: {code} public void method() { int i = 0; i++; i +=2; {code} * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] {code} class Listener { int i = 0; public void method() { } } {code} > Code formatter: define and hook code formatting enforcement for github PRs > -------------------------------------------------------------------------- > > Key: JBIDE-24797 > URL: https://issues.jboss.org/browse/JBIDE-24797 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.0.Final > Reporter: Andre Dietisheim > Fix For: 4.5.1.AM1 > > > Code formatting differs across developers. We should be at least consistent since odd formatting makes reading code more difficult for obvious reasons. > The most prominent differences I am aware of are > * use spaces vs tabs > * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): > {code} > if(XX){ > {code} > vs > {code} > if (XX) { > {code} > * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: > {code} > public void method() { > int i = 0; > i++; > i +=2; > {code} > * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] > {code} > class Listener { > int i = 0; > public void method() { > } > } > {code} > * multiple empty lines for no obvious reason like shown [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...] > {code} > public class ZZ { > int i = 0; > i++ > } > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-24797: ------------------------------------- Description: Code formatting differs across developers. We should be at least consistent since odd formatting makes reading code more difficult for obvious reasons. The most prominent differences I am aware of are * use spaces vs tabs * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): {code} if(XX){ {code} vs {code} if (XX) { {code} * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: {code} public void method() { int i = 0; i++; i +=2; {code} * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] {code} class Listener { int i = 0; public void method() { } } {code} was: Code formatting differs across developers. The most prominent differences I am aware of are * use spaces vs tabs * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): {code} if(XX){ {code} vs {code} if (XX) { {code} * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: {code} public void method() { int i = 0; i++; i +=2; {code} * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] {code} class Listener { int i = 0; public void method() { } } {code} > Code formatter: define and hook code formatting enforcement for github PRs > -------------------------------------------------------------------------- > > Key: JBIDE-24797 > URL: https://issues.jboss.org/browse/JBIDE-24797 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.0.Final > Reporter: Andre Dietisheim > Fix For: 4.5.1.AM1 > > > Code formatting differs across developers. We should be at least consistent since odd formatting makes reading code more difficult for obvious reasons. > The most prominent differences I am aware of are > * use spaces vs tabs > * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): > {code} > if(XX){ > {code} > vs > {code} > if (XX) { > {code} > * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: > {code} > public void method() { > int i = 0; > i++; > i +=2; > {code} > * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] > {code} > class Listener { > int i = 0; > public void method() { > } > } > {code} > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-24797: ------------------------------------- Sprint: devex #135 July 2017 > Code formatter: define and hook code formatting enforcement for github PRs > -------------------------------------------------------------------------- > > Key: JBIDE-24797 > URL: https://issues.jboss.org/browse/JBIDE-24797 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.0.Final > Reporter: Andre Dietisheim > Fix For: 4.5.1.AM1 > > > Code formatting differs across developers. We should be at least consistent since odd formatting makes reading code more difficult for obvious reasons. > The most prominent differences I am aware of are > * use spaces vs tabs > * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): > {code} > if(XX){ > {code} > vs > {code} > if (XX) { > {code} > * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: > {code} > public void method() { > int i = 0; > i++; > i +=2; > {code} > * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] > {code} > class Listener { > int i = 0; > public void method() { > } > } > {code} > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-24797: ------------------------------------- Description: Code formatting differs across developers. The most prominent differences I am aware of are * use spaces vs tabs * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): {code} if(XX){ {code} vs {code} if (XX) { {code} * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: {code} public void method() { int i = 0; i++; i +=2; {code} * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] {code} class Listener { int i = 0; public void method() { } } {code} was: Code formatting differs across developers. The most prominent differences I am aware of are * use spaces vs tabs * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): {code} if(XX){ {code} vs {code} if (XX) { {code} * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: {code} public void method() { int i = 0; i++; i +=2; {code} * odd identations of braces for anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] {code} class Listener { int i = 0; public void method() { } } {code} > Code formatter: define and hook code formatting enforcement for github PRs > -------------------------------------------------------------------------- > > Key: JBIDE-24797 > URL: https://issues.jboss.org/browse/JBIDE-24797 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.0.Final > Reporter: Andre Dietisheim > Fix For: 4.5.1.AM1 > > > Code formatting differs across developers. > The most prominent differences I am aware of are > * use spaces vs tabs > * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): > {code} > if(XX){ > {code} > vs > {code} > if (XX) { > {code} > * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: > {code} > public void method() { > int i = 0; > i++; > i +=2; > {code} > * odd identations of whole anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] > {code} > class Listener { > int i = 0; > public void method() { > } > } > {code} > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-24797: ------------------------------------- Description: Code formatting differs across developers. The most prominent differences I am aware of are * use spaces vs tabs * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): {code} if(XX){ {code} vs {code} if (XX) { {code} * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: {code} public void method() { int i = 0; i++; i +=2; {code} * odd identations of braces for anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] {code} class Listener { int i = 0; public void method() { } } {code} was: Code formatting differs across developers. The most prominent differences I am aware of are * use spaces vs tabs * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): {code} if(XX){ {code} vs {code} if (XX) { {code} * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...] * odd identations of braces for anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] {code} class Listener { int i = 0; public void method() { } } {code} > Code formatter: define and hook code formatting enforcement for github PRs > -------------------------------------------------------------------------- > > Key: JBIDE-24797 > URL: https://issues.jboss.org/browse/JBIDE-24797 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.0.Final > Reporter: Andre Dietisheim > Fix For: 4.5.1.AM1 > > > Code formatting differs across developers. > The most prominent differences I am aware of are > * use spaces vs tabs > * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): > {code} > if(XX){ > {code} > vs > {code} > if (XX) { > {code} > * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...]: > {code} > public void method() { > int i = 0; > i++; > i +=2; > {code} > * odd identations of braces for anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] > {code} > class Listener { > int i = 0; > public void method() { > } > } > {code} > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-24797: ------------------------------------- Description: Code formatting differs across developers. The most prominent differences I am aware of are * use spaces vs tabs * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): {code} if(XX){ {code} vs {code} if (XX) { {code} * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...] * odd identations of braces for anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] {code} class Listener { int i = 0; public void method() { } } {code} was: Code formatting differs across developers. The most prominent differences I am aware of are * use spaces vs tabs * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...] : {code} if(XX){ {code} vs {code} if (XX) { {code} * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...] * odd identations of braces for anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] {code} class Listener { int i = 0; public void method() { } } {code} > Code formatter: define and hook code formatting enforcement for github PRs > -------------------------------------------------------------------------- > > Key: JBIDE-24797 > URL: https://issues.jboss.org/browse/JBIDE-24797 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.0.Final > Reporter: Andre Dietisheim > Fix For: 4.5.1.AM1 > > > Code formatting differs across developers. > The most prominent differences I am aware of are > * use spaces vs tabs > * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...]): > {code} > if(XX){ > {code} > vs > {code} > if (XX) { > {code} > * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...] > * odd identations of braces for anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] > {code} > class Listener { > int i = 0; > public void method() { > } > } > {code} > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-24797) Code formatter: define and hook code formatting enforcement for github PRs

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-24797?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-24797: ------------------------------------------ [~dbocharov] [~jeffmaury] [~rob.stryker] as discussed yesterday > Code formatter: define and hook code formatting enforcement for github PRs > -------------------------------------------------------------------------- > > Key: JBIDE-24797 > URL: https://issues.jboss.org/browse/JBIDE-24797 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.5.0.Final > Reporter: Andre Dietisheim > Fix For: 4.5.1.AM1 > > > Code formatting differs across developers. > The most prominent differences I am aware of are > * use spaces vs tabs > * differences in formatting "if statements" (as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1536/files#d...] : > {code} > if(XX){ > {code} > vs > {code} > if (XX) { > {code} > * insonsitent code identations like displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1535/files#d...] > * odd identations of braces for anonymous classes as displayed [here|https://github.com/jbosstools/jbosstools-openshift/pull/1531/files#d...] > {code} > class Listener { > int i = 0; > public void method() { > } > } > {code} > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues August 2017